192510 2018-12-07 12:35:40 -0800 [ews-build] check-patch-relevance failure should not mark the overall build as failure 2018-12-08 05:04:34 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap lforschler webkit-bug-importer oldest_to_newest 1486114 0 aakash_jain 2018-12-07 12:35:40 -0800 When a check-patch-relevance step fails, it indicate that the patch doesn't have changes relevant to the builder, and therefore rest of the processing is skipped. Therefore failure in check-patch-relevance step should not mark the build as failure, instead the build should be marked as SKIPPED. 1486115 1 356830 aakash_jain 2018-12-07 12:37:41 -0800 Created attachment 356830 Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/16/builds/229 1486302 2 aakash_jain 2018-12-08 05:03:43 -0800 Committed r239008: <https://trac.webkit.org/changeset/239008> 1486303 3 webkit-bug-importer 2018-12-08 05:04:34 -0800 <rdar://problem/46574892> 356830 2018-12-07 12:37:41 -0800 2018-12-08 05:03:58 -0800 Proposed patch ews-build-check-relevance-skipped.patch text/plain 1185 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODk2MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTEyLTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBjaGVjay1wYXRjaC1yZWxldmFuY2UgZmFpbHVyZSBz aG91bGQgbm90IG1hcmsgdGhlIG92ZXJhbGwgYnVpbGQgYXMgZmFpbHVyZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNTEwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChDaGVja1BhdGNoUmVsZXZhbmNlLnN0YXJ0KToK KwogMjAxOC0xMi0wNyAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2V3cy1hcHBdIFNlbmQgYnVnIGlkIGFzIGEgYnVpbGQgcHJvcGVydHkKSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDIzODk2 MykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2lu ZyBjb3B5KQpAQCAtMTg3LDYgKzE4Nyw4IEBAIGNsYXNzIENoZWNrUGF0Y2hSZWxldmFuY2UoYnVp bGRzdGVwLkJ1aWwKIAogICAgICAgICBzZWxmLl9hZGRUb0xvZygnc3RkaW8nLCAnVGhpcyBwYXRj aCBkb2VzIG5vdCBoYXZlIHJlbGV2YW50IGNoYW5nZXMuJykKICAgICAgICAgc2VsZi5maW5pc2hl ZChGQUlMVVJFKQorICAgICAgICBzZWxmLmJ1aWxkLnJlc3VsdHMgPSBTS0lQUEVECisgICAgICAg IHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbJ1BhdGNoIGRvZXNuXCd0IGhhdmUgcmVsZXZhbnQg Y2hhbmdlcyddLCBTS0lQUEVEKQogICAgICAgICByZXR1cm4gTm9uZQogCiAK