192489 2018-12-06 22:46:08 -0800 Add keychain access entitlement to WebKitTestRunnerApp 2018-12-07 15:14:53 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan ap bfulgham commit-queue jiewen_tan lforschler oldest_to_newest 1485936 0 jiewen_tan 2018-12-06 22:46:08 -0800 Add keychain access entitlement to WebKitTestRunnerApp. 1485937 1 jiewen_tan 2018-12-06 22:46:33 -0800 <rdar://problem/45057952> 1485938 2 356784 jiewen_tan 2018-12-06 22:52:22 -0800 Created attachment 356784 Patch 1486058 3 356784 ap 2018-12-07 10:53:50 -0800 Comment on attachment 356784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356784&action=review > Tools/ChangeLog:3 > + Add keychain access entitlement to WebKitTestRunnerApp Does this fix tests? 1486060 4 356784 jiewen_tan 2018-12-07 11:03:50 -0800 Comment on attachment 356784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356784&action=review >> Tools/ChangeLog:3 >> + Add keychain access entitlement to WebKitTestRunnerApp > > Does this fix tests? Yes, it does. The error is about WebKitTestRunnerApp don't have the entitlement to query Keychain. iOS simulator always has some weird settings other than real devices. 1486080 5 ap 2018-12-07 11:18:11 -0800 Are there any tests that should be unskipped with this change? 1486094 6 jiewen_tan 2018-12-07 11:38:29 -0800 (In reply to Alexey Proskuryakov from comment #5) > Are there any tests that should be unskipped with this change? Those expectations are within internal. 1486165 7 356784 jiewen_tan 2018-12-07 14:52:12 -0800 Comment on attachment 356784 Patch Thanks Alexey for r+ this patch. 1486181 8 356784 commit-queue 2018-12-07 15:14:51 -0800 Comment on attachment 356784 Patch Clearing flags on attachment: 356784 Committed r238970: <https://trac.webkit.org/changeset/238970> 1486182 9 commit-queue 2018-12-07 15:14:53 -0800 All reviewed patches have been landed. Closing bug. 356784 2018-12-06 22:52:22 -0800 2018-12-07 15:14:51 -0800 Patch bug-192489-20181206225221.patch text/plain 1491 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4OTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2RmYTE4MmEzODBiNTgyNmI3OGFmMmU1ZjQ2ZmJhODky NmU0NzBkZS4uMzk3MzNlZWZlYTBiYWE2MWYyYWM3MWZmNzRmY2FjZDkzM2E5ZTI2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTEyLTA2ICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAg ICAgICAgQWRkIGtleWNoYWluIGFjY2VzcyBlbnRpdGxlbWVudCB0byBXZWJLaXRUZXN0UnVubmVy QXBwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI0 ODkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1MDU3OTUyPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1 cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVyQXBwLWlPUy5lbnRpdGxlbWVudHM6CisKIDIwMTgtMTIt MDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U10gV0tXZWJWaWV3IHNob3VsZCBtYXRjaCBVSVRleHRWaWV3IGJlaGF2aW9yIHdoZW4gZWRpdGlu ZyB0ZXh0IHdpdGggYW4gUlRMIGtleWJvYXJkCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0NvbmZpZ3VyYXRpb25zL1dlYktpdFRlc3RSdW5uZXJBcHAtaU9TLmVudGl0bGVtZW50 cyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJhdGlvbnMvV2ViS2l0VGVzdFJ1bm5l ckFwcC1pT1MuZW50aXRsZW1lbnRzCmluZGV4IDU4MWFmYWFlMjljMjNlYzI4MmVhYjY5ZjI1ZWM3 MTA1YmE0ZGUxYWMuLjRmNjU5NDVlYjA1NGYzZjc2NTk3ZDQzMWIyZDUzNWVkYzY1MDBkMGEgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJhdGlvbnMvV2ViS2l0VGVz dFJ1bm5lckFwcC1pT1MuZW50aXRsZW1lbnRzCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv Q29uZmlndXJhdGlvbnMvV2ViS2l0VGVzdFJ1bm5lckFwcC1pT1MuZW50aXRsZW1lbnRzCkBAIC0y LDcgKzIsMTEgQEAKIDwhRE9DVFlQRSBwbGlzdCBQVUJMSUMgIi0vL0FwcGxlLy9EVEQgUExJU1Qg MS4wLy9FTiIgImh0dHA6Ly93d3cuYXBwbGUuY29tL0RURHMvUHJvcGVydHlMaXN0LTEuMC5kdGQi PgogPHBsaXN0IHZlcnNpb249IjEuMCI+CiA8ZGljdD4KKwk8a2V5PmtleWNoYWluLWFjY2Vzcy1n cm91cHM8L2tleT4KKwk8YXJyYXk+CisJCTxzdHJpbmc+Y29tLmFwcGxlLldlYktpdFRlc3RSdW5u ZXJBcHA8L3N0cmluZz4KKwk8L2FycmF5PgogCTxrZXk+Y29tLmFwcGxlLmRldmVsb3Blci5XZWJL aXQuU2VydmljZVdvcmtlcnM8L2tleT4KLSAgICA8dHJ1ZS8+CisJPHRydWUvPgogPC9kaWN0Pgog PC9wbGlzdD4K