192483 2018-12-06 16:38:39 -0800 [Attachment Support] Cloned attachment elements lose their unique identifiers 2018-12-07 10:39:26 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin cdumez commit-queue esprehn+autocc ews-watchlist gyuyoung.kim mitz thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1485871 0 wenson_hsieh 2018-12-06 16:38:39 -0800 When using cloneNode() to clone an attachment element, the resulting attachment element's `uniqueIdentifier` will be the empty string, rather than the original attachment element's unique identifier. Currently, WebKit clients (e.g. Mail) work around this by saving the original attachment's unique identifier to a temporary attribute prior to cloning. Ideally, clients shouldn't need to hack around this for nodes that never appear in the document, since the attachment unique identifier is only guaranteed to uniquely identify attachment elements that are connected to the document. 1485910 1 356776 wenson_hsieh 2018-12-06 19:13:55 -0800 Created attachment 356776 Patch 1486034 2 356776 commit-queue 2018-12-07 10:38:07 -0800 Comment on attachment 356776 Patch Clearing flags on attachment: 356776 Committed r238954: <https://trac.webkit.org/changeset/238954> 1486035 3 commit-queue 2018-12-07 10:38:09 -0800 All reviewed patches have been landed. Closing bug. 1486037 4 webkit-bug-importer 2018-12-07 10:39:26 -0800 <rdar://problem/46558085> 356776 2018-12-06 19:13:55 -0800 2018-12-07 10:38:07 -0800 Patch bug-192483-20181206191354.patch text/plain 4795 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4OTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTJkOTQ2ZDZlZjAyZjZj YzJlMGZmODU5NmRhZTExOWE1NjBlMDNkYy4uNTllMTllMDBjNjNjZTQ2ZmU5NmUxZjRlNjU2MmY2 NjY5ZTA4YWVhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEyLTA2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtBdHRhY2htZW50 IFN1cHBvcnRdIENsb25lZCBhdHRhY2htZW50IGVsZW1lbnRzIGxvc2UgdGhlaXIgdW5pcXVlIGlk ZW50aWZpZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTI0ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIHBhdGNoIGFkZHMgbG9naWMgdG8gZW5zdXJlIHRoYXQgdGhlIHVuaXF1ZSBpZGVudGlm aWVyIG9mIGEgY2xvbmVkIGF0dGFjaG1lbnQgZWxlbWVudCBpcyB0aGUgc2FtZSBhcyB0aGUKKyAg ICAgICAgdW5pcXVlIGlkZW50aWZpZXIgb2YgdGhlIG9yaWdpbmFsIGF0dGFjaG1lbnQgZWxlbWVu dC4gSWYgdGhlIGNsb25lZCBhdHRhY2htZW50IGlzIGluc2VydGVkIGludG8gdGhlIHNhbWUKKyAg ICAgICAgZG9jdW1lbnQgYXMgdGhlIG9yaWdpbmFsIGF0dGFjaG1lbnQsIHRoZW4gd2Ugd2lsbCBl eGVyY2lzZSB0aGUgc2FtZSBjb2RlcGF0aCBmb3IgY29waWVkLWFuZC1wYXN0ZWQgYXR0YWNobWVu dHMsCisgICAgICAgIGFuZCBhc3NpZ24gYSBuZXcgdW5pcXVlIGlkZW50aWZpZXIgdG8gdGhlIGF0 dGFjaG1lbnQgZWxlbWVudCwgd2hpbGUgY3JlYXRpbmcgYSBuZXcgYF9XS0F0dGFjaG1lbnRgIGlu IHRoZSBjbGllbnQKKyAgICAgICAgdGhhdCdzIGJhY2tlZCBieSB0aGUgc2FtZSBgTlNGaWxlV3Jh cHBlcmAuCisKKyAgICAgICAgVGVzdDogV0tBdHRhY2htZW50VGVzdHMuQXR0YWNobWVudElkZW50 aWZpZXJPZkNsb25lZEF0dGFjaG1lbnQKKworICAgICAgICAqIGh0bWwvSFRNTEF0dGFjaG1lbnRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxBdHRhY2htZW50RWxlbWVudDo6Y29w eU5vbkF0dHJpYnV0ZVByb3BlcnRpZXNGcm9tRWxlbWVudCk6CisgICAgICAgICogaHRtbC9IVE1M QXR0YWNobWVudEVsZW1lbnQuaDoKKwogMjAxOC0xMi0wNiAgQWRyaWFuIFBlcmV6IGRlIENhc3Ry byAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIENvbnRlbnQgRXh0ZW5zaW9uczogTWlz YyBmaXhlcyB0byBkZWJ1Z2dpbmcgLyBwZXJmIHRlc3RpbmcgY29kZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuY3BwCmluZGV4IDhjZWQwMTIyMWE1ZTVmOGFh YWZiMzEzYmM3YjM5ZDJmYmNkN2Q5MDAuLmNiNmFjYjcxOGIzODY0ODEzMDU0ZTg2OTQ2MTVkZWI5 ZmQxOGJhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRF bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBdHRhY2htZW50RWxlbWVu dC5jcHAKQEAgLTg2LDYgKzg2LDEyIEBAIGNvbnN0IFN0cmluZyYgSFRNTEF0dGFjaG1lbnRFbGVt ZW50OjpnZXRBdHRhY2htZW50SWRlbnRpZmllcihIVE1MSW1hZ2VFbGVtZW50JiBpCiAgICAgcmV0 dXJuIGlkZW50aWZpZXI7CiB9CiAKK3ZvaWQgSFRNTEF0dGFjaG1lbnRFbGVtZW50Ojpjb3B5Tm9u QXR0cmlidXRlUHJvcGVydGllc0Zyb21FbGVtZW50KGNvbnN0IEVsZW1lbnQmIHNvdXJjZSkKK3sK KyAgICBtX3VuaXF1ZUlkZW50aWZpZXIgPSBkb3duY2FzdDxIVE1MQXR0YWNobWVudEVsZW1lbnQ+ KHNvdXJjZSkudW5pcXVlSWRlbnRpZmllcigpOworICAgIEhUTUxFbGVtZW50Ojpjb3B5Tm9uQXR0 cmlidXRlUHJvcGVydGllc0Zyb21FbGVtZW50KHNvdXJjZSk7Cit9CisKIFVSTCBIVE1MQXR0YWNo bWVudEVsZW1lbnQ6OmFyY2hpdmVSZXNvdXJjZVVSTChjb25zdCBTdHJpbmcmIGlkZW50aWZpZXIp CiB7CiAgICAgYXV0byByZXNvdXJjZVVSTCA9IFVSTCh7IH0sICJhcHBsZXdlYmRhdGE6Ly9hdHRh Y2htZW50LyJfcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBdHRhY2ht ZW50RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQu aAppbmRleCAwMjBkYzQwMGE3NTFkODhmNDgzYzQ1MzU5N2U0MWVjZWVmODE2MGIwLi4xMmUyMGEz NTA2OTFjNmVjYTEyNjhiYmJkOTA4MWZiNWJiMDZhNTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxBdHRhY2htZW50RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50LmgKQEAgLTUyLDYgKzUyLDggQEAgcHVibGljOgogICAg IGNvbnN0IFN0cmluZyYgdW5pcXVlSWRlbnRpZmllcigpIGNvbnN0IHsgcmV0dXJuIG1fdW5pcXVl SWRlbnRpZmllcjsgfQogICAgIHZvaWQgc2V0VW5pcXVlSWRlbnRpZmllcihjb25zdCBTdHJpbmcm IHVuaXF1ZUlkZW50aWZpZXIpIHsgbV91bmlxdWVJZGVudGlmaWVyID0gdW5pcXVlSWRlbnRpZmll cjsgfQogCisgICAgdm9pZCBjb3B5Tm9uQXR0cmlidXRlUHJvcGVydGllc0Zyb21FbGVtZW50KGNv bnN0IEVsZW1lbnQmKSBmaW5hbDsKKwogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgdXBkYXRlQXR0 cmlidXRlcyhzdGQ6Om9wdGlvbmFsPHVpbnQ2NF90PiYmIG5ld0ZpbGVTaXplLCBjb25zdCBTdHJp bmcmIG5ld0NvbnRlbnRUeXBlLCBjb25zdCBTdHJpbmcmIG5ld0ZpbGVuYW1lKTsKICAgICBXRUJD T1JFX0VYUE9SVCB2b2lkIHVwZGF0ZUVuY2xvc2luZ0ltYWdlV2l0aERhdGEoY29uc3QgU3RyaW5n JiBjb250ZW50VHlwZSwgUmVmPFNoYXJlZEJ1ZmZlcj4mJiBkYXRhKTsKIApkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGI0NmU1MDEyOWNkOWQ3MzVi ZjVlYTk5M2Y5M2FlOTYyNmY3ZTczY2IuLmYyYjhlOGM0NjQwYzg3MTczMjcxM2M4ZTMzODAxMDli OGZkOTQ3MjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOC0xMi0wNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KKworICAgICAgICBbQXR0YWNobWVudCBTdXBwb3J0XSBDbG9uZWQgYXR0 YWNobWVudCBlbGVtZW50cyBsb3NlIHRoZWlyIHVuaXF1ZSBpZGVudGlmaWVycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNDgzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW50cm9kdWNlIGEgbmV3IEFQ SSB0ZXN0LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS0F0 dGFjaG1lbnRUZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE4 LTEyLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OOiBydW4td2Via2l0LXRlc3RzIG1heSBmYWlsIHdoZW4gdXNpbmcgYm9vdGVkIHNp bXVsYXRvcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvV0tBdHRhY2htZW50VGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dENvY29hL1dLQXR0YWNobWVudFRlc3RzLm1tCmluZGV4IDA0OGI5MDc4YzU2ZDFkYjA0Mzk2ZTNi YzUwNTRjZDA4ODgzZWVjM2EuLjk0NDcyYWRmOTBlMTYyYTRlNjY1ZDIxYTY3MmIwZDY1MDc0OGRj NGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tB dHRhY2htZW50VGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbQpAQCAtMTQ4OCw2ICsxNDg4LDEzIEBAIFRFU1QoV0tB dHRhY2htZW50VGVzdHMsIENvcHlBbmRQYXN0ZUJldHdlZW5XZWJWaWV3cykKICAgICBFWFBFQ1Rf V0tfU1RSRVEoImFwcGxpY2F0aW9uL3ppcCIsIHBhc3RlZEFyY2hpdmVJbmZvLmNvbnRlbnRUeXBl KTsKIH0KIAorVEVTVChXS0F0dGFjaG1lbnRUZXN0cywgQXR0YWNobWVudElkZW50aWZpZXJPZkNs b25lZEF0dGFjaG1lbnQpCit7CisgICAgYXV0byB3ZWJWaWV3ID0gd2ViVmlld0ZvclRlc3RpbmdB dHRhY2htZW50cygpOworICAgIGF1dG8gYXR0YWNobWVudCA9IHJldGFpblB0cihbd2ViVmlldyBz eW5jaHJvbm91c2x5SW5zZXJ0QXR0YWNobWVudFdpdGhGaWxlbmFtZTpAImF0dGFjaG1lbnQucGRm IiBjb250ZW50VHlwZTpAImFwcGxpY2F0aW9uL3BkZiIgZGF0YTp0ZXN0UERGRGF0YSgpXSk7Cisg ICAgRVhQRUNUX1dLX1NUUkVRKFthdHRhY2htZW50IHVuaXF1ZUlkZW50aWZpZXJdLCBbd2ViVmll dyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZG9jdW1lbnQuYm9keS5jbG9uZU5vZGUo dHJ1ZSkucXVlcnlTZWxlY3RvcignYXR0YWNobWVudCcpLnVuaXF1ZUlkZW50aWZpZXIiXSk7Cit9 CisKICNwcmFnbWEgbWFyayAtIFBsYXRmb3JtLXNwZWNpZmljIHRlc3RzCiAKICNpZiBQTEFURk9S TShNQUMpCg==