192430 2018-12-05 14:46:24 -0800 Move more macros out of WebKit's config.h 2018-12-10 09:56:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap benjamin cdumez cmarcelo dbates ews-watchlist thorton webkit-bug-importer oldest_to_newest 1485448 0 ap 2018-12-05 14:46:24 -0800 Save some bug IDs by moving multiple macros at once! 1485452 1 356662 ap 2018-12-05 14:49:26 -0800 Created attachment 356662 proposed patch These all seem straightforward. Removing ifndefs, removing #else clauses, simplifying some of the conditions. 1486179 2 356662 thorton 2018-12-07 15:09:14 -0800 Comment on attachment 356662 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=356662&action=review > Source/WTF/wtf/Platform.h:1426 > +#if PLATFORM(IOS_FAMILY) || PLATFORM(MAC) Cocoa 1486609 3 ap 2018-12-10 09:55:50 -0800 Committed http://trac.webkit.org/r239034 1486610 4 webkit-bug-importer 2018-12-10 09:56:21 -0800 <rdar://problem/46598583> 356662 2018-12-05 14:49:26 -0800 2018-12-07 15:09:14 -0800 proposed patch VersionMacro10.txt text/plain 3653 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzg5MDgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTEyLTA1ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgbW9yZSBtYWNyb3Mgb3V0IG9mIFdlYktp dCdzIGNvbmZpZy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTI0MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE4LTEyLTA0ICBDYXJsb3MgR2FyY2lhIENhbXBv cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09VUF0gTW92ZSBVUkxTb3VwIGJh Y2sgdG8gV2ViQ29yZSBhZnRlciByMjM4NzcxCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDIz ODgwMCkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0 MTgsMyArMTQxOCwyNCBAQAogI2RlZmluZSBVU0VfQ0ZORVRXT1JLX0FVVE9fQURERURfSFRUUF9I RUFERVJfU1VQUFJFU1NJT04gMQogI2VuZGlmCiAjZW5kaWYKKworI2lmIFBMQVRGT1JNKE1BQykK KyNkZWZpbmUgSEFWRV9XSU5ET1dfU0VSVkVSX09DQ0xVU0lPTl9OT1RJRklDQVRJT05TIDEKKyNl bmRpZgorCisjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgfHwgUExBVEZPUk0oTUFDKQorI2RlZmlu ZSBIQVZFX1NFQ19BQ0NFU1NfQ09OVFJPTCAxCisjZW5kaWYKKworI2lmIFBMQVRGT1JNKElPUykK Ky8qIEZJWE1FOiBTYWZhcmlTZXJ2aWNlcy5mcmFtZXdvcmsgZXhpc3RzIG9uIG1hY09TLiBJdCBp cyBvbmx5IHVzZWQgYnkgV2ViS2l0IG9uIGlPUywgc28gdGhlIGJlaGF2aW9yIGlzIGNvcnJlY3Qs IGJ1dCB0aGUgbmFtZSBpcyBtaXNsZWFkaW5nLiAqLworI2RlZmluZSBIQVZFX1NBRkFSSV9TRVJW SUNFU19GUkFNRVdPUksgMQorI2VuZGlmCisKKyNpZiAoKFBMQVRGT1JNKE1BQykgJiYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDApIHx8IFBMQVRGT1JNKElPUykpICYm ICFkZWZpbmVkKF9faTM4Nl9fKQorI2RlZmluZSBIQVZFX1NBRkVfQlJPV1NJTkcgMQorI2VuZGlm CisKKyNpZiBQTEFURk9STShJT1MpCisjZGVmaW5lIEhBVkVfTElOS19QUkVWSUVXIDEKKyNlbmRp ZgpJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODkxMSkKKysrIFNvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMTItMDUgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBtb3JlIG1hY3JvcyBv dXQgb2YgV2ViS2l0J3MgY29uZmlnLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MjQzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogY29uZmlnLmg6CisKIDIwMTgtMTItMDUgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGlmeSBsb2dpYyBpbnNpZGUgV2ViUGFn ZVByb3h5Ojpjb250aW51ZU5hdmlnYXRpb25Jbk5ld1Byb2Nlc3MoKQpJbmRleDogU291cmNlL1dl YktpdC9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2NvbmZpZy5oCShyZXZp c2lvbiAyMzg4MDApCisrKyBTb3VyY2UvV2ViS2l0L2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBA IC02NiwxMiArNjYsNiBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKE1BQykKLSNp Zm5kZWYgSEFWRV9XSU5ET1dfU0VSVkVSX09DQ0xVU0lPTl9OT1RJRklDQVRJT05TCi0jZGVmaW5l IEhBVkVfV0lORE9XX1NFUlZFUl9PQ0NMVVNJT05fTk9USUZJQ0FUSU9OUyAxCi0jZW5kaWYKLSNl bmRpZgotCiAvLyBGSVhNRTogV2Ugc2hvdWxkIHdvcmsgdG93YXJkcyBub3QgdXNpbmcgQ3JlZGVu dGlhbFN0b3JhZ2UgaW4gV2ViS2l0IHRvIG5vdCBoYXZlIHByb2JsZW1zIHdpdGggZGlnZXN0IGF1 dGhlbnRpY2F0aW9uLgogI2lmbmRlZiBVU0VfQ1JFREVOVElBTF9TVE9SQUdFX1dJVEhfTkVUV09S S19TRVNTSU9OCiAjZGVmaW5lIFVTRV9DUkVERU5USUFMX1NUT1JBR0VfV0lUSF9ORVRXT1JLX1NF U1NJT04gMQpAQCAtODMsMTIgKzc3LDYgQEAKICNlbmRpZgogI2VuZGlmCiAKLSNpZm5kZWYgSEFW RV9TRUNfQUNDRVNTX0NPTlRST0wKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKSB8fCBQTEFURk9S TShNQUMpCi0jZGVmaW5lIEhBVkVfU0VDX0FDQ0VTU19DT05UUk9MIDEKLSNlbmRpZgotI2VuZGlm Ci0KICNpZm5kZWYgRU5BQkxFX05FVFdPUktfQ0FDSEVfU1BFQ1VMQVRJVkVfUkVWQUxJREFUSU9O CiAjaWYgKFBMQVRGT1JNKENPQ09BKSB8fCBQTEFURk9STShHVEspKQogI2RlZmluZSBFTkFCTEVf TkVUV09SS19DQUNIRV9TUEVDVUxBVElWRV9SRVZBTElEQVRJT04gMQpAQCAtOTcsMjggKzg1LDYg QEAKICNlbmRpZgogI2VuZGlmCiAKLSNpZm5kZWYgSEFWRV9TQUZBUklfU0VSVklDRVNfRlJBTUVX T1JLCi0jaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgKCFkZWZpbmVkIFRBUkdFVF9PU19JT1Mg fHwgVEFSR0VUX09TX0lPUykgJiYgIVBMQVRGT1JNKElPU01BQykKLSNkZWZpbmUgSEFWRV9TQUZB UklfU0VSVklDRVNfRlJBTUVXT1JLIDEKLSNlbHNlCi0jZGVmaW5lIEhBVkVfU0FGQVJJX1NFUlZJ Q0VTX0ZSQU1FV09SSyAwCi0jZW5kaWYKLSNlbmRpZgotCi0jaWZuZGVmIEhBVkVfTElOS19QUkVW SUVXCi0jaWYgZGVmaW5lZCBUQVJHRVRfT1NfSU9TICYmIFRBUkdFVF9PU19JT1MKLSNkZWZpbmUg SEFWRV9MSU5LX1BSRVZJRVcgMQotI2Vsc2UKLSNkZWZpbmUgSEFWRV9MSU5LX1BSRVZJRVcgMAot I2VuZGlmCi0jZW5kaWYKLQotI2lmICgoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEID49IDEwMTMwMCkgfHwgKFBMQVRGT1JNKElPU19GQU1JTFkpICYmIF9f SVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDExMDAwMCkpICYmICFkZWZpbmVkKF9f aTM4Nl9fKSAmJiAhUExBVEZPUk0oSU9TTUFDKQotI2RlZmluZSBIQVZFX1NBRkVfQlJPV1NJTkcg MQotI2Vsc2UKLSNkZWZpbmUgSEFWRV9TQUZFX0JST1dTSU5HIDAKLSNlbmRpZgotCiAjaWZuZGVm IEVOQUJMRV9IVFRQU19VUEdSQURFCiAjZGVmaW5lIEVOQUJMRV9IVFRQU19VUEdSQURFIDAKICNl bmRpZgo=