192428 2018-12-05 14:28:31 -0800 Move ENABLE_SEC_ITEM_SHIM out of WebKit's config.h 2018-12-10 10:08:27 -0800 1 1 1 Unclassified WebKit Animations Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap achristensen benjamin cdumez cmarcelo commit-queue dbates dino ews-watchlist thorton webkit-bug-importer oldest_to_newest 1485432 0 ap 2018-12-05 14:28:31 -0800 Doing it in small pieces. 1485436 1 356659 ap 2018-12-05 14:30:55 -0800 Created attachment 356659 proposed patch This also removes an ifndef, as I can't see any reason to check for earlier definition. At best, that can help trigger it from command line, but why? 1485440 2 356659 achristensen 2018-12-05 14:33:27 -0800 Comment on attachment 356659 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=356659&action=review > Source/WTF/wtf/Platform.h:1422 > +#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY) #if PLATFORM(COCOA)? > Source/WTF/wtf/Platform.h:1423 > +/* FIXME: This is a USE style macro, as it triggers the use of CFURLConnection framework stubs. */ Interesting. CFURLConnection isn't used on Cocoa platforms any more. Do we still need this code at all? 1485454 3 ap 2018-12-05 14:53:37 -0800 Unsure. These hooks are set globally per process, and I didn't check if anything in the underlying implementation of the modern API uses them. Also unsure if WebContent still needs them, or if all loading is gone for good from it. 1486611 4 356659 commit-queue 2018-12-10 09:59:02 -0800 Comment on attachment 356659 proposed patch Rejecting attachment 356659 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 356659, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=356659&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=192428&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 356659 from bug 192428. Fetching: https://bugs.webkit.org/attachment.cgi?id=356659 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file Source/WTF/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WTF/wtf/Platform.h Hunk #1 succeeded at 1448 with fuzz 2 (offset 30 lines). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/config.h Hunk #1 FAILED at 60. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/config.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10339329 1486618 5 ap 2018-12-10 10:07:11 -0800 Committed http://trac.webkit.org/r239035 It would be nice if this code can be just removed, but I won't be investigating that now. Added a FIXME. 1486619 6 webkit-bug-importer 2018-12-10 10:08:27 -0800 <rdar://problem/46599118> 356659 2018-12-05 14:30:55 -0800 2018-12-10 09:59:02 -0800 proposed patch VersionMacro9.txt text/plain 2144 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzg5MDgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTEyLTA1ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgRU5BQkxFX1NFQ19JVEVNX1NISU0gb3V0 IG9mIFdlYktpdCdzIGNvbmZpZy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTI0MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE4LTEyLTA0ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09VUF0gTW92ZSBV UkxTb3VwIGJhY2sgdG8gV2ViQ29yZSBhZnRlciByMjM4NzcxCkluZGV4OiBTb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJl dmlzaW9uIDIzODgwMCkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29w eSkKQEAgLTE0MTgsMyArMTQxOCw4IEBACiAjZGVmaW5lIFVTRV9DRk5FVFdPUktfQVVUT19BRERF RF9IVFRQX0hFQURFUl9TVVBQUkVTU0lPTiAxCiAjZW5kaWYKICNlbmRpZgorCisjaWYgUExBVEZP Uk0oTUFDKSB8fCBQTEFURk9STShJT1NfRkFNSUxZKQorLyogRklYTUU6IFRoaXMgaXMgYSBVU0Ug c3R5bGUgbWFjcm8sIGFzIGl0IHRyaWdnZXJzIHRoZSB1c2Ugb2YgQ0ZVUkxDb25uZWN0aW9uIGZy YW1ld29yayBzdHVicy4gKi8KKyNkZWZpbmUgRU5BQkxFX1NFQ19JVEVNX1NISU0gMQorI2VuZGlm CkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjM4OTA4KQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxOC0xMi0wNSAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIEVOQUJMRV9TRUNfSVRF TV9TSElNIG91dCBvZiBXZWJLaXQncyBjb25maWcuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjb25maWcuaDoKKwogMjAxOC0xMi0wNSAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgV2Vi c2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24gYSBwcm9wZXIgQVBJIG9iamVjdApJbmRleDogU291 cmNlL1dlYktpdC9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2NvbmZpZy5o CShyZXZpc2lvbiAyMzg4MDApCisrKyBTb3VyY2UvV2ViS2l0L2NvbmZpZy5oCSh3b3JraW5nIGNv cHkpCkBAIC02MCwxMiArNjAsNiBAQAogCiAjZGVmaW5lIFBMVUdJTl9BUkNISVRFQ1RVUkUoQVJD SCkgKGRlZmluZWQgUExVR0lOX0FSQ0hJVEVDVFVSRV8jI0FSQ0ggJiYgUExVR0lOX0FSQ0hJVEVD VFVSRV8jI0FSQ0gpCiAKLSNpZm5kZWYgRU5BQkxFX1NFQ19JVEVNX1NISU0KLSNpZiBQTEFURk9S TShNQUMpIHx8IFBMQVRGT1JNKElPU19GQU1JTFkpCi0jZGVmaW5lIEVOQUJMRV9TRUNfSVRFTV9T SElNIDEKLSNlbmRpZgotI2VuZGlmCi0KICNpZiBQTEFURk9STShNQUMpCiAjaWZuZGVmIEhBVkVf V0lORE9XX1NFUlZFUl9PQ0NMVVNJT05fTk9USUZJQ0FUSU9OUwogI2RlZmluZSBIQVZFX1dJTkRP V19TRVJWRVJfT0NDTFVTSU9OX05PVElGSUNBVElPTlMgMQo=