192413 2018-12-05 11:13:50 -0800 webkitpy: Clean-up apple_additions 2018-12-05 14:34:59 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1485318 0 jbedard 2018-12-05 11:13:50 -0800 There is some duplication of functions in apple additions, which is fallout from moving watchOS ports from apple_additions into webkitpy. 1485319 1 webkit-bug-importer 2018-12-05 11:14:41 -0800 <rdar://problem/46493491> 1485331 2 356626 jbedard 2018-12-05 11:24:49 -0800 Created attachment 356626 Patch 1485442 3 356626 commit-queue 2018-12-05 14:34:57 -0800 Comment on attachment 356626 Patch Clearing flags on attachment: 356626 Committed r238910: <https://trac.webkit.org/changeset/238910> 1485443 4 commit-queue 2018-12-05 14:34:59 -0800 All reviewed patches have been landed. Closing bug. 356626 2018-12-05 11:24:49 -0800 2018-12-05 14:34:57 -0800 Patch bug-192413-20181205112449.patch text/plain 2194 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODkwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE4LTEyLTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQ2xlYW4tdXAgYXBwbGVfYWRkaXRpb25zCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI0MTMKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzQ2NDkzNDkxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFmdGVyIHRoZSBhZGRpdGlvbiBvZiB3YXRjaE9TLCBzb21lIGZ1 bmN0aW9ucyB3aGljaCB3ZXJlIG9yaWdpbmFsbHkgaU9TIHNwZWNpZmljIHdlcmUKKyAgICAgICAg Z2VuZXJhbGl6ZWQgdG8gaW5jbHVkZSBhbGwgZGV2aWNlcy4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvcG9ydC9pb3NfZGV2aWNlLnB5OgorICAgICAgICAoSU9TRGV2aWNlUG9ydC5fZHJp dmVyX2NsYXNzKTogUmVwbGFjZSBpT1Mgc3BlY2lmaWMgY2FsbCB3aXRoIGdlbmVyYWxpemVkIGRl dmljZSBjYWxsLgorICAgICAgICAoSU9TRGV2aWNlUG9ydC5wYXRoX3RvX2NyYXNoX2xvZ3MpOiBE aXR0by4KKyAgICAgICAgKElPU0RldmljZVBvcnQuY2xlYW5fdXBfdGVzdF9ydW4pOiBEaXR0by4K KwogMjAxOC0xMi0wNSAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW01TRV1bR1N0cmVhbWVyXSBSZW1vdmUgdGhlIEFwcGVuZFBpcGVsaW5lIHN0YXRl IG1hY2hpbmUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3NfZGV2aWNlLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3NfZGV2aWNlLnB5 CShyZXZpc2lvbiAyMzg5MDApCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX2Rl dmljZS5weQkod29ya2luZyBjb3B5KQpAQCAtNTIsNyArNTIsNyBAQCBjbGFzcyBJT1NEZXZpY2VQ b3J0KElPU1BvcnQpOgogCiAgICAgZGVmIF9kcml2ZXJfY2xhc3Moc2VsZik6CiAgICAgICAgIGlm IGFwcGxlX2FkZGl0aW9ucygpOgotICAgICAgICAgICAgcmV0dXJuIGFwcGxlX2FkZGl0aW9ucygp Lmlvc19kZXZpY2VfZHJpdmVyKCkKKyAgICAgICAgICAgIHJldHVybiBhcHBsZV9hZGRpdGlvbnMo KS5kZXZpY2VfZHJpdmVyKCkKICAgICAgICAgcmV0dXJuIHN1cGVyKElPU0RldmljZVBvcnQsIHNl bGYpLl9kcml2ZXJfY2xhc3MoKQogCiAgICAgQGNsYXNzbWV0aG9kCkBAIC02Nyw3ICs2Nyw3IEBA IGNsYXNzIElPU0RldmljZVBvcnQoSU9TUG9ydCk6CiAgICAgZGVmIHBhdGhfdG9fY3Jhc2hfbG9n cyhzZWxmKToKICAgICAgICAgaWYgbm90IGFwcGxlX2FkZGl0aW9ucygpOgogICAgICAgICAgICAg cmFpc2UgUnVudGltZUVycm9yKHNlbGYuTk9fT05fREVWSUNFX1RFU1RJTkcpCi0gICAgICAgIHJl dHVybiBhcHBsZV9hZGRpdGlvbnMoKS5pb3NfY3Jhc2hfbG9nX3BhdGgoKQorICAgICAgICByZXR1 cm4gYXBwbGVfYWRkaXRpb25zKCkuZGV2aWNlX2NyYXNoX2xvZ19wYXRoKCkKIAogICAgIGRlZiBf bG9va19mb3JfYWxsX2NyYXNoX2xvZ3NfaW5fbG9nX2RpcihzZWxmLCBuZXdlcl90aGFuKToKICAg ICAgICAgbG9nX2xpc3QgPSB7fQpAQCAtMTE1LDQgKzExNSw0IEBAIGNsYXNzIElPU0RldmljZVBv cnQoSU9TUG9ydCk6CiAKICAgICBkZWYgY2xlYW5fdXBfdGVzdF9ydW4oc2VsZik6CiAgICAgICAg IHN1cGVyKElPU0RldmljZVBvcnQsIHNlbGYpLmNsZWFuX3VwX3Rlc3RfcnVuKCkKLSAgICAgICAg YXBwbGVfYWRkaXRpb25zKCkuaW9zX2RldmljZV9jbGVhbl91cF90ZXN0X3J1bihzZWxmLCBzZWxm Ll9wYXRoX3RvX2RyaXZlcigpLCBzZWxmLl9idWlsZF9wYXRoKCkpCisgICAgICAgIGFwcGxlX2Fk ZGl0aW9ucygpLmRldmljZV9jbGVhbl91cF90ZXN0X3J1bihzZWxmLCBzZWxmLl9wYXRoX3RvX2Ry aXZlcigpLCBzZWxmLl9idWlsZF9wYXRoKCkpCg==