192403 2018-12-05 09:18:58 -0800 Add some sanity checks inside WebBackForwardList::addItem() 2018-12-05 09:30:10 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 cdumez cdumez achristensen beidson ews-watchlist oldest_to_newest 1485259 0 cdumez 2018-12-05 09:18:58 -0800 Add some sanity checks inside WebBackForwardList::addItem() to help debug <rdar://problem/46399319>. This crash seems to indicate that WebBackForwardList::m_entries can contain duplicate entries somehow. 1485260 1 356611 cdumez 2018-12-05 09:19:58 -0800 Created attachment 356611 Patch 1485261 2 ews-watchlist 2018-12-05 09:22:08 -0800 Attachment 356611 did not pass style-queue: ERROR: Source/WebKit/UIProcess/WebBackForwardList.cpp:95: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/UIProcess/WebBackForwardList.cpp:164: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 356611 2018-12-05 09:19:58 -0800 2018-12-05 09:30:05 -0800 Patch bug-192403-20181205091957.patch text/plain 2142 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU1ZGZmMWMwMTlhODVmYWM0 MTMzYmExNzIyMGFmYjE1MjA1NDU4M2IuLmVmOThmYTM2ZmE3NTRiZjczNzllOTQ3YjU2MDYyNWE1 OWU4Yjk0MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTItMDUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc29tZSBzYW5pdHkgY2hlY2tz IGluc2lkZSBXZWJCYWNrRm9yd2FyZExpc3Q6OmFkZEl0ZW0oKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNDAzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNvbWUgc2FuaXR5IGNoZWNrcyBpbnNp ZGUgV2ViQmFja0ZvcndhcmRMaXN0OjphZGRJdGVtKCkgdG8gaGVscCBkZWJ1ZyA8cmRhcjovL3By b2JsZW0vNDYzOTkzMTk+LgorICAgICAgICBUaGlzIGNyYXNoIHNlZW1zIHRvIGluZGljYXRlIHRo YXQgV2ViQmFja0ZvcndhcmRMaXN0OjptX2VudHJpZXMgY2FuIGNvbnRhaW4gZHVwbGljYXRlIGVu dHJpZXMgc29tZWhvdy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3Qu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExpc3Q6OmFkZEl0ZW0pOgorCiAy MDE4LTEyLTA0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVn cmVzc2lvbihyMjM4ODE3KSBQU09OIFBhZ2UgQ2FjaGUgQVBJIHRlc3RzIGFyZSBmYWlsaW5nCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQmFja0ZvcndhcmRMaXN0LmNwcAppbmRleCAy MmNhNGMzZGI0ZjZkMDMxZTYwNjk3ODNjMWQ3OGJjZmY2ZmUxOWRjLi4wZjYzZjAzNGIzNzhiM2U4 NGE0MTJkOGU4Zjk5N2JjOTY2YjU0YTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYkJhY2tGb3J3YXJkTGlzdC5jcHAKQEAgLTkyLDYgKzkyLDggQEAgdm9pZCBXZWJCYWNrRm9y d2FyZExpc3Q6OmFkZEl0ZW0oUmVmPFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0+JiYgbmV3SXRlbSkK ICAgICBpZiAoIW1fcGFnZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgQVNTRVJUKG1fZW50cmll cy5maW5kTWF0Y2hpbmcoW25ld0l0ZW1QdHIgPSBuZXdJdGVtLnB0cigpXShhdXRvJiBpdGVtKSB7 IHJldHVybiBpdGVtLnB0cigpID09IG5ld0l0ZW1QdHI7IH0pID09IG5vdEZvdW5kKTsKKwogICAg IFZlY3RvcjxSZWY8V2ViQmFja0ZvcndhcmRMaXN0SXRlbT4+IHJlbW92ZWRJdGVtczsKICAgICAK ICAgICBpZiAobV9jdXJyZW50SW5kZXgpIHsKQEAgLTE1OSw2ICsxNjEsOCBAQCB2b2lkIFdlYkJh Y2tGb3J3YXJkTGlzdDo6YWRkSXRlbShSZWY8V2ViQmFja0ZvcndhcmRMaXN0SXRlbT4mJiBuZXdJ dGVtKQogICAgICAgICAgICAgbV9lbnRyaWVzLmluc2VydCgqbV9jdXJyZW50SW5kZXgsIFdURk1v dmUobmV3SXRlbSkpOwogICAgIH0KIAorICAgIEFTU0VSVChzdGQ6OmNvdW50X2lmKG1fZW50cmll cy5iZWdpbigpLCBtX2VudHJpZXMuZW5kKCksIFtuZXdJdGVtUHRyXShhdXRvJiBpdGVtKSB7IHJl dHVybiBpdGVtLnB0cigpID09IG5ld0l0ZW1QdHI7IH0pID09IDEpOworCiAgICAgTE9HKEJhY2tG b3J3YXJkLCAiKEJhY2svRm9yd2FyZCkgV2ViQmFja0ZvcndhcmRMaXN0ICVwIGFkZGVkIGFuIGl0 ZW0uIEN1cnJlbnQgc2l6ZSAlenUsIGN1cnJlbnQgaW5kZXggJXp1LCB0aHJldyBhd2F5ICV6dSBp dGVtcyIsIHRoaXMsIG1fZW50cmllcy5zaXplKCksICptX2N1cnJlbnRJbmRleCwgcmVtb3ZlZEl0 ZW1zLnNpemUoKSk7CiAgICAgbV9wYWdlLT5kaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QobmV3SXRl bVB0ciwgV1RGTW92ZShyZW1vdmVkSXRlbXMpKTsKIH0K