192390 2018-12-04 18:13:57 -0800 Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false 2018-12-05 15:50:17 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P3 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1485104 0 mattbaker 2018-12-04 18:13:57 -0800 Summary: SelectionController should not extend the selection when allowsMultipleSelection is false. Note: It isn't possible to circumvent the `allowsMultipleSelection` flag using the UI (by shift/command-clicking). This change will prevent circumventing the flag by setting `extendSelection = true` when calling `SelectionController.prototype.selectItem`. 1485105 1 webkit-bug-importer 2018-12-04 18:14:31 -0800 <rdar://problem/46473624> 1485108 2 356567 mattbaker 2018-12-04 18:21:46 -0800 Created attachment 356567 Patch 1485473 3 356567 hi 2018-12-05 15:24:28 -0800 Comment on attachment 356567 Patch r=me 1485484 4 356567 commit-queue 2018-12-05 15:50:16 -0800 Comment on attachment 356567 Patch Clearing flags on attachment: 356567 Committed r238914: <https://trac.webkit.org/changeset/238914> 1485485 5 commit-queue 2018-12-05 15:50:17 -0800 All reviewed patches have been landed. Closing bug. 356567 2018-12-04 18:21:46 -0800 2018-12-05 15:50:16 -0800 Patch bug-192390-20181204182138.patch text/plain 5636 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 MjcxY2FhOGEyZWRhYjZiMDAwZjBlNDZjM2MwZDlmNDgyNGE5OGEwLi44NWYzNTE4NTFjYWE2Zjcx YmIwZmQxMDE5NzYwZjYyNjRjOWQ5NzFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0xMi0wNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2VsZWN0aW9uQ29udHJvbGxlciBzaG91bGQgbm90 IGV4dGVuZCB0aGUgc2VsZWN0aW9uIHdoZW4gYWxsb3dzTXVsdGlwbGVTZWxlY3Rpb24gaXMgZmFs c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjM5 MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY0NzM2MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L1NlbGVjdGlvbkNvbnRyb2xsZXIuanM6CisgICAgICAgIChXSS5TZWxlY3Rpb25Db250cm9sbGVy LnByb3RvdHlwZS5zZWxlY3RJdGVtKToKKwogMjAxOC0xMi0wNCAgTWF0dCBCYWtlciAgPG1hdHRi YWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjM4 NjAyKTogRWxlbWVudHM6IGNoYW5naW5nIHNlbGVjdGlvbiBubyBsb25nZXIgaGlnaGxpZ2h0cyB0 aGUgc2VsZWN0ZWQgbm9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvU2VsZWN0aW9uQ29udHJvbGxlci5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NlbGVjdGlvbkNvbnRyb2xsZXIu anMKaW5kZXggZWE5ZTNiZmY1YTRmYzJlOTFjNTdhNzM1ZWE4NTg4NjI0OThhZTMwOC4uNzI1ZWMz ZTZlOGNkZmVmMjIyNzIxYzlhZGQzZDVlZTliMzI1NmRlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvU2VsZWN0aW9uQ29udHJvbGxl ci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9TZWxlY3Rpb25Db250cm9sbGVyLmpzCkBAIC04Nyw2ICs4Nyw5IEBAIFdJLlNlbGVjdGlvbkNv bnRyb2xsZXIgPSBjbGFzcyBTZWxlY3Rpb25Db250cm9sbGVyIGV4dGVuZHMgV0kuT2JqZWN0CiAg ICAgICAgIGNvbnNvbGUuYXNzZXJ0KCFleHRlbmRTZWxlY3Rpb24gfHwgdGhpcy5fYWxsb3dzTXVs dGlwbGVTZWxlY3Rpb24sICJDYW5ub3QgZXh0ZW5kIHNlbGVjdGlvbiB3aXRoIG11bHRpcGxlIHNl bGVjdGlvbiBkaXNhYmxlZC4iKTsKICAgICAgICAgY29uc29sZS5hc3NlcnQoaW5kZXggPj0gMCAm JiBpbmRleCA8IHRoaXMubnVtYmVyT2ZJdGVtcyk7CiAKKyAgICAgICAgaWYgKCF0aGlzLl9hbGxv d3NNdWx0aXBsZVNlbGVjdGlvbikKKyAgICAgICAgICAgIGV4dGVuZFNlbGVjdGlvbiA9IGZhbHNl OworCiAgICAgICAgIGlmICh0aGlzLmhhc1NlbGVjdGVkSXRlbShpbmRleCkpIHsKICAgICAgICAg ICAgIGlmICghZXh0ZW5kU2VsZWN0aW9uKQogICAgICAgICAgICAgICAgIHRoaXMuX2Rlc2VsZWN0 QWxsQW5kU2VsZWN0KGluZGV4KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiOWM5MDJiY2Y0MWI1ZjczMGNjNDQxZGQyZDdm NjU4YjEwYzRmNmUxLi5iNzg4ZDc5MzU1NjRiMDQ4ZTM4ODRlZWJlODA2NDkyOWExNTI1MDg3IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTItMDQgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJA YXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNlbGVjdGlvbkNvbnRyb2xsZXIg c2hvdWxkIG5vdCBleHRlbmQgdGhlIHNlbGVjdGlvbiB3aGVuIGFsbG93c011bHRpcGxlU2VsZWN0 aW9uIGlzIGZhbHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTIzOTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NDczNjI0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3RhYmxl L3RhYmxlLXNlbGVjdGlvbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL3RhYmxl L3RhYmxlLXNlbGVjdGlvbi5odG1sOgorICAgICAgICBEcml2ZS1ieSBmaXg6IHJlbW92ZWQgYGFs bG93c011bHRpcGxlU2VsZWN0aW9uYCBjaGVjayBmcm9tIHRlc3QgY2FzZQorICAgICAgICBUYWJs ZS5TZWxlY3RNdWx0aXBsZVJvd3MuRXh0ZW5kU2VsZWN0aW9uIHNpbmNlIGl0IGlzIHRlc3RlZCBp biBUYWJsZS5BbGxvd3NNdWx0aXBsZVNlbGVjdGlvbi4KKwogMjAxOC0xMS0zMCAgSmlld2VuIFRh biAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IHJlcG9ydCByZXNvdXJj ZSB0aW1pbmcgdG8gcGFyZW50IGZyYW1lIGZvciBoaXN0b3J5IGl0ZW1zCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbnNwZWN0b3IvdGFibGUvdGFibGUtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2luc3BlY3Rvci90YWJsZS90YWJsZS1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0 CmluZGV4IDU4ZGNjZjJhYjQwOWM3NWU0M2I5ZDg4YTE4YjZkY2U1Y2JmOTFjZjAuLjg1YjMxZjUw MWFhMmJhMWY5ZTE3NzNkY2RkZjIxYjBkNTc5YjdjNmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci90YWJsZS90YWJsZS1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci90YWJsZS90YWJsZS1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CkBAIC0z MSw3ICszMSw2IEBAIFBBU1M6IGFsbG93c011bHRpcGxlU2VsZWN0aW9uIGVuYWJsZWQuCiBQQVNT OiBhbGxvd3NNdWx0aXBsZVNlbGVjdGlvbiBkaXNhYmxlZC4KIAogLS0gUnVubmluZyB0ZXN0IGNh c2U6IFRhYmxlLlNlbGVjdE11bHRpcGxlUm93cy5FeHRlbmRTZWxlY3Rpb24KLVBBU1M6IGFsbG93 c011bHRpcGxlU2VsZWN0aW9uIGVuYWJsZWQuCiBTZWxlY3Rpbmcgcm93IDAuCiBQQVNTOiBUYWJs ZSBzZWxlY3Rpb24gY2hhbmdlZC4KIFBBU1M6IHNlbGVjdGVkUm93IHNob3VsZCBiZSAwLgpAQCAt NDMsNiArNDIsMTUgQEAgUEFTUzogVGFibGUgc2VsZWN0aW9uIGNoYW5nZWQuCiBQQVNTOiBzZWxl Y3RlZFJvdyBzaG91bGQgYmUgOS4KIFBBU1M6IHNlbGVjdGVkUm93cyBzaG91bGQgYmUgWzAsIDEs IDldLgogCistLSBSdW5uaW5nIHRlc3QgY2FzZTogVGFibGUuU2VsZWN0TXVsdGlwbGVSb3dzLkV4 dGVuZFNlbGVjdGlvbi5NdWx0aXBsZVNlbGVjdGlvbkRpc2FibGVkCitTZWxlY3Rpbmcgcm93IDAu CitQQVNTOiBUYWJsZSBzZWxlY3Rpb24gY2hhbmdlZC4KK1BBU1M6IHNlbGVjdGVkUm93IHNob3Vs ZCBiZSAwLgorU2VsZWN0aW5nIHJvdyAxLgorUEFTUzogVGFibGUgc2VsZWN0aW9uIGNoYW5nZWQu CitQQVNTOiBzZWxlY3RlZFJvdyBzaG91bGQgYmUgMS4KK1BBU1M6IHNlbGVjdGVkUm93cyBzaG91 bGQgYmUgWzFdLgorCiAtLSBSdW5uaW5nIHRlc3QgY2FzZTogVGFibGUuU2VsZWN0TXVsdGlwbGVS b3dzLlNlbGVjdFRoZVNhbWVSb3dUd2ljZS5FeHRlbmRTZWxlY3Rpb24KIFNlbGVjdGluZyByb3cg MC4KIFBBU1M6IFRhYmxlIHNlbGVjdGlvbiBjaGFuZ2VkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL3RhYmxlL3RhYmxlLXNlbGVjdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3RhYmxlL3RhYmxlLXNlbGVjdGlvbi5odG1sCmluZGV4IDI3YWU3YmFjYTFkYmZjY2Fh MDAzNjgwNWIyMjFkZGIyODA0OGEwYjkuLmRkZDdhMzhhMWYxOGEyODY2ZWRmMTQzMDI3MTk0OTU3 OTlmOTgwMDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci90YWJsZS90YWJsZS1z ZWxlY3Rpb24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdGFibGUvdGFibGUtc2Vs ZWN0aW9uLmh0bWwKQEAgLTc4LDEzICs3OCwxMyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAg ICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CiAgICAgfSk7CisKICAgICBzdWl0ZS5hZGRUZXN0 Q2FzZSh7CiAgICAgICAgIG5hbWU6ICJUYWJsZS5TZWxlY3RNdWx0aXBsZVJvd3MuRXh0ZW5kU2Vs ZWN0aW9uIiwKICAgICAgICAgZGVzY3JpcHRpb246ICJTZWxlY3QgbXVsdGlwbGUgcm93cywgZXh0 ZW5kaW5nIHRoZSBzZWxlY3Rpb24uIiwKICAgICAgICAgdGVzdCgpIHsKICAgICAgICAgICAgIGxl dCB0YWJsZSA9IEluc3BlY3RvclRlc3QuY3JlYXRlVGFibGUoKTsKICAgICAgICAgICAgIHRhYmxl LmFsbG93c011bHRpcGxlU2VsZWN0aW9uID0gdHJ1ZTsKLSAgICAgICAgICAgIEluc3BlY3RvclRl c3QuZXhwZWN0VGhhdCh0YWJsZS5hbGxvd3NNdWx0aXBsZVNlbGVjdGlvbiwgImFsbG93c011bHRp cGxlU2VsZWN0aW9uIGVuYWJsZWQuIik7CiAKICAgICAgICAgICAgIGNvbnN0IGV4dGVuZFNlbGVj dGlvbiA9IHRydWU7CiAKQEAgLTk3LDYgKzk3LDIzIEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAg ICB9CiAgICAgfSk7CiAKKyAgICBzdWl0ZS5hZGRUZXN0Q2FzZSh7CisgICAgICAgIG5hbWU6ICJU YWJsZS5TZWxlY3RNdWx0aXBsZVJvd3MuRXh0ZW5kU2VsZWN0aW9uLk11bHRpcGxlU2VsZWN0aW9u RGlzYWJsZWQiLAorICAgICAgICBkZXNjcmlwdGlvbjogIkF0dGVtcHQgdG8gZXh0ZW5kIHRoZSBz ZWxlY3Rpb24gd2hlbiBtdWx0aXBsZSBzZWxlY3Rpb24gaXMgZGlzYWJsZWQuIiwKKyAgICAgICAg dGVzdCgpIHsKKyAgICAgICAgICAgIGxldCB0YWJsZSA9IEluc3BlY3RvclRlc3QuY3JlYXRlVGFi bGUoKTsKKyAgICAgICAgICAgIHRhYmxlLmFsbG93c011bHRpcGxlU2VsZWN0aW9uID0gZmFsc2U7 CisKKyAgICAgICAgICAgIGNvbnN0IGV4dGVuZFNlbGVjdGlvbiA9IHRydWU7CisKKyAgICAgICAg ICAgIHRyaWdnZXJTZWxlY3RSb3codGFibGUsIDAsIGV4dGVuZFNlbGVjdGlvbik7CisgICAgICAg ICAgICB0cmlnZ2VyU2VsZWN0Um93KHRhYmxlLCAxLCBleHRlbmRTZWxlY3Rpb24pOworICAgICAg ICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RTaGFsbG93RXF1YWwodGFibGUuc2VsZWN0ZWRSb3dz LCBbMV0sICJzZWxlY3RlZFJvd3Mgc2hvdWxkIGJlIFsxXS4iKTsKKworICAgICAgICAgICAgcmV0 dXJuIHRydWU7CisgICAgICAgIH0KKyAgICB9KTsKKwogICAgIHN1aXRlLmFkZFRlc3RDYXNlKHsK ICAgICAgICAgbmFtZTogIlRhYmxlLlNlbGVjdE11bHRpcGxlUm93cy5TZWxlY3RUaGVTYW1lUm93 VHdpY2UuRXh0ZW5kU2VsZWN0aW9uIiwKICAgICAgICAgZGVzY3JpcHRpb246ICJTZWxlY3QgYW4g YWxyZWFkeSBzZWxlY3RlZCByb3csIGFuZCBleHRlbmQgdGhlIHNlbGVjdGlvbi4iLAo=