192378 2018-12-04 14:12:21 -0800 Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled. 2018-12-17 15:02:59 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Mac macOS 10.14 RESOLVED FIXED InRadar P2 Normal --- 1 skoppisetty webkit-unassigned cdumez commit-queue ews-watchlist rniwa skoppisetty webkit-bug-importer oldest_to_newest 1485001 0 skoppisetty 2018-12-04 14:12:21 -0800 FeedbackServer currently depends on Tornado-5.1, which further adds dependency of "singledispatch", "backports-abc" and "futures" python libraries. Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled will let us run the benchmark scripts without installing any new python libraries. 1485007 1 356534 skoppisetty 2018-12-04 14:28:14 -0800 Created attachment 356534 Patch 1488615 2 356534 commit-queue 2018-12-17 15:01:52 -0800 Comment on attachment 356534 Patch Clearing flags on attachment: 356534 Committed r239292: <https://trac.webkit.org/changeset/239292> 1488616 3 commit-queue 2018-12-17 15:01:53 -0800 All reviewed patches have been landed. Closing bug. 1488618 4 webkit-bug-importer 2018-12-17 15:02:59 -0800 <rdar://problem/46791637> 356534 2018-12-04 14:28:14 -0800 2018-12-17 15:01:52 -0800 Patch bug-192378-20181204142813.patch text/plain 2308 skoppisetty U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODc0CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVkODk1MjU3NDBl OTdjMTZmZWIxNTQwODc5NjhhNDI5NTJkMWExNGMuLmM4YzViYmRlYWJmODZmNzNmZWZhZTBhYmM2 ODdmMGNiODlmNDI4ODEgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTIt MDQgIFN1cmVzaCBLb3BwaXNldHR5ICA8c2tvcHBpc2V0dHlAYXBwbGUuY29tPgorCisgICAgICAg IEltcG9ydCBGZWVkYmFja1NlcnZlciBvbmx5IGlmICItZi8tLWZlZWRiYWNrLWluLWJyb3dzZXIi IG9wdGlvbiBpcyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkyMzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRmVlZGJhY2tTZXJ2ZXIgY3VycmVudGx5IGRlcGVuZHMgb24gVG9ybmFkby01 LjEsIHdoaWNoIGZ1cnRoZXIgYWRkcworICAgICAgICBkZXBlbmRlbmN5IG9mICJzaW5nbGVkaXNw YXRjaCIsICJiYWNrcG9ydHMtYWJjIiBhbmQgImZ1dHVyZXMiIHB5dGhvbiBsaWJyYXJpZXMuCisg ICAgICAgIEltcG9ydGluZyBGZWVkYmFja1NlcnZlciBvbmx5IGlmICItZi8tLWZlZWRiYWNrLWlu LWJyb3dzZXIiIG9wdGlvbiBpcyBlbmFibGVkCisgICAgICAgIHdpbGwgbGV0IHVzIHJ1biB0aGUg YmVuY2htYXJrIHNjcmlwdHMgd2l0aG91dCBpbnN0YWxsaW5nIGFueSBuZXcgcHl0aG9uIGxpYnJh cmllcy4KKworICAgICAgICAqIExhdW5jaFRpbWUvbGF1bmNoX3RpbWUucHk6CisgICAgICAgICog TGF1bmNoVGltZS9uZXdfdGFiLnB5OgorCiAyMDE4LTExLTA3ICBDYWlvIExpbWEgIDx0aWNhaW9s aW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbQmlnSW50XSBBZGQgc3VwcG9ydCB0byBCaWdJbnQg aW50byBWYWx1ZUFkZApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9MYXVuY2hUaW1lL2xh dW5jaF90aW1lLnB5IGIvUGVyZm9ybWFuY2VUZXN0cy9MYXVuY2hUaW1lL2xhdW5jaF90aW1lLnB5 CmluZGV4IDUzYTVhM2I3MjgzNjQ5NTVjMDU2NTgxNjkxNjMzMjk5OWM5NjQzZWQuLmJlODQ2Nzg3 M2ZlYTg2N2Y4ZjYxNzJkZGM4MThiY2Y4MmQwMWY2MGIgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNl VGVzdHMvTGF1bmNoVGltZS9sYXVuY2hfdGltZS5weQorKysgYi9QZXJmb3JtYW5jZVRlc3RzL0xh dW5jaFRpbWUvbGF1bmNoX3RpbWUucHkKQEAgLTEwLDcgKzEwLDYgQEAgaW1wb3J0IHN5cwogaW1w b3J0IHRocmVhZGluZwogaW1wb3J0IHRpbWUKIAotZnJvbSBmZWVkYmFja19zZXJ2ZXIgaW1wb3J0 IEZlZWRiYWNrU2VydmVyCiAKIAogIyBTdXByZXNzIGxvZ3MgZnJvbSBmZWVkYmFjayBzZXJ2ZXIK QEAgLTE0Niw2ICsxNDUsNyBAQCBjbGFzcyBMYXVuY2hUaW1lQmVuY2htYXJrOgogICAgICAgICBz ZWxmLl9zZXJ2ZXJfcmVhZHkuYWNxdWlyZSgpCiAKICAgICAgICAgaWYgc2VsZi5fZmVlZGJhY2tf aW5fYnJvd3NlcjoKKyAgICAgICAgICAgIGZyb20gZmVlZGJhY2tfc2VydmVyIGltcG9ydCBGZWVk YmFja1NlcnZlcgogICAgICAgICAgICAgc2VsZi5fZmVlZGJhY2tfc2VydmVyID0gRmVlZGJhY2tT ZXJ2ZXIoKQogICAgICAgICAgICAgc2VsZi5fZmVlZGJhY2tfcG9ydCA9IHNlbGYuX2ZlZWRiYWNr X3NlcnZlci5zdGFydCgpCiAKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvTGF1bmNoVGlt ZS9uZXdfdGFiLnB5IGIvUGVyZm9ybWFuY2VUZXN0cy9MYXVuY2hUaW1lL25ld190YWIucHkKaW5k ZXggZDVjNWQxOTEzM2Y5NjEzZTdiNGVhYmZiMGIzYzM3NDk2MzViOGIyYy4uMTYxYjY2NWY5OTI2 MjM5NTFjNjlmYzQ5N2RmMGQ5NmRhNzQzOTU4MiAxMDA3NTUKLS0tIGEvUGVyZm9ybWFuY2VUZXN0 cy9MYXVuY2hUaW1lL25ld190YWIucHkKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9MYXVuY2hUaW1l L25ld190YWIucHkKQEAgLTQsOCArNCw2IEBAIGltcG9ydCB0aW1lCiBmcm9tIHRocmVhZGluZyBp bXBvcnQgRXZlbnQKIAogZnJvbSBsYXVuY2hfdGltZSBpbXBvcnQgTGF1bmNoVGltZUJlbmNobWFy aywgRGVmYXVsdExhdW5jaFRpbWVIYW5kbGVyCi1pbXBvcnQgZmVlZGJhY2tfc2VydmVyCi0KIAog Y2xhc3MgTmV3VGFiQmVuY2htYXJrKExhdW5jaFRpbWVCZW5jaG1hcmspOgogICAgIGRlZiBfcGFy c2Vfd2FpdF90aW1lKHNlbGYsIHN0cmluZyk6Cg==