192360 2018-12-04 07:12:15 -0800 [GTK] Don't use the slice allocator 2018-12-10 06:56:26 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro aperez bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1484814 0 mcatanzaro 2018-12-04 07:12:15 -0800 The slice allocator has fallen out of favor: https://gitlab.gnome.org/GNOME/glib/issues/1079 We did this previously in bug #147357, but a new use has snuck into MiniBrowser. 1484816 1 356494 mcatanzaro 2018-12-04 07:16:42 -0800 Created attachment 356494 Patch 1486206 2 mcatanzaro 2018-12-07 16:05:03 -0800 Ping reviewers 1486324 3 356494 aperez 2018-12-08 11:22:55 -0800 Comment on attachment 356494 Patch r+ (informally) 1486545 4 356494 commit-queue 2018-12-10 06:56:24 -0800 Comment on attachment 356494 Patch Clearing flags on attachment: 356494 Committed r239027: <https://trac.webkit.org/changeset/239027> 1486546 5 commit-queue 2018-12-10 06:56:26 -0800 All reviewed patches have been landed. Closing bug. 356494 2018-12-04 07:16:42 -0800 2018-12-10 06:56:24 -0800 Patch bug-192360-20181204091641.patch text/plain 1827 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTZkZDU3ZjI4ZmJlYWRmMjc2Zjc0MTkwYmZmN2E4OGY1 NWUzOWE1ZS4uMjVlNjE2MTdkZTMwYTU2ZWJhODY5ZmRlMzcwMTk3MDAwNjc4OTI1MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTEyLTA0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBEb24ndCB1c2UgdGhlIHNsaWNlIGFsbG9jYXRvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMzYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9n dGsvbWFpbi5jOgorICAgICAgICAoYWJvdXREYXRhUmVxdWVzdEZyZWUpOgorICAgICAgICAoYWJv dXREYXRhUmVxdWVzdE5ldyk6CisKIDIwMTgtMTItMDMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9o c2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU01hY10gVW5hYmxlIHRvIHVwbG9hZCBub24t aW1hZ2UgZmlsZXMgdXNpbmcgZHJhZyBhbmQgZHJvcCBpbiBXS1dlYlZpZXcKZGlmZiAtLWdpdCBh L1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFp bi5jCmluZGV4IDZlZmY5NTBlM2E1OWMwMmVjY2NiYTMyMzE1YzcyZGM1ODMxOTIzMjAuLmFmYmU1 NTVlYTUyODNiYmI3Yzg3NDNmNGEzNzY3ZjZlNWNkMWVlNDEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01p bmlCcm93c2VyL2d0ay9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL21haW4uYwpA QCAtMjY4LDcgKzI2OCw3IEBAIHN0YXRpYyB2b2lkIGFib3V0RGF0YVJlcXVlc3RGcmVlKEFib3V0 RGF0YVJlcXVlc3QgKnJlcXVlc3QpCiAgICAgaWYgKHJlcXVlc3QtPmRhdGFNYXApCiAgICAgICAg IGdfaGFzaF90YWJsZV9kZXN0cm95KHJlcXVlc3QtPmRhdGFNYXApOwogCi0gICAgZ19zbGljZV9m cmVlKEFib3V0RGF0YVJlcXVlc3QsIHJlcXVlc3QpOworICAgIGdfZnJlZShyZXF1ZXN0KTsKIH0K IAogc3RhdGljIEFib3V0RGF0YVJlcXVlc3QqIGFib3V0RGF0YVJlcXVlc3ROZXcoV2ViS2l0VVJJ U2NoZW1lUmVxdWVzdCAqdXJpUmVxdWVzdCkKQEAgLTI3Niw3ICsyNzYsNyBAQCBzdGF0aWMgQWJv dXREYXRhUmVxdWVzdCogYWJvdXREYXRhUmVxdWVzdE5ldyhXZWJLaXRVUklTY2hlbWVSZXF1ZXN0 ICp1cmlSZXF1ZXN0KQogICAgIGlmICghYWJvdXREYXRhUmVxdWVzdE1hcCkKICAgICAgICAgYWJv dXREYXRhUmVxdWVzdE1hcCA9IGdfaGFzaF90YWJsZV9uZXdfZnVsbChnX2RpcmVjdF9oYXNoLCBn X2RpcmVjdF9lcXVhbCwgTlVMTCwgKEdEZXN0cm95Tm90aWZ5KWFib3V0RGF0YVJlcXVlc3RGcmVl KTsKIAotICAgIEFib3V0RGF0YVJlcXVlc3QgKnJlcXVlc3QgPSBnX3NsaWNlX25ldzAoQWJvdXRE YXRhUmVxdWVzdCk7CisgICAgQWJvdXREYXRhUmVxdWVzdCAqcmVxdWVzdCA9IGdfbmV3MChBYm91 dERhdGFSZXF1ZXN0LCAxKTsKICAgICByZXF1ZXN0LT5yZXF1ZXN0ID0gZ19vYmplY3RfcmVmKHVy aVJlcXVlc3QpOwogICAgIGdfaGFzaF90YWJsZV9pbnNlcnQoYWJvdXREYXRhUmVxdWVzdE1hcCwg R1VJTlRfVE9fUE9JTlRFUih3ZWJraXRfd2ViX3ZpZXdfZ2V0X3BhZ2VfaWQod2Via2l0X3VyaV9z Y2hlbWVfcmVxdWVzdF9nZXRfd2ViX3ZpZXcocmVxdWVzdC0+cmVxdWVzdCkpKSwgcmVxdWVzdCk7 CiAK