192346 2018-12-03 19:10:24 -0800 Web Inspector: Audit: save the expanded state of test groups 2018-12-03 22:01:26 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192107 InRadar P2 Normal --- 190754 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1484665 0 hi 2018-12-03 19:10:24 -0800 <https://webkit.org/b/192107> removed the auto-expanding of groups, but we should actually auto-expand if the user had previously done so (similar to resources). 1484666 1 webkit-bug-importer 2018-12-03 19:10:49 -0800 <rdar://problem/46440703> 1484667 2 webkit-bug-importer 2018-12-03 19:10:51 -0800 <rdar://problem/46440704> 1484673 3 356449 hi 2018-12-03 19:37:16 -0800 Created attachment 356449 Patch 1484698 4 356449 mattbaker 2018-12-03 20:32:21 -0800 Comment on attachment 356449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356449&action=review r=me > Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:54 > + this._expandedSetting = new WI.Setting("audit-tree-element-" + this.representedObject.name + "-expanded", false); How about using a template string? `audit-tree-element-${this.representedObject.name}-expanded` 1484700 5 356454 hi 2018-12-03 20:57:05 -0800 Created attachment 356454 Patch 1484712 6 commit-queue 2018-12-03 21:46:12 -0800 The commit-queue encountered the following flaky tests while processing attachment 356454: inspector/model/auditTestCase.html bug 192350 (author: drousso@apple.com) http/tests/inspector/network/loadResource-insecure-resource.html bug 192351 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch. 1484715 7 commit-queue 2018-12-03 21:46:21 -0800 The commit-queue encountered the following flaky tests while processing attachment 356454: inspector/unit-tests/event-listener.html bug 192050 (authors: bburg@apple.com and drousso@apple.com) The commit-queue is continuing to process your patch. 1484725 8 356454 commit-queue 2018-12-03 22:01:24 -0800 Comment on attachment 356454 Patch Clearing flags on attachment: 356454 Committed r238843: <https://trac.webkit.org/changeset/238843> 1484726 9 commit-queue 2018-12-03 22:01:26 -0800 All reviewed patches have been landed. Closing bug. 356449 2018-12-03 19:37:16 -0800 2018-12-03 20:56:59 -0800 Patch bug-192346-20181203193715.patch text/plain 2601 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE4NjcyZjBlNGVhOTE2ZmZlNTVkMTJkZjEzZjhj Y2FmOGI1MTZhZjUuLmU0NDA0OGQ0ZTcxNjM2NzdkMzlmMmI5MTA2MGE4ZGY5ZjU0YTE5YmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEyLTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogc2F2ZSB0aGUgZXhwYW5kZWQgc3RhdGUgb2YgdGVzdCBncm91cHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjM0NgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNDY0NDA3MDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VHJlZUVsZW1lbnQuanM6 CisgICAgICAgIChXSS5BdWRpdFRyZWVFbGVtZW50KToKKyAgICAgICAgKFdJLkF1ZGl0VHJlZUVs ZW1lbnQucHJvdG90eXBlLm9uYXR0YWNoKToKKyAgICAgICAgKFdJLkF1ZGl0VHJlZUVsZW1lbnQu cHJvdG90eXBlLm9uZXhwYW5kKTogQWRkZWQuCisgICAgICAgIChXSS5BdWRpdFRyZWVFbGVtZW50 LnByb3RvdHlwZS5vbmNvbGxhcHNlKTogQWRkZWQuCisKIDIwMTgtMTItMDMgIERldmluIFJvdXNz byAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0OiAi QWRkIERlZmF1bHQgQXVkaXRzIiBzaG93biB3aGVuIHRoZXJlIGFyZSBubyBmaWx0ZXIgcmVzdWx0 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv QXVkaXRUcmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0F1ZGl0VHJlZUVsZW1lbnQuanMKaW5kZXggNjk3NjM3NmU4M2U0NjdiMGNiYjkxMWUw OTlkOGRmNmUxNDY2YjliNy4uYTc3NDU0OWFlNjUyOGRhM2I4YjY5YzkyZTI1ZTBkYjBjNzZiNWY2 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv QXVkaXRUcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9BdWRpdFRyZWVFbGVtZW50LmpzCkBAIC00OSw2ICs0OSw5IEBAIFdJLkF1ZGl0 VHJlZUVsZW1lbnQgPSBjbGFzcyBBdWRpdFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuR2VuZXJhbFRy ZWVFbGVtZW50CiAKICAgICAgICAgY29uc3Qgc3VidGl0bGUgPSBudWxsOwogICAgICAgICBzdXBl cihjbGFzc05hbWVzLCByZXByZXNlbnRlZE9iamVjdC5uYW1lLCBzdWJ0aXRsZSwgcmVwcmVzZW50 ZWRPYmplY3QsIG9wdGlvbnMpOworCisgICAgICAgIGlmIChpc1Rlc3RHcm91cCkKKyAgICAgICAg ICAgIHRoaXMuX2V4cGFuZGVkU2V0dGluZyA9IG5ldyBXSS5TZXR0aW5nKCJhdWRpdC10cmVlLWVs ZW1lbnQtIiArIHRoaXMucmVwcmVzZW50ZWRPYmplY3QubmFtZSArICItZXhwYW5kZWQiLCBmYWxz ZSk7CiAgICAgfQogCiAgICAgLy8gUHJvdGVjdGVkCkBAIC02Niw2ICs2OSw5IEBAIFdJLkF1ZGl0 VHJlZUVsZW1lbnQgPSBjbGFzcyBBdWRpdFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuR2VuZXJhbFRy ZWVFbGVtZW50CiAgICAgICAgICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5hZGRFdmVu dExpc3RlbmVyKFdJLkF1ZGl0VGVzdEJhc2UuRXZlbnQuU2NoZWR1bGVkLCB0aGlzLl9oYW5kbGVU ZXN0R3JvdXBTY2hlZHVsZWQsIHRoaXMpOwogICAgICAgICB9CiAKKyAgICAgICAgaWYgKHRoaXMu X2V4cGFuZGVkU2V0dGluZyAmJiB0aGlzLl9leHBhbmRlZFNldHRpbmcudmFsdWUpCisgICAgICAg ICAgICB0aGlzLmV4cGFuZCgpOworCiAgICAgICAgIHRoaXMuX3VwZGF0ZUxldmVsKCk7CiAgICAg fQogCkBAIC05Niw2ICsxMDIsMjIgQEAgV0kuQXVkaXRUcmVlRWxlbWVudCA9IGNsYXNzIEF1ZGl0 VHJlZUVsZW1lbnQgZXh0ZW5kcyBXSS5HZW5lcmFsVHJlZUVsZW1lbnQKICAgICAgICAgfQogICAg IH0KIAorICAgIG9uZXhwYW5kKCkKKyAgICB7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMu ZXhwYW5kZWQpOworCisgICAgICAgIGlmICh0aGlzLl9leHBhbmRlZFNldHRpbmcpCisgICAgICAg ICAgICB0aGlzLl9leHBhbmRlZFNldHRpbmcudmFsdWUgPSB0aGlzLmV4cGFuZGVkOworICAgIH0K KworICAgIG9uY29sbGFwc2UoKQorICAgIHsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoIXRoaXMu ZXhwYW5kZWQpOworCisgICAgICAgIGlmICh0aGlzLl9leHBhbmRlZFNldHRpbmcpCisgICAgICAg ICAgICB0aGlzLl9leHBhbmRlZFNldHRpbmcudmFsdWUgPSB0aGlzLmV4cGFuZGVkOworICAgIH0K KwogICAgIG9uZGVsZXRlKCkKICAgICB7CiAgICAgICAgIGlmICghKHRoaXMucmVwcmVzZW50ZWRP YmplY3QgaW5zdGFuY2VvZiBXSS5BdWRpdFRlc3RCYXNlKSkK 356454 2018-12-03 20:57:05 -0800 2018-12-03 22:01:24 -0800 Patch bug-192346-20181203205705.patch text/plain 2592 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE4NjcyZjBlNGVhOTE2ZmZlNTVkMTJkZjEzZjhj Y2FmOGI1MTZhZjUuLjliYzk2NzI4OGRkNzU2NDEzOWRhNDQ2M2JlMWNjNjUzNmM1MzYwZWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEyLTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogc2F2ZSB0aGUgZXhwYW5kZWQgc3RhdGUgb2YgdGVzdCBncm91cHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjM0NgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNDY0NDA3MDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWF0dCBCYWtlci4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUcmVlRWxlbWVudC5qczoKKyAg ICAgICAgKFdJLkF1ZGl0VHJlZUVsZW1lbnQpOgorICAgICAgICAoV0kuQXVkaXRUcmVlRWxlbWVu dC5wcm90b3R5cGUub25hdHRhY2gpOgorICAgICAgICAoV0kuQXVkaXRUcmVlRWxlbWVudC5wcm90 b3R5cGUub25leHBhbmQpOiBBZGRlZC4KKyAgICAgICAgKFdJLkF1ZGl0VHJlZUVsZW1lbnQucHJv dG90eXBlLm9uY29sbGFwc2UpOiBBZGRlZC4KKwogMjAxOC0xMi0wMyAgRGV2aW4gUm91c3NvICA8 ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQXVkaXQ6ICJBZGQg RGVmYXVsdCBBdWRpdHMiIHNob3duIHdoZW4gdGhlcmUgYXJlIG5vIGZpbHRlciByZXN1bHRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRp dFRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQXVkaXRUcmVlRWxlbWVudC5qcwppbmRleCA2OTc2Mzc2ZTgzZTQ2N2IwY2JiOTExZTA5OWQ4 ZGY2ZTE0NjZiOWI3Li4yMDE1YjZhZDZhYzM1Mjg3YjEyZmFjY2U3NDI1NTI4NzQ4OGY0MjYyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRp dFRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0F1ZGl0VHJlZUVsZW1lbnQuanMKQEAgLTQ5LDYgKzQ5LDkgQEAgV0kuQXVkaXRUcmVl RWxlbWVudCA9IGNsYXNzIEF1ZGl0VHJlZUVsZW1lbnQgZXh0ZW5kcyBXSS5HZW5lcmFsVHJlZUVs ZW1lbnQKIAogICAgICAgICBjb25zdCBzdWJ0aXRsZSA9IG51bGw7CiAgICAgICAgIHN1cGVyKGNs YXNzTmFtZXMsIHJlcHJlc2VudGVkT2JqZWN0Lm5hbWUsIHN1YnRpdGxlLCByZXByZXNlbnRlZE9i amVjdCwgb3B0aW9ucyk7CisKKyAgICAgICAgaWYgKGlzVGVzdEdyb3VwKQorICAgICAgICAgICAg dGhpcy5fZXhwYW5kZWRTZXR0aW5nID0gbmV3IFdJLlNldHRpbmcoYGF1ZGl0LXRyZWUtZWxlbWVu dC0ke3RoaXMucmVwcmVzZW50ZWRPYmplY3QubmFtZX0tZXhwYW5kZWRgLCBmYWxzZSk7CiAgICAg fQogCiAgICAgLy8gUHJvdGVjdGVkCkBAIC02Niw2ICs2OSw5IEBAIFdJLkF1ZGl0VHJlZUVsZW1l bnQgPSBjbGFzcyBBdWRpdFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuR2VuZXJhbFRyZWVFbGVtZW50 CiAgICAgICAgICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5hZGRFdmVudExpc3RlbmVy KFdJLkF1ZGl0VGVzdEJhc2UuRXZlbnQuU2NoZWR1bGVkLCB0aGlzLl9oYW5kbGVUZXN0R3JvdXBT Y2hlZHVsZWQsIHRoaXMpOwogICAgICAgICB9CiAKKyAgICAgICAgaWYgKHRoaXMuX2V4cGFuZGVk U2V0dGluZyAmJiB0aGlzLl9leHBhbmRlZFNldHRpbmcudmFsdWUpCisgICAgICAgICAgICB0aGlz LmV4cGFuZCgpOworCiAgICAgICAgIHRoaXMuX3VwZGF0ZUxldmVsKCk7CiAgICAgfQogCkBAIC05 Niw2ICsxMDIsMjIgQEAgV0kuQXVkaXRUcmVlRWxlbWVudCA9IGNsYXNzIEF1ZGl0VHJlZUVsZW1l bnQgZXh0ZW5kcyBXSS5HZW5lcmFsVHJlZUVsZW1lbnQKICAgICAgICAgfQogICAgIH0KIAorICAg IG9uZXhwYW5kKCkKKyAgICB7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuZXhwYW5kZWQp OworCisgICAgICAgIGlmICh0aGlzLl9leHBhbmRlZFNldHRpbmcpCisgICAgICAgICAgICB0aGlz Ll9leHBhbmRlZFNldHRpbmcudmFsdWUgPSB0aGlzLmV4cGFuZGVkOworICAgIH0KKworICAgIG9u Y29sbGFwc2UoKQorICAgIHsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoIXRoaXMuZXhwYW5kZWQp OworCisgICAgICAgIGlmICh0aGlzLl9leHBhbmRlZFNldHRpbmcpCisgICAgICAgICAgICB0aGlz Ll9leHBhbmRlZFNldHRpbmcudmFsdWUgPSB0aGlzLmV4cGFuZGVkOworICAgIH0KKwogICAgIG9u ZGVsZXRlKCkKICAgICB7CiAgICAgICAgIGlmICghKHRoaXMucmVwcmVzZW50ZWRPYmplY3QgaW5z dGFuY2VvZiBXSS5BdWRpdFRlc3RCYXNlKSkK