192341 2018-12-03 16:30:09 -0800 Web Inspector: Audit: sidebar briefly shows "No Filter Results" before populating default audits 2018-12-03 20:07:03 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P4 Normal --- 1 mattbaker hi commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1484605 0 mattbaker 2018-12-03 16:30:09 -0800 Steps to Reproduce: 1. Select Audit tab 2. Close Inspector 3. Reopen Inspector => "No Filter Results" flashes before populating sidebar 1. Select Elements tab 2. Close Inspector 3. Reopen Inspector 4. Select Audit tab => "No Filter Results" flashes before populating sidebar 1484608 1 webkit-bug-importer 2018-12-03 16:31:04 -0800 <rdar://problem/46436550> 1484660 2 hi 2018-12-03 18:52:09 -0800 This is somewhat expected, as the `WI.ObjectStore` is async and will probably take a moment to load its data. The "No Filter Results" is appearing because we do add a `WI.TreeElement` for the "Results" folder in `initialLayout`, which is default hidden, therefore triggering the placeholder. We can improve this by delaying it's creation (and append) till it's needed. 1484664 3 356446 hi 2018-12-03 19:07:41 -0800 Created attachment 356446 Patch 1484671 4 356446 mattbaker 2018-12-03 19:27:33 -0800 Comment on attachment 356446 Patch r=me 1484690 5 356446 commit-queue 2018-12-03 20:07:01 -0800 Comment on attachment 356446 Patch Clearing flags on attachment: 356446 Committed r238842: <https://trac.webkit.org/changeset/238842> 1484691 6 commit-queue 2018-12-03 20:07:03 -0800 All reviewed patches have been landed. Closing bug. 356446 2018-12-03 19:07:41 -0800 2018-12-03 20:07:01 -0800 Patch bug-192341-20181203190740.patch text/plain 4354 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE4NjcyZjBlNGVhOTE2ZmZlNTVkMTJkZjEzZjhj Y2FmOGI1MTZhZjUuLmJlNzdmZjc4Y2ZmYTlhMTNmYmZiNjQ0Y2VkYjMwYmMzNjE4ODNkZDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEyLTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogc2lkZWJhciBicmllZmx5IHNob3dzICJObyBGaWx0ZXIgUmVzdWx0cyIgYmVmb3JlIHBv cHVsYXRpbmcgZGVmYXVsdCBhdWRpdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MjM0MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY0MzY1NTA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0F1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbC5qczoKKyAgICAgICAg KFdJLkF1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUuaW5pdGlhbExheW91dCk6 CisgICAgICAgIChXSS5BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLl9hZGRU ZXN0KToKKyAgICAgICAgKFdJLkF1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbC5wcm90b3R5cGUu X2FkZFJlc3VsdCk6CisgICAgICAgIChXSS5BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJv dG90eXBlLmFwcGx5RmlsdGVyc1RvVHJlZUVsZW1lbnQpOiBEZWxldGVkLgorICAgICAgICBEZWxh eSB0aGUgY29uc3RydWN0aW9uIG9mIHRoZSAiUmVzdWx0cyIgZm9sZGVyIHVudGlsIGl0J3MgbmVl ZGVkLCBzaW5jZSBhZGRpbmcgYSBoaWRkZW4KKyAgICAgICAgYFdJLlRyZWVFbGVtZW50YCB3aWxs IGNhdXNlIHRoZSBwbGFjZWhvbGRlciB0byBhcHBlYXIuCisKIDIwMTgtMTItMDMgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0 OiAiQWRkIERlZmF1bHQgQXVkaXRzIiBzaG93biB3aGVuIHRoZXJlIGFyZSBubyBmaWx0ZXIgcmVz dWx0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQXVkaXROYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXROYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCmluZGV4 IGEzYWRmMmMxODRkNjExZjI2OGJlM2Q1ZWI4YmQyZjg3MDhkOThjNjMuLjExODZiZmFlODdlMGFm Yzc3ZjdlOGFkNDUwZTIzNGZkN2E4MGVmZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdE5hdmln YXRpb25TaWRlYmFyUGFuZWwuanMKQEAgLTU3LDExICs1Nyw2IEBAIFdJLkF1ZGl0TmF2aWdhdGlv blNpZGViYXJQYW5lbCA9IGNsYXNzIEF1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbCBleHRlbmRz IFdJLk5hCiAKICAgICAgICAgdGhpcy5jb250ZW50VHJlZU91dGxpbmUuYWxsb3dzUmVwZWF0U2Vs ZWN0aW9uID0gZmFsc2U7CiAKLSAgICAgICAgdGhpcy5fcmVzdWx0c0ZvbGRlclRyZWVFbGVtZW50 ID0gbmV3IFdJLkZvbGRlclRyZWVFbGVtZW50KFdJLlVJU3RyaW5nKCJSZXN1bHRzIikpOwotICAg ICAgICB0aGlzLmNvbnRlbnRUcmVlT3V0bGluZS5hcHBlbmRDaGlsZCh0aGlzLl9yZXN1bHRzRm9s ZGVyVHJlZUVsZW1lbnQpOwotICAgICAgICB0aGlzLl9yZXN1bHRzRm9sZGVyVHJlZUVsZW1lbnQu aGlkZGVuID0gdHJ1ZTsKLSAgICAgICAgdGhpcy5fcmVzdWx0c0ZvbGRlclRyZWVFbGVtZW50LmV4 cGFuZCgpOwotCiAgICAgICAgIGxldCBuYXZpZ2F0aW9uQmFyID0gbmV3IFdJLk5hdmlnYXRpb25C YXI7CiAKICAgICAgICAgdGhpcy5fc3RhcnRTdG9wQnV0dG9uTmF2aWdhdGlvbkl0ZW0gPSBuZXcg V0kuVG9nZ2xlQnV0dG9uTmF2aWdhdGlvbkl0ZW0oImF1ZGl0LXN0YXJ0LXN0b3AiLCBXSS5VSVN0 cmluZygiU3RhcnQiKSwgV0kuVUlTdHJpbmcoIlN0b3AiKSwgIkltYWdlcy9BdWRpdFN0YXJ0LnN2 ZyIsICJJbWFnZXMvQXVkaXRTdG9wLnN2ZyIsIDEzLCAxMyk7CkBAIC0xMDksMTQgKzEwNCw2IEBA IFdJLkF1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbCA9IGNsYXNzIEF1ZGl0TmF2aWdhdGlvblNp ZGViYXJQYW5lbCBleHRlbmRzIFdJLk5hCiAgICAgICAgICAgICB0aGlzLl91cGRhdGVOb0F1ZGl0 c1BsYWNlaG9sZGVyKCk7CiAgICAgfQogCi0gICAgYXBwbHlGaWx0ZXJzVG9UcmVlRWxlbWVudCh0 cmVlRWxlbWVudCkKLSAgICB7Ci0gICAgICAgIHN1cGVyLmFwcGx5RmlsdGVyc1RvVHJlZUVsZW1l bnQodHJlZUVsZW1lbnQpOwotCi0gICAgICAgIGlmICh0cmVlRWxlbWVudCA9PT0gdGhpcy5fcmVz dWx0c0ZvbGRlclRyZWVFbGVtZW50ICYmICFXSS5hdWRpdE1hbmFnZXIucmVzdWx0cy5sZW5ndGgp Ci0gICAgICAgICAgICB0aGlzLl9yZXN1bHRzRm9sZGVyVHJlZUVsZW1lbnQuaGlkZGVuID0gdHJ1 ZTsKLSAgICB9Ci0KICAgICAvLyBQcml2YXRlCiAKICAgICBfYWRkVGVzdCh0ZXN0KQpAQCAtMTI1 LDkgKzExMiwxMyBAQCBXSS5BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgPSBjbGFzcyBBdWRp dE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5OYQogCiAgICAgICAgIHRoaXMuX3Vw ZGF0ZVN0YXJ0U3RvcEJ1dHRvbk5hdmlnYXRpb25JdGVtU3RhdGUoKTsKIAotICAgICAgICB0aGlz LmNvbnRlbnRUcmVlT3V0bGluZS5pbnNlcnRDaGlsZChuZXcgV0kuQXVkaXRUcmVlRWxlbWVudCh0 ZXN0KSwgdGhpcy5jb250ZW50VHJlZU91dGxpbmUuY2hpbGRyZW4uaW5kZXhPZih0aGlzLl9yZXN1 bHRzRm9sZGVyVHJlZUVsZW1lbnQpKTsKKyAgICAgICAgbGV0IHRyZWVFbGVtZW50ID0gbmV3IFdJ LkF1ZGl0VHJlZUVsZW1lbnQodGVzdCk7CiAKLSAgICAgICAgdGhpcy5fcmVzdWx0c0ZvbGRlclRy ZWVFbGVtZW50LmhpZGRlbiA9ICF0aGlzLl9yZXN1bHRzRm9sZGVyVHJlZUVsZW1lbnQuY2hpbGRy ZW4ubGVuZ3RoOworICAgICAgICBpZiAodGhpcy5fcmVzdWx0c0ZvbGRlclRyZWVFbGVtZW50KSB7 CisgICAgICAgICAgICB0aGlzLmNvbnRlbnRUcmVlT3V0bGluZS5pbnNlcnRDaGlsZCh0cmVlRWxl bWVudCwgdGhpcy5jb250ZW50VHJlZU91dGxpbmUuY2hpbGRyZW4uaW5kZXhPZih0aGlzLl9yZXN1 bHRzRm9sZGVyVHJlZUVsZW1lbnQpKTsKKyAgICAgICAgICAgIHRoaXMuX3Jlc3VsdHNGb2xkZXJU cmVlRWxlbWVudC5oaWRkZW4gPSAhdGhpcy5fcmVzdWx0c0ZvbGRlclRyZWVFbGVtZW50LmNoaWxk cmVuLmxlbmd0aDsKKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICB0aGlzLmNvbnRlbnRUcmVl T3V0bGluZS5hcHBlbmRDaGlsZCh0cmVlRWxlbWVudCk7CiAKICAgICAgICAgdGhpcy5oaWRlRW1w dHlDb250ZW50UGxhY2Vob2xkZXIoKTsKICAgICB9CkBAIC0xMzgsNyArMTI5LDEyIEBAIFdJLkF1 ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbCA9IGNsYXNzIEF1ZGl0TmF2aWdhdGlvblNpZGViYXJQ YW5lbCBleHRlbmRzIFdJLk5hCiAKICAgICAgICAgdGhpcy5fdXBkYXRlU3RhcnRTdG9wQnV0dG9u TmF2aWdhdGlvbkl0ZW1TdGF0ZSgpOwogCi0gICAgICAgIHRoaXMuX3Jlc3VsdHNGb2xkZXJUcmVl RWxlbWVudC5oaWRkZW4gPSBmYWxzZTsKKyAgICAgICAgaWYgKCF0aGlzLl9yZXN1bHRzRm9sZGVy VHJlZUVsZW1lbnQpIHsKKyAgICAgICAgICAgIHRoaXMuX3Jlc3VsdHNGb2xkZXJUcmVlRWxlbWVu dCA9IG5ldyBXSS5Gb2xkZXJUcmVlRWxlbWVudChXSS5VSVN0cmluZygiUmVzdWx0cyIpKTsKKyAg ICAgICAgICAgIHRoaXMuY29udGVudFRyZWVPdXRsaW5lLmFwcGVuZENoaWxkKHRoaXMuX3Jlc3Vs dHNGb2xkZXJUcmVlRWxlbWVudCk7CisgICAgICAgIH0KKworICAgICAgICB0aGlzLl9yZXN1bHRz Rm9sZGVyVHJlZUVsZW1lbnQuZXhwYW5kKCk7CiAKICAgICAgICAgbGV0IHJlc3VsdEZvbGRlclRy ZWVFbGVtZW50ID0gbmV3IFdJLkZvbGRlclRyZWVFbGVtZW50KFdJLlVJU3RyaW5nKCJSdW4gJWQi KS5mb3JtYXQoaW5kZXggKyAxKSk7CiAgICAgICAgIGlmIChyZXN1bHQgaW5zdGFuY2VvZiBXSS5B dWRpdFRlc3RSZXN1bHRCYXNlKSB7Cg==