192320 2018-12-03 13:31:28 -0800 REGRESSION (r238090): position:fixed sidebar on https://www.w3.org/TR/SVG2/coords.html does not stay fixed 2018-12-04 18:19:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://www.w3.org/TR/SVG2/coords.html InRadar P2 Normal --- 192342 1 simon.fraser simon.fraser bfulgham commit-queue ryanhaddad simon.fraser webkit-bug-importer zalan oldest_to_newest 1484476 0 simon.fraser 2018-12-03 13:31:28 -0800 The position:fixed sidebar on https://www.w3.org/TR/SVG2/coords.html doesn't stay fixed; it scrolls, then snaps when you hover. 1484477 1 webkit-bug-importer 2018-12-03 13:33:34 -0800 <rdar://problem/46429833> 1484548 2 simon.fraser 2018-12-03 15:03:50 -0800 The page is using main thread scrolling (because of fixed backgrounds), and the compositing update pass is failing to update the positions of fixed elements. 1484650 3 356443 simon.fraser 2018-12-03 18:17:21 -0800 Created attachment 356443 Patch 1484669 4 356448 simon.fraser 2018-12-03 19:18:50 -0800 Created attachment 356448 Patch 1484670 5 356448 zalan 2018-12-03 19:22:13 -0800 Comment on attachment 356448 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356448&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:669 > + bool isPageScroll = !updateRoot || updateRoot == &rootRenderLayer(); auto 1484685 6 356448 commit-queue 2018-12-03 20:03:56 -0800 Comment on attachment 356448 Patch Clearing flags on attachment: 356448 Committed r238840: <https://trac.webkit.org/changeset/238840> 1484686 7 commit-queue 2018-12-03 20:03:58 -0800 All reviewed patches have been landed. Closing bug. 1484845 8 ryanhaddad 2018-12-04 09:14:18 -0800 The layout test added with this change is frequently failing, as EWS indicated here: https://webkit-queues.webkit.org/patch/356448/ios-sim-ews https://webkit-queues.webkit.org/patch/356448/mac-ews https://webkit-queues.webkit.org/patch/356448/mac-debug-ews Link to image diff showing the scrollbar appearing in an unexpected location: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r238851%20(14458)/compositing/fixed-with-main-thread-scrolling-diffs.html 1484849 9 ryanhaddad 2018-12-04 09:17:26 -0800 Reverted r238840 for reason: The layout test added with this change is frequently failing. Committed r238855: <https://trac.webkit.org/changeset/238855> 1485082 10 ryanhaddad 2018-12-04 17:14:30 -0800 This was re-landed in https://trac.webkit.org/changeset/238876/webkit The test is still failing on the bots: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r238877%20(14473)/results.html http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Ffixed-with-main-thread-scrolling.html 1485107 11 simon.fraser 2018-12-04 18:19:17 -0800 Relanded in https://trac.webkit.org/r238876 Attempted to de-flake the test in https://trac.webkit.org/r238883. 356443 2018-12-03 18:17:21 -0800 2018-12-03 19:18:49 -0800 Patch bug-192320-20181203181721.patch text/plain 7218 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRlNjE1ZGQyYmRkNTIy NGRiOTM3ZTVkNGM0N2NlOWJiNDY4YThiMS4uMDA0NTZjZjEzN2VkNGFjZWNhZDZkYjk2MWNkNWJi ZTQ0MGJhZWE0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTEyLTAzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyMzgwOTApOiBwb3NpdGlvbjpmaXhlZCBzaWRlYmFyIG9uIGh0dHBzOi8vd3d3LnczLm9yZy9U Ui9TVkcyL2Nvb3Jkcy5odG1sIGRvZXMgbm90IHN0YXkgZml4ZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjMyMAorICAgICAgICA8cmRhcjovL3By b2JsZW0vNDY0Mjk4MzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBXaGVuIHdlIGZhbGwgaW50byBzbG93IHNjcm9sbGluZyBtb2RlIChm b3IgZXhhbXBsZSwgYmVjYXVzZSBvZiBiYWNrZ3JvdW5kLWF0dGFjaG1lbnQ6IGZpeGVkKSwKKyAg ICAgICAgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycygpIG5l ZWRzIHRvIHNldCB0aGUgZ2VvbWV0cnkgZGlydHkgYml0IG9uIGxheWVycworICAgICAgICBmb3Ig dmlld3BvcnQtY29uc3RyYWluZWQgb2JqZWN0cyBzbyB3ZSB1cGRhdGUgdGhlbS4KKyAgICAgICAg CisgICAgICAgIFRoaXMgaXMgb25seSBuZWNlc3NhcnkgZm9yIHBhZ2Ugc2Nyb2xsaW5nOyBmb3Ig b3ZlcmZsb3cgc2Nyb2xscywgdXBkYXRlTGF5ZXJQb3NpdGlvbnMoKSBhbHJlYWR5CisgICAgICAg IGRvZXMgZW5vdWdoIGRpcnR5aW5nIHRoYXQgZml4ZWQgbGF5ZXJzIG5lc3RlZCBpbnNpZGUgc2Ny b2xsZXJzIGdldCB1cGRhdGVkLgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0aW5nL2ZpeGVkLXdp dGgtbWFpbi10aHJlYWQtc2Nyb2xsaW5nLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21w b3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycyk6CisKIDIwMTgtMTItMDMgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRnJhbWVWaWV3J3MgVmll d3BvcnRDb25zdHJhaW5lZE9iamVjdFNldCBjYW4gY29udGFpbiBSZW5kZXJMYXllck1vZGVsT2Jq ZWN0cyByYXRoZXIgdGhhbiBSZW5kZXJFbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCBlMDExMjU1OTlmZWUwYTg5 ZjZkOTZhZGM0MTY4NzI4ZDBhNDcyNWUyLi4yMDhjNjU2MTI0Mzc1MzAzZDZmNzkyNmQ5Mjk1ZmE2 OTAxNDg1OWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcApAQCAtNjY2LDkgKzY2NiwyMCBAQCBib29sIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoQ29tcG9zaXRpbmdVcGRhdGVUeXBlIHVw ZGF0ZQogICAgIGlmICghbV9jb21wb3NpdGluZyAmJiAobV9mb3JjZUNvbXBvc2l0aW5nTW9kZSB8 fCAoaXNNYWluRnJhbWVDb21wb3NpdG9yKCkgJiYgcGFnZSgpLnBhZ2VPdmVybGF5Q29udHJvbGxl cigpLm92ZXJsYXlDb3VudCgpKSkpCiAgICAgICAgIGVuYWJsZUNvbXBvc2l0aW5nTW9kZSh0cnVl KTsKIAorICAgIGJvb2wgaXNQYWdlU2Nyb2xsID0gIXVwZGF0ZVJvb3QgfHwgdXBkYXRlUm9vdCA9 PSAmcm9vdFJlbmRlckxheWVyKCk7CiAgICAgdXBkYXRlUm9vdCA9ICZyb290UmVuZGVyTGF5ZXIo KTsKIAogICAgIGlmICh1cGRhdGVUeXBlID09IENvbXBvc2l0aW5nVXBkYXRlVHlwZTo6T25TY3Jv bGwgfHwgdXBkYXRlVHlwZSA9PSBDb21wb3NpdGluZ1VwZGF0ZVR5cGU6Ok9uQ29tcG9zaXRlZFNj cm9sbCkgeworICAgICAgICAvLyBXZSBvbmx5IGdldCBoZXJlIGlmIHdlIGRpZG4ndCBzY3JvbGwg b24gdGhlIHNjcm9sbGluZyB0aHJlYWQsIHNvIHRoaXMgdXBkYXRlIG5lZWRzIHRvIHJlLXBvc2l0 aW9uIHZpZXdwb3J0LWNvbnN0cmFpbmVkIGxheWVycy4KKyAgICAgICAgaWYgKG1fcmVuZGVyVmll dy5zZXR0aW5ncygpLmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxl ZCgpICYmIGlzUGFnZVNjcm9sbCkgeworICAgICAgICAgICAgaWYgKGF1dG8qIHZpZXdwb3J0Q29u c3RyYWluZWRPYmplY3RzID0gbV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLnZpZXdwb3J0Q29uc3Ry YWluZWRPYmplY3RzKCkpIHsKKyAgICAgICAgICAgICAgICBmb3IgKGF1dG8qIHJlbmRlcmVyIDog KnZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChh dXRvKiBsYXllciA9IHJlbmRlcmVyLT5sYXllcigpKQorICAgICAgICAgICAgICAgICAgICAgICAg bGF5ZXItPnNldE5lZWRzQ29tcG9zaXRpbmdHZW9tZXRyeVVwZGF0ZSgpOworICAgICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCiAgICAgICAgIC8vIFNjcm9sbGluZyBj YW4gYWZmZWN0IG92ZXJsYXAuIEZJWE1FOiBhdm9pZCBmb3IgcGFnZSBzY3JvbGxpbmcuCiAgICAg ICAgIHVwZGF0ZVJvb3QtPnNldERlc2NlbmRhbnRzTmVlZENvbXBvc2l0aW5nUmVxdWlyZW1lbnRz VHJhdmVyc2FsKCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJiYzAwOGRjMTM2Y2VmMTljNTdlNzIyZTcxZWZl ZWJkMzAzYmM5OTUuLmIxMjM5OGQ5MThhMWRhZWM5YzcyY2NmYzhiYzdmZTFhYmRiOGYzMTkgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0xMi0wMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjM4MDkwKTogcG9zaXRpb246 Zml4ZWQgc2lkZWJhciBvbiBodHRwczovL3d3dy53My5vcmcvVFIvU1ZHMi9jb29yZHMuaHRtbCBk b2VzIG5vdCBzdGF5IGZpeGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTIzMjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NDI5ODMzPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29tcG9zaXRp bmcvZml4ZWQtd2l0aC1tYWluLXRocmVhZC1zY3JvbGxpbmctZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1tYWluLXRocmVhZC1zY3JvbGxpbmcu aHRtbDogQWRkZWQuCisKIDIwMTgtMTItMDMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIERvIG5vdCBoYW5kbGUga2V5IGV2ZW50cyB0aGF0IGFyZSBr ZXkgY29tbWFuZHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2ZpeGVkLXdp dGgtbWFpbi10aHJlYWQtc2Nyb2xsaW5nLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9maXhlZC13aXRoLW1haW4tdGhyZWFkLXNjcm9sbGluZy1leHBlY3RlZC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjZiZjdjYmE2ODgxYWVlOTJiMzRkNGY1YWNjZmM2ZmJjMjM1ZDkyMmYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9maXhlZC13aXRoLW1haW4tdGhy ZWFkLXNjcm9sbGluZy1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMzYgQEAKKzwhRE9DVFlQRSBo dG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAgIGJvZHkgeworICAgICAg ICAgICAgaGVpZ2h0OiA2MDAwcHg7CisgICAgICAgIH0KKyAgICAgICAgLmJveCB7CisgICAgICAg ICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgICAgICB0b3A6IDU3MThweDsKKyAgICAg ICAgICAgIGxlZnQ6IDEwcHg7CisgICAgICAgICAgICB3aWR0aDogMjAwcHg7CisgICAgICAgICAg ICBoZWlnaHQ6IDIwMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47Cisg ICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIC5maXhlZC1iYWNrZ3JvdW5kIHsKKyAgICAgICAg ICAgIG1hcmdpbi10b3A6IDMwMHB4OworICAgICAgICAgICAgaGVpZ2h0OiAyMDBweDsKKyAgICAg ICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVudCh3aGl0ZSwgc2lsdmVyKTsK KyAgICAgICAgICAgIGJhY2tncm91bmQtYXR0YWNobWVudDogZml4ZWQ7CisgICAgICAgIH0KKyAg ICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisKKzxkaXYgY2xhc3M9ImJveCI+PC9kaXY+CisK KzxkaXYgY2xhc3M9ImZpeGVkLWJhY2tncm91bmQiPgorICAgIEkgaGF2ZSBhIGZpeGVkIGJhY2tn cm91bmQuCis8L2Rpdj4KKzxzY3JpcHQ+CisgICAgd2luZG93LnNjcm9sbFRvKDAsIDYwMDApOwor PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9maXhlZC13aXRoLW1haW4tdGhyZWFkLXNjcm9sbGluZy5odG1sIGIvTGF5b3V0VGVz dHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1tYWluLXRocmVhZC1zY3JvbGxpbmcuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi45NTE2NjAzNDBmMDc3YjdkMzVmYmM3NTExNjk0ODc2NjllNmEyMjkxCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1tYWluLXRocmVh ZC1zY3JvbGxpbmcuaHRtbApAQCAtMCwwICsxLDYwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgICBib2R5IHsKKyAgICAgICAgICAgIGhlaWdo dDogNjAwMHB4OworICAgICAgICB9CisgICAgICAgIC5ib3ggeworICAgICAgICAgICAgcG9zaXRp b246IGZpeGVkOworICAgICAgICAgICAgdG9wOiAxMHB4OworICAgICAgICAgICAgbGVmdDogMTBw eDsKKyAgICAgICAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgICAgIGhlaWdodDogMjAwcHg7 CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKKyAgICAgICAgfQorICAgICAg ICAKKyAgICAgICAgLmZpeGVkLWJhY2tncm91bmQgeworICAgICAgICAgICAgbWFyZ2luLXRvcDog MzAwcHg7CisgICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OworICAgICAgICAgICAgYmFja2dyb3Vu ZC1pbWFnZTogbGluZWFyLWdyYWRpZW50KHdoaXRlLCBzaWx2ZXIpOworICAgICAgICAgICAgYmFj a2dyb3VuZC1hdHRhY2htZW50OiBmaXhlZDsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAg PHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICB0 ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9u IHNjcm9sbFRlc3QoKQorICAgICAgICB7CisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1v dmVUbygyMCwgMjApOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhX aGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xLCAiYmVnYW4iLCAibm9uZSIpOworICAgICAgICAg ICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAs IC0xMDAsICJjaGFuZ2VkIiwgIm5vbmUiKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNl U2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAtMTAwLCAiY2hhbmdlZCIsICJu b25lIik7CisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5k TW9tZW50dW1QaGFzZXMoMCwgLTEsICJjaGFuZ2VkIiwgIm5vbmUiKTsKKyAgICAgICAgICAgIGV2 ZW50U2VuZGVyLm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAwLCAi ZW5kZWQiLCAibm9uZSIpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdp dGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xMDAsICJub25lIiwgImJlZ2luIik7CisgICAg ICAgICAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFz ZXMoMCwgLTEwMCwgIm5vbmUiLCAiY29udGludWUiKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAtMTAwLCAibm9uZSIs ICJjb250aW51ZSIpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhX aGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xMDAsICJub25lIiwgImNvbnRpbnVlIik7CisgICAg ICAgICAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFz ZXMoMCwgMCwgIm5vbmUiLCAiZW5kIik7CisgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURv bmUoKTsKKyAgICAgICAgfQorCisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2Fk JywgKCkgPT4geworICAgICAgICAgICAgc2V0VGltZW91dCgoKSA9PiB7CisgICAgICAgICAgICAg ICAgc2Nyb2xsVGVzdCgpOworICAgICAgICAgICAgfSwgMCkKKyAgICAgICAgfSwgZmFsc2UpOwor ICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisKKzxkaXYgY2xhc3M9ImJveCI+PC9kaXY+ CisKKzxkaXYgY2xhc3M9ImZpeGVkLWJhY2tncm91bmQiPgorICAgIEkgaGF2ZSBhIGZpeGVkIGJh Y2tncm91bmQuCis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K 356448 2018-12-03 19:18:50 -0800 2018-12-03 20:03:56 -0800 Patch bug-192320-20181203191850.patch text/plain 7218 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRlNjE1ZGQyYmRkNTIy NGRiOTM3ZTVkNGM0N2NlOWJiNDY4YThiMS4uMDA0NTZjZjEzN2VkNGFjZWNhZDZkYjk2MWNkNWJi ZTQ0MGJhZWE0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTEyLTAzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyMzgwOTApOiBwb3NpdGlvbjpmaXhlZCBzaWRlYmFyIG9uIGh0dHBzOi8vd3d3LnczLm9yZy9U Ui9TVkcyL2Nvb3Jkcy5odG1sIGRvZXMgbm90IHN0YXkgZml4ZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjMyMAorICAgICAgICA8cmRhcjovL3By b2JsZW0vNDY0Mjk4MzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBXaGVuIHdlIGZhbGwgaW50byBzbG93IHNjcm9sbGluZyBtb2RlIChm b3IgZXhhbXBsZSwgYmVjYXVzZSBvZiBiYWNrZ3JvdW5kLWF0dGFjaG1lbnQ6IGZpeGVkKSwKKyAg ICAgICAgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycygpIG5l ZWRzIHRvIHNldCB0aGUgZ2VvbWV0cnkgZGlydHkgYml0IG9uIGxheWVycworICAgICAgICBmb3Ig dmlld3BvcnQtY29uc3RyYWluZWQgb2JqZWN0cyBzbyB3ZSB1cGRhdGUgdGhlbS4KKyAgICAgICAg CisgICAgICAgIFRoaXMgaXMgb25seSBuZWNlc3NhcnkgZm9yIHBhZ2Ugc2Nyb2xsaW5nOyBmb3Ig b3ZlcmZsb3cgc2Nyb2xscywgdXBkYXRlTGF5ZXJQb3NpdGlvbnMoKSBhbHJlYWR5CisgICAgICAg IGRvZXMgZW5vdWdoIGRpcnR5aW5nIHRoYXQgZml4ZWQgbGF5ZXJzIG5lc3RlZCBpbnNpZGUgc2Ny b2xsZXJzIGdldCB1cGRhdGVkLgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0aW5nL2ZpeGVkLXdp dGgtbWFpbi10aHJlYWQtc2Nyb2xsaW5nLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21w b3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycyk6CisKIDIwMTgtMTItMDMgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRnJhbWVWaWV3J3MgVmll d3BvcnRDb25zdHJhaW5lZE9iamVjdFNldCBjYW4gY29udGFpbiBSZW5kZXJMYXllck1vZGVsT2Jq ZWN0cyByYXRoZXIgdGhhbiBSZW5kZXJFbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCBlMDExMjU1OTlmZWUwYTg5 ZjZkOTZhZGM0MTY4NzI4ZDBhNDcyNWUyLi4yMDhjNjU2MTI0Mzc1MzAzZDZmNzkyNmQ5Mjk1ZmE2 OTAxNDg1OWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcApAQCAtNjY2LDkgKzY2NiwyMCBAQCBib29sIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoQ29tcG9zaXRpbmdVcGRhdGVUeXBlIHVw ZGF0ZQogICAgIGlmICghbV9jb21wb3NpdGluZyAmJiAobV9mb3JjZUNvbXBvc2l0aW5nTW9kZSB8 fCAoaXNNYWluRnJhbWVDb21wb3NpdG9yKCkgJiYgcGFnZSgpLnBhZ2VPdmVybGF5Q29udHJvbGxl cigpLm92ZXJsYXlDb3VudCgpKSkpCiAgICAgICAgIGVuYWJsZUNvbXBvc2l0aW5nTW9kZSh0cnVl KTsKIAorICAgIGJvb2wgaXNQYWdlU2Nyb2xsID0gIXVwZGF0ZVJvb3QgfHwgdXBkYXRlUm9vdCA9 PSAmcm9vdFJlbmRlckxheWVyKCk7CiAgICAgdXBkYXRlUm9vdCA9ICZyb290UmVuZGVyTGF5ZXIo KTsKIAogICAgIGlmICh1cGRhdGVUeXBlID09IENvbXBvc2l0aW5nVXBkYXRlVHlwZTo6T25TY3Jv bGwgfHwgdXBkYXRlVHlwZSA9PSBDb21wb3NpdGluZ1VwZGF0ZVR5cGU6Ok9uQ29tcG9zaXRlZFNj cm9sbCkgeworICAgICAgICAvLyBXZSBvbmx5IGdldCBoZXJlIGlmIHdlIGRpZG4ndCBzY3JvbGwg b24gdGhlIHNjcm9sbGluZyB0aHJlYWQsIHNvIHRoaXMgdXBkYXRlIG5lZWRzIHRvIHJlLXBvc2l0 aW9uIHZpZXdwb3J0LWNvbnN0cmFpbmVkIGxheWVycy4KKyAgICAgICAgaWYgKG1fcmVuZGVyVmll dy5zZXR0aW5ncygpLmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxl ZCgpICYmIGlzUGFnZVNjcm9sbCkgeworICAgICAgICAgICAgaWYgKGF1dG8qIHZpZXdwb3J0Q29u c3RyYWluZWRPYmplY3RzID0gbV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLnZpZXdwb3J0Q29uc3Ry YWluZWRPYmplY3RzKCkpIHsKKyAgICAgICAgICAgICAgICBmb3IgKGF1dG8qIHJlbmRlcmVyIDog KnZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChh dXRvKiBsYXllciA9IHJlbmRlcmVyLT5sYXllcigpKQorICAgICAgICAgICAgICAgICAgICAgICAg bGF5ZXItPnNldE5lZWRzQ29tcG9zaXRpbmdHZW9tZXRyeVVwZGF0ZSgpOworICAgICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCiAgICAgICAgIC8vIFNjcm9sbGluZyBj YW4gYWZmZWN0IG92ZXJsYXAuIEZJWE1FOiBhdm9pZCBmb3IgcGFnZSBzY3JvbGxpbmcuCiAgICAg ICAgIHVwZGF0ZVJvb3QtPnNldERlc2NlbmRhbnRzTmVlZENvbXBvc2l0aW5nUmVxdWlyZW1lbnRz VHJhdmVyc2FsKCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJiYzAwOGRjMTM2Y2VmMTljNTdlNzIyZTcxZWZl ZWJkMzAzYmM5OTUuLmIxMjM5OGQ5MThhMWRhZWM5YzcyY2NmYzhiYzdmZTFhYmRiOGYzMTkgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0xMi0wMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjM4MDkwKTogcG9zaXRpb246 Zml4ZWQgc2lkZWJhciBvbiBodHRwczovL3d3dy53My5vcmcvVFIvU1ZHMi9jb29yZHMuaHRtbCBk b2VzIG5vdCBzdGF5IGZpeGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTIzMjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NDI5ODMzPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29tcG9zaXRp bmcvZml4ZWQtd2l0aC1tYWluLXRocmVhZC1zY3JvbGxpbmctZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1tYWluLXRocmVhZC1zY3JvbGxpbmcu aHRtbDogQWRkZWQuCisKIDIwMTgtMTItMDMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIERvIG5vdCBoYW5kbGUga2V5IGV2ZW50cyB0aGF0IGFyZSBr ZXkgY29tbWFuZHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2ZpeGVkLXdp dGgtbWFpbi10aHJlYWQtc2Nyb2xsaW5nLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9maXhlZC13aXRoLW1haW4tdGhyZWFkLXNjcm9sbGluZy1leHBlY3RlZC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjZiZjdjYmE2ODgxYWVlOTJiMzRkNGY1YWNjZmM2ZmJjMjM1ZDkyMmYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9maXhlZC13aXRoLW1haW4tdGhy ZWFkLXNjcm9sbGluZy1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMzYgQEAKKzwhRE9DVFlQRSBo dG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAgIGJvZHkgeworICAgICAg ICAgICAgaGVpZ2h0OiA2MDAwcHg7CisgICAgICAgIH0KKyAgICAgICAgLmJveCB7CisgICAgICAg ICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgICAgICB0b3A6IDU3MThweDsKKyAgICAg ICAgICAgIGxlZnQ6IDEwcHg7CisgICAgICAgICAgICB3aWR0aDogMjAwcHg7CisgICAgICAgICAg ICBoZWlnaHQ6IDIwMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47Cisg ICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIC5maXhlZC1iYWNrZ3JvdW5kIHsKKyAgICAgICAg ICAgIG1hcmdpbi10b3A6IDMwMHB4OworICAgICAgICAgICAgaGVpZ2h0OiAyMDBweDsKKyAgICAg ICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVudCh3aGl0ZSwgc2lsdmVyKTsK KyAgICAgICAgICAgIGJhY2tncm91bmQtYXR0YWNobWVudDogZml4ZWQ7CisgICAgICAgIH0KKyAg ICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisKKzxkaXYgY2xhc3M9ImJveCI+PC9kaXY+CisK KzxkaXYgY2xhc3M9ImZpeGVkLWJhY2tncm91bmQiPgorICAgIEkgaGF2ZSBhIGZpeGVkIGJhY2tn cm91bmQuCis8L2Rpdj4KKzxzY3JpcHQ+CisgICAgd2luZG93LnNjcm9sbFRvKDAsIDYwMDApOwor PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9maXhlZC13aXRoLW1haW4tdGhyZWFkLXNjcm9sbGluZy5odG1sIGIvTGF5b3V0VGVz dHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1tYWluLXRocmVhZC1zY3JvbGxpbmcuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi45NTE2NjAzNDBmMDc3YjdkMzVmYmM3NTExNjk0ODc2NjllNmEyMjkxCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1tYWluLXRocmVh ZC1zY3JvbGxpbmcuaHRtbApAQCAtMCwwICsxLDYwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgICBib2R5IHsKKyAgICAgICAgICAgIGhlaWdo dDogNjAwMHB4OworICAgICAgICB9CisgICAgICAgIC5ib3ggeworICAgICAgICAgICAgcG9zaXRp b246IGZpeGVkOworICAgICAgICAgICAgdG9wOiAxMHB4OworICAgICAgICAgICAgbGVmdDogMTBw eDsKKyAgICAgICAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgICAgIGhlaWdodDogMjAwcHg7 CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKKyAgICAgICAgfQorICAgICAg ICAKKyAgICAgICAgLmZpeGVkLWJhY2tncm91bmQgeworICAgICAgICAgICAgbWFyZ2luLXRvcDog MzAwcHg7CisgICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OworICAgICAgICAgICAgYmFja2dyb3Vu ZC1pbWFnZTogbGluZWFyLWdyYWRpZW50KHdoaXRlLCBzaWx2ZXIpOworICAgICAgICAgICAgYmFj a2dyb3VuZC1hdHRhY2htZW50OiBmaXhlZDsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAg PHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICB0 ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9u IHNjcm9sbFRlc3QoKQorICAgICAgICB7CisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1v dmVUbygyMCwgMjApOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhX aGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xLCAiYmVnYW4iLCAibm9uZSIpOworICAgICAgICAg ICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAs IC0xMDAsICJjaGFuZ2VkIiwgIm5vbmUiKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNl U2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAtMTAwLCAiY2hhbmdlZCIsICJu b25lIik7CisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5k TW9tZW50dW1QaGFzZXMoMCwgLTEsICJjaGFuZ2VkIiwgIm5vbmUiKTsKKyAgICAgICAgICAgIGV2 ZW50U2VuZGVyLm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAwLCAi ZW5kZWQiLCAibm9uZSIpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdp dGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xMDAsICJub25lIiwgImJlZ2luIik7CisgICAg ICAgICAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFz ZXMoMCwgLTEwMCwgIm5vbmUiLCAiY29udGludWUiKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAtMTAwLCAibm9uZSIs ICJjb250aW51ZSIpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhX aGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xMDAsICJub25lIiwgImNvbnRpbnVlIik7CisgICAg ICAgICAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFz ZXMoMCwgMCwgIm5vbmUiLCAiZW5kIik7CisgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURv bmUoKTsKKyAgICAgICAgfQorCisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2Fk JywgKCkgPT4geworICAgICAgICAgICAgc2V0VGltZW91dCgoKSA9PiB7CisgICAgICAgICAgICAg ICAgc2Nyb2xsVGVzdCgpOworICAgICAgICAgICAgfSwgMCkKKyAgICAgICAgfSwgZmFsc2UpOwor ICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisKKzxkaXYgY2xhc3M9ImJveCI+PC9kaXY+ CisKKzxkaXYgY2xhc3M9ImZpeGVkLWJhY2tncm91bmQiPgorICAgIEkgaGF2ZSBhIGZpeGVkIGJh Y2tncm91bmQuCis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K