192317 2018-12-03 12:34:25 -0800 Web Inspector: Audit: navigating while tests are running should stop and clear all results 2018-12-03 20:06:40 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190754 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1484446 0 hi 2018-12-03 12:34:25 -0800 # STEPS TO REPRODUCE 1. open WebInspector 2. enable the Audit tab 3. load the default audits 4. start running the test 5. refresh the page => any tests with results are cleared, but all active tests (e.g. one's that have been queued but not yet run) continue running # NOTE For (4), it may be necessary to add an `await Promise.delay(1000)` inside `WI.AuditTestCase.prototype.run`, as the audits can run quite fast 1484584 1 webkit-bug-importer 2018-12-03 15:57:59 -0800 <rdar://problem/46435222> 1484632 2 356440 hi 2018-12-03 17:06:40 -0800 Created attachment 356440 Patch 1484649 3 356440 joepeck 2018-12-03 18:13:34 -0800 Comment on attachment 356440 Patch r=me You could write a test for this, but it seems like it could be rather artificial. 1484676 4 356440 hi 2018-12-03 19:43:11 -0800 Comment on attachment 356440 Patch (In reply to Joseph Pecoraro from comment #3) > You could write a test for this, but it seems like it could be rather artificial. I'd need to wait for <https://webkit.org/b/192171> to land, as I'd need to create a long test that doesn't interfere with the page (e.g. a `setTimeout`), and I'd imagine that that would be pretty flakey. 1484688 5 356440 commit-queue 2018-12-03 20:06:38 -0800 Comment on attachment 356440 Patch Clearing flags on attachment: 356440 Committed r238841: <https://trac.webkit.org/changeset/238841> 1484689 6 commit-queue 2018-12-03 20:06:40 -0800 All reviewed patches have been landed. Closing bug. 356440 2018-12-03 17:06:40 -0800 2018-12-03 20:06:38 -0800 Patch bug-192317-20181203170640.patch text/plain 3727 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ2MDNhN2VhMTZlMTI5ZjhkYjFjNmQwMWYxYjU5 NjdiYmQzM2M5OWMuLjQxZWNjMjJlOTUyMDYxYTQwNmFlY2JlMzM3MjFjYzdkMDYxMGQwMzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEyLTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogbmF2aWdhdGluZyB3aGlsZSB0ZXN0cyBhcmUgcnVubmluZyBzaG91bGQgc3RvcCBhbmQg Y2xlYXIgYWxsIHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MjMxNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY0MzUyMjI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0F1ZGl0TWFuYWdlci5qczoKKyAgICAgICAgKFdJLkF1ZGl0TWFuYWdl ci5wcm90b3R5cGUuYXN5bmMgc3RhcnQpOgorICAgICAgICAoV0kuQXVkaXRNYW5hZ2VyLnByb3Rv dHlwZS5faGFuZGxlRnJhbWVNYWluUmVzb3VyY2VEaWRDaGFuZ2UpOgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwuanM6CisgICAgICAg IChXSS5BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLmluaXRpYWxMYXlvdXQp OgorICAgICAgICBEcml2ZS1ieTogcGFzcyB0aGUgaW5kZXggb2YgdGhlIHNhdmVkIHJlc3VsdC4K KwogMjAxOC0xMi0wMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjM4NTk5KTogTXVsdGlwbGUgU2VsZWN0aW9u OiByZXN0b3Jpbmcgc2VsZWN0aW9uIHdoZW4gb3BlbmluZyBXZWJJbnNwZWN0b3IgcHV0cyB0aGUg VHJlZUVsZW1lbnQgaW50byBhIHBlcm1hbmVudCBzZWxlY3RlZCBzdGF0ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQXVkaXRNYW5h Z2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv QXVkaXRNYW5hZ2VyLmpzCmluZGV4IDBhYjkyMDFjMDkyODNmOTc4MGQxODQ2MDM2NjhjYjQxMmRi ZGMzMWEuLjYyZDc0OTM3MDFjMDM3YWIzMTQ3ZmM5NDQ5ZTQ2YWIxZGFkYzgwNDcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0F1ZGl0 TWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9BdWRpdE1hbmFnZXIuanMKQEAgLTY2LDYgKzY2LDggQEAgV0kuQXVkaXRNYW5hZ2Vy ID0gY2xhc3MgQXVkaXRNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIGlmICghdGVz dHMubGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgIGxldCBtYWluUmVzb3Vy Y2UgPSBXSS5uZXR3b3JrTWFuYWdlci5tYWluRnJhbWUubWFpblJlc291cmNlOworCiAgICAgICAg IHRoaXMuX3J1bm5pbmdTdGF0ZSA9IFdJLkF1ZGl0TWFuYWdlci5SdW5uaW5nU3RhdGUuQWN0aXZl OwogICAgICAgICB0aGlzLl9ydW5uaW5nVGVzdHMgPSB0ZXN0czsKICAgICAgICAgZm9yIChsZXQg dGVzdCBvZiB0aGlzLl9ydW5uaW5nVGVzdHMpCkBAIC04MSw2ICs4MywxMiBAQCBXSS5BdWRpdE1h bmFnZXIgPSBjbGFzcyBBdWRpdE1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgdGhp cy5fcnVubmluZ1Rlc3RzID0gW107CiAKICAgICAgICAgdGhpcy5fYWRkUmVzdWx0KHJlc3VsdCk7 CisKKyAgICAgICAgaWYgKG1haW5SZXNvdXJjZSAhPT0gV0kubmV0d29ya01hbmFnZXIubWFpbkZy YW1lLm1haW5SZXNvdXJjZSkgeworICAgICAgICAgICAgLy8gTmF2aWdhdGVkIHdoaWxlIHRlc3Rz IHdlcmUgcnVubmluZy4KKyAgICAgICAgICAgIGZvciAobGV0IHRlc3Qgb2YgdGhpcy5fdGVzdHMp CisgICAgICAgICAgICAgICAgdGVzdC5jbGVhclJlc3VsdCgpOworICAgICAgICB9CiAgICAgfQog CiAgICAgc3RvcCgpCkBAIC0xOTQsOCArMjAyLDEyIEBAIFdJLkF1ZGl0TWFuYWdlciA9IGNsYXNz IEF1ZGl0TWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICBpZiAoIWV2ZW50LnRhcmdl dC5pc01haW5GcmFtZSgpKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGZvciAobGV0 IHRlc3Qgb2YgdGhpcy5fdGVzdHMpCi0gICAgICAgICAgICB0ZXN0LmNsZWFyUmVzdWx0KCk7Cisg ICAgICAgIGlmICh0aGlzLl9ydW5uaW5nU3RhdGUgPT09IFdJLkF1ZGl0TWFuYWdlci5SdW5uaW5n U3RhdGUuQWN0aXZlKQorICAgICAgICAgICAgdGhpcy5zdG9wKCk7CisgICAgICAgIGVsc2Ugewor ICAgICAgICAgICAgZm9yIChsZXQgdGVzdCBvZiB0aGlzLl90ZXN0cykKKyAgICAgICAgICAgICAg ICB0ZXN0LmNsZWFyUmVzdWx0KCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBhZGREZWZhdWx0 VGVzdHNJZk5lZWRlZCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFu ZWwuanMKaW5kZXggMDA1YzQ2ODgzNjM4OWQxOTdhMzllYjQzODkyMjI4NTE2NDllN2YwMi4uZmJi ZmNhZGJhZGY0NDRjN2E0YTE3NzA2OTFkODJjYmVhOTJiYzUzZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXROYXZpZ2F0aW9uU2lkZWJh clBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0F1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwpAQCAtODMsOCArODMsOSBAQCBXSS5BdWRp dE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgPSBjbGFzcyBBdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFu ZWwgZXh0ZW5kcyBXSS5OYQogICAgICAgICBmb3IgKGxldCB0ZXN0IG9mIFdJLmF1ZGl0TWFuYWdl ci50ZXN0cykKICAgICAgICAgICAgIHRoaXMuX2FkZFRlc3QodGVzdCk7CiAKLSAgICAgICAgZm9y IChsZXQgcmVzdWx0IG9mIFdJLmF1ZGl0TWFuYWdlci5yZXN1bHRzKQotICAgICAgICAgICAgdGhp cy5fYWRkUmVzdWx0KHJlc3VsdCk7CisgICAgICAgIFdJLmF1ZGl0TWFuYWdlci5yZXN1bHRzLmZv ckVhY2goKHJlc3VsdCwgaSkgPT4geworICAgICAgICAgICAgdGhpcy5fYWRkUmVzdWx0KHJlc3Vs dCwgaSk7CisgICAgICAgIH0pOwogCiAgICAgICAgIFdJLmF1ZGl0TWFuYWdlci5hZGRFdmVudExp c3RlbmVyKFdJLkF1ZGl0TWFuYWdlci5FdmVudC5UZXN0QWRkZWQsIHRoaXMuX2hhbmRsZUF1ZGl0 VGVzdEFkZGVkLCB0aGlzKTsKICAgICAgICAgV0kuYXVkaXRNYW5hZ2VyLmFkZEV2ZW50TGlzdGVu ZXIoV0kuQXVkaXRNYW5hZ2VyLkV2ZW50LlRlc3RDb21wbGV0ZWQsIHRoaXMuX2hhbmRsZUF1ZGl0 VGVzdENvbXBsZXRlZCwgdGhpcyk7Cg==