192297 2018-12-02 21:37:11 -0800 [LFC][BFC][MarginCollapsing] Add MarginCollapse::establishesBlockFormattingContext 2018-12-06 07:22:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1484257 0 zalan 2018-12-02 21:37:11 -0800 too deal with WebKit quirk 1484258 1 356355 zalan 2018-12-02 21:41:45 -0800 Created attachment 356355 Patch 1485690 2 zalan 2018-12-06 07:21:56 -0800 Committed r238930: <https://trac.webkit.org/changeset/238930> 1485691 3 webkit-bug-importer 2018-12-06 07:22:37 -0800 <rdar://problem/46523099> 356355 2018-12-02 21:41:45 -0800 2018-12-05 08:28:29 -0800 Patch bug-192297-20181202214137.patch text/plain 3735 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFhYzU2ZmY0YWMwMWFj ZDE1MTk2NDI4YjY1MTYyMDU0ZjBiYjhiOS4uNmQ5ZWVmNjk3MjQ0NjUxMTg0NzdjMzM2OTg3NmNm MzA5MWNjMzlhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEyLTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXVtNYXJnaW5D b2xsYXBzaW5nXSBBZGQgTWFyZ2luQ29sbGFwc2U6OmVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5n Q29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkyMjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2ViS2l0IHRyZWF0cyB0aGUgZG9jdW1lbnQgZWxlbWVudCByZW5kZXJlciBhcyBhIGJsb2NrIGZv cm1hdHRpbmcgY29udGV4dCByb290LiAKKworICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRp bmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OmVz dGFibGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjpNYXJnaW5Db2xsYXBzZTo6aXNN YXJnaW5Ub3BDb2xsYXBzZWRXaXRoUGFyZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6Ok1hcmdpbkNvbGxhcHNlOjppc01hcmdp bkJvdHRvbUNvbGxhcHNlZFdpdGhQYXJlbnQpOgorCiAyMDE4LTEyLTAyICBaYWxhbiBCdWp0YXMg IDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgcnVudGltZSBmZWF0dXJlIGZsYWcg Zm9yIExheW91dEZvcm1hdHRpbmdDb250ZXh0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5jcHAKaW5k ZXggZWI3OTNiM2NkNGYwNmRiZWU1OTdkYThiNDQ1YjY3OTAzZDQwN2MyMS4uYmYxYTA4Y2NiNjU5 ZTU3MzU5MzdjNzZlODIyZTg3ZGJhODg5ZTQ4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3Bw CkBAIC02OSw2ICs2OSwxNSBAQCBzdGF0aWMgYm9vbCBoYXNQYWRkaW5nQWZ0ZXIoY29uc3QgQm94 JiBsYXlvdXRCb3gpCiAgICAgcmV0dXJuIGhhc1BhZGRpbmcobGF5b3V0Qm94LnN0eWxlKCkucGFk ZGluZ0FmdGVyKCkpOwogfQogCitzdGF0aWMgYm9vbCBlc3RhYmxpc2hlc0Jsb2NrRm9ybWF0dGlu Z0NvbnRleHQoY29uc3QgQm94JiBsYXlvdXRCb3gpCit7CisgICAgLy8gV2ViS2l0IHRyZWF0cyB0 aGUgZG9jdW1lbnQgZWxlbWVudCByZW5kZXJlciBhcyBhIGJsb2NrIGZvcm1hdHRpbmcgY29udGV4 dCByb290LiBJdCBwcm9iYWJseSBvbmx5IGltcGFjdHMgbWFyZ2luIGNvbGxhcHNpbmcsIHNvIGxl dCdzIG5vdCBkbworICAgIC8vIGEgbGF5b3V0IHdpZGUgcXVpcmsgb24gdGhpcyBmb3Igbm93Lgor ICAgIGlmIChsYXlvdXRCb3guaXNEb2N1bWVudEJveCgpKQorICAgICAgICByZXR1cm4gdHJ1ZTsK KyAgICByZXR1cm4gbGF5b3V0Qm94LmVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dCgp OworfQorCiBzdGF0aWMgTGF5b3V0VW5pdCBtYXJnaW5WYWx1ZShMYXlvdXRVbml0IGN1cnJlbnRN YXJnaW5WYWx1ZSwgTGF5b3V0VW5pdCBjYW5kaWRhdGVNYXJnaW5WYWx1ZSkKIHsKICAgICBpZiAo IWNhbmRpZGF0ZU1hcmdpblZhbHVlKQpAQCAtMTMxLDE0ICsxNDAsOSBAQCBib29sIEJsb2NrRm9y bWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjpNYXJnaW5Db2xsYXBzZTo6aXNNYXJnaW5Ub3BDb2xs YXBzZWRXaXRoUAogICAgIGlmIChsYXlvdXRCb3gucHJldmlvdXNJbkZsb3dTaWJsaW5nKCkpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIC8vIFdlIG5ldmVyIG1hcmdpbiBjb2xsYXBzZSB0 aGUgaW5pdGlhbCBjb250YWluaW5nIGJsb2NrLgotICAgIEFTU0VSVChsYXlvdXRCb3gucGFyZW50 KCkpOwogICAgIGF1dG8mIHBhcmVudCA9ICpsYXlvdXRCb3gucGFyZW50KCk7Ci0gICAgaWYgKHBh cmVudC5lc3RhYmxpc2hlc0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQoKSkKLSAgICAgICAgcmV0dXJu IGZhbHNlOwotCi0gICAgLy8gTWFyZ2lucyBvZiB0aGUgcm9vdCBlbGVtZW50J3MgYm94IGRvIG5v dCBjb2xsYXBzZS4KLSAgICBpZiAocGFyZW50LmlzRG9jdW1lbnRCb3goKSB8fCBwYXJlbnQuaXNJ bml0aWFsQ29udGFpbmluZ0Jsb2NrKCkpCisgICAgLy8gTWFyZ2lucyBvZiBlbGVtZW50cyB0aGF0 IGVzdGFibGlzaCBuZXcgYmxvY2sgZm9ybWF0dGluZyBjb250ZXh0cyBkbyBub3QgY29sbGFwc2Ug d2l0aCB0aGVpciBpbi1mbG93IGNoaWxkcmVuCisgICAgaWYgKGVzdGFibGlzaGVzQmxvY2tGb3Jt YXR0aW5nQ29udGV4dChwYXJlbnQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAo aGFzQm9yZGVyQmVmb3JlKHBhcmVudCkpCkBAIC0zMDgsMTggKzMxMiwxMyBAQCBib29sIEJsb2Nr Rm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjpNYXJnaW5Db2xsYXBzZTo6aXNNYXJnaW5Cb3R0 b21Db2xsYXBzZWRXaQogICAgIGlmIChpc01hcmdpbkJvdHRvbUNvbGxhcHNlZFRocm91Z2gobGF5 b3V0Qm94KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgLy8gV2UgbmV2ZXIgbWFyZ2lu IGNvbGxhcHNlIHRoZSBpbml0aWFsIGNvbnRhaW5pbmcgYmxvY2suCi0gICAgQVNTRVJUKGxheW91 dEJveC5wYXJlbnQoKSk7Ci0gICAgYXV0byYgcGFyZW50ID0gKmxheW91dEJveC5wYXJlbnQoKTsK ICAgICAvLyBPbmx5IHRoZSBsYXN0IGlubGZsb3cgY2hpbGQgY29sbGFwc2VzIHdpdGggcGFyZW50 LgogICAgIGlmIChsYXlvdXRCb3gubmV4dEluRmxvd1NpYmxpbmcoKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCi0gICAgaWYgKHBhcmVudC5lc3RhYmxpc2hlc0Jsb2NrRm9ybWF0dGluZ0NvbnRl eHQoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgLy8gTWFyZ2lucyBvZiB0aGUgcm9v dCBlbGVtZW50J3MgYm94IGRvIG5vdCBjb2xsYXBzZS4KLSAgICBpZiAocGFyZW50LmlzRG9jdW1l bnRCb3goKSB8fCBwYXJlbnQuaXNJbml0aWFsQ29udGFpbmluZ0Jsb2NrKCkpCisgICAgYXV0byYg cGFyZW50ID0gKmxheW91dEJveC5wYXJlbnQoKTsKKyAgICAvLyBNYXJnaW5zIG9mIGVsZW1lbnRz IHRoYXQgZXN0YWJsaXNoIG5ldyBibG9jayBmb3JtYXR0aW5nIGNvbnRleHRzIGRvIG5vdCBjb2xs YXBzZSB3aXRoIHRoZWlyIGluLWZsb3cgY2hpbGRyZW4KKyAgICBpZiAoZXN0YWJsaXNoZXNCbG9j a0Zvcm1hdHRpbmdDb250ZXh0KHBhcmVudCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAg IGlmIChoYXNCb3JkZXJCZWZvcmUocGFyZW50KSkK