192265 2018-11-30 16:16:35 -0800 Editable images should always return some data, even if the canvas doesn't have a size yet 2018-11-30 17:11:22 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin commit-queue mitz simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1483820 0 thorton 2018-11-30 16:16:35 -0800 Editable images should always return some data, even if the canvas doesn't have a size yet 1483821 1 356259 thorton 2018-11-30 16:16:49 -0800 Created attachment 356259 Patch 1483822 2 thorton 2018-11-30 16:16:51 -0800 <rdar://problem/46385911> 1483857 3 commit-queue 2018-11-30 17:10:33 -0800 The commit-queue encountered the following flaky tests while processing attachment 356259: inspector/css/css-property.html bug 192269 (authors: drousso@apple.com and nvasilyev@apple.com) The commit-queue is continuing to process your patch. 1483858 4 356259 commit-queue 2018-11-30 17:11:21 -0800 Comment on attachment 356259 Patch Clearing flags on attachment: 356259 Committed r238767: <https://trac.webkit.org/changeset/238767> 1483859 5 commit-queue 2018-11-30 17:11:22 -0800 All reviewed patches have been landed. Closing bug. 356259 2018-11-30 16:16:49 -0800 2018-11-30 17:11:21 -0800 Patch bug-192265-20181130161648.patch text/plain 5628 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGEyODdkY2EzODIyNTBiMGRi OTlkNGI4YzNiODcyMzc2MjAzYzYwMGUuLjMxMDA4MTk3ZDc0NWU1ZjVhNzBiYzU3YzkxMjAzZmMx YzZjNjZjZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMTEtMzAgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRWRpdGFibGUgaW1hZ2Vz IHNob3VsZCBhbHdheXMgcmV0dXJuIHNvbWUgZGF0YSwgZXZlbiBpZiB0aGUgY2FudmFzIGRvZXNu J3QgaGF2ZSBhIHNpemUgeWV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTIyNjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2Mzg1OTExPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNz L2lvcy9XS0RyYXdpbmdWaWV3Lm1tOgorICAgICAgICAoLVtXS0RyYXdpbmdWaWV3IGxheW91dFN1 YnZpZXdzXSk6CisgICAgICAgIChlbXB0eUltYWdlKToKKyAgICAgICAgKC1bV0tEcmF3aW5nVmll dyByZW5kZXJlZERyYXdpbmddKToKKyAgICAgICAgKC1bV0tEcmF3aW5nVmlldyBQTkdSZXByZXNl bnRhdGlvbl0pOgorICAgICAgICBTb21lIGNsaWVudHMgc3Ryb25nbHkgZGVwZW5kIG9uIHRoZXJl IGJlaW5nIHNvbWUgZGF0YSBpbiBhbiBpbWFnZSwgZXZlbiBpZgorICAgICAgICBpdCdzIG5vdCBv ZiBhIHVzYWJsZSBzaXplIHlldC4gV2UnbGwgaW52YWxpZGF0ZSB0aGUgYXR0YWNobWVudCB3aGVu IHRoZQorICAgICAgICBjYW52YXMgc2l6ZSBjaGFuZ2VzLCBzbyBpdCB3aWxsIGV2ZW50dWFsbHkg c2V0dGxlIGF0IGEgdXNhYmxlIHNpemUgKGFmdGVyCisgICAgICAgIHRoZSBmaXJzdCBsYXllciB0 cmVlIGNvbW1pdCB0aGF0IGluY2x1ZGVzIHRoZSBlZGl0YWJsZSBpbWFnZSkuCisKIDIwMTgtMTEt MzAgIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRhQGFwcGxlLmNvbT4KIAogICAgICAgICAt W1dLUHJvY2Vzc1Bvb2wgX2Rvd25sb2FkVVJMUmVxdWVzdDpdIHNob3VsZCBhbGxvdyBzcGVjaWZ5 aW5nIHRoZSBpbml0aWF0aW5nIHdlYiB2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tEcmF3aW5nVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0RyYXdpbmdWaWV3Lm1tCmluZGV4IGY4ZDI1MDBlMjY0MjdkOGI5ZTFkZmQ4MTM1YzA0NGY1 NjBhYTA4MjAuLmQwZDkwM2RlYTcyNzkzNjZiZTM4YjA3YzllNDVjYjk1ZGFkMmI2MGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0RyYXdpbmdWaWV3Lm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0RyYXdpbmdWaWV3Lm1tCkBAIC0zOSw4ICsz OSwxMCBAQCBAZW5kCiBAaW1wbGVtZW50YXRpb24gV0tEcmF3aW5nVmlldyB7CiAgICAgUmV0YWlu UHRyPFBLQ2FudmFzVmlldz4gX3BlbmNpbFZpZXc7CiAKKyNpZiAhUExBVEZPUk0oSU9TX0ZBTUlM WV9TSU1VTEFUT1IpCiAgICAgT1NPYmplY3RQdHI8ZGlzcGF0Y2hfcXVldWVfdD4gX3JlbmRlclF1 ZXVlOwogICAgIFJldGFpblB0cjxQS0ltYWdlUmVuZGVyZXI+IF9yZW5kZXJlcjsKKyNlbmRpZgog CiAgICAgV2Vha1B0cjxXZWJLaXQ6OldlYlBhZ2VQcm94eT4gX3dlYlBhZ2VQcm94eTsKIH0KQEAg LTcwLDE4ICs3MiwzNiBAQCAtICh2b2lkKWxheW91dFN1YnZpZXdzCiAgICAgaWYgKCFDR1JlY3RF cXVhbFRvUmVjdChbX3BlbmNpbFZpZXcgZnJhbWVdLCBzZWxmLmJvdW5kcykpIHsKICAgICAgICAg W19wZW5jaWxWaWV3IHNldEZyYW1lOnNlbGYuYm91bmRzXTsKIAorI2lmICFQTEFURk9STShJT1Nf RkFNSUxZX1NJTVVMQVRPUikKICAgICAgICAgLy8gVGhlIHJlbmRlcmVyIGlzIGluc3RhbnRpYXRl ZCBmb3IgYSBwYXJ0aWN1bGFyIHNpemUgb3V0cHV0OyBpZgogICAgICAgICAvLyB0aGUgc2l6ZSBj aGFuZ2VzLCB3ZSBuZWVkIHRvIHJlLWNyZWF0ZSB0aGUgcmVuZGVyZXIuCiAgICAgICAgIF9yZW5k ZXJlciA9IG5pbDsKKyNlbmRpZgogCiAgICAgICAgIFtzZWxmIGludmFsaWRhdGVBdHRhY2htZW50 XTsKICAgICB9CiB9CiAKLS0gKE5TRGF0YSAqKVBOR1JlcHJlc2VudGF0aW9uCitzdGF0aWMgVUlJ bWFnZSAqZW1wdHlJbWFnZSgpCit7CisgICAgVUlHcmFwaGljc0JlZ2luSW1hZ2VDb250ZXh0KENH U2l6ZU1ha2UoMSwgMSkpOworICAgIENHQ29udGV4dENsZWFyUmVjdChVSUdyYXBoaWNzR2V0Q3Vy cmVudENvbnRleHQoKSwgQ0dSZWN0TWFrZSgwLCAwLCAxLCAxKSk7CisgICAgVUlJbWFnZSAqcmVz dWx0SW1hZ2UgPSBVSUdyYXBoaWNzR2V0SW1hZ2VGcm9tQ3VycmVudEltYWdlQ29udGV4dCgpOwor ICAgIFVJR3JhcGhpY3NFbmRJbWFnZUNvbnRleHQoKTsKKworICAgIHJldHVybiByZXN1bHRJbWFn ZTsKK30KKworLSAoVUlJbWFnZSAqKXJlbmRlcmVkRHJhd2luZwogeworI2lmIFBMQVRGT1JNKElP U19GQU1JTFlfU0lNVUxBVE9SKQorICAgIC8vIFBLSW1hZ2VSZW5kZXJlciBjdXJyZW50bHkgZG9l c24ndCB3b3JrIGluIHRoZSBzaW11bGF0b3IuIEluIG9yZGVyIHRvCisgICAgLy8gYWxsb3cgc3Ry b2tlcyB0byBwZXJzaXN0IHJlZ2FyZGxlc3MgKG1vc3RseSBmb3IgdGVzdGluZyksIHdlJ2xsCisg ICAgLy8gc3ludGhlc2l6ZSBhbiBlbXB0eSAxeDEgaW1hZ2UuCisgICAgcmV0dXJuIGVtcHR5SW1h Z2UoKTsKKyNlbHNlCiAgICAgaWYgKCFzZWxmLmJvdW5kcy5zaXplLndpZHRoIHx8ICFzZWxmLmJv dW5kcy5zaXplLmhlaWdodCB8fCAhc2VsZi53aW5kb3cuc2NyZWVuLnNjYWxlKQotICAgICAgICBy ZXR1cm4gbmlsOworICAgICAgICByZXR1cm4gZW1wdHlJbWFnZSgpOwogCiAgICAgaWYgKCFfcmVu ZGVyUXVldWUpCiAgICAgICAgIF9yZW5kZXJRdWV1ZSA9IGFkb3B0T1NPYmplY3QoZGlzcGF0Y2hf cXVldWVfY3JlYXRlKCJjb20uYXBwbGUuV2ViS2l0LldLRHJhd2luZ1ZpZXcuUmVuZGVyaW5nIiwg RElTUEFUQ0hfUVVFVUVfU0VSSUFMKSk7CkBAIC04OSwzMSArMTA5LDI3IEBAIC0gKE5TRGF0YSAq KVBOR1JlcHJlc2VudGF0aW9uCiAgICAgaWYgKCFfcmVuZGVyZXIpCiAgICAgICAgIF9yZW5kZXJl ciA9IGFkb3B0TlMoW1dlYktpdDo6YWxsb2NQS0ltYWdlUmVuZGVyZXJJbnN0YW5jZSgpIGluaXRX aXRoU2l6ZTpzZWxmLmJvdW5kcy5zaXplIHNjYWxlOnNlbGYud2luZG93LnNjcmVlbi5zY2FsZSBy ZW5kZXJRdWV1ZTpfcmVuZGVyUXVldWUuZ2V0KCldKTsKIAotICAgIGF1dG8qIGRyYXdpbmcgPSBb X3BlbmNpbFZpZXcgZHJhd2luZ107Ci0KICAgICBfX2Jsb2NrIFJldGFpblB0cjxVSUltYWdlPiBy ZXN1bHRJbWFnZTsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZX1NJTVVMQVRPUikKLSAgICAvLyBQ S0ltYWdlUmVuZGVyZXIgY3VycmVudGx5IGRvZXNuJ3Qgd29yayBpbiB0aGUgc2ltdWxhdG9yLiBJ biBvcmRlciB0bwotICAgIC8vIGFsbG93IHN0cm9rZXMgdG8gcGVyc2lzdCByZWdhcmRsZXNzICht b3N0bHkgZm9yIHRlc3RpbmcpLCB3ZSdsbAotICAgIC8vIHN5bnRoZXNpemUgYW4gZW1wdHkgMXgx IGltYWdlLgotICAgIFVJR3JhcGhpY3NCZWdpbkltYWdlQ29udGV4dChDR1NpemVNYWtlKDEsIDEp KTsKLSAgICBDR0NvbnRleHRDbGVhclJlY3QoVUlHcmFwaGljc0dldEN1cnJlbnRDb250ZXh0KCks IENHUmVjdE1ha2UoMCwgMCwgMSwgMSkpOwotICAgIHJlc3VsdEltYWdlID0gVUlHcmFwaGljc0dl dEltYWdlRnJvbUN1cnJlbnRJbWFnZUNvbnRleHQoKTsKLSAgICBVSUdyYXBoaWNzRW5kSW1hZ2VD b250ZXh0KCk7Ci0jZWxzZQotICAgIFtfcmVuZGVyZXIgcmVuZGVyRHJhd2luZzpkcmF3aW5nIGNv bXBsZXRpb246XihVSUltYWdlICppbWFnZSkgeworCisgICAgW19yZW5kZXJlciByZW5kZXJEcmF3 aW5nOltfcGVuY2lsVmlldyBkcmF3aW5nXSBjb21wbGV0aW9uOl4oVUlJbWFnZSAqaW1hZ2UpIHsK ICAgICAgICAgcmVzdWx0SW1hZ2UgPSBpbWFnZTsKICAgICB9XTsKLSNlbmRpZgogCiAgICAgLy8g RklYTUU6IElkZWFsbHkgd2Ugd291bGQgbm90IHN5bmNocm9ub3VzbHkgd2FpdCBmb3IgdGhpcyBy ZW5kZXJpbmcsCiAgICAgLy8gYnV0IE5TRmlsZVdyYXBwZXIgcmVxdWlyZXMgZGF0YSBzeW5jaHJv bm91c2x5LCBhbmQgb3VyIGNsaWVudHMgZXhwZWN0CiAgICAgLy8gYW4gTlNGaWxlV3JhcHBlciB0 byBiZSBhdmFpbGFibGUgc3luY2hyb25vdXNseS4KICAgICBkaXNwYXRjaF9zeW5jKF9yZW5kZXJR dWV1ZS5nZXQoKSwgXnsgfSk7CiAKKyAgICByZXR1cm4gcmVzdWx0SW1hZ2UuZ2V0KCk7CisjZW5k aWYKK30KKworLSAoTlNEYXRhICopUE5HUmVwcmVzZW50YXRpb24KK3sKKyAgICBSZXRhaW5QdHI8 VUlJbWFnZT4gaW1hZ2UgPSBbc2VsZiByZW5kZXJlZERyYXdpbmddOwogICAgIFJldGFpblB0cjxO U011dGFibGVEYXRhPiBQTkdEYXRhID0gYWRvcHROUyhbW05TTXV0YWJsZURhdGEgYWxsb2NdIGlu aXRdKTsKICAgICBSZXRhaW5QdHI8Q0dJbWFnZURlc3RpbmF0aW9uUmVmPiBpbWFnZURlc3RpbmF0 aW9uID0gYWRvcHRDRihDR0ltYWdlRGVzdGluYXRpb25DcmVhdGVXaXRoRGF0YSgoX19icmlkZ2Ug Q0ZNdXRhYmxlRGF0YVJlZilQTkdEYXRhLmdldCgpLCBrVVRUeXBlUE5HLCAxLCBuaWwpKTsKLSAg ICBOU1N0cmluZyAqYmFzZTY0RHJhd2luZyA9IFtbZHJhd2luZyBzZXJpYWxpemVdIGJhc2U2NEVu Y29kZWRTdHJpbmdXaXRoT3B0aW9uczowXTsKKyAgICBOU1N0cmluZyAqYmFzZTY0RHJhd2luZyA9 IFtbW19wZW5jaWxWaWV3IGRyYXdpbmddIHNlcmlhbGl6ZV0gYmFzZTY0RW5jb2RlZFN0cmluZ1dp dGhPcHRpb25zOjBdOwogICAgIE5TRGljdGlvbmFyeSAqcHJvcGVydGllcyA9IG5pbDsKICAgICBp ZiAoYmFzZTY0RHJhd2luZykgewogICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIHB1dCB0aGlz IHNvbWV3aGVyZSBsZXNzIHVzZXItZmFjaW5nIHRoYW4gdGhlIEVYSUYgVXNlciBDb21tZW50IGZp ZWxkLgpAQCAtMTI0LDcgKzE0MCw3IEBAIC0gKE5TRGF0YSAqKVBOR1JlcHJlc2VudGF0aW9uCiAg ICAgICAgIH07CiAgICAgfQogICAgIENHSW1hZ2VEZXN0aW5hdGlvblNldFByb3BlcnRpZXMoaW1h Z2VEZXN0aW5hdGlvbi5nZXQoKSwgKF9fYnJpZGdlIENGRGljdGlvbmFyeVJlZilwcm9wZXJ0aWVz KTsKLSAgICBDR0ltYWdlRGVzdGluYXRpb25BZGRJbWFnZShpbWFnZURlc3RpbmF0aW9uLmdldCgp LCBbcmVzdWx0SW1hZ2UgQ0dJbWFnZV0sIChfX2JyaWRnZSBDRkRpY3Rpb25hcnlSZWYpcHJvcGVy dGllcyk7CisgICAgQ0dJbWFnZURlc3RpbmF0aW9uQWRkSW1hZ2UoaW1hZ2VEZXN0aW5hdGlvbi5n ZXQoKSwgW2ltYWdlIENHSW1hZ2VdLCAoX19icmlkZ2UgQ0ZEaWN0aW9uYXJ5UmVmKXByb3BlcnRp ZXMpOwogICAgIENHSW1hZ2VEZXN0aW5hdGlvbkZpbmFsaXplKGltYWdlRGVzdGluYXRpb24uZ2V0 KCkpOwogCiAgICAgcmV0dXJuIFBOR0RhdGEuYXV0b3JlbGVhc2UoKTsK