<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>192258</bug_id>
          
          <creation_ts>2018-11-30 14:42:59 -0800</creation_ts>
          <short_desc>Fix the bytecode code generator scripts to pretty print Bytecodes.h.</short_desc>
          <delta_ts>2018-11-30 16:15:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>keith_miller</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1483764</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-11-30 14:42:59 -0800</bug_when>
    <thetext>patch coming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483766</commentid>
    <comment_count>1</comment_count>
      <attachid>356242</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-11-30 14:46:49 -0800</bug_when>
    <thetext>Created attachment 356242
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483778</commentid>
    <comment_count>2</comment_count>
      <attachid>356242</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-11-30 15:20:12 -0800</bug_when>
    <thetext>Comment on attachment 356242
proposed patch.

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483812</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-30 16:13:23 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 356242:

workers/bomb.html bug 171985 (author: fpizlo@apple.com)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483813</commentid>
    <comment_count>4</comment_count>
      <attachid>356242</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-30 16:14:11 -0800</bug_when>
    <thetext>Comment on attachment 356242
proposed patch.

Clearing flags on attachment: 356242

Committed r238761: &lt;https://trac.webkit.org/changeset/238761&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483814</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-30 16:14:13 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1483817</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-11-30 16:15:33 -0800</bug_when>
    <thetext>&lt;rdar://problem/46387828&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>356242</attachid>
            <date>2018-11-30 14:46:49 -0800</date>
            <delta_ts>2018-11-30 16:14:11 -0800</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-192258.patch</filename>
            <type>text/plain</type>
            <size>3400</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM4NzU3KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA
CisyMDE4LTExLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG
aXggdGhlIGJ5dGVjb2RlIGNvZGUgZ2VuZXJhdG9yIHNjcmlwdHMgdG8gcHJldHR5IHByaW50IEJ5
dGVjb2Rlcy5oLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTkyMjU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgVGhpcyBtYWtlcyBCeXRlY29kZXMuaCBtb3JlIGh1bWFuIHJlYWRhYmxlLgorCisgICAgICAg
ICogZ2VuZXJhdG9yL0RTTC5yYjoKKyAgICAgICAgKiBnZW5lcmF0b3IvU2VjdGlvbi5yYjoKKwog
MjAxOC0xMS0zMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk
IHRoZSBnZW5lcmF0b3IgZGlyZWN0b3J5IHRvIHRoZSBYY29kZSBwcm9qZWN0LgpJbmRleDogU291
cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRvci9EU0wucmIKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L0phdmFTY3JpcHRDb3JlL2dlbmVyYXRvci9EU0wucmIJKHJldmlzaW9uIDIzODc1NikKKysrIFNv
dXJjZS9KYXZhU2NyaXB0Q29yZS9nZW5lcmF0b3IvRFNMLnJiCSh3b3JraW5nIGNvcHkpCkBAIC05
OSwxMyArOTksMTIgQEAgbW9kdWxlIERTTAogCiAgICAgZGVmIHNlbGYud3JpdGVfYnl0ZWNvZGVz
KGJ5dGVjb2RlX2xpc3QsIGJ5dGVjb2Rlc19maWxlbmFtZSkKICAgICAgICAgR2VuZXJhdGVkRmls
ZTo6Y3JlYXRlKGJ5dGVjb2Rlc19maWxlbmFtZSwgYnl0ZWNvZGVfbGlzdCkgZG8gfHRlbXBsYXRl
fAotICAgICAgICAgICAgdGVtcGxhdGUucHJlZml4ID0gIiNwcmFnbWEgb25jZSIKKyAgICAgICAg
ICAgIHRlbXBsYXRlLnByZWZpeCA9ICIjcHJhZ21hIG9uY2VcbiIKICAgICAgICAgICAgIG51bV9v
cGNvZGVzID0gQHNlY3Rpb25zLm1hcCgmOm9wY29kZXMpLmZsYXR0ZW4uc2l6ZQogICAgICAgICAg
ICAgdGVtcGxhdGUuYm9keSA9IDw8LUVPRgotICAgICAgICAgICAgICAgICN7QHNlY3Rpb25zLm1h
cCB7IHxzfCBzLmhlYWRlcl9oZWxwZXJzKG51bV9vcGNvZGVzKSB9LmpvaW4oIlxuIil9Ci0KLSAg
ICAgICAgICAgICAgICAjZGVmaW5lIEZPUl9FQUNIX0JZVEVDT0RFX1NUUlVDVChtYWNybykgXFwK
LSAgICAgICAgICAgICAgICAje29wY29kZXNfZm9yKDplbWl0X2luX3N0cnVjdHNfZmlsZSkubWFw
IHsgfG9wfCAibWFjcm8oI3tvcC5jYXBpdGFsaXplZF9uYW1lfSkgXFwiIH0uam9pbigiXG4iKX0K
KyN7QHNlY3Rpb25zLm1hcCB7IHxzfCBzLmhlYWRlcl9oZWxwZXJzKG51bV9vcGNvZGVzKSB9Lmpv
aW4oIlxuIil9CisjZGVmaW5lIEZPUl9FQUNIX0JZVEVDT0RFX1NUUlVDVChtYWNybykgXFwKKyN7
b3Bjb2Rlc19mb3IoOmVtaXRfaW5fc3RydWN0c19maWxlKS5tYXAgeyB8b3B8ICIgICAgbWFjcm8o
I3tvcC5jYXBpdGFsaXplZF9uYW1lfSkgXFwiIH0uam9pbigiXG4iKX0KICAgICAgICAgICAgIEVP
RgogICAgICAgICBlbmQKICAgICBlbmQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9nZW5l
cmF0b3IvU2VjdGlvbi5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZ2Vu
ZXJhdG9yL1NlY3Rpb24ucmIJKHJldmlzaW9uIDIzODc1NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9nZW5lcmF0b3IvU2VjdGlvbi5yYgkod29ya2luZyBjb3B5KQpAQCAtNjEsNyArNjEsNyBA
QCBjbGFzcyBTZWN0aW9uCiAgICAgICBvdXQgPSBTdHJpbmdJTy5uZXcKICAgICAgIGlmIGNvbmZp
Z1s6ZW1pdF9pbl9oX2ZpbGVdCiAgICAgICAgICAgb3V0LndyaXRlKCIjZGVmaW5lIEZPUl9FQUNI
XyN7Y29uZmlnWzptYWNyb19uYW1lX2NvbXBvbmVudF19X0lEKG1hY3JvKSBcXFxuIikKLSAgICAg
ICAgICBvcGNvZGVzLmVhY2ggeyB8b3Bjb2RlfCBvdXQud3JpdGUoIm1hY3JvKCN7b3Bjb2RlLm5h
bWV9LCAje29wY29kZS5sZW5ndGh9KSBcXFxuIikgfQorICAgICAgICAgIG9wY29kZXMuZWFjaCB7
IHxvcGNvZGV8IG91dC53cml0ZSgiICAgIG1hY3JvKCN7b3Bjb2RlLm5hbWV9LCAje29wY29kZS5s
ZW5ndGh9KSBcXFxuIikgfQogICAgICAgICAgIG91dCA8PCAiXG4iCiAKICAgICAgICAgICBvdXQu
d3JpdGUoIiNkZWZpbmUgTlVNQkVSX09GXyN7Y29uZmlnWzptYWNyb19uYW1lX2NvbXBvbmVudF19
X0lEUyAje29wY29kZXMubGVuZ3RofVxuIikKQEAgLTc3LDcgKzc3LDcgQEAgY2xhc3MgU2VjdGlv
bgogICAgICAgICAgICAgICAgICAgYnJlYWsKICAgICAgICAgICAgICAgZW5kCiAKLSAgICAgICAg
ICAgICAgb3V0LndyaXRlKCJtYWNybyhzaXplb2YoI3tvcGNvZGVzW2ldLmNhcGl0YWxpemVkX25h
bWV9OjpNZXRhZGF0YSkpXFxcbiIpCisgICAgICAgICAgICAgIG91dC53cml0ZSgiICAgIG1hY3Jv
KHNpemVvZigje29wY29kZXNbaV0uY2FwaXRhbGl6ZWRfbmFtZX06Ok1ldGFkYXRhKSlcXFxuIikK
ICAgICAgICAgICAgICAgaSArPSAxCiAgICAgICAgICAgZW5kCiAgICAgICAgICAgb3V0IDw8ICJc
biIKQEAgLTkwLDE0ICs5MCwxMiBAQCBjbGFzcyBTZWN0aW9uCiAgICAgICAgICAgICAgICAgICBi
cmVhawogICAgICAgICAgICAgICBlbmQKIAotICAgICAgICAgICAgICBvdXQud3JpdGUoIm1hY3Jv
KGFsaWdub2YoI3tvcGNvZGVzW2ldLmNhcGl0YWxpemVkX25hbWV9OjpNZXRhZGF0YSkpXFxcbiIp
CisgICAgICAgICAgICAgIG91dC53cml0ZSgiICAgIG1hY3JvKGFsaWdub2YoI3tvcGNvZGVzW2ld
LmNhcGl0YWxpemVkX25hbWV9OjpNZXRhZGF0YSkpXFxcbiIpCiAgICAgICAgICAgICAgIGkgKz0g
MQogICAgICAgICAgIGVuZAotICAgICAgICAgIG91dCA8PCAiXG4iCiAgICAgICBlbmQKIAogICAg
ICAgaWYgY29uZmlnWzplbWl0X29wY29kZV9pZF9zdHJpbmdfdmFsdWVzX2luX2hfZmlsZV0KLSAg
ICAgICAgICBvdXQgPDwgIlxuIgogICAgICAgICAgIG9wY29kZXMuZWFjaCB7IHxvcGNvZGV8CiAg
ICAgICAgICAgICAgIG91dC53cml0ZSgiI2RlZmluZSAje29wY29kZS5uYW1lfV92YWx1ZV9zdHJp
bmcgXCIje29wY29kZS5pZH1cIlxuIikKICAgICAgICAgICB9Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>