192257 2018-11-30 14:41:19 -0800 REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS' 2018-11-30 16:26:10 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED InRadar, Regression P1 Normal --- 192160 1 dbates jbedard commit-queue ews-watchlist glenn lforschler slewis webkit-bug-importer oldest_to_newest 1483759 0 dbates 2018-11-30 14:41:19 -0800 Ran `run-api-tests --debug --ios-simulator`. It dies with the following error: AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS': [[ $ Tools/Scripts/run-api-tests --debug --ios-simulator --no-build Checking build ... AttributeError raised: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS' Traceback (most recent call last): File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 58, in main return run(port, options, args, stderr) File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 76, in run result = manager.run(args, json_output=options.json_output) File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/manager.py", line 163, in run self._initialize_devices() File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/manager.py", line 132, in _initialize_devices SimulatedDeviceManager.initialize_devices(DeviceRequest(DeviceType.from_string(self._port.DEFAULT_DEVICE_CLASS), allow_incomplete_match=True), self.host, simulator_ui=False) AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS' ]] 1483760 1 webkit-bug-importer 2018-11-30 14:41:53 -0800 <rdar://problem/46384671> 1483761 2 webkit-bug-importer 2018-11-30 14:41:53 -0800 <rdar://problem/46384673> 1483793 3 356251 jbedard 2018-11-30 15:37:16 -0800 Created attachment 356251 Patch 1483829 4 356251 commit-queue 2018-11-30 16:26:09 -0800 Comment on attachment 356251 Patch Clearing flags on attachment: 356251 Committed r238763: <https://trac.webkit.org/changeset/238763> 1483830 5 commit-queue 2018-11-30 16:26:10 -0800 All reviewed patches have been landed. Closing bug. 356251 2018-11-30 15:37:16 -0800 2018-11-30 16:26:09 -0800 Patch bug-192257-20181130153715.patch text/plain 2040 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODc1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE4LTExLTMwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjM4NzQ5KTogcnVuLWFwaS10ZXN0cyBkaWVzIHdp dGggQXR0cmlidXRlRXJyb3I6ICdJT1NTaW11bGF0b3JQb3J0JyBvYmplY3QgaGFzIG5vIGF0dHJp YnV0ZSAnREVGQVVMVF9ERVZJQ0VfQ0xBU1MnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIyNTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2Mzg0 NjcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZv bGxvdy11cCBmaXggZm9yIHIyMzg3NDkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2Fw aV90ZXN0cy9tYW5hZ2VyLnB5OgorICAgICAgICAoTWFuYWdlci5faW5pdGlhbGl6ZV9kZXZpY2Vz KTogVXNlIERFRkFVTFRfREVWSUNFX1RZUEUgaW5zdGVhZCBvZiBERUZBVUxUX0RFVklDRV9DTEFT Uy4KKwogMjAxOC0xMS0zMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg ICAgIFtQU09OXSBXZSBhcmUgc29tZXRpbWVzIHN3YXBwaW5nIHByb2Nlc3NlcyBldmVuIHRob3Vn aCB0aGVyZSBpcyBhbiBvcGVuZWQgd2luZG93IHdpdGggYW4gb3BlbmVyIGxpbmsgdG8gdXMKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYXBpX3Rlc3RzL21hbmFnZXIucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9hcGlfdGVzdHMvbWFuYWdlci5weQkocmV2aXNp b24gMjM4NzU3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9hcGlfdGVzdHMvbWFuYWdlci5w eQkod29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYsNiBAQCBpbXBvcnQgb3MKIAogZnJvbSB3ZWJr aXRweS5hcGlfdGVzdHMucnVubmVyIGltcG9ydCBSdW5uZXIKIGZyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCi1mcm9tIHdlYmtpdHB5Lnhjb2Rl LmRldmljZV90eXBlIGltcG9ydCBEZXZpY2VUeXBlCiBmcm9tIHdlYmtpdHB5Lnhjb2RlLnNpbXVs YXRlZF9kZXZpY2UgaW1wb3J0IERldmljZVJlcXVlc3QsIFNpbXVsYXRlZERldmljZU1hbmFnZXIK IAogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQpAQCAtMTI5LDcgKzEyOCw3IEBA IGNsYXNzIE1hbmFnZXIob2JqZWN0KToKIAogICAgIGRlZiBfaW5pdGlhbGl6ZV9kZXZpY2VzKHNl bGYpOgogICAgICAgICBpZiAnc2ltdWxhdG9yJyBpbiBzZWxmLl9wb3J0LnBvcnRfbmFtZToKLSAg ICAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuaW5pdGlhbGl6ZV9kZXZpY2VzKERldmlj ZVJlcXVlc3QoRGV2aWNlVHlwZS5mcm9tX3N0cmluZyhzZWxmLl9wb3J0LkRFRkFVTFRfREVWSUNF X0NMQVNTKSwgYWxsb3dfaW5jb21wbGV0ZV9tYXRjaD1UcnVlKSwgc2VsZi5ob3N0LCBzaW11bGF0 b3JfdWk9RmFsc2UpCisgICAgICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLmluaXRpYWxp emVfZGV2aWNlcyhEZXZpY2VSZXF1ZXN0KHNlbGYuX3BvcnQuREVGQVVMVF9ERVZJQ0VfVFlQRSwg YWxsb3dfaW5jb21wbGV0ZV9tYXRjaD1UcnVlKSwgc2VsZi5ob3N0LCBzaW11bGF0b3JfdWk9RmFs c2UpCiAgICAgICAgIGVsaWYgJ2RldmljZScgaW4gc2VsZi5fcG9ydC5wb3J0X25hbWU6CiAgICAg ICAgICAgICByYWlzZSBSdW50aW1lRXJyb3IoJ1J1bm5pbmcgYXBpIHRlc3RzIG9uIHt9IGlzIG5v dCBzdXBwb3J0ZWQnLmZvcm1hdChzZWxmLl9wb3J0LnBvcnRfbmFtZSkpCiAK