192227 2018-11-30 07:36:51 -0800 Add script to automatically close GitHub pull requests 2019-07-10 11:45:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro dbates dean_johnson dino don.olmstead jond lforschler mcatanzaro mjs rniwa oldest_to_newest 1483526 0 mcatanzaro 2018-11-30 07:36:51 -0800 This script will close all open pull requests at https://github.com/WebKit/webkit with a friendly message: """ Thank you for your interest in contributing to WebKit! This repository is a mirror and does not accept pull requests. Please submit your contribution to [WebKit Bugzilla](https://bugs.webkit.org/) for code review. Please also read [Contributing Code](https://webkit.org/contributing-code/) for an introduction to the contribution process. We apologize for the inconvenience and hope to see you on WebKit Bugzilla soon! """ If we run the script on a daily basis, then potential contributors can be redirected to Bugzilla in a timely manner, instead of getting frustrated that their pull requests were ignored until somebody notices them weeks later. We have two options to run it: (a) I could configure it to run nightly on my personal VPS, if Jon is OK with granting my GitHub account access to the WebKit repo. (b) Apple could run it on Apple infrastructure, if someone from Apple wants to manage this. If we do (b) then the script should be rewritten in python2 instead of python3. (The configparser syntax is different enough that it's easier to support only one python version.) 1483527 1 356176 mcatanzaro 2018-11-30 07:40:14 -0800 Created attachment 356176 Patch 1483542 2 don.olmstead 2018-11-30 09:07:01 -0800 The script itself is fine but there's a GitHub app that looks like it would fit the bill. https://probot.github.io/apps/close-issue/ 1483548 3 mcatanzaro 2018-11-30 09:10:48 -0800 (In reply to Don Olmstead from comment #2) > The script itself is fine but there's a GitHub app that looks like it would > fit the bill. > > https://probot.github.io/apps/close-issue/ Not clear if that can close pull requests? Doesn't look like it? 1483560 4 356176 don.olmstead 2018-11-30 09:30:48 -0800 Comment on attachment 356176 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356176&action=review > Tools/Scripts/close-pull-requests:77 > + issue = github.Issue.Issue(requester=req._requester, > + headers={}, > + attributes=issue_data, > + completed=True) I had thought all PRs are technically issues. So you could just try installing it on a dummy repo and see what happens. 1483561 5 don.olmstead 2018-11-30 09:32:16 -0800 So to be clear I think the script is perfectly fine as is the only reason I bring up the Close Issue Probot is the whole hosting issue. https://github.com/offu/close-issue-app is the source for it so if it doesn't fit the bill maybe we can extend it and do a PR on it. 1483986 6 mcatanzaro 2018-12-01 08:41:45 -0800 (In reply to Don Olmstead from comment #5) > So to be clear I think the script is perfectly fine as is the only reason I > bring up the Close Issue Probot is the whole hosting issue. > > https://github.com/offu/close-issue-app is the source for it so if it > doesn't fit the bill maybe we can extend it and do a PR on it. I'm fine with using that app if that's what we want to do. I'd hesitate to give an app access to my own GitHub account, though. 1484398 7 ap 2018-12-03 10:41:46 -0800 Not maintaining a service that runs scripts seems better than maintaining it. Can we have a separate GitHub account for the app? 1484405 8 don.olmstead 2018-12-03 10:45:51 -0800 (In reply to Alexey Proskuryakov from comment #7) > Not maintaining a service that runs scripts seems better than maintaining > it. Can we have a separate GitHub account for the app? Someone who has org access to WebKit on GitHub would need to enable it. When enabling it it will ask permissions for things. If the permissions it asks for are ok then it should just work. 1484431 9 mcatanzaro 2018-12-03 11:58:08 -0800 (In reply to Don Olmstead from comment #8) > Someone who has org access to WebKit on GitHub would need to enable it. Of the five people who have access, the only name I recognize is Jon (CCed). 1491110 10 mcatanzaro 2019-01-01 12:02:53 -0800 Anyway, I can have this dumb little script running immediately if we make the decision to go that route, if I'm granted access to the GitHub repo. If we want to use the app, someone else will have to take charge. Either way, it's blocked on Jon Davis since he's the only current contributor with access to the GitHub repo. 1533733 11 mcatanzaro 2019-05-06 19:03:00 -0700 Ping: Jon. 1535004 12 mcatanzaro 2019-05-10 08:56:17 -0700 (In reply to Michael Catanzaro from comment #0) > (a) I could configure it to run nightly on my personal VPS, if Jon is OK > with granting my GitHub account access to the WebKit repo. I actually no longer have a personal VPS, but Igalia could set this up easily enough. I'm sure Apple could, too. 1542375 13 mcatanzaro 2019-06-06 06:26:49 -0700 I tried emailing, Jon but I think he missed it. We really need a response from Jon here, as he's the only Apple developer who controls the GitHub repo. It would be embarrassing to have to ask old Google developers for help with WebKit's GitHub repo. ;) 1548326 14 rniwa 2019-06-26 19:04:22 -0700 What do we need to do in the Github repo / account?? 1548475 15 mcatanzaro 2019-06-27 07:31:36 -0700 To use my script, we would need a GitHub access token for an account with access to the GitHub repo. We could create a new GitHub account for this purpose, give it access to the WebKit repo, and then create an access token for it. Access tokens are created under GitHub settings -> Developer settings -> Access tokens. I've tested this already and the only permission required is the public_repo permission; everything else can be unchecked. Then we would need to set up a server to run the script on a regular basis (e.g. daily). You could do that at Apple or we could do it at Igalia, whichever you would prefer. We could alternatively forget about my script and try setting up https://github.com/offu/close-issue-app instead, as Don suggested. That may or may not be easier. Either way, we need help from someone with access to the GitHub repo (Jon or Ryosuke). 1548697 16 rniwa 2019-06-27 19:00:45 -0700 We should probably also lock the conversation if we can. I had to lock the conversation on https://github.com/WebKit/webkit/pull/20 even after closing PR because the person kept commenting on it. 1548811 17 356176 mcatanzaro 2019-06-28 08:10:27 -0700 Comment on attachment 356176 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356176&action=review > Tools/Scripts/close-pull-requests:79 > + issue.create_comment(MESSAGE) > + req.edit(state='closed') Not tested, but I think we would just need to do: issue.lock('resolved') Python API docs: https://pygithub.readthedocs.io/en/latest/github_objects/Issue.html?highlight=lock#github.Issue.Issue.lock GitHub docs: https://developer.github.com/v3/issues/#lock-an-issue In particular, note the 'resolved' string is important and the lock will fail if we don't have it there. 1551747 18 jond 2019-07-10 11:33:01 -0700 I've setup an instance of this script to run daily at around 9 AM on an internal instance at Apple. 1551756 19 mcatanzaro 2019-07-10 11:45:02 -0700 Awesome, thanks Jon! I'll close this, I suppose. We can still commit it to Tools/Scripts if we want, but doesn't seem necessary. 356176 2018-11-30 07:40:14 -0800 2019-07-10 11:45:07 -0700 Patch bug-192227-20181130094013.patch text/plain 4940 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjc0ODlmMjY5MDg0YjVmNWM4NGU0NTQzMWI3ODBiMGZl YzllNjNjOS4uMjQ2ZWE2ZmVhMjRlZTI3MTc5NzI3ZDVhNjFmYTQyNTIxMzYwM2ZiOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTExLTMwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBBZGQgc2NyaXB0IHRvIGF1dG9tYXRpY2FsbHkgY2xvc2UgR2l0SHViIHB1 bGwgcmVxdWVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MjIyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgc2NyaXB0IHdpbGwgY2xvc2UgYWxsIG9wZW4gcHVsbCByZXF1ZXN0cyBhdCBodHRw czovL2dpdGh1Yi5jb20vV2ViS2l0L3dlYmtpdCB3aXRoIGEKKyAgICAgICAgZnJpZW5kbHkgbWVz c2FnZS4gSWYgd2UgcnVuIHRoZSBzY3JpcHQgb24gYSBkYWlseSBiYXNpcywgdGhlbiBwb3RlbnRp YWwgY29udHJpYnV0b3JzIGNhbiBiZQorICAgICAgICByZWRpcmVjdGVkIHRvIEJ1Z3ppbGxhIGlu IGEgdGltZWx5IG1hbm5lciwgaW5zdGVhZCBvZiBnZXR0aW5nIGZydXN0cmF0ZWQgdGhhdCB0aGVp ciBwdWxsCisgICAgICAgIHJlcXVlc3RzIHdlcmUgaWdub3JlZCB1bnRpbCBzb21lYm9keSBub3Rp Y2VzIHRoZW0gd2Vla3MgbGF0ZXIuCisKKyAgICAgICAgKiBTY3JpcHRzL2Nsb3NlLXB1bGwtcmVx dWVzdHM6IEFkZGVkLgorCiAyMDE4LTExLTI4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NNYWNdIERyb3BwaW5nIHRleHQgc2VsZWN0aW9ucyBm cm9tIHdlYiBjb250ZW50IGludG8gZWRpdGFibGUgZWxlbWVudHMgY3Jhc2hlcyB0aGUgd2ViIHBy b2Nlc3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvY2xvc2UtcHVsbC1yZXF1ZXN0cyBiL1Rv b2xzL1NjcmlwdHMvY2xvc2UtcHVsbC1yZXF1ZXN0cwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41ZDRmNTZkYTc2OTQ2 MWIyM2ViM2Y4MTNiOWI4YWFmZTQ4MmJmZjlmCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2Ny aXB0cy9jbG9zZS1wdWxsLXJlcXVlc3RzCkBAIC0wLDAgKzEsNzkgQEAKKyMhL3Vzci9iaW4vZW52 IHB5dGhvbjMKKyMKKyMgQ29weXJpZ2h0IChDKSAyMDE4IElnYWxpYSBTLkwuCisjIENvcHlyaWdo dCAoQykgMjAxOCBNZXRyb2xvZ2ljYWwgR3JvdXAgQi5WLgorIworIyBSZWRpc3RyaWJ1dGlvbiBh bmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCisjIGFyZSBtZXQ6CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUg bXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAyLiAgUmVkaXN0 cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmln aHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1h dGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjCisjIFRISVMgU09GVFdB UkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElT JycgQU5EIEFOWQorIyBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBC VVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisjIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRB QklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyMgRElTQ0xB SU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJF IExJQUJMRSBGT1IgQU5ZCisjIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUws IEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisjIChJTkNMVURJTkcsIEJVVCBO T1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNF UzsKKyMgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQ VElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OCisjIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBX SEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJ TkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhF IFVTRSBPRiBUSElTCisjIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklM SVRZIE9GIFNVQ0ggREFNQUdFLgorCisjIFRoaXMgc2NyaXB0IGV4aXN0cyB0byBjbG9zZSBhbGwg b3BlbiBwdWxsIHJlcXVlc3RzIGF0CisjIGh0dHBzOi8vZ2l0aHViLmNvbS9XZWJLaXQvd2Via2l0 CisjCisjIEl0IGlzIGJhc2VkIG9uIGEgbXVjaCBtb3JlIHNvcGhpc3RpY2F0ZWQgc2NyaXB0Ogor IyBodHRwczovL2dpdGxhYi5nbm9tZS5vcmcvSW5mcmFzdHJ1Y3R1cmUvc3lzYWRtaW4tYmluL2Js b2IvbWFzdGVyL2Nsb3NlX3B1bGxfcmVxdWVzdHMucHkKKyMgV2UgaGF2ZSBwZXJtaXNzaW9uIGZy b20gdGhlIGF1dGhvciB0byB1c2UgaXQgd2l0aCBhIEJTRCBsaWNlbnNlOgorIyBodHRwczovL2dp dGxhYi5nbm9tZS5vcmcvSW5mcmFzdHJ1Y3R1cmUvc3lzYWRtaW4tYmluL2lzc3Vlcy8xMgorIwor IyBUbyB1c2UgdGhpcyBzY3JpcHQgeW91IG11c3QgY3JlYXRlIGEgZ2l0aHViLm9hdXRoIGluIHRo ZSBjd2QgeW91IHdpbGwKKyMgZXhlY3V0ZSB0aGUgc2NyaXB0IGZyb20uIEl0cyBjb250ZW50cyBz aG91bGQgbG9vayBsaWtlIHRoaXM6CisjCisjIFtnaXRodWJdCisjIG9hdXRoX3Rva2VuID0gYWFh YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhCisjCisjIHdpdGggdGhlICdhJ3Mg cmVwbGFjZWQgYnkgYSBHaXRIdWIgYWNjZXNzIHRva2VuLiBPZiBjb3Vyc2UgdGhlIGFjY2VzcyB0 b2tlbgorIyBzaG91bGQgcHJvdmlkZSBhY2Nlc3MgdG8gYW4gYWNjb3VudCB3aXRoIHdyaXRlIGFj Y2VzcyB0byBXZWJLaXQncyBHaXRIdWIgZm9yay4KKworaW1wb3J0IGNvbmZpZ3BhcnNlcgoraW1w b3J0IGdpdGh1YgoraW1wb3J0IG9zCitpbXBvcnQgc3lzCisKK01FU1NBR0UgPSAiIiJUaGFuayB5 b3UgZm9yIHlvdXIgaW50ZXJlc3QgaW4gY29udHJpYnV0aW5nIHRvIFdlYktpdCEKKworVGhpcyBy ZXBvc2l0b3J5IGlzIGEgbWlycm9yIGFuZCBkb2VzIG5vdCBhY2NlcHQgcHVsbCByZXF1ZXN0cy4g UGxlYXNlIHN1Ym1pdCB5b3VyIGNvbnRyaWJ1dGlvbiB0byBbV2ViS2l0IEJ1Z3ppbGxhXShodHRw czovL2J1Z3Mud2Via2l0Lm9yZy8pIGZvciBjb2RlIHJldmlldy4gUGxlYXNlIGFsc28gcmVhZCBb Q29udHJpYnV0aW5nIENvZGVdKGh0dHBzOi8vd2Via2l0Lm9yZy9jb250cmlidXRpbmctY29kZS8p IGZvciBhbiBpbnRyb2R1Y3Rpb24gdG8gdGhlIGNvbnRyaWJ1dGlvbiBwcm9jZXNzLiBXZSBhcG9s b2dpemUgZm9yIHRoZSBpbmNvbnZlbmllbmNlIGFuZCBob3BlIHRvIHNlZSB5b3Ugb24gV2ViS2l0 IEJ1Z3ppbGxhIHNvb24hCisiIiIKKworY29uZmlnX2ZpbGUgPSAnZ2l0aHViLm9hdXRoJworaWYg bm90IG9zLnBhdGguaXNmaWxlKGNvbmZpZ19maWxlKToKKyAgICBwcmludCgnTm8gY29uZmlndXJh dGlvbiBmaWxlIGNvdWxkIGJlIGZvdW5kIGF0ICVzJyAlIGNvbmZpZ19maWxlKQorICAgIHN5cy5l eGl0KDEpCisKK2NvbmZpZyA9IGNvbmZpZ3BhcnNlci5Db25maWdQYXJzZXIoKQorY29uZmlnLnJl YWRfZmlsZShvcGVuKGNvbmZpZ19maWxlKSkKKworaWYgY29uZmlnLmhhc19vcHRpb24oJ2dpdGh1 YicsICdvYXV0aF90b2tlbicpOgorICAgIGF1dGhfdG9rZW4gPSBjb25maWcuZ2V0KCdnaXRodWIn LCAnb2F1dGhfdG9rZW4nKQorZWxzZToKKyAgICBwcmludCgnTWFrZSBzdXJlICVzIGhhcyBhIGdp dGh1YiBzZWN0aW9uIGFuZCBhbiBvYXV0aF90b2tlbiBrZXkvdmFsdWUgcGFpcicgJSBjb25maWdf ZmlsZSkKKyAgICBzeXMuZXhpdCgxKQorCitnaHViID0gZ2l0aHViLkdpdGh1YihhdXRoX3Rva2Vu KQorcmVwbyA9IGdodWIuZ2V0X29yZ2FuaXphdGlvbignV2ViS2l0JykuZ2V0X3JlcG8oJ3dlYmtp dCcpCisKKyMgQ2xvc2UgZWFjaCBwdWxsIHJlcXVlc3QKK3B1bGxfcmVxdWVzdHMgPSByZXBvLmdl dF9wdWxscygnb3BlbicpCitmb3IgcmVxIGluIHB1bGxfcmVxdWVzdHM6CisgICAgaXNzdWVfZGF0 YSA9IHsndXJsJzogcmVwby51cmwgKyAnL2lzc3Vlcy8nICsgc3RyKHJlcS5udW1iZXIpfQorICAg IGlzc3VlID0gZ2l0aHViLklzc3VlLklzc3VlKHJlcXVlc3Rlcj1yZXEuX3JlcXVlc3RlciwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoZWFkZXJzPXt9LAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGF0dHJpYnV0ZXM9aXNzdWVfZGF0YSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjb21wbGV0ZWQ9VHJ1ZSkKKyAgICBpc3N1ZS5jcmVhdGVfY29tbWVudChN RVNTQUdFKQorICAgIHJlcS5lZGl0KHN0YXRlPSdjbG9zZWQnKQo=