192203 2018-11-29 17:01:29 -0800 [JSC] Keep TypeMaybeBigInt small 2018-12-03 03:37:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist fpizlo guijemont keith_miller mark.lam msaboff saam ticaiolima webkit-bug-importer oldest_to_newest 1483309 0 ysuzuki 2018-11-29 17:01:29 -0800 [JSC] Keep TypeMaybeBigInt small 1483310 1 356097 ysuzuki 2018-11-29 17:06:22 -0800 Created attachment 356097 Patch 1483495 2 ticaiolima 2018-11-30 04:56:30 -0800 Informal review here. LGTM. 1483924 3 ysuzuki 2018-11-30 21:04:16 -0800 Ping? 1483945 4 356097 saam 2018-12-01 00:21:10 -0800 Comment on attachment 356097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356097&action=review > Source/JavaScriptCore/parser/ResultType.h:35 > + static constexpr Type TypeInt32 = 0x1 << 0; style nit: i’m not sure if this is a UI issue in bugzilla, but this line is the only line without the “=“ lined up. We should align it 1483948 5 356097 ysuzuki 2018-12-01 00:36:58 -0800 Comment on attachment 356097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356097&action=review Thank you! >> Source/JavaScriptCore/parser/ResultType.h:35 >> + static constexpr Type TypeInt32 = 0x1 << 0; > > style nit: i’m not sure if this is a UI issue in bugzilla, but this line is the only line without the “=“ lined up. We should align it It seems that this is UI issue. This `=` is aligned to the other ones actually :) 1483949 6 ysuzuki 2018-12-01 00:38:57 -0800 Committed r238778: <https://trac.webkit.org/changeset/238778> 1483950 7 webkit-bug-importer 2018-12-01 00:39:29 -0800 <rdar://problem/46394250> 1484325 8 guijemont 2018-12-03 03:37:26 -0800 *** Bug 192152 has been marked as a duplicate of this bug. *** 356097 2018-11-29 17:06:22 -0800 2018-12-01 00:21:10 -0800 Patch bug-192203-20181130100621.patch text/plain 2705 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NzZkMjFiNzAxNmIxNjk5YWI4ZDNmMTg3Y2VmNmMwNjgxNjBhMmUwLi4yODk0NDU3NTI3ZDVlOThl YjZlOGYyNGJlNzM2MWQ4MjIxYTAxYWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0xMS0yOSAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIFtKU0NdIEtlZXAgVHlwZU1heWJlQmlnSW50IHNtYWxsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIyMDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBCaWdJbnQg aXMgYmVpbmcgaW1wbGVtZW50ZWQsIG1vcmUgYW5kIG1vcmUgYnl0ZWNvZGVzIHN0YXJ0IHJldHVy bmluZyBCaWdJbnQuCisgICAgICAgIEl0IG1lYW5zIHRoYXQgUmVzdWx0VHlwZSBvZiB0aGVzZSBi eXRlY29kZXMgaW5jbHVkZSBUeXBlTWF5YmVCaWdJbnQuIEhvd2V2ZXIsCisgICAgICAgIFR5cGVN YXliZUJpZ0ludCB3YXMgbGFyZ2UgbnVtYmVyIDB4MjAsIGxlYWRpbmcgdG8gd2lkZSBpbnN0cnVj dGlvbiBzaW5jZSBSZXN1bHRUeXBlCisgICAgICAgIGVhc2lseSBiZWNvbWVzIGxhcmdlciB0aGFu IDMyIChlLmcuIFR5cGVJbnQzMiB8IFR5cGVNYXliZUJpZ0ludCA9PSAzMykuCisKKyAgICAgICAg VGhpcyBwYXRjaCBzb3J0cyB0aGUgbnVtYmVycyBvZiBUeXBlTWF5YmVYWFggYmFzZWQgb24gdGhl IGZyZXF1ZW5jeSBvZiBhcHBlYXJhbmNlIGluCisgICAgICAgIHRoZSBjb2RlLgorCisgICAgICAg ICogcGFyc2VyL1Jlc3VsdFR5cGUuaDoKKwogMjAxOC0xMS0yOSAgSnVzdGluIE1pY2hhdWQgIDxq dXN0aW5fbWljaGF1ZEBhcHBsZS5jb20+CiAKICAgICAgICAgQ1NTIFBhaW50aW5nIEFQSSBzaG91 bGQgcGFzcyAndGhpcycgY29ycmVjdGx5IHRvIHBhaW50IGNhbGxiYWNrLCBhbmQgcmVwYWludCB3 aGVuIHByb3BlcnRpZXMgY2hhbmdlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9SZXN1bHRUeXBlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1Jlc3Vs dFR5cGUuaAppbmRleCBmNzU0ZDRjNThlZGMyMzlhZmNkY2IzNGIzNjYwYTg3MmE0ZDZlMGI0Li5j NTNkMTdjNGFjOGRmZjRiMjQzZWM5ZDA2MzM5NWU1MGI4OTdkMTIzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1Jlc3VsdFR5cGUuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcGFyc2VyL1Jlc3VsdFR5cGUuaApAQCAtMzIsMTUgKzMyLDE1IEBAIG5hbWVzcGFj ZSBKU0MgewogICAgICAgICBmcmllbmQgc3RydWN0IE9wZXJhbmRUeXBlczsKIAogICAgICAgICB1 c2luZyBUeXBlID0gdWludDhfdDsKLSAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBUeXBlIFR5cGVJ bnQzMiA9IDE7Ci0gICAgICAgIHN0YXRpYyBjb25zdGV4cHIgVHlwZSBUeXBlTWF5YmVOdW1iZXIg PSAweDAyOwotICAgICAgICBzdGF0aWMgY29uc3RleHByIFR5cGUgVHlwZU1heWJlU3RyaW5nID0g MHgwNDsKLSAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBUeXBlIFR5cGVNYXliZU51bGwgICA9IDB4 MDg7Ci0gICAgICAgIHN0YXRpYyBjb25zdGV4cHIgVHlwZSBUeXBlTWF5YmVCb29sICAgPSAweDEw OwotICAgICAgICBzdGF0aWMgY29uc3RleHByIFR5cGUgVHlwZU1heWJlQmlnSW50ID0gMHgyMDsK LSAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBUeXBlIFR5cGVNYXliZU90aGVyICA9IDB4NDA7Ci0K LSAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBUeXBlIFR5cGVCaXRzID0gVHlwZU1heWJlTnVtYmVy IHwgVHlwZU1heWJlU3RyaW5nIHwgVHlwZU1heWJlTnVsbCB8IFR5cGVNYXliZUJvb2wgfCBUeXBl TWF5YmVCaWdJbnQgfCBUeXBlTWF5YmVPdGhlcjsKKyAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBU eXBlIFR5cGVJbnQzMiAgICAgICA9IDB4MSA8PCAwOworICAgICAgICBzdGF0aWMgY29uc3RleHBy IFR5cGUgVHlwZU1heWJlTnVtYmVyID0gMHgxIDw8IDE7CisgICAgICAgIHN0YXRpYyBjb25zdGV4 cHIgVHlwZSBUeXBlTWF5YmVTdHJpbmcgPSAweDEgPDwgMjsKKyAgICAgICAgc3RhdGljIGNvbnN0 ZXhwciBUeXBlIFR5cGVNYXliZUJpZ0ludCA9IDB4MSA8PCAzOworICAgICAgICBzdGF0aWMgY29u c3RleHByIFR5cGUgVHlwZU1heWJlTnVsbCAgID0gMHgxIDw8IDQ7CisgICAgICAgIHN0YXRpYyBj b25zdGV4cHIgVHlwZSBUeXBlTWF5YmVCb29sICAgPSAweDEgPDwgNTsKKyAgICAgICAgc3RhdGlj IGNvbnN0ZXhwciBUeXBlIFR5cGVNYXliZU90aGVyICA9IDB4MSA8PCA2OworCisgICAgICAgIHN0 YXRpYyBjb25zdGV4cHIgVHlwZSBUeXBlQml0cyA9IFR5cGVNYXliZU51bWJlciB8IFR5cGVNYXli ZVN0cmluZyB8IFR5cGVNYXliZUJpZ0ludCB8IFR5cGVNYXliZU51bGwgfCBUeXBlTWF5YmVCb29s IHwgVHlwZU1heWJlT3RoZXI7CiAKICAgICBwdWJsaWM6CiAgICAgICAgIHN0YXRpYyBjb25zdGV4 cHIgaW50IG51bUJpdHNOZWVkZWQgPSA3Owo=