192093 2018-11-28 11:51:26 -0800 Web Inspector: REGRESSION(r238599): Multiple Selection: selecting a breakpoint will change the selection to it's parent on the first click 2018-11-30 14:41:03 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 191483 1 hi mattbaker commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1482565 0 hi 2018-11-28 11:51:26 -0800 * STEPS TO REPRODUCE: 1. open WebInspector 2. set a few breakpoints in the same JS file 3. click one of the breakpoints in the Debugger sidebar => selection changes from the breakpoint to the script (which is it's parent) 1482588 1 webkit-bug-importer 2018-11-28 12:42:06 -0800 <rdar://problem/46318466> 1483692 2 356226 mattbaker 2018-11-30 12:56:16 -0800 Created attachment 356226 Patch 1483713 3 356226 hi 2018-11-30 13:47:42 -0800 Comment on attachment 356226 Patch r=me, nice fix :) 1483757 4 356226 commit-queue 2018-11-30 14:41:02 -0800 Comment on attachment 356226 Patch Clearing flags on attachment: 356226 Committed r238757: <https://trac.webkit.org/changeset/238757> 1483758 5 commit-queue 2018-11-30 14:41:03 -0800 All reviewed patches have been landed. Closing bug. 356226 2018-11-30 12:56:16 -0800 2018-11-30 14:41:02 -0800 Patch bug-192093-20181130125616.patch text/plain 4583 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBh OGUxZGU5YTBjZmQwYzVlMzRlYTRhMWRmMWRjYjE3ZmU4MDY3MTM1Li4xN2I0ZjFkN2ZlODc5MDY3 NWZiOGZhMzQ1MGIwMTZhZjBjNjQwOGFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxOC0xMS0zMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjM4NTk5KTogTXVsdGlwbGUg U2VsZWN0aW9uOiBzZWxlY3RpbmcgYSBicmVha3BvaW50IHdpbGwgY2hhbmdlIHRoZSBzZWxlY3Rp b24gdG8gaXQncyBwYXJlbnQgb24gdGhlIGZpcnN0IGNsaWNrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIwOTMKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQ2MzE4NDY2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdJ LlRyZWVFbGVtZW50LnByb3RvdHlwZS5zZWxlY3QpOgorICAgICAgICBUcmVlRWxlbWVudCBzaG91 bGRuJ3QgbWFuYWdlIHRoZSBUcmVlT3V0bGluZSdzIHNlbGVjdGlvbiBiYXJyaWVyLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdJLlRy ZWVPdXRsaW5lKToKKyAgICAgICAgKFdJLlRyZWVPdXRsaW5lLnByb3RvdHlwZS5nZXQgcHJvY2Vz c2luZ1NlbGVjdGlvbkNoYW5nZSk6CisgICAgICAgIChXSS5UcmVlT3V0bGluZS5wcm90b3R5cGUu c2VsZWN0aW9uQ29udHJvbGxlclNlbGVjdGlvbkRpZENoYW5nZSk6CisgICAgICAgIChXSS5UcmVl T3V0bGluZS5wcm90b3R5cGUuc2VsZWN0VHJlZUVsZW1lbnRJbnRlcm5hbCk6CisgICAgICAgIFRo ZSBzZWxlY3Rpb24gcmUtZW50cnkgYmFycmllciBgcHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZWAg c2hvdWxkIGJlCisgICAgICAgIG1hbmFnZWQgaW50ZXJuYWxseSBieSBUcmVlT3V0bGluZSwgYW5k IGV4cG9zZWQgYXMgYSByZWFkLW9ubHkgcHJvcGVydHkuCisgICAgICAgIEZpeCBhIGJ1ZyB3aGVy ZSB0aGUgYmFycmllciB3YXMgY2xlYXJlZCBiZWZvcmUgZGlzcGF0Y2hpbmcgdGhlIGNoYW5nZQor ICAgICAgICBub3RpZmljYXRpb24sIHdoaWNoIGNhbiBjYXVzZSByZS1lbnRyeSBhcyBhIHNpZGUg ZWZmZWN0LgorCiAyMDE4LTExLTI5ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSVEw6IGRpc2Nsb3N1cmUgdHJpYW5nbGVzIHNob3Vs ZCBiZSBmbGlwcGVkIGFuZCBhbGlnbmVkIHJpZ2h0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVFbGVtZW50LmpzCmluZGV4IDU0NWZj NzFkYjAyN2IyMTQ4NGQ5NWIyOWJhODI4YTY5ZmY3YjgxMmIuLjU0ZDhiYzAwZjVmMzdlOTY4MWJl OGI1ODI1OGQwM2MxNWExODI4NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVFbGVtZW50LmpzCkBAIC01MTQsMTYgKzUxNCwx MiBAQCBXSS5UcmVlRWxlbWVudCA9IGNsYXNzIFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuT2JqZWN0 CiAgICAgICAgIGlmICghdHJlZU91dGxpbmUpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAg ICAgdHJlZU91dGxpbmUucHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZSA9IHRydWU7Ci0KICAgICAg ICAgdGhpcy5zZWxlY3RlZCA9IHRydWU7CiAgICAgICAgIHRyZWVPdXRsaW5lLnNlbGVjdFRyZWVF bGVtZW50SW50ZXJuYWwodGhpcywgc3VwcHJlc3NPblNlbGVjdCwgc2VsZWN0ZWRCeVVzZXIpOwog CiAgICAgICAgIGlmICghc3VwcHJlc3NPblNlbGVjdCAmJiB0aGlzLm9uc2VsZWN0KQogICAgICAg ICAgICAgdGhpcy5vbnNlbGVjdCh0aGlzLCBzZWxlY3RlZEJ5VXNlcik7CiAKLSAgICAgICAgdHJl ZU91dGxpbmUucHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZSA9IGZhbHNlOwotCiAgICAgICAgIGxl dCB0cmVlT3V0bGluZUdyb3VwID0gV0kuVHJlZU91dGxpbmVHcm91cC5ncm91cEZvclRyZWVPdXRs aW5lKHRyZWVPdXRsaW5lKTsKICAgICAgICAgaWYgKCF0cmVlT3V0bGluZUdyb3VwKQogICAgICAg ICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcwppbmRleCA0YmQ5MGRmOWI4MWQ4MzkxMDIyY2Fi NGE1YjZiMmEzNDU5NGQxNjMzLi42MWEzYzQxODdkY2EzMjIzMjZmYWQ3NTk4ODAzNTRiOGVjNjJh NTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UcmVlT3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UcmVlT3V0bGluZS5qcwpAQCAtNTksNyArNTksNyBAQCBXSS5UcmVlT3V0bGluZSA9 IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIHRoaXMuX3RyZWVF bGVtZW50SW5kZXhDYWNoZSA9IG5ldyBNYXA7CiAKICAgICAgICAgdGhpcy5faXRlbVdhc1NlbGVj dGVkQnlVc2VyID0gZmFsc2U7Ci0gICAgICAgIHRoaXMuX3Byb2Nlc3NpbmdTZWxlY3Rpb25Db250 cm9sbGVyU2VsZWN0aW9uRGlkQ2hhbmdlID0gZmFsc2U7CisgICAgICAgIHRoaXMuX3Byb2Nlc3Np bmdTZWxlY3Rpb25DaGFuZ2UgPSBmYWxzZTsKICAgICAgICAgdGhpcy5fc3VwcHJlc3NOZXh0U2Vs ZWN0aW9uRGlkQ2hhbmdlRXZlbnQgPSBmYWxzZTsKIAogICAgICAgICB0aGlzLl92aXJ0dWFsaXpl ZFZpc2libGVUcmVlRWxlbWVudHMgPSBudWxsOwpAQCAtMTMyLDYgKzEzMiw4IEBAIFdJLlRyZWVP dXRsaW5lID0gY2xhc3MgVHJlZU91dGxpbmUgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgcmV0 dXJuIFtdOwogICAgIH0KIAorICAgIGdldCBwcm9jZXNzaW5nU2VsZWN0aW9uQ2hhbmdlKCkgeyBy ZXR1cm4gdGhpcy5fcHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZTsgfQorCiAgICAgZ2V0IGhpZGRl bigpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5faGlkZGVuOwpAQCAtNzg4LDcgKzc5MCw3 IEBAIFdJLlRyZWVPdXRsaW5lID0gY2xhc3MgVHJlZU91dGxpbmUgZXh0ZW5kcyBXSS5PYmplY3QK IAogICAgIHNlbGVjdGlvbkNvbnRyb2xsZXJTZWxlY3Rpb25EaWRDaGFuZ2UoY29udHJvbGxlciwg ZGVzZWxlY3RlZEl0ZW1zLCBzZWxlY3RlZEl0ZW1zKQogICAgIHsKLSAgICAgICAgdGhpcy5fcHJv Y2Vzc2luZ1NlbGVjdGlvbkNvbnRyb2xsZXJTZWxlY3Rpb25EaWRDaGFuZ2UgPSB0cnVlOworICAg ICAgICB0aGlzLl9wcm9jZXNzaW5nU2VsZWN0aW9uQ2hhbmdlID0gdHJ1ZTsKIAogICAgICAgICBm b3IgKGxldCBpbmRleCBvZiBkZXNlbGVjdGVkSXRlbXMpIHsKICAgICAgICAgICAgIGxldCB0cmVl RWxlbWVudCA9IHRoaXMuX3RyZWVFbGVtZW50QXRJbmRleChpbmRleCk7CkBAIC04MTAsOSArODEy LDkgQEAgV0kuVHJlZU91dGxpbmUgPSBjbGFzcyBUcmVlT3V0bGluZSBleHRlbmRzIFdJLk9iamVj dAogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5fcHJvY2Vzc2luZ1Nl bGVjdGlvbkNvbnRyb2xsZXJTZWxlY3Rpb25EaWRDaGFuZ2UgPSBmYWxzZTsKLQogICAgICAgICB0 aGlzLl9kaXNwYXRjaFNlbGVjdGlvbkRpZENoYW5nZUV2ZW50KCk7CisKKyAgICAgICAgdGhpcy5f cHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZSA9IGZhbHNlOwogICAgIH0KIAogICAgIHNlbGVjdGlv bkNvbnRyb2xsZXJOZXh0U2VsZWN0YWJsZUluZGV4KGNvbnRyb2xsZXIsIGluZGV4KQpAQCAtODU1 LDcgKzg1Nyw3IEBAIFdJLlRyZWVPdXRsaW5lID0gY2xhc3MgVHJlZU91dGxpbmUgZXh0ZW5kcyBX SS5PYmplY3QKIAogICAgIHNlbGVjdFRyZWVFbGVtZW50SW50ZXJuYWwodHJlZUVsZW1lbnQsIHN1 cHByZXNzTm90aWZpY2F0aW9uID0gZmFsc2UsIHNlbGVjdGVkQnlVc2VyID0gZmFsc2UpCiAgICAg ewotICAgICAgICBpZiAodGhpcy5fcHJvY2Vzc2luZ1NlbGVjdGlvbkNvbnRyb2xsZXJTZWxlY3Rp b25EaWRDaGFuZ2UpCisgICAgICAgIGlmICh0aGlzLl9wcm9jZXNzaW5nU2VsZWN0aW9uQ2hhbmdl KQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMuX2l0ZW1XYXNTZWxlY3RlZEJ5 VXNlciA9IHNlbGVjdGVkQnlVc2VyOwo=