192086 2018-11-28 10:18:52 -0800 [GTK][WPE] Fix BubblewrapLauncher clang warnings 2018-11-29 02:20:05 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela tpopela bugs-noreply commit-queue mcatanzaro oldest_to_newest 1482504 0 tpopela 2018-11-28 10:18:52 -0800 ../../Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:474:37: warning: variable 'i' is uninitialized when used here [-Wuninitialized] for (size_t i; splitPaths.get()[i]; ++i) ^ ../../Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:474:18: note: initialize the variable 'i' to silence this warning for (size_t i; splitPaths.get()[i]; ++i) ^ = 0 ../../Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:574:34: warning: missing field 'datum_b' initializer [-Wmissing-field-initializers] struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, (int)TIOCSTI); ^ /usr/include/seccomp.h:211:23: note: expanded from macro 'SCMP_A1' #define SCMP_A1(...) SCMP_CMP(1, __VA_ARGS__) ^ /usr/include/seccomp.h:201:58: note: expanded from macro 'SCMP_CMP' #define SCMP_CMP(...) ((struct scmp_arg_cmp){__VA_ARGS__}) ^ 1482506 1 355886 tpopela 2018-11-28 10:20:56 -0800 Created attachment 355886 Patch 1482518 2 355886 mcatanzaro 2018-11-28 10:42:45 -0800 Comment on attachment 355886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355886&action=review > Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:474 > - for (size_t i; splitPaths.get()[i]; ++i) > + for (size_t i = 0; splitPaths.get()[i]; ++i) Ow! > Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:574 > - struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, (int)TIOCSTI); > + struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, (scmp_datum_t)TIOCSTI, 0); I spent too long investigating why you have the trailing 0. Would be more clear if we add an unnecessary cast: struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, (scmp_datum_t)TIOCSTI, (scmp_datum_t)0); But now I notice that we are impermissibly using C-style casts here. How about: struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, static_cast<scmp_datum_t>(TIOCSTI), static_cast<scmp_datum_t>(0)); Er, maybe too verbose. It's probably fine with just the first cast. But it should be a static_cast. 1482582 3 355886 tpopela 2018-11-28 12:28:42 -0800 Comment on attachment 355886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355886&action=review >> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:574 >> + struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, (scmp_datum_t)TIOCSTI, 0); > > I spent too long investigating why you have the trailing 0. Would be more clear if we add an unnecessary cast: > > struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, (scmp_datum_t)TIOCSTI, (scmp_datum_t)0); > > But now I notice that we are impermissibly using C-style casts here. How about: > > struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, static_cast<scmp_datum_t>(TIOCSTI), static_cast<scmp_datum_t>(0)); > > Er, maybe too verbose. It's probably fine with just the first cast. But it should be a static_cast. True, that sounds a lot better (I don't know, why I didn't do that)! :) 1482864 4 355985 tpopela 2018-11-29 01:02:45 -0800 Created attachment 355985 Patch for landing 1482874 5 commit-queue 2018-11-29 01:53:06 -0800 The commit-queue encountered the following flaky tests while processing attachment 355985: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. 1482881 6 commit-queue 2018-11-29 01:53:25 -0800 The commit-queue encountered the following flaky tests while processing attachment 355985: imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-inset-001.html bug 192139 (author: rego@igalia.com) imported/w3c/web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form.html bug 192140 (author: mjs@apple.com) webgl/1.0.2/conformance/more/conformance/quickCheckAPI-A.html bug 192141 (author: roger_fong@apple.com) The commit-queue is continuing to process your patch. 1482885 7 commit-queue 2018-11-29 02:19:25 -0800 The commit-queue encountered the following flaky tests while processing attachment 355985: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. 1482886 8 355985 commit-queue 2018-11-29 02:20:03 -0800 Comment on attachment 355985 Patch for landing Clearing flags on attachment: 355985 Committed r238663: <https://trac.webkit.org/changeset/238663> 1482887 9 commit-queue 2018-11-29 02:20:05 -0800 All reviewed patches have been landed. Closing bug. 355886 2018-11-28 10:20:56 -0800 2018-11-29 01:02:41 -0800 Patch bug-192086-20181128192054.patch text/plain 2006 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY0MGRkMTcxYTAxNTNlNjQx YjNjN2ZkMjY3NTU1ZDhlM2MwYzMzNjAuLmU2YjExMTczM2M5YTU2ZWYwMWEzMjhmY2JhNzAxNWJj YjAyMGVkNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTEtMjggIFRvbWFzIFBv cGVsYSAgPHRwb3BlbGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEZpeCBCdWJi bGV3cmFwTGF1bmNoZXIgY2xhbmcgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjA4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3Jh cExhdW5jaGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6YmluZFBhdGhWYXIpOiBJbml0aWFsaXpl IHRoZSBpIHZhcmlhYmxlIHRvIDAuCisgICAgICAgIChXZWJLaXQ6OnNldHVwU2VjY29tcCk6IElu aXRpYWxpemUgdGhlIG9wdGlvbmFsIGRhdHVtX2IgbWVtYmVyLgorCiAyMDE4LTExLTI4ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogUkVHUkVTU0lPTihyMjM4Mzc4KTogcmVsb2FkaW5nIFdlYkluc3BlY3RvciBhZnRlciBhIHNl dHRpbmdzIGNoYW5nZSBkb2Vzbid0IHJlLXNob3cgV2ViSW5zcGVjdG9yCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5j cHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVu Y2hlci5jcHAKaW5kZXggMWIwNGYzNmNlY2M0NDI2NzJjNzJhZDI5YTY2ZGViNWM2NTRlODFjZC4u YmJkOWE4OTRkM2MyNzZiYjg4OWI2ZjZiOWQ2YzhlZDg2NjBiNmY3MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExh dW5jaGVyLmNwcApAQCAtNDcxLDcgKzQ3MSw3IEBAIHN0YXRpYyBib29sIGJpbmRQYXRoVmFyKFZl Y3RvcjxDU3RyaW5nPiYgYXJncywgY29uc3QgY2hhciogdmFybmFtZSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgR1VuaXF1ZVB0cjxjaGFyKj4gc3BsaXRQYXRocyhnX3N0cnNwbGl0KHBh dGhWYWx1ZSwgIjoiLCAtMSkpOwotICAgIGZvciAoc2l6ZV90IGk7IHNwbGl0UGF0aHMuZ2V0KClb aV07ICsraSkKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgc3BsaXRQYXRocy5nZXQoKVtpXTsgKytp KQogICAgICAgICBiaW5kSWZFeGlzdHMoYXJncywgc3BsaXRQYXRocy5nZXQoKVtpXSk7CiAKICAg ICByZXR1cm4gdHJ1ZTsKQEAgLTU3MSw3ICs1NzEsNyBAQCBzdGF0aWMgaW50IHNldHVwU2VjY29t cCgpCiAgICAgLy8gIGh0dHBzOi8vZ2l0Lmdub21lLm9yZy9icm93c2UvbGludXgtdXNlci1jaHJv b3QKICAgICAvLyAgICBpbiBzcmMvc2V0dXAtc2VjY29tcC5jCiAgICAgc3RydWN0IHNjbXBfYXJn X2NtcCBjbG9uZUFyZyA9IFNDTVBfQTAoU0NNUF9DTVBfTUFTS0VEX0VRLCBDTE9ORV9ORVdVU0VS LCBDTE9ORV9ORVdVU0VSKTsKLSAgICBzdHJ1Y3Qgc2NtcF9hcmdfY21wIHR0eUFyZyA9IFNDTVBf QTEoU0NNUF9DTVBfRVEsIChpbnQpVElPQ1NUSSk7CisgICAgc3RydWN0IHNjbXBfYXJnX2NtcCB0 dHlBcmcgPSBTQ01QX0ExKFNDTVBfQ01QX0VRLCAoc2NtcF9kYXR1bV90KVRJT0NTVEksIDApOwog ICAgIHN0cnVjdCB7CiAgICAgICAgIGludCBzY2FsbDsKICAgICAgICAgc3RydWN0IHNjbXBfYXJn X2NtcCogYXJnOwo= 355985 2018-11-29 01:02:45 -0800 2018-11-29 02:20:03 -0800 Patch for landing bug-192086-20181129100243.patch text/plain 2023 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY0OTUwYmYwYTUzOWUzZjlh MzUxNzQzY2NkZjFmZDY4NWJkNzYwY2YuLjhiNmNjNzA5ZjM3NTg5NzgzYWM2NDgxNGI2ZTJiNmUw MjBkNmIwYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTEtMjkgIFRvbWFzIFBv cGVsYSAgPHRwb3BlbGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEZpeCBCdWJi bGV3cmFwTGF1bmNoZXIgY2xhbmcgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjA4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE1pY2hh ZWwgQ2F0YW56YXJvLgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxl d3JhcExhdW5jaGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6YmluZFBhdGhWYXIpOiBJbml0aWFs aXplIHRoZSBpIHZhcmlhYmxlIHRvIDAuCisgICAgICAgIChXZWJLaXQ6OnNldHVwU2VjY29tcCk6 IEluaXRpYWxpemUgdGhlIG9wdGlvbmFsIGRhdHVtX2IgbWVtYmVyLgorCiAyMDE4LTExLTI4ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogUkVHUkVTU0lPTig/KTogYWxsICJTaG93ICoiIGRldmVsb3AgbWVudSBpdGVtcyBjYXVz ZSB0aGUgcGFnZSB0byBjcmFzaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv TGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCmluZGV4IDFiMDRmMzZj ZWNjNDQyNjcyYzcyYWQyOWE2NmRlYjVjNjU0ZTgxY2QuLjQ1NDJhYTQ2YzBkMjYzNTNmOTc0Njcy MWVlNTkzN2UyYzg2MTFkN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xh dW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKQEAgLTQ3MSw3ICs0 NzEsNyBAQCBzdGF0aWMgYm9vbCBiaW5kUGF0aFZhcihWZWN0b3I8Q1N0cmluZz4mIGFyZ3MsIGNv bnN0IGNoYXIqIHZhcm5hbWUpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIEdVbmlxdWVQ dHI8Y2hhcio+IHNwbGl0UGF0aHMoZ19zdHJzcGxpdChwYXRoVmFsdWUsICI6IiwgLTEpKTsKLSAg ICBmb3IgKHNpemVfdCBpOyBzcGxpdFBhdGhzLmdldCgpW2ldOyArK2kpCisgICAgZm9yIChzaXpl X3QgaSA9IDA7IHNwbGl0UGF0aHMuZ2V0KClbaV07ICsraSkKICAgICAgICAgYmluZElmRXhpc3Rz KGFyZ3MsIHNwbGl0UGF0aHMuZ2V0KClbaV0pOwogCiAgICAgcmV0dXJuIHRydWU7CkBAIC01NzEs NyArNTcxLDcgQEAgc3RhdGljIGludCBzZXR1cFNlY2NvbXAoKQogICAgIC8vICBodHRwczovL2dp dC5nbm9tZS5vcmcvYnJvd3NlL2xpbnV4LXVzZXItY2hyb290CiAgICAgLy8gICAgaW4gc3JjL3Nl dHVwLXNlY2NvbXAuYwogICAgIHN0cnVjdCBzY21wX2FyZ19jbXAgY2xvbmVBcmcgPSBTQ01QX0Ew KFNDTVBfQ01QX01BU0tFRF9FUSwgQ0xPTkVfTkVXVVNFUiwgQ0xPTkVfTkVXVVNFUik7Ci0gICAg c3RydWN0IHNjbXBfYXJnX2NtcCB0dHlBcmcgPSBTQ01QX0ExKFNDTVBfQ01QX0VRLCAoaW50KVRJ T0NTVEkpOworICAgIHN0cnVjdCBzY21wX2FyZ19jbXAgdHR5QXJnID0gU0NNUF9BMShTQ01QX0NN UF9FUSwgc3RhdGljX2Nhc3Q8c2NtcF9kYXR1bV90PihUSU9DU1RJKSwgc3RhdGljX2Nhc3Q8c2Nt cF9kYXR1bV90PigwKSk7CiAgICAgc3RydWN0IHsKICAgICAgICAgaW50IHNjYWxsOwogICAgICAg ICBzdHJ1Y3Qgc2NtcF9hcmdfY21wKiBhcmc7Cg==