192060 2018-11-27 18:01:27 -0800 Fix the mis-spelled "m_clienstWaitingForAsyncDecoding" 2018-11-27 19:06:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez commit-queue dbates ews-watchlist japhet sabouhallawa simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1482294 0 simon.fraser 2018-11-27 18:01:27 -0800 Fix the mis-spelled "m_clienstWaitingForAsyncDecoding" 1482295 1 355832 simon.fraser 2018-11-27 18:01:57 -0800 Created attachment 355832 Patch 1482312 2 commit-queue 2018-11-27 18:38:39 -0800 The commit-queue encountered the following flaky tests while processing attachment 355832: webgl/2.0.0/conformance/more/functions/drawArrays.html bug 192063 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch. 1482317 3 commit-queue 2018-11-27 18:38:53 -0800 The commit-queue encountered the following flaky tests while processing attachment 355832: inspector/dom/breakpoint-for-event-listener.html bug 192064 (author: drousso@apple.com) webgl/1.0.2/conformance/more/functions/bindBufferBadArgs.html bug 192065 (author: roger_fong@apple.com) The commit-queue is continuing to process your patch. 1482323 4 355832 commit-queue 2018-11-27 19:05:24 -0800 Comment on attachment 355832 Patch Clearing flags on attachment: 355832 Committed r238600: <https://trac.webkit.org/changeset/238600> 1482324 5 commit-queue 2018-11-27 19:05:26 -0800 All reviewed patches have been landed. Closing bug. 1482325 6 webkit-bug-importer 2018-11-27 19:06:29 -0800 <rdar://problem/46297897> 355832 2018-11-27 18:01:57 -0800 2018-11-27 19:05:24 -0800 Patch bug-192060-20181127180156.patch text/plain 7226 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWQyYzBiNTg3NDk4Nzg0 OWRiNTgwMTRiZjk3NGM1NGY3NDRkOGRhNy4uZGU3ODE1ODlhMGE1ZGUwODRjYTdiZjBiOTdkMzZk M2YzMTk3OWIwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTExLTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCB0aGUgbWlz LXNwZWxsZWQgIm1fY2xpZW5zdFdhaXRpbmdGb3JBc3luY0RlY29kaW5nIgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMDYwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSBtaXMtc3BlbGxpbmcg b2YgIm1fY2xpZW5zdFdhaXRpbmdGb3JBc3luY0RlY29kaW5nIi4KKworICAgICAgICAqIGxvYWRl ci9jYWNoZS9DYWNoZWRJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRJbWFnZTo6 ZGlkUmVtb3ZlQ2xpZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZEltYWdlOjppc0NsaWVu dFdhaXRpbmdGb3JBc3luY0RlY29kaW5nIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hl ZEltYWdlOjphZGRDbGllbnRXYWl0aW5nRm9yQXN5bmNEZWNvZGluZyk6CisgICAgICAgIChXZWJD b3JlOjpDYWNoZWRJbWFnZTo6cmVtb3ZlQWxsQ2xpZW50c1dhaXRpbmdGb3JBc3luY0RlY29kaW5n KToKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZEltYWdlOjphbGxDbGllbnRzUmVtb3ZlZCk6Cisg ICAgICAgIChXZWJDb3JlOjpDYWNoZWRJbWFnZTo6Y2xlYXIpOgorICAgICAgICAoV2ViQ29yZTo6 Q2FjaGVkSW1hZ2U6OmNyZWF0ZUltYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZEltYWdl OjppbWFnZUZyYW1lQXZhaWxhYmxlKToKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkSW1h Z2UuaDoKKwogMjAxOC0xMS0yNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBBdm9pZCB0cmlnZ2VyaW5nIGNvbXBvc2l0aW5nIHVwZGF0ZXMgd2hlbiBv bmx5IHRoZSByb290IGxheWVyIGlzIGNvbXBvc2l0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv Y2FjaGUvQ2FjaGVkSW1hZ2UuY3BwCmluZGV4IDhiM2YyZGI3YTJmZjNhNjE1Mzg3ZTA1OTU4ODM5 YzFiYmNmMzAxZjEuLjE4ZmRhZTJhYWRiMDNlYTlkZDcxZmNlZGI1YjlkMGY5YWMzNWI2YmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmNwcApAQCAtMTMwLDcg KzEzMCw3IEBAIHZvaWQgQ2FjaGVkSW1hZ2U6OmRpZFJlbW92ZUNsaWVudChDYWNoZWRSZXNvdXJj ZUNsaWVudCYgY2xpZW50KQogICAgIEFTU0VSVChjbGllbnQucmVzb3VyY2VDbGllbnRUeXBlKCkg PT0gQ2FjaGVkSW1hZ2VDbGllbnQ6OmV4cGVjdGVkVHlwZSgpKTsKIAogICAgIG1fcGVuZGluZ0Nv bnRhaW5lckNvbnRleHRSZXF1ZXN0cy5yZW1vdmUoJnN0YXRpY19jYXN0PENhY2hlZEltYWdlQ2xp ZW50Jj4oY2xpZW50KSk7Ci0gICAgbV9jbGllbnN0V2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcucmVt b3ZlKCZzdGF0aWNfY2FzdDxDYWNoZWRJbWFnZUNsaWVudCY+KGNsaWVudCkpOworICAgIG1fY2xp ZW50c1dhaXRpbmdGb3JBc3luY0RlY29kaW5nLnJlbW92ZSgmc3RhdGljX2Nhc3Q8Q2FjaGVkSW1h Z2VDbGllbnQmPihjbGllbnQpKTsKIAogICAgIGlmIChtX3N2Z0ltYWdlQ2FjaGUpCiAgICAgICAg IG1fc3ZnSW1hZ2VDYWNoZS0+cmVtb3ZlQ2xpZW50RnJvbUNhY2hlKCZzdGF0aWNfY2FzdDxDYWNo ZWRJbWFnZUNsaWVudCY+KGNsaWVudCkpOwpAQCAtMTQyLDM2ICsxNDIsMzYgQEAgdm9pZCBDYWNo ZWRJbWFnZTo6ZGlkUmVtb3ZlQ2xpZW50KENhY2hlZFJlc291cmNlQ2xpZW50JiBjbGllbnQpCiAK IGJvb2wgQ2FjaGVkSW1hZ2U6OmlzQ2xpZW50V2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcoQ2FjaGVk SW1hZ2VDbGllbnQmIGNsaWVudCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9jbGllbnN0V2FpdGlu Z0ZvckFzeW5jRGVjb2RpbmcuY29udGFpbnMoJmNsaWVudCk7CisgICAgcmV0dXJuIG1fY2xpZW50 c1dhaXRpbmdGb3JBc3luY0RlY29kaW5nLmNvbnRhaW5zKCZjbGllbnQpOwogfQogCiB2b2lkIENh Y2hlZEltYWdlOjphZGRDbGllbnRXYWl0aW5nRm9yQXN5bmNEZWNvZGluZyhDYWNoZWRJbWFnZUNs aWVudCYgY2xpZW50KQogewogICAgIEFTU0VSVChjbGllbnQucmVzb3VyY2VDbGllbnRUeXBlKCkg PT0gQ2FjaGVkSW1hZ2VDbGllbnQ6OmV4cGVjdGVkVHlwZSgpKTsKLSAgICBpZiAobV9jbGllbnN0 V2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcuY29udGFpbnMoJmNsaWVudCkpCisgICAgaWYgKG1fY2xp ZW50c1dhaXRpbmdGb3JBc3luY0RlY29kaW5nLmNvbnRhaW5zKCZjbGllbnQpKQogICAgICAgICBy ZXR1cm47CiAgICAgaWYgKCFtX2NsaWVudHMuY29udGFpbnMoJmNsaWVudCkpIHsKICAgICAgICAg Ly8gSWYgdGhlIDxodG1sPiBlbGVtZW50IGRvZXMgbm90IGhhdmUgaXRzIG93biBiYWNrZ3JvdW5k IHNwZWNpZmllZCwgcGFpbnRpbmcgdGhlIHJvb3QgYm94CiAgICAgICAgIC8vIHJlbmRlcmVyIHVz ZXMgdGhlIHN0eWxlIG9mIHRoZSA8Ym9keT4gZWxlbWVudCwgc2VlIFJlbmRlclZpZXc6OnJlbmRl cmVyRm9yUm9vdEJhY2tncm91bmQoKS4KICAgICAgICAgLy8gSW4gdGhpcyBjYXNlLCB0aGUgY2xp ZW50IHdlIGFyZSBhc2tlZCB0byBhZGQgaXMgdGhlIHJvb3QgYm94IHJlbmRlcmVyLiBTaW5jZSB3 ZSBjYW4ndCBhZGQKLSAgICAgICAgLy8gYSBjbGllbnQgdG8gbV9jbGllbnN0V2FpdGluZ0ZvckFz eW5jRGVjb2RpbmcgdW5sZXNzIGl0IGlzIG9uZSBvZiB0aGUgbV9jbGllbnRzLCB3ZSBhcmUgZ29p bmcKKyAgICAgICAgLy8gYSBjbGllbnQgdG8gbV9jbGllbnRzV2FpdGluZ0ZvckFzeW5jRGVjb2Rp bmcgdW5sZXNzIGl0IGlzIG9uZSBvZiB0aGUgbV9jbGllbnRzLCB3ZSBhcmUgZ29pbmcKICAgICAg ICAgLy8gdG8gY2FuY2VsIHRoZSByZXBhaW50IG9wdGltaXphdGlvbiB3ZSBkbyBpbiBDYWNoZWRJ bWFnZTo6aW1hZ2VGcmFtZUF2YWlsYWJsZSgpIGJ5IGFkZGluZwotICAgICAgICAvLyBhbGwgdGhl IG1fY2xpZW50cyB0byBtX2NsaWVuc3RXYWl0aW5nRm9yQXN5bmNEZWNvZGluZy4KKyAgICAgICAg Ly8gYWxsIHRoZSBtX2NsaWVudHMgdG8gbV9jbGllbnRzV2FpdGluZ0ZvckFzeW5jRGVjb2Rpbmcu CiAgICAgICAgIENhY2hlZFJlc291cmNlQ2xpZW50V2Fsa2VyPENhY2hlZEltYWdlQ2xpZW50PiB3 YWxrZXIobV9jbGllbnRzKTsKICAgICAgICAgd2hpbGUgKGF1dG8qIGNsaWVudCA9IHdhbGtlci5u ZXh0KCkpCi0gICAgICAgICAgICBtX2NsaWVuc3RXYWl0aW5nRm9yQXN5bmNEZWNvZGluZy5hZGQo Y2xpZW50KTsKKyAgICAgICAgICAgIG1fY2xpZW50c1dhaXRpbmdGb3JBc3luY0RlY29kaW5nLmFk ZChjbGllbnQpOwogICAgIH0gZWxzZQotICAgICAgICBtX2NsaWVuc3RXYWl0aW5nRm9yQXN5bmNE ZWNvZGluZy5hZGQoJmNsaWVudCk7CisgICAgICAgIG1fY2xpZW50c1dhaXRpbmdGb3JBc3luY0Rl Y29kaW5nLmFkZCgmY2xpZW50KTsKIH0KICAgICAKIHZvaWQgQ2FjaGVkSW1hZ2U6OnJlbW92ZUFs bENsaWVudHNXYWl0aW5nRm9yQXN5bmNEZWNvZGluZygpCiB7Ci0gICAgaWYgKG1fY2xpZW5zdFdh aXRpbmdGb3JBc3luY0RlY29kaW5nLmlzRW1wdHkoKSB8fCAhaGFzSW1hZ2UoKSB8fCAhaXM8Qml0 bWFwSW1hZ2U+KGltYWdlKCkpKQorICAgIGlmIChtX2NsaWVudHNXYWl0aW5nRm9yQXN5bmNEZWNv ZGluZy5pc0VtcHR5KCkgfHwgIWhhc0ltYWdlKCkgfHwgIWlzPEJpdG1hcEltYWdlPihpbWFnZSgp KSkKICAgICAgICAgcmV0dXJuOwogICAgIGRvd25jYXN0PEJpdG1hcEltYWdlPihpbWFnZSgpKS0+ c3RvcEFzeW5jRGVjb2RpbmdRdWV1ZSgpOwotICAgIGZvciAoYXV0byogY2xpZW50IDogbV9jbGll bnN0V2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcpCisgICAgZm9yIChhdXRvKiBjbGllbnQgOiBtX2Ns aWVudHNXYWl0aW5nRm9yQXN5bmNEZWNvZGluZykKICAgICAgICAgY2xpZW50LT5pbWFnZUNoYW5n ZWQodGhpcyk7Ci0gICAgbV9jbGllbnN0V2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcuY2xlYXIoKTsK KyAgICBtX2NsaWVudHNXYWl0aW5nRm9yQXN5bmNEZWNvZGluZy5jbGVhcigpOwogfQogCiB2b2lk IENhY2hlZEltYWdlOjpzd2l0Y2hDbGllbnRzVG9SZXZhbGlkYXRlZFJlc291cmNlKCkKQEAgLTE5 Niw3ICsxOTYsNyBAQCB2b2lkIENhY2hlZEltYWdlOjpzd2l0Y2hDbGllbnRzVG9SZXZhbGlkYXRl ZFJlc291cmNlKCkKIHZvaWQgQ2FjaGVkSW1hZ2U6OmFsbENsaWVudHNSZW1vdmVkKCkKIHsKICAg ICBtX3BlbmRpbmdDb250YWluZXJDb250ZXh0UmVxdWVzdHMuY2xlYXIoKTsKLSAgICBtX2NsaWVu c3RXYWl0aW5nRm9yQXN5bmNEZWNvZGluZy5jbGVhcigpOworICAgIG1fY2xpZW50c1dhaXRpbmdG b3JBc3luY0RlY29kaW5nLmNsZWFyKCk7CiAgICAgaWYgKG1faW1hZ2UgJiYgIWVycm9yT2NjdXJy ZWQoKSkKICAgICAgICAgbV9pbWFnZS0+cmVzZXRBbmltYXRpb24oKTsKIH0KQEAgLTMzOCw3ICsz MzgsNyBAQCB2b2lkIENhY2hlZEltYWdlOjpjbGVhcigpCiAgICAgZGVzdHJveURlY29kZWREYXRh KCk7CiAgICAgY2xlYXJJbWFnZSgpOwogICAgIG1fcGVuZGluZ0NvbnRhaW5lckNvbnRleHRSZXF1 ZXN0cy5jbGVhcigpOwotICAgIG1fY2xpZW5zdFdhaXRpbmdGb3JBc3luY0RlY29kaW5nLmNsZWFy KCk7CisgICAgbV9jbGllbnRzV2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcuY2xlYXIoKTsKICAgICBz ZXRFbmNvZGVkU2l6ZSgwKTsKIH0KIApAQCAtMzYyLDcgKzM2Miw3IEBAIGlubGluZSB2b2lkIENh Y2hlZEltYWdlOjpjcmVhdGVJbWFnZSgpCiAgICAgICAgICAgICAgICAgc2V0Q29udGFpbmVyQ29u dGV4dEZvckNsaWVudCgqcmVxdWVzdC5rZXksIHJlcXVlc3QudmFsdWUuY29udGFpbmVyU2l6ZSwg cmVxdWVzdC52YWx1ZS5jb250YWluZXJab29tLCByZXF1ZXN0LnZhbHVlLmltYWdlVVJMKTsKICAg ICAgICAgfQogICAgICAgICBtX3BlbmRpbmdDb250YWluZXJDb250ZXh0UmVxdWVzdHMuY2xlYXIo KTsKLSAgICAgICAgbV9jbGllbnN0V2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcuY2xlYXIoKTsKKyAg ICAgICAgbV9jbGllbnRzV2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcuY2xlYXIoKTsKICAgICB9CiB9 CiAKQEAgLTYyNyw3ICs2MjcsNyBAQCB2b2lkIENhY2hlZEltYWdlOjppbWFnZUZyYW1lQXZhaWxh YmxlKGNvbnN0IEltYWdlJiBpbWFnZSwgSW1hZ2VBbmltYXRpbmdTdGF0ZSBhbgogCiAgICAgd2hp bGUgKENhY2hlZEltYWdlQ2xpZW50KiBjbGllbnQgPSBjbGllbnRXYWxrZXIubmV4dCgpKSB7CiAg ICAgICAgIC8vIEFsbCB0aGUgY2xpZW50cyBvZiBhbmltYXRlZCBpbWFnZXMgaGF2ZSB0byBiZSBu b3RpZmllZC4gVGhlIG5ldyBmcmFtZSBoYXMgdG8gYmUgZHJhd24gaW4gYWxsIG9mIHRoZW0uCi0g ICAgICAgIGlmIChhbmltYXRpbmdTdGF0ZSA9PSBJbWFnZUFuaW1hdGluZ1N0YXRlOjpObyAmJiAh bV9jbGllbnN0V2FpdGluZ0ZvckFzeW5jRGVjb2RpbmcuY29udGFpbnMoY2xpZW50KSkKKyAgICAg ICAgaWYgKGFuaW1hdGluZ1N0YXRlID09IEltYWdlQW5pbWF0aW5nU3RhdGU6Ok5vICYmICFtX2Ns aWVudHNXYWl0aW5nRm9yQXN5bmNEZWNvZGluZy5jb250YWlucyhjbGllbnQpKQogICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgIGlmIChjbGllbnQtPmltYWdlRnJhbWVBdmFpbGFibGUoKnRo aXMsIGFuaW1hdGluZ1N0YXRlLCBjaGFuZ2VSZWN0KSA9PSBWaXNpYmxlSW5WaWV3cG9ydFN0YXRl OjpZZXMpCiAgICAgICAgICAgICB2aXNpYmxlU3RhdGUgPSBWaXNpYmxlSW5WaWV3cG9ydFN0YXRl OjpZZXM7CkBAIC02MzcsNyArNjM3LDcgQEAgdm9pZCBDYWNoZWRJbWFnZTo6aW1hZ2VGcmFtZUF2 YWlsYWJsZShjb25zdCBJbWFnZSYgaW1hZ2UsIEltYWdlQW5pbWF0aW5nU3RhdGUgYW4KICAgICAg ICAgbV9pbWFnZS0+c3RvcEFuaW1hdGlvbigpOwogCiAgICAgaWYgKGRlY29kaW5nU3RhdHVzICE9 IERlY29kaW5nU3RhdHVzOjpQYXJ0aWFsKQotICAgICAgICBtX2NsaWVuc3RXYWl0aW5nRm9yQXN5 bmNEZWNvZGluZy5jbGVhcigpOworICAgICAgICBtX2NsaWVudHNXYWl0aW5nRm9yQXN5bmNEZWNv ZGluZy5jbGVhcigpOwogfQogCiB2b2lkIENhY2hlZEltYWdlOjpjaGFuZ2VkSW5SZWN0KGNvbnN0 IEltYWdlJiBpbWFnZSwgY29uc3QgSW50UmVjdCogcmVjdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L2NhY2hlL0NhY2hlZEltYWdlLmgKaW5kZXggNzAxODUxZjk4N2I4YTE3MzVmY2IzZDE3YzUxNmM3 ZWI2YzcxNmY4NC4uYjIzOTU3Y2JhYmUxZTdjN2UyM2ZiZjczYWJhMjU0YTBlMTU4NjJmOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmgKQEAgLTE3Miw3ICsxNzIs NyBAQCBwcml2YXRlOgogICAgIHVzaW5nIENvbnRhaW5lckNvbnRleHRSZXF1ZXN0cyA9IEhhc2hN YXA8Y29uc3QgQ2FjaGVkSW1hZ2VDbGllbnQqLCBDb250YWluZXJDb250ZXh0PjsKICAgICBDb250 YWluZXJDb250ZXh0UmVxdWVzdHMgbV9wZW5kaW5nQ29udGFpbmVyQ29udGV4dFJlcXVlc3RzOwog Ci0gICAgSGFzaFNldDxDYWNoZWRJbWFnZUNsaWVudCo+IG1fY2xpZW5zdFdhaXRpbmdGb3JBc3lu Y0RlY29kaW5nOworICAgIEhhc2hTZXQ8Q2FjaGVkSW1hZ2VDbGllbnQqPiBtX2NsaWVudHNXYWl0 aW5nRm9yQXN5bmNEZWNvZGluZzsKIAogICAgIFJlZlB0cjxDYWNoZWRJbWFnZU9ic2VydmVyPiBt X2ltYWdlT2JzZXJ2ZXI7CiAgICAgUmVmUHRyPEltYWdlPiBtX2ltYWdlOwo=