192034 2018-11-27 13:57:49 -0800 Remove kCCNotVerified 2018-11-28 09:39:18 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan ap commit-queue jiewen_tan tsavell webkit-bug-importer oldest_to_newest 1482102 0 jiewen_tan 2018-11-27 13:57:49 -0800 Remove kCCNotVerified as the return code is never used by CCRSACryptorVerify. 1482103 1 jiewen_tan 2018-11-27 13:58:04 -0800 <rdar://problem/46235863> 1482106 2 355776 jiewen_tan 2018-11-27 14:00:38 -0800 Created attachment 355776 Patch 1482114 3 355776 ap 2018-11-27 14:12:31 -0800 Comment on attachment 355776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355776&action=review > Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:80 > - return Exception { OperationError }; > + return false; This changes the behavior in the case of kCCParamError from raising an exception to returning false. Is that OK? 1482125 4 355776 jiewen_tan 2018-11-27 14:25:56 -0800 Comment on attachment 355776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355776&action=review > Source/WebCore/ChangeLog:9 > + No change of behaviours. Covered by existing tests. Instead? >> Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:80 >> + return false; > > This changes the behavior in the case of kCCParamError from raising an exception to returning false. Is that OK? I think it is fine. 1) It doesn't regress any of the crypto test. 2) The spec doesn't define we should return OperationError here as the sanity check of the web params are performed in a higher level. 3) It is better to return yes or no for signature verification to prevent any potential attacks. 1482141 5 ap 2018-11-27 14:48:21 -0800 > I think it is fine. I don't have any strong objection. However, I would be more comfortable not doing a behavior change in a build fix patch. 1482146 6 jiewen_tan 2018-11-27 14:54:32 -0800 (In reply to Alexey Proskuryakov from comment #5) > > I think it is fine. > > I don't have any strong objection. > > However, I would be more comfortable not doing a behavior change in a build > fix patch. Okay, I will keep the kCCDecodeError then. 1482160 7 355792 jiewen_tan 2018-11-27 15:18:20 -0800 Created attachment 355792 Patch 1482174 8 355792 ap 2018-11-27 15:29:50 -0800 Comment on attachment 355792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355792&action=review > Source/WebCore/crypto/CommonCryptoUtilities.h:-76 > - kCCNotVerified = -4306 We don't need this for EC, do we? 1482180 9 355792 jiewen_tan 2018-11-27 15:35:43 -0800 Comment on attachment 355792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355792&action=review Thanks Alexey for r+ this patch. >> Source/WebCore/crypto/CommonCryptoUtilities.h:-76 >> - kCCNotVerified = -4306 > > We don't need this for EC, do we? We don't. EC directly returns true or false. 1482215 10 commit-queue 2018-11-27 16:25:29 -0800 The commit-queue encountered the following flaky tests while processing attachment 355792: webgl/2.0.0/conformance/more/functions/bindBuffer.html bug 192051 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch. 1482216 11 355792 commit-queue 2018-11-27 16:26:18 -0800 Comment on attachment 355792 Patch Clearing flags on attachment: 355792 Committed r238588: <https://trac.webkit.org/changeset/238588> 1482217 12 commit-queue 2018-11-27 16:26:20 -0800 All reviewed patches have been landed. Closing bug. 1482458 13 tsavell 2018-11-28 09:31:52 -0800 It looks like the change in https://trac.webkit.org/changeset/238588/webkit has caused an API failure on iOS Failed TestWebKitAPI.SafeBrowsing.VisitUnsafeWebsite /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:215 Expected: (warning.subviews.firstObject.subviews[2].frame.size.height) > (0), actual: 0 vs 0 this was the first run that had the failure: https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1200 1482462 14 tsavell 2018-11-28 09:39:18 -0800 disregard my previous comment. I had the wrong revision 355776 2018-11-27 14:00:38 -0800 2018-11-27 15:18:19 -0800 Patch bug-192034-20181127140037.patch text/plain 2346 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQyYmVjYWY0NjIwMmI4 NWM2NDU0YWQ3MDllNzU5MGQyNTQ2MzY1YS4uMWVhYWQzYWUxMDVkMTgyMzEzOTViZmEwMTA3Nzg3 MzhjOTg0MmNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTI3ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGtDQ05vdFZl cmlmaWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTIwMzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2MjM1ODYzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBiZWhhdmlvdXJz LgorCisgICAgICAgICogY3J5cHRvL0NvbW1vbkNyeXB0b1V0aWxpdGllcy5oOgorICAgICAgICAq IGNyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVNYWMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6dmVyaWZ5UlNBU1NBX1BLQ1MxX3YxXzUpOgorCiAyMDE4LTExLTE1ICBK aWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1dGhOXSBV c2UgYSByZWFsIG5vbmNlIGZvciBDVEFQSElEX0lOSVQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2NyeXB0by9Db21tb25DcnlwdG9VdGlsaXRpZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2NyeXB0 by9Db21tb25DcnlwdG9VdGlsaXRpZXMuaAppbmRleCA5Mjg1NTE1MDVmZDg0MjU2NzhhNTVmN2U3 NTE5ZDUxNDI4NDA1ZDRkLi4yZDQxZjgyNjI2ZTgzNmRhYThhNTA2NzU0ZjZkZjRiNTBiNjE5NmE2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vQ29tbW9uQ3J5cHRvVXRpbGl0aWVz LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NvbW1vbkNyeXB0b1V0aWxpdGllcy5oCkBA IC03MSwxMCArNzEsNiBAQCBlbnVtIHsKICAgICBjY1JTQVBTU1BhZGRpbmcgPSAxMDA1CiB9Owog dHlwZWRlZiB1aW50MzJfdCBDQ0FzeW1tZXRyaWNQYWRkaW5nOwotCi1lbnVtIHsKLSAgICBrQ0NO b3RWZXJpZmllZCA9IC00MzA2Ci19OwogI2VuZGlmCiAKIHR5cGVkZWYgc3RydWN0IF9DQ0JpZ051 bVJlZiAqQ0NCaWdOdW1SZWY7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vbWFj L0NyeXB0b0FsZ29yaXRobVJTQVNTQV9QS0NTMV92MV81TWFjLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2NyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVNYWMuY3BwCmluZGV4 IDYyODRjMzg0YWRiYjJiMDZjOWZjNjk1NTYxNWE0NzU5NDRmZGZiYWYuLjZmY2Y2ZjQxYTdhYmI3 Y2I0OWY2N2QwMGRiZjU3NzcyMWU1NDcxYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Ny eXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVNYWMuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2NyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVN YWMuY3BwCkBAIC03NywxMCArNzcsNyBAQCBzdGF0aWMgRXhjZXB0aW9uT3I8Ym9vbD4gdmVyaWZ5 UlNBU1NBX1BLQ1MxX3YxXzUoQ3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllciBoYXNoLAogICAgIGF1 dG8gc3RhdHVzID0gQ0NSU0FDcnlwdG9yVmVyaWZ5KGtleSwgY2NQS0NTMVBhZGRpbmcsIGRpZ2Vz dERhdGEuZGF0YSgpLCBkaWdlc3REYXRhLnNpemUoKSwgZGlnZXN0QWxnb3JpdGhtLCAwLCBzaWdu YXR1cmUuZGF0YSgpLCBzaWduYXR1cmUuc2l6ZSgpKTsKICAgICBpZiAoIXN0YXR1cykKICAgICAg ICAgcmV0dXJuIHRydWU7Ci0gICAgaWYgKHN0YXR1cyA9PSBrQ0NOb3RWZXJpZmllZCB8fCBzdGF0 dXMgPT0ga0NDRGVjb2RlRXJyb3IpIC8vIDxyZGFyOi8vcHJvYmxlbS8xNTQ2NDk4Mj4gQ0NSU0FD cnlwdG9yVmVyaWZ5IHJldHVybnMga0NDRGVjb2RlRXJyb3IgaW5zdGVhZCBvZiBrQ0NOb3RWZXJp ZmllZCBzb21ldGltZXMKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgcmV0dXJuIEV4Y2Vw dGlvbiB7IE9wZXJhdGlvbkVycm9yIH07CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiBFeGNlcHRp b25PcjxWZWN0b3I8dWludDhfdD4+IENyeXB0b0FsZ29yaXRobVJTQVNTQV9QS0NTMV92MV81Ojpw bGF0Zm9ybVNpZ24oY29uc3QgQ3J5cHRvS2V5UlNBJiBrZXksIGNvbnN0IFZlY3Rvcjx1aW50OF90 PiYgZGF0YSkK 355792 2018-11-27 15:18:20 -0800 2018-11-27 16:26:18 -0800 Patch bug-192034-20181127151819.patch text/plain 2225 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQyYmVjYWY0NjIwMmI4 NWM2NDU0YWQ3MDllNzU5MGQyNTQ2MzY1YS4uMWVhYWQzYWUxMDVkMTgyMzEzOTViZmEwMTA3Nzg3 MzhjOTg0MmNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTI3ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGtDQ05vdFZl cmlmaWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTIwMzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2MjM1ODYzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBiZWhhdmlvdXJz LgorCisgICAgICAgICogY3J5cHRvL0NvbW1vbkNyeXB0b1V0aWxpdGllcy5oOgorICAgICAgICAq IGNyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVNYWMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6dmVyaWZ5UlNBU1NBX1BLQ1MxX3YxXzUpOgorCiAyMDE4LTExLTE1ICBK aWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1dGhOXSBV c2UgYSByZWFsIG5vbmNlIGZvciBDVEFQSElEX0lOSVQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2NyeXB0by9Db21tb25DcnlwdG9VdGlsaXRpZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2NyeXB0 by9Db21tb25DcnlwdG9VdGlsaXRpZXMuaAppbmRleCA5Mjg1NTE1MDVmZDg0MjU2NzhhNTVmN2U3 NTE5ZDUxNDI4NDA1ZDRkLi4yZDQxZjgyNjI2ZTgzNmRhYThhNTA2NzU0ZjZkZjRiNTBiNjE5NmE2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vQ29tbW9uQ3J5cHRvVXRpbGl0aWVz LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NvbW1vbkNyeXB0b1V0aWxpdGllcy5oCkBA IC03MSwxMCArNzEsNiBAQCBlbnVtIHsKICAgICBjY1JTQVBTU1BhZGRpbmcgPSAxMDA1CiB9Owog dHlwZWRlZiB1aW50MzJfdCBDQ0FzeW1tZXRyaWNQYWRkaW5nOwotCi1lbnVtIHsKLSAgICBrQ0NO b3RWZXJpZmllZCA9IC00MzA2Ci19OwogI2VuZGlmCiAKIHR5cGVkZWYgc3RydWN0IF9DQ0JpZ051 bVJlZiAqQ0NCaWdOdW1SZWY7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vbWFj L0NyeXB0b0FsZ29yaXRobVJTQVNTQV9QS0NTMV92MV81TWFjLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2NyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVNYWMuY3BwCmluZGV4 IDYyODRjMzg0YWRiYjJiMDZjOWZjNjk1NTYxNWE0NzU5NDRmZGZiYWYuLjE5YjkwY2VkMmE4OTgw YzAxMGI4MTkxMmUzMTk3YmI3YjA0ODY0YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Ny eXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVNYWMuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2NyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtUlNBU1NBX1BLQ1MxX3YxXzVN YWMuY3BwCkBAIC03Nyw3ICs3Nyw3IEBAIHN0YXRpYyBFeGNlcHRpb25Pcjxib29sPiB2ZXJpZnlS U0FTU0FfUEtDUzFfdjFfNShDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGhhc2gsCiAgICAgYXV0 byBzdGF0dXMgPSBDQ1JTQUNyeXB0b3JWZXJpZnkoa2V5LCBjY1BLQ1MxUGFkZGluZywgZGlnZXN0 RGF0YS5kYXRhKCksIGRpZ2VzdERhdGEuc2l6ZSgpLCBkaWdlc3RBbGdvcml0aG0sIDAsIHNpZ25h dHVyZS5kYXRhKCksIHNpZ25hdHVyZS5zaXplKCkpOwogICAgIGlmICghc3RhdHVzKQogICAgICAg ICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAoc3RhdHVzID09IGtDQ05vdFZlcmlmaWVkIHx8IHN0YXR1 cyA9PSBrQ0NEZWNvZGVFcnJvcikgLy8gPHJkYXI6Ly9wcm9ibGVtLzE1NDY0OTgyPiBDQ1JTQUNy eXB0b3JWZXJpZnkgcmV0dXJucyBrQ0NEZWNvZGVFcnJvciBpbnN0ZWFkIG9mIGtDQ05vdFZlcmlm aWVkIHNvbWV0aW1lcworICAgIGlmIChzdGF0dXMgPT0ga0NDRGVjb2RlRXJyb3IpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAogICAgIHJldHVybiBFeGNlcHRpb24geyBPcGVyYXRpb25FcnJvciB9 Owo=