191997 2018-11-26 23:56:01 -0800 REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds 2018-12-06 04:40:57 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191998 Gtk P3 Normal --- 1 leio webkit-unassigned aperez bugs-noreply cadubentzen commit-queue mcatanzaro pnormand zan oldest_to_newest 1481839 0 leio 2018-11-26 23:56:01 -0800 webkit-gtk built without GL support leads to build/link failures of webkit-gtk itself, or any consumer (downstream reports had webkit-gtk consumers fail to link against 2.22.2, but I myself had trouble getting itself 2.22.4 built). /usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../lib64/libwebkit2gtk-4.0.so: undefined reference to `WebCore::LayerRepresentation::makePlatformLayerTypeless(WebCore::TextureMapperPlatformLayer*)' /usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../lib64/libwebkit2gtk-4.0.so: undefined reference to `WebCore::LayerRepresentation::releasePlatformLayer(void*)' /usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../lib64/libwebkit2gtk-4.0.so: undefined reference to `WebCore::LayerRepresentation::retainPlatformLayer(void*)' Michael Catanzaro helped track this down to probably being a regression since async scrolling was enabled: <mcatanzaro> Problem is ScrollingStateNode.h uses this function #if ENABLE(ASYNC_SCROLLING) || USE(COORDINATED_GRAPHICS) <mcatanzaro> But it's defined only #if USE(COORDINATED_GRAPHICS) <mcatanzaro> Guess: the non-GL build has been broken since we turned on ENABLE(ASYNC_SCROLLING) <mcatanzaro> And that was https://trac.webkit.org/changeset/231043/webkit <mcatanzaro> This is bug report territory now since the right fix is unclear. Maybe async scrolling needs to depend on GL. 1481855 1 mcatanzaro 2018-11-27 02:03:05 -0800 The fix for this is not obvious to me, but I guess the build guards are wrong in ScrollingStateNode.h: #if ENABLE(ASYNC_SCROLLING) || USE(COORDINATED_GRAPHICS) Expresses the intent for this file to work if USE(COORDINATED_GRAPHICS) is disabled, but it doesn't. Another option would be to add explicit dependencies at the CMake level if async scrolling really is supposed to depend on coordinated graphics, but they would have to be duplicated in both OptionsGTK.cmake and OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option: WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL) 1481859 2 mcatanzaro 2018-11-27 02:11:06 -0800 (We also might want to consider removing the ENABLE_OPENGL, option since clearly nobody has attempted to build 2.22 with it disabled before now. It exists only for embedded systems, and we never test building without it. But nowadays we expect embedded systems will mostly want to use WPE, and WPE requires OpenGL, so maybe it doesn't make sense anymore. Not sure.) 1485571 3 356698 cadubentzen 2018-12-05 19:28:17 -0800 Created attachment 356698 Patch 1485575 4 cadubentzen 2018-12-05 19:30:15 -0800 (In reply to Michael Catanzaro from comment #1) > Another option would be to add explicit dependencies at the CMake level if > async scrolling really is supposed to depend on coordinated graphics, but > they would have to be duplicated in both OptionsGTK.cmake and > OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option: > > WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL) Did that in OptionsGTK.cmake but it is not need for WPE because 1) there's no ENABLE_OPENGL for WPE 2) ENABLE_ASYNC_SCROLLING is always on there explicitly 1485675 5 aperez 2018-12-06 03:41:27 -0800 (In reply to Carlos Eduardo Ramalho from comment #4) > (In reply to Michael Catanzaro from comment #1) > > Another option would be to add explicit dependencies at the CMake level if > > async scrolling really is supposed to depend on coordinated graphics, but > > they would have to be duplicated in both OptionsGTK.cmake and > > OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option: > > > > WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL) > > Did that in OptionsGTK.cmake but it is not need for WPE because > 1) there's no ENABLE_OPENGL for WPE > 2) ENABLE_ASYNC_SCROLLING is always on there explicitly JFTR, this seems like a reasonably good approach to me. 1485681 6 356698 commit-queue 2018-12-06 04:40:56 -0800 Comment on attachment 356698 Patch Clearing flags on attachment: 356698 Committed r238928: <https://trac.webkit.org/changeset/238928> 1485682 7 commit-queue 2018-12-06 04:40:57 -0800 All reviewed patches have been landed. Closing bug. 356698 2018-12-05 19:28:17 -0800 2018-12-06 04:40:56 -0800 Patch bug-191997-20181206042815.patch text/plain 5107 cadubentzen U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDNlNGQ0NjNhYWU5YWQ2 NTgyMTJjMDI3MmY5OTY4N2EzZDc3YjJmMy4uYWZiMDJkN2RiOTQ1YmIyNjcyZjZlNDIxMzdkNzEx ZTk3YTY1OTI5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEyLTA1ICBDYXJs b3MgRWR1YXJkbyBSYW1hbGhvICA8Y2FkdWJlbnR6ZW5AZ21haWwuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04ocjIzMTA0Myk6IFtHVEtdIFVuZGVmaW5lZCByZWZlcmVuY2VzIHRvIFdlYkNvcmU6 OkxheWVyUmVwcmVzZW50YXRpb246Oiogd2l0aCAtREVOQUJMRV9PUEVOR0w9T0ZGIGJ1aWxkcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTk3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxk IHdpdGggLURFTkFCTEVfT1BFTkdMPU9GRiBhbmQgLURFTkFCTEVfVklERU89T0ZGLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJlZC4gT25seSBmaXhpbmcgYnVpbGQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ndGsvUGxhdGZvcm1XaGVlbEV2ZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBsYXRmb3JtV2hlZWxFdmVudDo6UGxhdGZvcm1XaGVlbEV2ZW50KTogYWRkIHJlcXVpcmVk ICNpZiBFTkFCTEUoQVNZTkNfU0NST0xMSU5HKQorCiAyMDE4LTEyLTA1ICBEb24gT2xtc3RlYWQg IDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW1BsYXlTdGF0aW9uXSBFbmFibGUg V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZwppbmRleCBiYzZmYTJmY2U5MzdhNGI2OGUxMWQ5NjVhYTdiNDg2Y2E3OGEz NmFlLi43NjEzNzdiYTMxMTZkZTM2MWFlYWYxZDM0MGY5MWM4Njk4OTM5N2Y1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDE4LTEyLTA1ICBDYXJsb3MgRWR1YXJkbyBSYW1hbGhvICA8Y2Fk dWJlbnR6ZW5AZ21haWwuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzMTA0Myk6IFtHVEtd IFVuZGVmaW5lZCByZWZlcmVuY2VzIHRvIFdlYkNvcmU6OkxheWVyUmVwcmVzZW50YXRpb246Oiog d2l0aCAtREVOQUJMRV9PUEVOR0w9T0ZGIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdpdGggLURFTkFCTEVfT1BFTkdMPU9G RiBhbmQgLURFTkFCTEVfVklERU89T0ZGLgorCisgICAgICAgICogU2hhcmVkL1dlYkV2ZW50Q29u dmVyc2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYktpdDJQbGF0Zm9ybVdoZWVsRXZlbnQ6 OldlYktpdDJQbGF0Zm9ybVdoZWVsRXZlbnQpOiBhZGQgcmVxdWlyZWQgI2lmIEVOQUJMRShBU1lO Q19TQ1JPTExJTkcpCisKIDIwMTgtMTItMDUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBTaW1wbGlmeSBsb2dpYyBpbnNpZGUgV2ViUGFnZVByb3h5Ojpjb250aW51 ZU5hdmlnYXRpb25Jbk5ld1Byb2Nlc3MoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1BsYXRmb3JtV2hlZWxFdmVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUGxhdGZvcm1XaGVlbEV2ZW50R3RrLmNwcAppbmRleCAzMTFhNmI0ZTU5NzBmMWEw MzQwNjYwMWIyZmVhYWFmYWZjODUwMzIyLi5iOTZlZTA3MDY1NTRkNzAwOThiNjA2YWExMDU5ZjI1 OWZiMDE1ZWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZv cm1XaGVlbEV2ZW50R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxh dGZvcm1XaGVlbEV2ZW50R3RrLmNwcApAQCAtODcsNiArODcsNyBAQCBQbGF0Zm9ybVdoZWVsRXZl bnQ6OlBsYXRmb3JtV2hlZWxFdmVudChHZGtFdmVudFNjcm9sbCogZXZlbnQpCiAgICAgbV93aGVl bFRpY2tzWCA9IG1fZGVsdGFYOwogICAgIG1fd2hlZWxUaWNrc1kgPSBtX2RlbHRhWTsKIAorI2lm IEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpCiAjaWZuZGVmIEdUS19BUElfVkVSU0lPTl8yCiAjaWYg R1RLX0NIRUNLX1ZFUlNJT04oMywgMjAsIDApCiAgICAgbV9waGFzZSA9IGV2ZW50LT5pc19zdG9w ID8KQEAgLTEwMCw2ICsxMDEsNyBAQCBQbGF0Zm9ybVdoZWVsRXZlbnQ6OlBsYXRmb3JtV2hlZWxF dmVudChHZGtFdmVudFNjcm9sbCogZXZlbnQpCiAjZWxzZQogICAgIG1fcGhhc2UgPSBQbGF0Zm9y bVdoZWVsRXZlbnRQaGFzZUNoYW5nZWQ7CiAjZW5kaWYgLy8gR1RLX0FQSV9WRVJTSU9OXzIKKyNl bmRpZiAvLyBFTkFCTEUoQVNZTkNfU0NST0xMSU5HKQogCiAgICAgbV9wb3NpdGlvbiA9IEludFBv aW50KHN0YXRpY19jYXN0PGludD4oZXZlbnQtPngpLCBzdGF0aWNfY2FzdDxpbnQ+KGV2ZW50LT55 KSk7CiAgICAgbV9nbG9iYWxQb3NpdGlvbiA9IEludFBvaW50KHN0YXRpY19jYXN0PGludD4oZXZl bnQtPnhfcm9vdCksIHN0YXRpY19jYXN0PGludD4oZXZlbnQtPnlfcm9vdCkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViRXZlbnRDb252ZXJzaW9uLmNwcCBiL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL1dlYkV2ZW50Q29udmVyc2lvbi5jcHAKaW5kZXggOGU2YjVkOWYwMTdiMzY2 OWQzOTdlODVlZDVmODkzZjkwZjI4YzIwNC4uY2YyN2JmZmRlMDIxNDU3MGU3YzFlMTdlNTk1OWM5 NzBkYjAyMjQ4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViRXZlbnRDb252 ZXJzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJFdmVudENvbnZlcnNpb24u Y3BwCkBAIC0xNTcsNyArMTU3LDcgQEAgcHVibGljOgogICAgICAgICBtX3doZWVsVGlja3NZID0g d2ViRXZlbnQud2hlZWxUaWNrcygpLmhlaWdodCgpOwogICAgICAgICBtX2dyYW51bGFyaXR5ID0g KHdlYkV2ZW50LmdyYW51bGFyaXR5KCkgPT0gV2ViV2hlZWxFdmVudDo6U2Nyb2xsQnlQYWdlV2hl ZWxFdmVudCkgPyBXZWJDb3JlOjpTY3JvbGxCeVBhZ2VXaGVlbEV2ZW50IDogV2ViQ29yZTo6U2Ny b2xsQnlQaXhlbFdoZWVsRXZlbnQ7CiAgICAgICAgIG1fZGlyZWN0aW9uSW52ZXJ0ZWRGcm9tRGV2 aWNlID0gd2ViRXZlbnQuZGlyZWN0aW9uSW52ZXJ0ZWRGcm9tRGV2aWNlKCk7Ci0jaWYgUExBVEZP Uk0oQ09DT0EpIHx8IFBMQVRGT1JNKEdUSykKKyNpZiAoUExBVEZPUk0oQ09DT0EpIHx8IFBMQVRG T1JNKEdUSykpICYmIEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpCiAgICAgICAgIG1fcGhhc2UgPSBz dGF0aWNfY2FzdDxXZWJDb3JlOjpQbGF0Zm9ybVdoZWVsRXZlbnRQaGFzZT4od2ViRXZlbnQucGhh c2UoKSk7CiAgICAgICAgIG1fbW9tZW50dW1QaGFzZSA9IHN0YXRpY19jYXN0PFdlYkNvcmU6OlBs YXRmb3JtV2hlZWxFdmVudFBoYXNlPih3ZWJFdmVudC5tb21lbnR1bVBoYXNlKCkpOwogI2VuZGlm CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFr ZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDNmMGQzN2Q2MGI2MzhjZjE5Nzk0MjZkMjIyMjI5MDk4 NTkwMjgyYWIuLmVlZmUwMmUzMWIxMzk1OTU3ZjAxMGE0NjYxNDc4ZjYyMzllNTNiM2EgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9P cHRpb25zR1RLLmNtYWtlCkBAIC05NSw2ICs5NSw3IEBAIFdFQktJVF9PUFRJT05fQ09ORkxJQ1Qo RU5BQkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyBFTkFCTEVfR0xFUzIpCiAKIFdFQktJVF9PUFRJ T05fREVQRU5EKEVOQUJMRV8zRF9UUkFOU0ZPUk1TIEVOQUJMRV9PUEVOR0wpCiBXRUJLSVRfT1BU SU9OX0RFUEVORChFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIEVOQUJMRV9PUEVOR0wpCitX RUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfQVNZTkNfU0NST0xMSU5HIEVOQUJMRV9PUEVOR0wp CiBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfR0xFUzIgRU5BQkxFX09QRU5HTCkKIFdFQktJ VF9PUFRJT05fREVQRU5EKEVOQUJMRV9QTFVHSU5fUFJPQ0VTU19HVEsyIEVOQUJMRV9YMTFfVEFS R0VUKQogV0VCS0lUX09QVElPTl9ERVBFTkQoRU5BQkxFX1dFQkdMIEVOQUJMRV9PUEVOR0wpCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggM2VmZTg3NTgzZTJkZDgxMGFh NmU4ODE3NDdkYWQ5NDc0NDQxMjQ0YS4uZmI4ZjRjNGI0ZmU3ODhkOTg4ZTQ5YjczMDU2ODNhNzRm MTllNDFjNiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE4LTEyLTA1ICBDYXJsb3MgRWR1YXJkbyBSYW1hbGhvICA8Y2FkdWJlbnR6ZW5A Z21haWwuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzMTA0Myk6IFtHVEtdIFVuZGVmaW5l ZCByZWZlcmVuY2VzIHRvIFdlYkNvcmU6OkxheWVyUmVwcmVzZW50YXRpb246Oiogd2l0aCAtREVO QUJMRV9PUEVOR0w9T0ZGIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkxOTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdpdGggLURFTkFCTEVfT1BFTkdMPU9GRiBhbmQgLURF TkFCTEVfVklERU89T0ZGCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFr ZTogbWFrZSBFTkFCTEVfQVNZTkNfU0NST0xMSU5HIGRlcGVuZCBvbiBFTkFCTEVfT1BFTkdMCisK IDIwMTgtMTItMDUgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAg ICAgICBbUGxheVN0YXRpb25dIEVuYWJsZSBXZWJDb3JlCg==