<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191941</bug_id>
          
          <creation_ts>2018-11-24 02:58:27 -0800</creation_ts>
          <short_desc>[GTK] Disable the sampling profiler by default if the JIT is off</short_desc>
          <delta_ts>2018-11-26 02:57:20 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>186722</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alberto Garcia">berto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1481289</commentid>
    <comment_count>0</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2018-11-24 02:58:27 -0800</bug_when>
    <thetext>ENABLE_SAMPLING_PROFILER is on by default but it conflicts with ENABLE_C_LOOP, so the build fails on platform where the JIT is not supported, like x86:

This is what happens with WebKitGTK+ 2.23.1:

CMake Error at Source/cmake/WebKitFeatures.cmake:252 (message):
  ENABLE_SAMPLING_PROFILER conflicts with ENABLE_C_LOOP.  You must disable
  one or the other.
Call Stack (most recent call first):
  Source/cmake/WebKitFeatures.cmake:260 (_WEBKIT_OPTION_ENFORCE_CONFLICTS)
  Source/cmake/WebKitFeatures.cmake:285 (_WEBKIT_OPTION_ENFORCE_ALL_CONFLICTS)
  Source/cmake/OptionsGTK.cmake:162 (WEBKIT_OPTION_END)
  Source/cmake/WebKitCommon.cmake:59 (include)
  CMakeLists.txt:163 (include)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1481294</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-11-24 06:52:02 -0800</bug_when>
    <thetext>It&apos;s set properly in WebKitFeatures.cmake, so we just need to not override it in OptionsGTK.cmake. It&apos;s easiest to handle this in bug #186722.

*** This bug has been marked as a duplicate of bug 186722 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>