191912 2018-11-22 11:34:05 -0800 Improve fast/scrolling/scrolling-tree-includes-frame.html 2018-11-22 12:33:33 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172914 1 fred.wang fred.wang commit-queue simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1480996 0 fred.wang 2018-11-22 11:34:05 -0800 Improve fast/scrolling/scrolling-tree-includes-frame.html 1480998 1 355480 fred.wang 2018-11-22 11:40:23 -0800 Created attachment 355480 Patch 1480999 2 fred.wang 2018-11-22 11:40:57 -0800 I'm extracting this from the patch of bug 172914. 1481002 3 355480 fred.wang 2018-11-22 11:53:34 -0800 Comment on attachment 355480 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355480&action=review > LayoutTests/fast/scrolling/scrolling-tree-includes-frame.html:27 > + border: 1px solid black; this is not necessary, per border: 0 below. > LayoutTests/fast/scrolling/scrolling-tree-includes-frame.html:35 > + <iframe id="frame" onload="doTest()" srcdoc=" id="frame" is not used 1481003 4 355481 fred.wang 2018-11-22 11:54:27 -0800 Created attachment 355481 Patch for landing 1481007 5 355481 commit-queue 2018-11-22 12:33:00 -0800 Comment on attachment 355481 Patch for landing Clearing flags on attachment: 355481 Committed r238450: <https://trac.webkit.org/changeset/238450> 1481008 6 commit-queue 2018-11-22 12:33:01 -0800 All reviewed patches have been landed. Closing bug. 1481009 7 webkit-bug-importer 2018-11-22 12:33:33 -0800 <rdar://problem/46215230> 355480 2018-11-22 11:40:23 -0800 2018-11-22 11:54:23 -0800 Patch bug-191912-20181122204021.patch text/plain 2979 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Mzk0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTUzNzMzMjg2ZDhhZTU4Y2Q0ZmZj MGU1YmQwOGExOGU5MjNiYTcyYi4uOWU0YzVkZmM5MDlhNjM5OTIwZDE4M2JiYmMzNTk5YzdjNGNl NzMzZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTExLTIyICBGcmVkZXJpYyBXYW5nICA8 ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBJbXByb3ZlIGZhc3Qvc2Nyb2xsaW5nL3Njcm9s bGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTkxMgorCisgICAgICAgIFRoZXNlIGFyZSBzbWFsbCBp bXByb3ZlbWVudHMgdG8gc2Nyb2xsaW5nLXRyZWUtaW5jbHVkZXMtZnJhbWUuaHRtbDoKKyAgICAg ICAgLSBSdW4gZG9UZXN0KCkgYWZ0ZXIgdGhlIGlmcmFtZSBpcyBsb2FkZWQgYW5kIHVzZSB3YWl0 VW50aWxEb25lL25vdGlmeURvbmUgZm9yIG1vcmUgcmVsaWFibGUgdGltaW5nLgorICAgICAgICAt IFVzZSBpZnJhbWVAc3JjZG9jIGluc3RlYWQgb2YgaWZyYW1lQHNyYyBhbmQgcHV0IHRoZSBjb250 ZW50IG9mIHRoZSBpZnJhbWUgZG9jdW1lbnQgaW4gaXRzIG93biBsaW5lLgorICAgICAgICAtIE1v dmUgdGhlIGlmcmFtZSBzdHlsZSBpbiBhIHNlcGFyYXRlIDxzdHlsZT4gdGFnIGFuZCBlbnN1cmUg dGhlIGlmcmFtZSBpcyByZWFsbHkgcG9zaXRpb25lZCBhdCAoMCwwKQorICAgICAgICB3aXRoIG5v IGV4dHJhIG1hcmdpbi9wYWRkaW5nL2JvcmRlci4KKyAgICAgICAgVGhlIHRlc3QgZXhwZWN0YXRp b24gaXMgbm90IGNoYW5nZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L3Njcm9sbGluZy9zY3JvbGxpbmctdHJlZS1pbmNsdWRlcy1mcmFt ZS5odG1sOgorCiAyMDE4LTExLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIENsaWNrIG9uIG5vZGUgYXNzaWduZWQgdG8gc2xvdCBpbiBidXR0b24ncyBzaGFk b3cgY2F1c2UgbG9zcyBvZiBidXR0b24gZm9jdXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3Qvc2Nyb2xsaW5nL3Njcm9sbGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L3Njcm9sbGluZy9zY3JvbGxpbmctdHJlZS1pbmNsdWRlcy1mcmFtZS5odG1sCmlu ZGV4IGM5NjE0NjhhYTE3Yjk0MWNjNWRkYTVkNjNiYmMwMDQ3YzVjZjVmZjguLmEyNGNlZjM4ZDNm YjA3MjA5MTIwOWMzYzllMTRkM2JmZDhkNGY1YTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zh c3Qvc2Nyb2xsaW5nL3Njcm9sbGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcvc2Nyb2xsaW5nLXRyZWUtaW5jbHVkZXMtZnJhbWUuaHRt bApAQCAtMywyMCArMywzOCBAQAogICA8aGVhZD4KICAgICA8dGl0bGU+Q2hlY2sgd2hldGhlciBz Y3JvbGxhYmxlIGlmcmFtZXMgYXJlIGluY2x1ZGVkIGluIHRoZSBzY3JvbGxpbmcgdHJlZSB3aGVu IGFzeW5jIGZyYW1lIHNjcm9sbGluZyBpcyBlbmFibGVkPC90aXRsZT4KICAgICA8c2NyaXB0Pgot ICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVy KSB7CiAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgICAgICAgdGVzdFJ1 bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgICB9CiAgICAgICBpZiAod2luZG93LmludGVybmFs cykKICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNldEFzeW5jRnJhbWVTY3Jv bGxpbmdFbmFibGVkKHRydWUpOwogICAgICAgZnVuY3Rpb24gZG9UZXN0KCkKICAgICAgIHsKICAg ICAgICAgICBpZiAod2luZG93LmludGVybmFscykKICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3Njcm9sbGluZ1RyZWUnKS5pbm5lclRleHQgPSB3aW5kb3cuaW50ZXJuYWxz LnNjcm9sbGluZ1N0YXRlVHJlZUFzVGV4dCgpICsgIlxuIjsKKyAgICAgICAgICBpZiAod2luZG93 LnRlc3RSdW5uZXIpCisgICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwogICAg ICAgfQotICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBkb1Rlc3QsIGZhbHNl KTsKICAgICA8L3NjcmlwdD4KKyAgICA8c3R5bGU+CisgICAgICBpZnJhbWUgeworICAgICAgICAg IHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICBsZWZ0OiAwOworICAgICAgICAgIHRvcDog MDsKKyAgICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgICAgaGVpZ2h0OiAyMDBweDsKKyAg ICAgICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKKyAgICAgICAgICBtYXJnaW46IDA7Cisg ICAgICAgICAgYm9yZGVyOiAwOworICAgICAgICAgIHBhZGRpbmc6IDA7CisgICAgICB9CisgICAg PC9zdHlsZT4KICAgPC9oZWFkPgogICA8Ym9keT4KLSAgICA8aWZyYW1lIGlkPSJmcmFtZSIgc3R5 bGU9IndpZHRoOiAxMDBweDsgaGVpZ2h0OiAyMDBweDsgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7 IiBzcmM9ImRhdGE6dGV4dC9odG1sLDxkaXYgc3R5bGU9J3dpZHRoOiAzMDBweDsgaGVpZ2h0OiA0 MDBweDsgYmFja2dyb3VuZDogZ3JheTsnPjwvZGl2PiI+PC9pZnJhbWU+CisgICAgPGlmcmFtZSBp ZD0iZnJhbWUiIG9ubG9hZD0iZG9UZXN0KCkiIHNyY2RvYz0iCisgICAgICAgIDxkaXYgc3R5bGU9 J3dpZHRoOiAzMDBweDsgaGVpZ2h0OiA0MDBweDsgYmFja2dyb3VuZDogZ3JheTsnPjwvZGl2PiI+ CisgICAgPC9pZnJhbWU+CiAgICAgPHByZSBpZD0ic2Nyb2xsaW5nVHJlZSI+PC9wcmU+CiAgIDwv Ym9keT4KIDwvaHRtbD4K 355481 2018-11-22 11:54:27 -0800 2018-11-22 12:33:00 -0800 Patch for landing bug-191912-20181122205426.patch text/plain 2966 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDQ5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjk3NTdmNTQ3NGUxYWMwY2FhYjEx ZWQ4MmI4NTY4ZWU0MDZlMmViNC4uYTllYjhlZTZlZDM3ZTViOGI1NDI1ZjY0MTMwMzlhYjI3MWMx NDY3MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTExLTIyICBGcmVkZXJpYyBXYW5nICA8 ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBJbXByb3ZlIGZhc3Qvc2Nyb2xsaW5nL3Njcm9s bGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTkxMgorCisgICAgICAgIFRoZXNlIGFyZSBzbWFsbCBp bXByb3ZlbWVudHMgdG8gc2Nyb2xsaW5nLXRyZWUtaW5jbHVkZXMtZnJhbWUuaHRtbDoKKyAgICAg ICAgLSBSdW4gZG9UZXN0KCkgYWZ0ZXIgdGhlIGlmcmFtZSBpcyBsb2FkZWQgYW5kIHVzZSB3YWl0 VW50aWxEb25lL25vdGlmeURvbmUgZm9yIG1vcmUgcmVsaWFibGUgdGltaW5nLgorICAgICAgICAt IFVzZSBpZnJhbWVAc3JjZG9jIGluc3RlYWQgb2YgaWZyYW1lQHNyYyBhbmQgcHV0IHRoZSBjb250 ZW50IG9mIHRoZSBpZnJhbWUgZG9jdW1lbnQgaW4gaXRzIG93biBsaW5lLgorICAgICAgICAtIE1v dmUgdGhlIGlmcmFtZSBzdHlsZSBpbiBhIHNlcGFyYXRlIDxzdHlsZT4gdGFnIGFuZCBlbnN1cmUg dGhlIGlmcmFtZSBpcyByZWFsbHkgcG9zaXRpb25lZCBhdCAoMCwwKQorICAgICAgICB3aXRoIG5v IGV4dHJhIG1hcmdpbi9wYWRkaW5nL2JvcmRlci4KKyAgICAgICAgLSBSZW1vdmUgdW5uZWNlc3Nh cnkgaWQ9ImZyYW1lIgorICAgICAgICBUaGUgdGVzdCBleHBlY3RhdGlvbiBpcyBub3QgY2hhbmdl ZC4KKworICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgorCisgICAgICAgICogZmFz dC9zY3JvbGxpbmcvc2Nyb2xsaW5nLXRyZWUtaW5jbHVkZXMtZnJhbWUuaHRtbDoKKwogMjAxOC0x MS0yMiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lG Q10gT2Zmc2V0IGZvcm1hdHRpbmcgY29udGV4dCByb290IHJ1bnMgd2l0aCBob3Jpem9udGFsIG1h cmdpbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3Njcm9sbGluZy9zY3JvbGxpbmct dHJlZS1pbmNsdWRlcy1mcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcvc2Ny b2xsaW5nLXRyZWUtaW5jbHVkZXMtZnJhbWUuaHRtbAppbmRleCBjOTYxNDY4YWExN2I5NDFjYzVk ZGE1ZDYzYmJjMDA0N2M1Y2Y1ZmY4Li40YmIyZDE5MDAwNTYxMjBlNDUwMDk1ZjQyMzdjY2QyNWY0 ZmQ1ZjkxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3Njcm9sbGluZy9zY3JvbGxpbmct dHJlZS1pbmNsdWRlcy1mcmFtZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5n L3Njcm9sbGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwKQEAgLTMsMjAgKzMsMzcgQEAKICAg PGhlYWQ+CiAgICAgPHRpdGxlPkNoZWNrIHdoZXRoZXIgc2Nyb2xsYWJsZSBpZnJhbWVzIGFyZSBp bmNsdWRlZCBpbiB0aGUgc2Nyb2xsaW5nIHRyZWUgd2hlbiBhc3luYyBmcmFtZSBzY3JvbGxpbmcg aXMgZW5hYmxlZDwvdGl0bGU+CiAgICAgPHNjcmlwdD4KLSAgICAgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikKKyAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAgICAgICAgIHRlc3RSdW5u ZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOwor ICAgICAgfQogICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCiAgICAgICAgICAgd2luZG93Lmlu dGVybmFscy5zZXR0aW5ncy5zZXRBc3luY0ZyYW1lU2Nyb2xsaW5nRW5hYmxlZCh0cnVlKTsKICAg ICAgIGZ1bmN0aW9uIGRvVGVzdCgpCiAgICAgICB7CiAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRl cm5hbHMpCiAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzY3JvbGxpbmdU cmVlJykuaW5uZXJUZXh0ID0gd2luZG93LmludGVybmFscy5zY3JvbGxpbmdTdGF0ZVRyZWVBc1Rl eHQoKSArICJcbiI7CisgICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAg ICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKICAgICAgIH0KLSAgICAgIHdpbmRvdy5hZGRF dmVudExpc3RlbmVyKCdsb2FkJywgZG9UZXN0LCBmYWxzZSk7CiAgICAgPC9zY3JpcHQ+CisgICAg PHN0eWxlPgorICAgICAgaWZyYW1lIHsKKyAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7Cisg ICAgICAgICAgbGVmdDogMDsKKyAgICAgICAgICB0b3A6IDA7CisgICAgICAgICAgd2lkdGg6IDEw MHB4OworICAgICAgICAgIGhlaWdodDogMjAwcHg7CisgICAgICAgICAgbWFyZ2luOiAwOworICAg ICAgICAgIGJvcmRlcjogMDsKKyAgICAgICAgICBwYWRkaW5nOiAwOworICAgICAgfQorICAgIDwv c3R5bGU+CiAgIDwvaGVhZD4KICAgPGJvZHk+Ci0gICAgPGlmcmFtZSBpZD0iZnJhbWUiIHN0eWxl PSJ3aWR0aDogMTAwcHg7IGhlaWdodDogMjAwcHg7IGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOyIg c3JjPSJkYXRhOnRleHQvaHRtbCw8ZGl2IHN0eWxlPSd3aWR0aDogMzAwcHg7IGhlaWdodDogNDAw cHg7IGJhY2tncm91bmQ6IGdyYXk7Jz48L2Rpdj4iPjwvaWZyYW1lPgorICAgIDxpZnJhbWUgb25s b2FkPSJkb1Rlc3QoKSIgc3JjZG9jPSIKKyAgICAgICAgPGRpdiBzdHlsZT0nd2lkdGg6IDMwMHB4 OyBoZWlnaHQ6IDQwMHB4OyBiYWNrZ3JvdW5kOiBncmF5Oyc+PC9kaXY+Ij4KKyAgICA8L2lmcmFt ZT4KICAgICA8cHJlIGlkPSJzY3JvbGxpbmdUcmVlIj48L3ByZT4KICAgPC9ib2R5PgogPC9odG1s Pgo=