191795 2018-11-16 16:57:02 -0800 ProcessSwap.NavigationWithLockedHistoryWithoutPSON API test is a flaky crash in debug 2018-11-16 18:27:34 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 191781 1 cdumez cdumez achristensen cdumez commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1479752 0 cdumez 2018-11-16 16:57:02 -0800 ProcessSwap.NavigationWithLockedHistoryWithoutPSON API test is a flaky crash in debug: TestWebKitAPI.ProcessSwap.NavigationWithLockedHistoryWithoutPSON _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. Received data during response processing, queuing it. Received data during response processing, queuing it. _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. ASSERTION FAILED: process->hasOneRef() /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebProcessPool.cpp(344) : virtual WebKit::WebProcessPool::~WebProcessPool() 1 0x10cff1b59 WTFCrash 2 0x11305395b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1139b0441 WebKit::WebProcessPool::~WebProcessPool() 4 0x1139b1d35 WebKit::WebProcessPool::~WebProcessPool() 5 0x113647b8e -[WKProcessPool dealloc] 6 0x113686cc6 WTF::RetainPtr<WKProcessPool>::~RetainPtr() 7 0x113686c55 WTF::RetainPtr<WKProcessPool>::~RetainPtr() 8 0x113686c39 LazyInitialized<WTF::RetainPtr<WKProcessPool> >::~LazyInitialized() 9 0x11367bfd5 LazyInitialized<WTF::RetainPtr<WKProcessPool> >::~LazyInitialized() 10 0x11367bebf -[WKWebViewConfiguration .cxx_destruct] 11 0x7fff5e4d51f5 object_cxxDestructFromClass(objc_object*, objc_class*) 12 0x7fff5e4cd9f0 objc_destructInstance 13 0x7fff5e4cd992 object_dispose 14 0x1136933f6 WTF::RetainPtr<WKWebViewConfiguration>::~RetainPtr() 15 0x11366fdb5 WTF::RetainPtr<WKWebViewConfiguration>::~RetainPtr() 16 0x11366fd48 -[WKWebView .cxx_destruct] 17 0x7fff5e4d51f5 object_cxxDestructFromClass(objc_object*, objc_class*) 18 0x7fff5e4cd9f0 objc_destructInstance 19 0x7fff5e4cd992 object_dispose 20 0x7fff2f970849 -[NSResponder dealloc] 21 0x7fff2f96ebb4 -[NSView dealloc] 22 0x113663e6e -[WKWebView dealloc] 23 0x7fff5e4ce7c2 (anonymous namespace)::AutoreleasePoolPage::pop(void*) 24 0x7fff322f8d42 _CFAutoreleasePoolPop 25 0x7fff346c396e -[NSAutoreleasePool drain] 26 0x10c34b297 main 27 0x7fff5f5a108d start 28 0x2 1479755 1 355164 cdumez 2018-11-16 17:03:07 -0800 Created attachment 355164 Patch 1479756 2 355164 rniwa 2018-11-16 17:05:19 -0800 Comment on attachment 355164 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355164&action=review > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:212 > + else > + reply.second({ }); Why do we need to do this? 1479757 3 cdumez 2018-11-16 17:06:04 -0800 (In reply to Ryosuke Niwa from comment #2) > Comment on attachment 355164 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355164&action=review > > > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:212 > > + else > > + reply.second({ }); > > Why do we need to do this? It is a CompletionHandler, it needs to be called or it will ASSERT in its destructor. 1479791 4 355164 commit-queue 2018-11-16 18:26:14 -0800 Comment on attachment 355164 Patch Clearing flags on attachment: 355164 Committed r238335: <https://trac.webkit.org/changeset/238335> 1479792 5 commit-queue 2018-11-16 18:26:16 -0800 All reviewed patches have been landed. Closing bug. 1479793 6 webkit-bug-importer 2018-11-16 18:27:34 -0800 <rdar://problem/46145919> 355164 2018-11-16 17:03:07 -0800 2018-11-16 18:26:14 -0800 Patch bug-191795-20181116170305.patch text/plain 5113 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGEwMjA5ZjYzYmZkNzE2NjFl YzYyZWU4Y2NlOTI3OTMxNTU0Yzg1ZTkuLmY2ZWRmNjJhMTZkYmNjNWY4N2ZmZTE3NGRiZDg5MDQ3 NDRjZmE1OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMTEtMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBQcm9jZXNzU3dhcC5OYXZpZ2F0aW9u V2l0aExvY2tlZEhpc3RvcnlXaXRob3V0UFNPTiBBUEkgdGVzdCBpcyBhIGZsYWt5IGNyYXNoIGlu IGRlYnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTE3OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ ZiB0aGUgV2ViUHJvY2Vzc1Bvb2wgaXMgZ2V0dGluZyBkZXN0cm95ZWQgd2hpbGUgdGhlcmUgaXMg YSBwcmV3YXJtZWQgV2ViQ29udGVudCBwcm9jZXNzCisgICAgICAgIHRoYXQgaXMgYXdhaXRpbmcg aXRzIGNvbm5uZWN0aW9uIHRvIHRoZSBuZXR3b3JrIHByb2Nlc3MsIHRoZW4gd2UnbGwgaGl0IHRo ZQorICAgICAgICBwcm9jZXNzLT5oYXNPbmVSZWYoKSBhc3NlcnRpb24gaW4gdGhlIFdlYlByb2Nl c3NQb29sIGRlc3RydWN0b3IuIFRoaXMgaXMgYmVjYXVzZQorICAgICAgICBOZXR3b3JrUHJvY2Vz c1Byb3h5OjptX3BlbmRpbmdDb25uZWN0aW9uUmVwbGllcyBrZWVwcyBhIFJlZlB0ciB0byB0aGUg V2ViUHJvY2Vzc1Byb3h5CisgICAgICAgIHRoYXQgaXMgYXdhaXRpbmcgdGhlIGNvbm5lY3Rpb24u IFRoZSBOZXR3b3JrUHJvY2Vzc1Byb3h5IGRvZXMgbm90IHJlYWxseSBuZWVkIHRvIGtlZXAKKyAg ICAgICAgdGhlIFdlYlByb2Nlc3NQcm94eSBhbGl2ZSBpbiB0aGlzIGNhc2Ugc28gdGhpcyBwYXRj aCBzd2l0Y2hlcyB0byB1c2luZyBhIFdlYWtQdHIgaW5zdGVhZC4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpO ZXR3b3JrUHJvY2Vzc1Byb3h5OjpnZXROZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24pOgorICAgICAg ICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc1Byb3h5OjpuZXR3b3JrUHJvY2Vzc0NyYXNoZWQpOgor ICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5Lmg6CisKIDIwMTgtMTEtMTYgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0g QWRkICJXZWJLaXREZXZpY2VJbmZvUGVybWlzc2lvblJlcXVlc3QuaCIgaW50byB3ZWJraXQyLmgK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nl c3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9j ZXNzUHJveHkuY3BwCmluZGV4IGUxMDdmNWIyNjZlMjFjMmFjYzgzOTNkYzk3NGM5ZDkxZThmNTY3 ZmYuLmYwYjYxMzJhNGNjMjM3YjdjYTc5YWVhNjZjNDA3MTQ2ZGI1NGVhZGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5 LmNwcApAQCAtMTE4LDcgKzExOCw3IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3NQcm94eTo6cHJvY2Vz c1dpbGxTaHV0RG93bihJUEM6OkNvbm5lY3Rpb24mIGNvbm5lY3Rpb24pCiAKIHZvaWQgTmV0d29y a1Byb2Nlc3NQcm94eTo6Z2V0TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uKFdlYlByb2Nlc3NQcm94 eSYgd2ViUHJvY2Vzc1Byb3h5LCBNZXNzYWdlczo6V2ViUHJvY2Vzc1Byb3h5OjpHZXROZXR3b3Jr UHJvY2Vzc0Nvbm5lY3Rpb246OkRlbGF5ZWRSZXBseSYmIHJlcGx5KQogewotICAgIG1fcGVuZGlu Z0Nvbm5lY3Rpb25SZXBsaWVzLmFwcGVuZChzdGQ6Om1ha2VfcGFpcigmd2ViUHJvY2Vzc1Byb3h5 LCBXVEZNb3ZlKHJlcGx5KSkpOworICAgIG1fcGVuZGluZ0Nvbm5lY3Rpb25SZXBsaWVzLmFwcGVu ZChzdGQ6Om1ha2VfcGFpcihtYWtlV2Vha1B0cih3ZWJQcm9jZXNzUHJveHkpLCBXVEZNb3ZlKHJl cGx5KSkpOwogCiAgICAgaWYgKHN0YXRlKCkgPT0gU3RhdGU6OkxhdW5jaGluZykgewogICAgICAg ICBtX251bVBlbmRpbmdDb25uZWN0aW9uUmVxdWVzdHMrKzsKQEAgLTIwNSw4ICsyMDUsMTIgQEAg dm9pZCBOZXR3b3JrUHJvY2Vzc1Byb3h5OjpuZXR3b3JrUHJvY2Vzc0NyYXNoZWQoKQogCiAgICAg VmVjdG9yPHN0ZDo6cGFpcjxSZWZQdHI8V2ViUHJvY2Vzc1Byb3h5PiwgTWVzc2FnZXM6OldlYlBy b2Nlc3NQcm94eTo6R2V0TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uOjpEZWxheWVkUmVwbHk+PiBw ZW5kaW5nUmVwbGllczsKICAgICBwZW5kaW5nUmVwbGllcy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5 KG1fcGVuZGluZ0Nvbm5lY3Rpb25SZXBsaWVzLnNpemUoKSk7Ci0gICAgZm9yIChhdXRvJiByZXBs eSA6IG1fcGVuZGluZ0Nvbm5lY3Rpb25SZXBsaWVzKQotICAgICAgICBwZW5kaW5nUmVwbGllcy5h cHBlbmQoV1RGTW92ZShyZXBseSkpOworICAgIGZvciAoYXV0byYgcmVwbHkgOiBtX3BlbmRpbmdD b25uZWN0aW9uUmVwbGllcykgeworICAgICAgICBpZiAocmVwbHkuZmlyc3QpCisgICAgICAgICAg ICBwZW5kaW5nUmVwbGllcy5hcHBlbmQoc3RkOjptYWtlX3BhaXIobWFrZVJlZlB0cihyZXBseS5m aXJzdC5nZXQoKSksIFdURk1vdmUocmVwbHkuc2Vjb25kKSkpOworICAgICAgICBlbHNlCisgICAg ICAgICAgICByZXBseS5zZWNvbmQoeyB9KTsKKyAgICB9CiAKICAgICAvLyBUZWxsIHRoZSBuZXR3 b3JrIHByb2Nlc3MgbWFuYWdlciB0byBmb3JnZXQgYWJvdXQgdGhpcyBuZXR3b3JrIHByb2Nlc3Mg cHJveHkuIFRoaXMgd2lsbCBjYXVzZSB1cyB0byBiZSBkZWxldGVkLgogICAgIG1fcHJvY2Vzc1Bv b2wubmV0d29ya1Byb2Nlc3NDcmFzaGVkKCp0aGlzLCBXVEZNb3ZlKHBlbmRpbmdSZXBsaWVzKSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9j ZXNzUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nl c3NQcm94eS5oCmluZGV4IDMzMjQwZTNkYWMzMjI5YTEyOWUyODdlODNjNDdmMTZlMzJlMTcwZTIu LjU0OTViZTM5MTRhNGMyNjA3YjVhODE0ZmUwZjdiNjcxYTA2NWRiMzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5oCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5oCkBA IC0xNzUsNyArMTc1LDcgQEAgcHJpdmF0ZToKICAgICBXZWJQcm9jZXNzUG9vbCYgbV9wcm9jZXNz UG9vbDsKICAgICAKICAgICB1bnNpZ25lZCBtX251bVBlbmRpbmdDb25uZWN0aW9uUmVxdWVzdHM7 Ci0gICAgRGVxdWU8c3RkOjpwYWlyPFJlZlB0cjxXZWJQcm9jZXNzUHJveHk+LCBNZXNzYWdlczo6 V2ViUHJvY2Vzc1Byb3h5OjpHZXROZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb246OkRlbGF5ZWRSZXBs eT4+IG1fcGVuZGluZ0Nvbm5lY3Rpb25SZXBsaWVzOworICAgIERlcXVlPHN0ZDo6cGFpcjxXZWFr UHRyPFdlYlByb2Nlc3NQcm94eT4sIE1lc3NhZ2VzOjpXZWJQcm9jZXNzUHJveHk6OkdldE5ldHdv cmtQcm9jZXNzQ29ubmVjdGlvbjo6RGVsYXllZFJlcGx5Pj4gbV9wZW5kaW5nQ29ubmVjdGlvblJl cGxpZXM7CiAKICAgICBIYXNoTWFwPHVpbnQ2NF90LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKFdl YnNpdGVEYXRhKT4+IG1fcGVuZGluZ0ZldGNoV2Vic2l0ZURhdGFDYWxsYmFja3M7CiAgICAgSGFz aE1hcDx1aW50NjRfdCwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPj4gbV9wZW5kaW5nRGVsZXRl V2Vic2l0ZURhdGFDYWxsYmFja3M7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQcm9jZXNzUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQ cm94eS5oCmluZGV4IDdiZWI5NTE2NjU1NzI2NTQxOWQzZGE5MzIzZTQ4OWE5OTRkMGNlMzkuLjYx NjlhZDczMjg0MzNiNjUzZGM4NGQ3Y2Q1YjI0NWY3ZDhlNzU3YzUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5oCkBAIC05NCw3ICs5NCw3IEBAIHR5cGVkZWYgUmVm Q291bnRlcjxCYWNrZ3JvdW5kV2ViUHJvY2Vzc0NvdW50ZXJUeXBlPiBCYWNrZ3JvdW5kV2ViUHJv Y2Vzc0NvdW50ZXI7CiB0eXBlZGVmIEJhY2tncm91bmRXZWJQcm9jZXNzQ291bnRlcjo6VG9rZW4g QmFja2dyb3VuZFdlYlByb2Nlc3NUb2tlbjsKICNlbmRpZgogCi1jbGFzcyBXZWJQcm9jZXNzUHJv eHkgOiBwdWJsaWMgQ2hpbGRQcm9jZXNzUHJveHksIHB1YmxpYyBSZXNwb25zaXZlbmVzc1RpbWVy OjpDbGllbnQsIHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxXZWJQcm9jZXNzUHJveHk+LCBw cml2YXRlIFByb2Nlc3NUaHJvdHRsZXJDbGllbnQgeworY2xhc3MgV2ViUHJvY2Vzc1Byb3h5IDog cHVibGljIENoaWxkUHJvY2Vzc1Byb3h5LCBwdWJsaWMgUmVzcG9uc2l2ZW5lc3NUaW1lcjo6Q2xp ZW50LCBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8V2ViUHJvY2Vzc1Byb3h5PiwgcHVibGlj IENhbk1ha2VXZWFrUHRyPFdlYlByb2Nlc3NQcm94eT4sIHByaXZhdGUgUHJvY2Vzc1Rocm90dGxl ckNsaWVudCB7CiBwdWJsaWM6CiAgICAgdHlwZWRlZiBIYXNoTWFwPHVpbnQ2NF90LCBSZWZQdHI8 V2ViRnJhbWVQcm94eT4+IFdlYkZyYW1lUHJveHlNYXA7CiAgICAgdHlwZWRlZiBIYXNoTWFwPHVp bnQ2NF90LCBXZWJQYWdlUHJveHkqPiBXZWJQYWdlUHJveHlNYXA7Cg==