191790 2018-11-16 16:22:40 -0800 [ews-app] Set Foreign Keys in EWS Django app models 2019-02-14 13:27:51 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194667 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1479725 0 aakash_jain 2018-11-16 16:22:40 -0800 Fix TODO for configuring Foreign Keys in EWS Django app models. 1479728 1 355157 aakash_jain 2018-11-16 16:24:08 -0800 Created attachment 355157 Proposed patch 1479750 2 355157 kocsen_chung 2018-11-16 16:53:26 -0800 Comment on attachment 355157 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355157&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/steps.py:-30 > - buildid = models.IntegerField() # TODO: set foreign key Nit: May be too late now but if should we make it `build_id` instead of `buildid`. 1481293 3 355157 aakash_jain 2018-11-24 05:22:10 -0800 Comment on attachment 355157 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355157&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/steps.py:-30 >> - buildid = models.IntegerField() # TODO: set foreign key > > Nit: May be too late now but if should we make it `build_id` instead of `buildid`. This patch already deleted buildid variable, and adds 'build'. Django internally seems to convert build to build_id as it is used as a ForeignKey. 1481665 4 aakash_jain 2018-11-26 13:45:11 -0800 Committed r238518: <https://trac.webkit.org/changeset/238518> 1481666 5 webkit-bug-importer 2018-11-26 13:46:31 -0800 <rdar://problem/46255319> 355157 2018-11-16 16:24:08 -0800 2018-11-26 12:45:08 -0800 Proposed patch ews-app_foreign_key.patch text/plain 2283 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODMyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTExLTE2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gU2V0IEZvcmVpZ24gS2V5cyBpbiBFV1MgRGphbmdvIGFw cCBtb2RlbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MTc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkcy5weTogU2V0IEZv cmVpZ24gS2V5LgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVs cy9zdGVwcy5weTogRGl0dG8uCisKIDIwMTgtMTEtMTYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uKFBTT04pIFdlYktpdC5HZW9sb2NhdGlvblRy YW5zaXRpb25Ub0hpZ2hBY2N1cmFjeSBBUEkgdGVzdCBpcyB0aW1pbmcgb3V0CkluZGV4OiBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGRzLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZHMu cHkJKHJldmlzaW9uIDIzODMyMykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAv ZXdzL21vZGVscy9idWlsZHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTIzLDEwICsyMywxMSBAQAog ZnJvbSBfX2Z1dHVyZV9fIGltcG9ydCB1bmljb2RlX2xpdGVyYWxzCiAKIGZyb20gZGphbmdvLmRi IGltcG9ydCBtb2RlbHMKK2Zyb20gZXdzLm1vZGVscy5wYXRjaCBpbXBvcnQgUGF0Y2gKIAogCiBj bGFzcyBCdWlsZHMobW9kZWxzLk1vZGVsKToKLSAgICBwYXRjaGlkID0gbW9kZWxzLkludGVnZXJG aWVsZCgpICAjIFRPRE86IHNldCBmb3JlaWduIGtleQorICAgIHBhdGNoID0gbW9kZWxzLkZvcmVp Z25LZXkoUGF0Y2gsIG9uX2RlbGV0ZT1tb2RlbHMuQ0FTQ0FERSkKICAgICBidWlsZGlkID0gbW9k ZWxzLkludGVnZXJGaWVsZChwcmltYXJ5X2tleT1UcnVlKQogICAgIGJ1aWxkZXJpZCA9IG1vZGVs cy5JbnRlZ2VyRmllbGQoKQogICAgIG51bWJlciA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQpJbmRl eDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXBzLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9z dGVwcy5weQkocmV2aXNpb24gMjM4MzIzKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWFwcC9ld3MvbW9kZWxzL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMywxMSArMjMsMTIg QEAKIGZyb20gX19mdXR1cmVfXyBpbXBvcnQgdW5pY29kZV9saXRlcmFscwogCiBmcm9tIGRqYW5n by5kYiBpbXBvcnQgbW9kZWxzCitmcm9tIGV3cy5tb2RlbHMuYnVpbGRzIGltcG9ydCBCdWlsZHMK IAogCiBjbGFzcyBTdGVwcyhtb2RlbHMuTW9kZWwpOgogICAgIHN0ZXBpZCA9IG1vZGVscy5JbnRl Z2VyRmllbGQocHJpbWFyeV9rZXk9VHJ1ZSkKLSAgICBidWlsZGlkID0gbW9kZWxzLkludGVnZXJG aWVsZCgpICAjIFRPRE86IHNldCBmb3JlaWduIGtleQorICAgIGJ1aWxkID0gbW9kZWxzLkZvcmVp Z25LZXkoQnVpbGRzLCBvbl9kZWxldGU9bW9kZWxzLkNBU0NBREUpCiAgICAgcmVzdWx0ID0gbW9k ZWxzLkludGVnZXJGaWVsZCgpCiAgICAgc3RhdGVfc3RyaW5nID0gbW9kZWxzLlRleHRGaWVsZCgp CiAgICAgc3RhcnRlZF9hdCA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQpAQCAtMzYsNCArMzcsNCBA QCBjbGFzcyBTdGVwcyhtb2RlbHMuTW9kZWwpOgogICAgIG1vZGlmaWVkID0gbW9kZWxzLkRhdGVU aW1lRmllbGQoYXV0b19ub3c9VHJ1ZSkKIAogICAgIGRlZiBfX3N0cl9fKHNlbGYpOgotICAgICAg ICByZXR1cm4gc3RyKHNlbGYuYnVpbGRpZCkKKyAgICAgICAgcmV0dXJuIHN0cihzZWxmLnN0ZXBp ZCkK