191766 2018-11-16 12:51:51 -0800 Web Inspector: TreeOutline shouldn't select first child of an expanded element on right arrow key 2018-11-28 15:08:11 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All REOPENED https://bugs.webkit.org/show_bug.cgi?id=191483 InRadar P4 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1479571 0 mattbaker 2018-11-16 12:51:51 -0800 Summary: TreeOutline shouldn't select first child of an expanded element on right arrow key. Steps to Reproduce: 1. Select a tree element with at least one child 2. Expand the tree element 3. Press Right Arrow key => Selection moves to first child. In Finder and Xcode, the selection does not change. We should continue to do the following behaviors, which match the system: - Pressing the Left Arrow key when the first child of an expanded item is selected moves the selection up to the parent - Pressing the Right Arrow key when an item is collapsed expands the item 1479572 1 355104 mattbaker 2018-11-16 12:53:18 -0800 Created attachment 355104 Patch 1479588 2 355104 hi 2018-11-16 13:34:42 -0800 Comment on attachment 355104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355104&action=review rs=me Should we do anything special if the folder is already expanded? It seems like in that case we’d effectively be doing nothing. I suppose I’d that’s what the system does then it’s better to match 🤔 > Source/WebInspectorUI/ChangeLog:10 > + Match system behavior. This comment isn’t descriptive. Either remove it or make it more explanatory. 1479607 3 355117 mattbaker 2018-11-16 14:03:55 -0800 Created attachment 355117 Patch for landing 1479610 4 mattbaker 2018-11-16 14:07:47 -0800 (In reply to Devin Rousso from comment #2) > Comment on attachment 355104 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355104&action=review > > rs=me > > Should we do anything special if the folder is already expanded? It seems > like in that case we’d effectively be doing nothing. I suppose I’d that’s > what the system does then it’s better to match 🤔 Doing nothing on Right Arrow when the selected item is expanded is precisely the system behavior being followed. It's curious that the opposite - selecting the parent on Left Arrow when the first child is selected - is the system behavior. 🤔 1479645 5 355117 commit-queue 2018-11-16 14:45:22 -0800 Comment on attachment 355117 Patch for landing Clearing flags on attachment: 355117 Committed r238305: <https://trac.webkit.org/changeset/238305> 1479646 6 commit-queue 2018-11-16 14:45:24 -0800 All reviewed patches have been landed. Closing bug. 1479647 7 webkit-bug-importer 2018-11-16 14:45:54 -0800 <rdar://problem/46140393> 1479649 8 webkit-bug-importer 2018-11-16 14:46:00 -0800 <rdar://problem/46140392> 1482683 9 hi 2018-11-28 15:04:18 -0800 This was undone by r238599 <https://webkit.org/b/191483>. 355104 2018-11-16 12:53:18 -0800 2018-11-16 14:03:53 -0800 Patch bug-191766-20181116125313.patch text/plain 1955 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ODQyOGJmOWNjZDE4YjU2NDVmNmUwNmJjODcyZWNiMjNlMWNiMjZmLi45N2RiYTc3M2YwNzIzYzNk YzNlMWNmOGI1YTI4MzM2NTlhNDE5NGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0xMS0xNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVHJlZU91dGxpbmUgc2hvdWxkbid0IHNlbGVjdCBm aXJzdCBjaGlsZCBvZiBhbiBleHBhbmRlZCBlbGVtZW50IG9uIHJpZ2h0IGFycm93IGtleQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNzY2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV0kuVHJlZU91dGxpbmUucHJvdG90 eXBlLl90cmVlS2V5RG93bik6CisgICAgICAgIE1hdGNoIHN5c3RlbSBiZWhhdmlvci4KKwogMjAx OC0xMS0xNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogVGFibGUgc2hvdWxkIHJlY2FsY3VsYXRlIHNjcm9sbGFibGUgaGVpZ2h0IHdo ZW4gcmVzaXplZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcwppbmRleCA4ZWMzZjk5ZTcxMzhkZGM0ZTEzYzg3Yzky NjQyNTc0NjU3NmQxOWJiLi4yMWFjM2MyMjdkZDYzMWRlNmYzNzk4MjdmYzE4NzgxNWM5MmMxYzk2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9U cmVlT3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UcmVlT3V0bGluZS5qcwpAQCAtNTYzLDEyICs1NjMsNyBAQCBXSS5UcmVlT3V0bGluZSA9 IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICAgICAgaGFu ZGxlZCA9IHRydWU7CiAgICAgICAgICAgICB9IGVsc2UgaWYgKHRoaXMuc2VsZWN0ZWRUcmVlRWxl bWVudC5oYXNDaGlsZHJlbikgewogICAgICAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOwotICAg ICAgICAgICAgICAgIGlmICh0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQuZXhwYW5kZWQpIHsKLSAg ICAgICAgICAgICAgICAgICAgbmV4dFNlbGVjdGVkRWxlbWVudCA9IHRoaXMuc2VsZWN0ZWRUcmVl RWxlbWVudC5jaGlsZHJlblswXTsKLSAgICAgICAgICAgICAgICAgICAgd2hpbGUgKG5leHRTZWxl Y3RlZEVsZW1lbnQgJiYgIW5leHRTZWxlY3RlZEVsZW1lbnQuc2VsZWN0YWJsZSkKLSAgICAgICAg ICAgICAgICAgICAgICAgIG5leHRTZWxlY3RlZEVsZW1lbnQgPSBuZXh0U2VsZWN0ZWRFbGVtZW50 Lm5leHRTaWJsaW5nOwotICAgICAgICAgICAgICAgICAgICBoYW5kbGVkID0gbmV4dFNlbGVjdGVk RWxlbWVudCA/IHRydWUgOiBmYWxzZTsKLSAgICAgICAgICAgICAgICB9IGVsc2UgeworICAgICAg ICAgICAgICAgIGlmICghdGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50LmV4cGFuZGVkKSB7CiAgICAg ICAgICAgICAgICAgICAgIGlmIChldmVudC5hbHRLZXkpCiAgICAgICAgICAgICAgICAgICAgICAg ICB0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQuZXhwYW5kUmVjdXJzaXZlbHkoKTsKICAgICAgICAg ICAgICAgICAgICAgZWxzZQo= 355117 2018-11-16 14:03:55 -0800 2018-11-16 14:45:22 -0800 Patch for landing bug-191766-20181116140349.patch text/plain 1921 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ODQyOGJmOWNjZDE4YjU2NDVmNmUwNmJjODcyZWNiMjNlMWNiMjZmLi4zNzdjNzYxZWMwMzE3NGQ0 OGNkOTA0ZmY5MGQwYzU2YjY4ZjQ3ZjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0xMS0xNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVHJlZU91dGxpbmUgc2hvdWxkbid0IHNlbGVjdCBm aXJzdCBjaGlsZCBvZiBhbiBleHBhbmRlZCBlbGVtZW50IG9uIHJpZ2h0IGFycm93IGtleQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNzY2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9UcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdJLlRyZWVPdXRsaW5lLnByb3RvdHlw ZS5fdHJlZUtleURvd24pOgorCiAyMDE4LTExLTE0ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBUYWJsZSBzaG91bGQgcmVjYWxjdWxh dGUgc2Nyb2xsYWJsZSBoZWlnaHQgd2hlbiByZXNpemVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCmluZGV4IDhl YzNmOTllNzEzOGRkYzRlMTNjODdjOTI2NDI1NzQ2NTc2ZDE5YmIuLjIxYWMzYzIyN2RkNjMxZGU2 ZjM3OTgyN2ZjMTg3ODE1YzkyYzFjOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCkBAIC01NjMsMTIgKzU2 Myw3IEBAIFdJLlRyZWVPdXRsaW5lID0gY2xhc3MgVHJlZU91dGxpbmUgZXh0ZW5kcyBXSS5PYmpl Y3QKICAgICAgICAgICAgICAgICBoYW5kbGVkID0gdHJ1ZTsKICAgICAgICAgICAgIH0gZWxzZSBp ZiAodGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50Lmhhc0NoaWxkcmVuKSB7CiAgICAgICAgICAgICAg ICAgaGFuZGxlZCA9IHRydWU7Ci0gICAgICAgICAgICAgICAgaWYgKHRoaXMuc2VsZWN0ZWRUcmVl RWxlbWVudC5leHBhbmRlZCkgewotICAgICAgICAgICAgICAgICAgICBuZXh0U2VsZWN0ZWRFbGVt ZW50ID0gdGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50LmNoaWxkcmVuWzBdOwotICAgICAgICAgICAg ICAgICAgICB3aGlsZSAobmV4dFNlbGVjdGVkRWxlbWVudCAmJiAhbmV4dFNlbGVjdGVkRWxlbWVu dC5zZWxlY3RhYmxlKQotICAgICAgICAgICAgICAgICAgICAgICAgbmV4dFNlbGVjdGVkRWxlbWVu dCA9IG5leHRTZWxlY3RlZEVsZW1lbnQubmV4dFNpYmxpbmc7Ci0gICAgICAgICAgICAgICAgICAg IGhhbmRsZWQgPSBuZXh0U2VsZWN0ZWRFbGVtZW50ID8gdHJ1ZSA6IGZhbHNlOwotICAgICAgICAg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgaWYgKCF0aGlzLnNlbGVjdGVkVHJlZUVs ZW1lbnQuZXhwYW5kZWQpIHsKICAgICAgICAgICAgICAgICAgICAgaWYgKGV2ZW50LmFsdEtleSkK ICAgICAgICAgICAgICAgICAgICAgICAgIHRoaXMuc2VsZWN0ZWRUcmVlRWxlbWVudC5leHBhbmRS ZWN1cnNpdmVseSgpOwogICAgICAgICAgICAgICAgICAgICBlbHNlCg==