191553 2018-11-12 10:45:53 -0800 Web Inspector: Canvas: don't start with auto-capture enabled 2018-12-05 21:32:11 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190856 173807 175485 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1477633 0 hi 2018-11-12 10:45:53 -0800 If the user has previously turned off auto-capture but still had a non-zero frame count, opening the Canvas tab shouldn't re-enable auto-capture. 1477635 1 354569 hi 2018-11-12 10:48:27 -0800 Created attachment 354569 Patch 1477663 2 354569 mattbaker 2018-11-12 11:55:35 -0800 Comment on attachment 354569 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354569&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js:226 > this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width", (textMetrics.width + 8) + "px"); Out of curiosity, where does the 8px come from? It looks like it comes from canvasOverviewContentView.css:184: .navigation-bar > .item.canvas-recording-auto-capture > label > input { width: 1.5em; min-width: 1.5em; margin: 0 4px; text-align: center; } If so this should be a const, with a comment warning to keep it in sync with the stylesheet. I know this is off topic for this patch, but I noticed it while reading the file for context. 1478378 3 354791 hi 2018-11-14 03:23:13 -0800 Created attachment 354791 Patch 1478384 4 354791 commit-queue 2018-11-14 04:01:39 -0800 Comment on attachment 354791 Patch Clearing flags on attachment: 354791 Committed r238169: <https://trac.webkit.org/changeset/238169> 1478385 5 commit-queue 2018-11-14 04:01:40 -0800 All reviewed patches have been landed. Closing bug. 1478386 6 webkit-bug-importer 2018-11-14 04:02:37 -0800 <rdar://problem/46059298> 354569 2018-11-12 10:48:27 -0800 2018-11-14 03:23:11 -0800 Patch 191553.txt text/plain 1823 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkwOTIxYWE4ODI1Li4yZDRmYjk0NjU0YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTEtMTEgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENh bnZhczogZG9uJ3Qgc3RhcnQgd2l0aCBhdXRvLWNhcHR1cmUgZW5hYmxlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNTUzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L0NhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5DYW52YXNPdmVydmll d0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fdXBkYXRlUmVjb3JkaW5nQXV0b0NhcHR1cmVJbnB1dEVs ZW1lbnRTaXplKToKKyAgICAgICAgKFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcucHJvdG90 eXBlLl9oYW5kbGVSZWNvcmRpbmdBdXRvQ2FwdHVyZUlucHV0KToKKwogMjAxOC0xMS0xMSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog TmV0d29yazogYWRkIGJ1dHRvbiB0byBzaG93IHN5c3RlbSBjZXJ0aWZpY2F0ZSBkaWFsb2cKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZh c092ZXJ2aWV3Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LmpzCmluZGV4IDJhNzUwYzEyMDI0 Li40NDMwYThkNTQ3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ2FudmFzT3ZlcnZpZXdDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3 LmpzCkBAIC0yMjYsMTIgKzIyNiwxNCBAQCBXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3ID0g Y2xhc3MgQ2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbGxlYwogICAgICAg ICAgICAgdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50LnN0 eWxlLnNldFByb3BlcnR5KCJ3aWR0aCIsICh0ZXh0TWV0cmljcy53aWR0aCArIDgpICsgInB4Iik7 CiAgICAgICAgIH0pOwogCi0gICAgICAgIHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlTmF2aWdh dGlvbkl0ZW0uY2hlY2tlZCA9ICEhZnJhbWVDb3VudDsKKyAgICAgICAgcmV0dXJuIGZyYW1lQ291 bnQ7CiAgICAgfQogCiAgICAgX2hhbmRsZVJlY29yZGluZ0F1dG9DYXB0dXJlSW5wdXQoZXZlbnQp CiAgICAgewotICAgICAgICB0aGlzLl91cGRhdGVSZWNvcmRpbmdBdXRvQ2FwdHVyZUlucHV0RWxl bWVudFNpemUoKTsKKyAgICAgICAgbGV0IGZyYW1lQ291bnQgPSB0aGlzLl91cGRhdGVSZWNvcmRp bmdBdXRvQ2FwdHVyZUlucHV0RWxlbWVudFNpemUoKTsKKyAgICAgICAgdGhpcy5fcmVjb3JkaW5n QXV0b0NhcHR1cmVOYXZpZ2F0aW9uSXRlbS5jaGVja2VkID0gISFmcmFtZUNvdW50OworCiAgICAg ICAgIHRoaXMuX3NldFJlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudCgpOwogICAgIH0KIAo= 354791 2018-11-14 03:23:13 -0800 2018-11-14 04:01:39 -0800 Patch bug-191553-20181114032312.patch text/plain 4279 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM0MTk4YWU2NGU1ODRjNWM0MmEwNzczMGJiZmNk ZmI3ZDIxMWM2ZjQuLjllZDAzNjkxOGMyN2I4Zjc0Nzk2YjkwZjE0Y2ExYTUwYTc2MDU0ZmQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTE0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IGRvbid0IHN0YXJ0IHdpdGggYXV0by1jYXB0dXJlIGVuYWJsZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTU1MworCisgICAgICAgIFJl dmlld2VkIGJ5IE1hdHQgQmFrZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Nh bnZhc092ZXJ2aWV3Q29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5DYW52YXNPdmVydmlld0Nv bnRlbnRWaWV3LnByb3RvdHlwZS5fc2V0UmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50KToK KyAgICAgICAgKFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcucHJvdG90eXBlLl91cGRhdGVS ZWNvcmRpbmdBdXRvQ2FwdHVyZUlucHV0RWxlbWVudFNpemUpOgorICAgICAgICAoV0kuQ2FudmFz T3ZlcnZpZXdDb250ZW50Vmlldy5wcm90b3R5cGUuX2hhbmRsZVJlY29yZGluZ0F1dG9DYXB0dXJl SW5wdXQpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzT3ZlcnZpZXdDb250 ZW50Vmlldy5jc3M6CisgICAgICAgICgubmF2aWdhdGlvbi1iYXIgPiAuaXRlbS5jYW52YXMtcmVj b3JkaW5nLWF1dG8tY2FwdHVyZSA+IGxhYmVsID4gaW5wdXQpOgorCiAyMDE4LTExLTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBO ZXR3b3JrOiBzaG93IHNlY3VyZSBjZXJ0aWZpY2F0ZSBkZXRhaWxzIHBlci1yZXF1ZXN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNP dmVydmlld0NvbnRlbnRWaWV3LmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcuY3NzCmluZGV4IDNkN2FjNjY3YzZi MDFlYjJiNTljZWI3ZGY3YmYwZDMzNGFmMTQwZmEuLmUwODg4NWRjN2ExMzAwZGY5MThlZDIyY2Fl NGU0NGUzNGQyYjg3NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcuY3NzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZp ZXcuY3NzCkBAIC0xODEsOCArMTgxLDEwIEBACiAubmF2aWdhdGlvbi1iYXIgPiAuaXRlbS5jYW52 YXMtcmVjb3JkaW5nLWF1dG8tY2FwdHVyZSA+IGxhYmVsID4gaW5wdXQgewogICAgIHdpZHRoOiAx LjVlbTsKICAgICBtaW4td2lkdGg6IDEuNWVtOwotICAgIG1hcmdpbjogMCA0cHg7CisgICAgbWFy Z2luOiAwIHZhcigtLXJlY29yZGluZy1hdXRvLWNhcHR1cmUtaW5wdXQtbWFyZ2luKTsgCiAgICAg dGV4dC1hbGlnbjogY2VudGVyOworCisgICAgLS1yZWNvcmRpbmctYXV0by1jYXB0dXJlLWlucHV0 LW1hcmdpbjogNHB4OyAvKiBLZWVwIHRoaXMgaW4gc3luYyB3aXRoIGByZWNvcmRpbmdBdXRvQ2Fw dHVyZUlucHV0TWFyZ2luYC4gKi8KIH0KIAogLm5hdmlnYXRpb24tYmFyID4gLml0ZW0uY2FudmFz LXJlY29yZGluZy1hdXRvLWNhcHR1cmUgPiBsYWJlbCA+IGlucHV0Ojotd2Via2l0LWlubmVyLXNw aW4tYnV0dG9uIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LmpzCmlu ZGV4IDJhNzUwYzEyMDI0YTA5ZTc3NWQ4ZjMxNTNmZThkMWQ1NmFhNDNlNDAuLjcxOThkNTYzYjE0 OWIyYjVjODhmMDNlMDViYWU0NzkyZDhhYTQ2MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzT3Zl cnZpZXdDb250ZW50Vmlldy5qcwpAQCAtMjAyLDcgKzIwMiwxMCBAQCBXSS5DYW52YXNPdmVydmll d0NvbnRlbnRWaWV3ID0gY2xhc3MgQ2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyBleHRlbmRzIFdJ LkNvbGxlYwogICAgICAgICBsZXQgZnJhbWVDb3VudCA9IHBhcnNlSW50KHRoaXMuX3JlY29yZGlu Z0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVudC52YWx1ZSk7CiAgICAgICAgIGNvbnNv bGUuYXNzZXJ0KCFpc05hTihmcmFtZUNvdW50KSAmJiBmcmFtZUNvdW50ID49IDApOwogCi0gICAg ICAgIGxldCBlbmFibGVkID0gZnJhbWVDb3VudCAmJiAhIXRoaXMuX3JlY29yZGluZ0F1dG9DYXB0 dXJlTmF2aWdhdGlvbkl0ZW0uY2hlY2tlZDsKKyAgICAgICAgaWYgKHRoaXMuX3JlY29yZGluZ0F1 dG9DYXB0dXJlTmF2aWdhdGlvbkl0ZW0uY2hlY2tlZCkKKyAgICAgICAgICAgIGZyYW1lQ291bnQg PSBNYXRoLm1heCgxLCBmcmFtZUNvdW50KTsKKworICAgICAgICBsZXQgZW5hYmxlZCA9IGZyYW1l Q291bnQgPiAwICYmICEhdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVOYXZpZ2F0aW9uSXRlbS5j aGVja2VkOwogCiAgICAgICAgIFdJLmNhbnZhc01hbmFnZXIuc2V0UmVjb3JkaW5nQXV0b0NhcHR1 cmVGcmFtZUNvdW50KGVuYWJsZWQsIGZyYW1lQ291bnQpOwogICAgIH0KQEAgLTIyMSwxNyArMjI0 LDIxIEBAIFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcgPSBjbGFzcyBDYW52YXNPdmVydmll d0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29sbGVjCiAgICAgICAgICAgICAgICAgdGhpcy5fcmVj b3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50Ll9fY2FjaGVkRm9udCA9IGNv bXB1dGVkU3R5bGUuZm9udDsKICAgICAgICAgICAgIH0KIAorICAgICAgICAgICAgY29uc3QgcmVj b3JkaW5nQXV0b0NhcHR1cmVJbnB1dE1hcmdpbiA9IDg7IC8vIEtlZXAgdGhpcyBpbiBzeW5jIHdp dGggYC0tcmVjb3JkaW5nLWF1dG8tY2FwdHVyZS1pbnB1dC1tYXJnaW5gLgorCiAgICAgICAgICAg ICBjb250ZXh0LmZvbnQgPSB0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1 dEVsZW1lbnQuX19jYWNoZWRGb250OwogICAgICAgICAgICAgbGV0IHRleHRNZXRyaWNzID0gY29u dGV4dC5tZWFzdXJlVGV4dCh0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1 dEVsZW1lbnQudmFsdWUpOwotICAgICAgICAgICAgdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVG cmFtZUNvdW50SW5wdXRFbGVtZW50LnN0eWxlLnNldFByb3BlcnR5KCJ3aWR0aCIsICh0ZXh0TWV0 cmljcy53aWR0aCArIDgpICsgInB4Iik7CisgICAgICAgICAgICB0aGlzLl9yZWNvcmRpbmdBdXRv Q2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1lbnQuc3R5bGUuc2V0UHJvcGVydHkoIndpZHRoIiwg KHRleHRNZXRyaWNzLndpZHRoICsgcmVjb3JkaW5nQXV0b0NhcHR1cmVJbnB1dE1hcmdpbikgKyAi cHgiKTsKICAgICAgICAgfSk7CiAKLSAgICAgICAgdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVO YXZpZ2F0aW9uSXRlbS5jaGVja2VkID0gISFmcmFtZUNvdW50OworICAgICAgICByZXR1cm4gZnJh bWVDb3VudDsKICAgICB9CiAKICAgICBfaGFuZGxlUmVjb3JkaW5nQXV0b0NhcHR1cmVJbnB1dChl dmVudCkKICAgICB7Ci0gICAgICAgIHRoaXMuX3VwZGF0ZVJlY29yZGluZ0F1dG9DYXB0dXJlSW5w dXRFbGVtZW50U2l6ZSgpOworICAgICAgICBsZXQgZnJhbWVDb3VudCA9IHRoaXMuX3VwZGF0ZVJl Y29yZGluZ0F1dG9DYXB0dXJlSW5wdXRFbGVtZW50U2l6ZSgpOworICAgICAgICB0aGlzLl9yZWNv cmRpbmdBdXRvQ2FwdHVyZU5hdmlnYXRpb25JdGVtLmNoZWNrZWQgPSAhIWZyYW1lQ291bnQ7CisK ICAgICAgICAgdGhpcy5fc2V0UmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50KCk7CiAgICAg fQogCg==