191526 2018-11-11 18:06:58 -0800 [WebAuthN] Store necessary authenticator info into HID authenticators 2021-11-01 12:46:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan achristensen alex.gaynor bfulgham cdumez jiewen_tan webkit-bug-importer oldest_to_newest 1477450 0 jiewen_tan 2018-11-11 18:06:58 -0800 Store necessary authenticator info into HID authenticators. 1478366 1 354784 jiewen_tan 2018-11-14 01:55:11 -0800 Created attachment 354784 Patch 1479009 2 354784 jiewen_tan 2018-11-15 12:03:24 -0800 Comment on attachment 354784 Patch I guess I don't need any review for this one. I will land an unreviewed patch on my own. 1479012 3 354784 cdumez 2018-11-15 12:06:40 -0800 Comment on attachment 354784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354784&action=review > Source/WebKit/ChangeLog:8 > + Somehow this is fixed by r238166. Some very minor improvment over it. typo: improvment "Somehow"? You don't know how? I personally find this changelog confusing. 1479058 4 jiewen_tan 2018-11-15 13:11:26 -0800 (In reply to Chris Dumez from comment #3) > Comment on attachment 354784 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354784&action=review > > > Source/WebKit/ChangeLog:8 > > + Somehow this is fixed by r238166. Some very minor improvment over it. > > typo: improvment > > "Somehow"? You don't know how? I personally find this changelog confusing. I thought I was working on a branch for this change, and I didn't. Therefore I actually made this change in: Committed r238166: <https://trac.webkit.org/changeset/238166>. The change is actually simple as well. Which I just move the AuthenticatorGetInfoResponse to the CtapHidAuthenticator after we have the response. And use the userVerificationAvailability info when issuing requests to authenticators in CtapHidAuthenticator. 1479077 5 jiewen_tan 2018-11-15 13:32:57 -0800 Committed r238247: <https://trac.webkit.org/changeset/238247> 1479078 6 webkit-bug-importer 2018-11-15 13:33:30 -0800 <rdar://problem/46106274> 1810781 7 354784 achristensen 2021-11-01 12:46:16 -0700 Comment on attachment 354784 Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review. 354784 2018-11-14 01:55:11 -0800 2021-11-01 12:46:16 -0700 Patch bug-191526-20181114015510.patch text/plain 2551 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxNzYzNzNjNjJmMjczZGFi NGJmNDZjNDc4MDFjOTNiODlkMzU0NzIuLjU2MGU1OGI5MTU0NjMzNWQ4ZTQ4MWQ3NzEyMmQxYWE2 YTJiMjkxYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTEtMTQgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aE5dIFN0b3JlIG5l Y2Vzc2FyeSBhdXRoZW50aWNhdG9yIGluZm8gaW50byBISUQgYXV0aGVudGljYXRvcnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTUyNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWVob3cgdGhpcyBp cyBmaXhlZCBieSByMjM4MTY2LiBTb21lIHZlcnkgbWlub3IgaW1wcm92bWVudCBvdmVyIGl0Lgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLV2Vic2l0ZURhdGFTdG9yZVJlZi5jcHA6Cisg ICAgICAgIChXS1dlYnNpdGVEYXRhU3RvcmVTZXRXZWJBdXRoZW50aWNhdGlvbk1vY2tDb25maWd1 cmF0aW9uKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFw SGlkQXV0aGVudGljYXRvci5oOgorCiAyMDE4LTExLTEzICBKaWV3ZW4gVGFuICA8amlld2VuX3Rh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1dGhOXSBTdXBwb3J0IENUQVAgSElEIGF1dGhl bnRpY2F0b3JzIG9uIG1hY09TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQy9XS1dlYnNpdGVEYXRhU3RvcmVSZWYuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0MvV0tXZWJzaXRlRGF0YVN0b3JlUmVmLmNwcAppbmRleCA0MDEyODA4YWMzZjI1ZmVlZGE4 MmY4YjA4MjkzN2U2M2FkZDY3NzUzLi44N2NlNzljNDFhODgwOGFiODViMDkwYTIwNGM5NDY4YmJl OGYyZjNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1dlYnNp dGVEYXRhU3RvcmVSZWYuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dL V2Vic2l0ZURhdGFTdG9yZVJlZi5jcHAKQEAgLTYxMSw3ICs2MTEsNiBAQCB2b2lkIFdLV2Vic2l0 ZURhdGFTdG9yZVNldFdlYkF1dGhlbnRpY2F0aW9uTW9ja0NvbmZpZ3VyYXRpb24oV0tXZWJzaXRl RGF0YVN0b3JlUgogICAgICAgICBpZiAoc3ViU3RhZ2UgPT0gIm1zZyIpCiAgICAgICAgICAgICBo aWQuc3ViU3RhZ2UgPSBNb2NrV2ViQXV0aGVudGljYXRpb25Db25maWd1cmF0aW9uOjpIaWQ6OlN1 YlN0YWdlOjpNc2c7CiAKLQogICAgICAgICBhdXRvIGVycm9yID0gV2ViS2l0Ojp0b0ltcGwoc3Rh dGljX2Nhc3Q8V0tTdHJpbmdSZWY+KFdLRGljdGlvbmFyeUdldEl0ZW1Gb3JLZXkoaGlkUmVmLCBh ZG9wdFdLKFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJFcnJvciIpKS5nZXQoKSkpKS0+ c3RyaW5nKCk7CiAgICAgICAgIGlmIChlcnJvciA9PSAic3VjY2VzcyIpCiAgICAgICAgICAgICBo aWQuZXJyb3IgPSBNb2NrV2ViQXV0aGVudGljYXRpb25Db25maWd1cmF0aW9uOjpIaWQ6OkVycm9y OjpTdWNjZXNzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVu dGljYXRpb24vZmlkby9DdGFwSGlkQXV0aGVudGljYXRvci5oIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwSGlkQXV0aGVudGljYXRvci5oCmluZGV4 IDk2OGVjZTJjN2QxMDIyNDBlZmQ4MWFhNThmYmFjN2U3Nzg3MTI0ZjcuLmZkZjYyNzk1MjU2OTFk ZWM1ZmE4ZDM1NmUwYWUxOWYyYmYyMDdiNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL2ZpZG8vQ3RhcEhpZEF1dGhlbnRpY2F0b3IuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9maWRvL0N0YXBIaWRB dXRoZW50aWNhdG9yLmgKQEAgLTM2LDcgKzM2LDYgQEAgY2xhc3MgQ3RhcEhpZERyaXZlcjsKIAog Y2xhc3MgQ3RhcEhpZEF1dGhlbnRpY2F0b3IgZmluYWwgOiBwdWJsaWMgQXV0aGVudGljYXRvciB7 CiBwdWJsaWM6Ci0gICAgLy8gRklYTUUoMTkxNTI2KTogU2hvdWxkIHN0b3JlIEF1dGhlbnRpY2F0 b3JTdXBwb3J0ZWRPcHRpb25zOjpVc2VyVmVyaWZpY2F0aW9uQXZhaWxhYmlsaXR5LgogICAgIHN0 YXRpYyBSZWY8Q3RhcEhpZEF1dGhlbnRpY2F0b3I+IGNyZWF0ZShzdGQ6OnVuaXF1ZV9wdHI8Q3Rh cEhpZERyaXZlcj4mJiBkcml2ZXIsIGZpZG86OkF1dGhlbnRpY2F0b3JHZXRJbmZvUmVzcG9uc2Um JiBpbmZvKQogICAgIHsKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQ3RhcEhpZEF1dGhl bnRpY2F0b3IoV1RGTW92ZShkcml2ZXIpLCBXVEZNb3ZlKGluZm8pKSk7Cg==