191522 2018-11-11 17:56:29 -0800 [WebAuthN] PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::AuthenticatorAttachment should be optional 2018-11-15 12:29:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan achristensen alex.gaynor bfulgham cdumez commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1477443 0 jiewen_tan 2018-11-11 17:56:29 -0800 PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::AuthenticatorAttachment should be optional. 1478350 1 354777 jiewen_tan 2018-11-14 00:37:58 -0800 Created attachment 354777 Patch 1478404 2 354777 achristensen 2018-11-14 06:10:36 -0800 Comment on attachment 354777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review > Source/WebCore/ChangeLog:11 > + Covered by existing tests. Is there an observable change in behavior from this change? 1478441 3 354777 bfulgham 2018-11-14 08:14:09 -0800 Comment on attachment 354777 Patch Looks good. I assume there's no WPT for this, or you would have unskipped it. 1479007 4 354777 jiewen_tan 2018-11-15 12:02:01 -0800 Comment on attachment 354777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review Thanks Brent for r+ this patch. >> Source/WebCore/ChangeLog:11 >> + Covered by existing tests. > > Is there an observable change in behavior from this change? Things are a little bit tricky here. There is currently no way of testing the wrong(before) behavior as we only support one kind of authenticators in macOS currently. That means we get the same response if authenticatorAttachment = std::nullopt or CrossPlatform. 1479031 5 354777 commit-queue 2018-11-15 12:28:17 -0800 Comment on attachment 354777 Patch Clearing flags on attachment: 354777 Committed r238240: <https://trac.webkit.org/changeset/238240> 1479032 6 commit-queue 2018-11-15 12:28:19 -0800 All reviewed patches have been landed. Closing bug. 1479033 7 webkit-bug-importer 2018-11-15 12:29:35 -0800 <rdar://problem/46104073> 354777 2018-11-14 00:37:58 -0800 2018-11-15 12:28:17 -0800 Patch bug-191522-20181114003758.patch text/plain 4063 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGVmZDBlYmE2OGRlYWUz Y2JkYTM5MDAzMDA5MjZiNDY3Yjk3MThlMS4uOTBiZGUxZjdiNDM4NDM2NGM2OGI3YzVkODNlMmZh NGU4NWVmZWZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTExLTE0ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkF1dGhOXSBQdWJs aWNLZXlDcmVkZW50aWFsQ3JlYXRpb25PcHRpb25zOjpBdXRoZW50aWNhdG9yU2VsZWN0aW9uQ3Jp dGVyaWE6OkF1dGhlbnRpY2F0b3JBdHRhY2htZW50IHNob3VsZCBiZSBvcHRpb25hbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNTIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaWduIHRvIHRo ZSBXZWJJREwsIEF1dGhlbnRpY2F0b3JTZWxlY3Rpb25Dcml0ZXJpYTo6QXV0aGVudGljYXRvckF0 dGFjaG1lbnQgc2hvdWxkIGJlIG9wdGlvbmFsLgorICAgICAgICBodHRwczovL3d3dy53My5vcmcv VFIvd2ViYXV0aG4vI2RpY3RkZWYtYXV0aGVudGljYXRvcnNlbGVjdGlvbmNyaXRlcmlhCisKKyAg ICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvd2Vi YXV0aG4vUHVibGljS2V5Q3JlZGVudGlhbENyZWF0aW9uT3B0aW9ucy5oOgorICAgICAgICAoV2Vi Q29yZTo6UHVibGljS2V5Q3JlZGVudGlhbENyZWF0aW9uT3B0aW9uczo6QXV0aGVudGljYXRvclNl bGVjdGlvbkNyaXRlcmlhOjpkZWNvZGUpOgorCiAyMDE4LTExLTEzICBKaWV3ZW4gVGFuICA8amll d2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1dGhOXSBTdXBwb3J0IENUQVAgSElE IGF1dGhlbnRpY2F0b3JzIG9uIG1hY09TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxNzYzNzNjNjJmMjczZGFiNGJm NDZjNDc4MDFjOTNiODlkMzU0NzIuLmE0ZTA5ZTVhZjAxNGJiMTA3ZGU1MjUxYWVlOGZkYWYyYzlm OTgyYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTEtMTQgIEppZXdlbiBUYW4g IDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aE5dIFB1YmxpY0tleUNy ZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnM6OkF1dGhlbnRpY2F0b3JTZWxlY3Rpb25Dcml0ZXJpYTo6 QXV0aGVudGljYXRvckF0dGFjaG1lbnQgc2hvdWxkIGJlIG9wdGlvbmFsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE1MjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJBdXRoZW50 aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkF1dGhl bnRpY2F0b3JNYW5hZ2VySW50ZXJuYWw6OmNvbGxlY3RUcmFuc3BvcnRzKToKKwogMjAxOC0xMS0x MyAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJBdXRo Tl0gU3VwcG9ydCBDVEFQIEhJRCBhdXRoZW50aWNhdG9ycyBvbiBtYWNPUwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9QdWJsaWNLZXlDcmVkZW50aWFsQ3JlYXRp b25PcHRpb25zLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL1B1YmxpY0tleUNy ZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnMuaAppbmRleCAzMWYzMjI5OTYyOTMyYmFkNjYxMWNlMjE2 NTAyYTIyYWQ4NjVjNTQ1Li5iYTY4ZGY5MmIxODJjN2E5YjEzYTM2NmZhOTExNjA4MmViNDY1ZGJl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL1B1YmxpY0tleUNy ZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmF1dGhuL1B1YmxpY0tleUNyZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnMuaApAQCAtNjYsOCArNjYs NyBAQCBzdHJ1Y3QgUHVibGljS2V5Q3JlZGVudGlhbENyZWF0aW9uT3B0aW9ucyB7CiAgICAgfTsK IAogICAgIHN0cnVjdCBBdXRoZW50aWNhdG9yU2VsZWN0aW9uQ3JpdGVyaWEgewotICAgICAgICAv LyBGSVhNRSgxOTE1MjIpCi0gICAgICAgIEF1dGhlbnRpY2F0b3JBdHRhY2htZW50IGF1dGhlbnRp Y2F0b3JBdHRhY2htZW50IHsgQXV0aGVudGljYXRvckF0dGFjaG1lbnQ6OkNyb3NzUGxhdGZvcm0g fTsKKyAgICAgICAgc3RkOjpvcHRpb25hbDxBdXRoZW50aWNhdG9yQXR0YWNobWVudD4gYXV0aGVu dGljYXRvckF0dGFjaG1lbnQ7CiAgICAgICAgIGJvb2wgcmVxdWlyZVJlc2lkZW50S2V5IHsgZmFs c2UgfTsKICAgICAgICAgVXNlclZlcmlmaWNhdGlvblJlcXVpcmVtZW50IHVzZXJWZXJpZmljYXRp b24geyBVc2VyVmVyaWZpY2F0aW9uUmVxdWlyZW1lbnQ6OlByZWZlcnJlZCB9OwogCkBAIC0xMTcs NyArMTE2LDcgQEAgc3RkOjpvcHRpb25hbDxQdWJsaWNLZXlDcmVkZW50aWFsQ3JlYXRpb25PcHRp b25zOjpBdXRoZW50aWNhdG9yU2VsZWN0aW9uQ3JpdGVyaWEKIHsKICAgICBQdWJsaWNLZXlDcmVk ZW50aWFsQ3JlYXRpb25PcHRpb25zOjpBdXRoZW50aWNhdG9yU2VsZWN0aW9uQ3JpdGVyaWEgcmVz dWx0OwogCi0gICAgc3RkOjpvcHRpb25hbDxBdXRoZW50aWNhdG9yQXR0YWNobWVudD4gYXV0aGVu dGljYXRvckF0dGFjaG1lbnQ7CisgICAgc3RkOjpvcHRpb25hbDxzdGQ6Om9wdGlvbmFsPEF1dGhl bnRpY2F0b3JBdHRhY2htZW50Pj4gYXV0aGVudGljYXRvckF0dGFjaG1lbnQ7CiAgICAgZGVjb2Rl ciA+PiBhdXRoZW50aWNhdG9yQXR0YWNobWVudDsKICAgICBpZiAoIWF1dGhlbnRpY2F0b3JBdHRh Y2htZW50KQogICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRvck1hbmFnZXIu Y3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQXV0aGVudGlj YXRvck1hbmFnZXIuY3BwCmluZGV4IDJjNGU3NmE0MWEwNGQ4MGRjOTk3MDdmYTU3YTcyNWUzZGU0 NjJiMjcuLjY1OTVmOWMwYWYzM2M5YmFjMzhjMTZlNmZhM2IzZGJlY2E3NDVmODYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0 b3JNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgY29uc3QgdW5z aWduZWQgbWF4VGltZU91dFZhbHVlID0gMTIwMDAwOwogc3RhdGljIEF1dGhlbnRpY2F0b3JNYW5h Z2VyOjpUcmFuc3BvcnRTZXQgY29sbGVjdFRyYW5zcG9ydHMoY29uc3Qgc3RkOjpvcHRpb25hbDxQ dWJsaWNLZXlDcmVkZW50aWFsQ3JlYXRpb25PcHRpb25zOjpBdXRoZW50aWNhdG9yU2VsZWN0aW9u Q3JpdGVyaWE+JiBhdXRoZW50aWNhdG9yU2VsZWN0aW9uKQogewogICAgIEF1dGhlbnRpY2F0b3JN YW5hZ2VyOjpUcmFuc3BvcnRTZXQgcmVzdWx0OwotICAgIGlmICghYXV0aGVudGljYXRvclNlbGVj dGlvbikgeworICAgIGlmICghYXV0aGVudGljYXRvclNlbGVjdGlvbiB8fCAhYXV0aGVudGljYXRv clNlbGVjdGlvbi0+YXV0aGVudGljYXRvckF0dGFjaG1lbnQpIHsKICAgICAgICAgYXV0byBhZGRS ZXN1bHQgPSByZXN1bHQuYWRkKEF1dGhlbnRpY2F0b3JUcmFuc3BvcnQ6OkludGVybmFsKTsKICAg ICAgICAgQVNTRVJUX1VOVVNFRChhZGRSZXN1bHQsIGFkZFJlc3VsdC5pc05ld0VudHJ5KTsKICNp ZiBQTEFURk9STShNQUMpCg==