191481 2018-11-09 12:33:38 -0800 REGRESSION(r223264): [GTK] Unable to drag documents on Google Drive 2018-11-13 13:18:09 -0800 1 1 1 Unclassified WebKit UI Events WebKit Local Build PC Linux NEW Regression P2 Normal --- 178214 1 beau.adkins mcatanzaro beau.adkins cdumez dbates ews-watchlist mcatanzaro oldest_to_newest 1477056 0 beau.adkins 2018-11-09 12:33:38 -0800 After r223264, you can no longer drag and drop documents on the Google Drive home screen that shows all your documents. I bisected it down to this revision, but after reviewing the change, I just can't see how this change is actually breaking anything. From my reading, it should only have any actual effect on Mac. As far as a GTK build is concerned, it looks like it just adds an unused member to a few mouse event classes. 1477344 1 cdumez 2018-11-10 19:05:29 -0800 The issue is likely that MousrEvent.buttons is exposed to the Web but unimplemented on GTK. It should either get implemented in GTK or unexposed for this port. 1477378 2 mcatanzaro 2018-11-11 08:01:52 -0800 Thanks for investigating, Chris! 1477381 3 mcatanzaro 2018-11-11 08:49:45 -0800 Hm, looks like WebEventFactory::createWebMouseEvent in Source/WebKit/Shared/gtk/WebEventFactory.cpp is already passing the pressed mouse buttons into the WebMouseEvent constructor. So that looks fine. The PlatformMouseEvent constructors are not doing so. I'm attaching a patch to fix these constructors as a starting point, but it's not enough to fix Google Drive. Further investigation will be required as to why it's still not working. 1477384 4 354506 mcatanzaro 2018-11-11 08:50:16 -0800 Created attachment 354506 WIP patch 1477385 5 ews-watchlist 2018-11-11 08:52:17 -0800 Attachment 354506 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1477386 6 mcatanzaro 2018-11-11 08:52:39 -0800 (In reply to Michael Catanzaro from comment #3) > Hm, looks like WebEventFactory::createWebMouseEvent in > Source/WebKit/Shared/gtk/WebEventFactory.cpp is already passing the pressed > mouse buttons into the WebMouseEvent constructor. So that looks fine. It was implemented in r230988, a good time after r223264, but still a while back. 1478044 7 beau.adkins 2018-11-13 10:23:18 -0800 Thanks Michael, Backporting this patch into the 2.20 branch that I am working off of does indeed restore drag/drop functionality for Google Drive. I guess this ticket should be closed as invalid. 1478099 8 mcatanzaro 2018-11-13 12:51:41 -0800 No, because it's broken in trunk with or without my patch. 1478116 9 beau.adkins 2018-11-13 13:18:09 -0800 Michael, Ok. Just to clarify, as it might help: I am running off of the 2.20 branch. The drag/drop on Google Drive was broken there. But when I merged in 230988 to the 2.20 branch, everything is working now. This is WITHOUT merging in your attachment to this ticket though. So maybe there was another commit after the 2.20 branch or after 230988 that rebroke it? 354506 2018-11-11 08:50:16 -0800 2018-11-11 08:50:32 -0800 WIP patch bug-191481-20181111105015.patch text/plain 2971 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U0ZDlhMTgxNzQ2ZTVm YWIyMTVkYjU3YTc0NDI5ZTUyYWRhMDc3Mi4uOWNjYjhjYmE5MzI0MDg1ZDE3MjdmYmNhNjU4OWUz OTY3MTBmNDhhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTExLTExICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIyMjMyNjQpOiBbR1RLXSBVbmFibGUgdG8gZHJhZyBkb2N1bWVudHMgb24gR29vZ2xlIERy aXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE0 ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QbGF0Zm9ybU1vdXNl RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Nb3VzZUV2ZW50OjpQbGF0 Zm9ybU1vdXNlRXZlbnQpOgorCiAyMDE4LTExLTEwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gZWRpdCBpbWFnZXMg aW5saW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1N b3VzZUV2ZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybU1v dXNlRXZlbnRHdGsuY3BwCmluZGV4IDkzMzdmODFhMzVjNGM0ZTI2ZGQxNzI4YmM5OTUxYTkyZmU0 Y2NjNWEuLmU2MWZkYzExOWM2MTU4ZTE3Mzg5YjhhMjI4MTc3N2RmZmRmNWRhYWYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybU1vdXNlRXZlbnRHdGsuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybU1vdXNlRXZlbnRHdGsu Y3BwCkBAIC00Myw2ICs0Myw3IEBAIFBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2 ZW50KEdka0V2ZW50QnV0dG9uKiBldmVudCkKICAgICBtX3Bvc2l0aW9uID0gSW50UG9pbnQoKGlu dClldmVudC0+eCwgKGludClldmVudC0+eSk7CiAgICAgbV9nbG9iYWxQb3NpdGlvbiA9IEludFBv aW50KChpbnQpZXZlbnQtPnhfcm9vdCwgKGludClldmVudC0+eV9yb290KTsKICAgICBtX2J1dHRv biA9IE5vQnV0dG9uOworICAgIG1fYnV0dG9ucyA9IDA7CiAgICAgbV9jbGlja0NvdW50ID0gMDsK ICAgICBtX21vZGlmaWVyRmxhZ3MgPSAwOwogCkBAIC01Nyw2ICs1OCwxMyBAQCBQbGF0Zm9ybU1v dXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChHZGtFdmVudEJ1dHRvbiogZXZlbnQpCiAgICAg aWYgKFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6bW9kaWZpZXJzQ29udGFpbkNhcHNMb2NrKGV2ZW50 LT5zdGF0ZSkpCiAgICAgICAgIG1fbW9kaWZpZXJzLmFkZChQbGF0Zm9ybUV2ZW50OjpNb2RpZmll cjo6Q2Fwc0xvY2tLZXkpOwogCisgICAgaWYgKGV2ZW50LT5zdGF0ZSAmIEdES19CVVRUT04xX01B U0spCisgICAgICAgIG1fYnV0dG9ucyB8PSBMZWZ0QnV0dG9uOworICAgIGlmIChldmVudC0+c3Rh dGUgJiBHREtfQlVUVE9OMl9NQVNLKQorICAgICAgICBtX2J1dHRvbnMgfD0gTWlkZGxlQnV0dG9u OworICAgIGlmIChldmVudC0+c3RhdGUgJiBHREtfQlVUVE9OM19NQVNLKQorICAgICAgICBtX2J1 dHRvbnMgfD0gUmlnaHRCdXR0b247CisKICAgICBzd2l0Y2ggKGV2ZW50LT50eXBlKSB7CiAgICAg Y2FzZSBHREtfQlVUVE9OX1BSRVNTOgogICAgIGNhc2UgR0RLXzJCVVRUT05fUFJFU1M6CkBAIC05 Miw2ICsxMDAsNyBAQCBQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChHZGtF dmVudE1vdGlvbiogbW90aW9uKQogICAgIG1fcG9zaXRpb24gPSBJbnRQb2ludCgoaW50KW1vdGlv bi0+eCwgKGludCltb3Rpb24tPnkpOwogICAgIG1fZ2xvYmFsUG9zaXRpb24gPSBJbnRQb2ludCgo aW50KW1vdGlvbi0+eF9yb290LCAoaW50KW1vdGlvbi0+eV9yb290KTsKICAgICBtX2J1dHRvbiA9 IE5vQnV0dG9uOworICAgIG1fYnV0dG9ucyA9IDA7CiAgICAgbV9jbGlja0NvdW50ID0gMDsKICAg ICBtX21vZGlmaWVyRmxhZ3MgPSAwOwogCkBAIC0xMTYsMTEgKzEyNSwxOCBAQCBQbGF0Zm9ybU1v dXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChHZGtFdmVudE1vdGlvbiogbW90aW9uKQogICAg ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9OwogCi0gICAgaWYgKG1vdGlvbi0+c3Rh dGUgJiBHREtfQlVUVE9OMV9NQVNLKQotICAgICAgICBtX2J1dHRvbiA9IExlZnRCdXR0b247Ci0g ICAgZWxzZSBpZiAobW90aW9uLT5zdGF0ZSAmIEdES19CVVRUT04yX01BU0spCi0gICAgICAgIG1f YnV0dG9uID0gTWlkZGxlQnV0dG9uOwotICAgIGVsc2UgaWYgKG1vdGlvbi0+c3RhdGUgJiBHREtf QlVUVE9OM19NQVNLKQorICAgIGlmIChtb3Rpb24tPnN0YXRlICYgR0RLX0JVVFRPTjNfTUFTSykg ewogICAgICAgICBtX2J1dHRvbiA9IFJpZ2h0QnV0dG9uOworICAgICAgICBtX2J1dHRvbnMgfD0g UmlnaHRCdXR0b247CisgICAgfQorICAgIGlmIChtb3Rpb24tPnN0YXRlICYgR0RLX0JVVFRPTjJf TUFTSykgeworICAgICAgICBtX2J1dHRvbiA9IE1pZGRsZUJ1dHRvbjsKKyAgICAgICAgbV9idXR0 b25zIHw9IE1pZGRsZUJ1dHRvbjsKKyAgICB9CisgICAgaWYgKG1vdGlvbi0+c3RhdGUgJiBHREtf QlVUVE9OMV9NQVNLKSB7CisgICAgICAgIG1fYnV0dG9uID0gTGVmdEJ1dHRvbjsKKyAgICAgICAg bV9idXR0b25zIHw9IExlZnRCdXR0b247CisgICAgfQogfQotfQorCit9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCg==