191381 2018-11-07 10:05:30 -0800 [iOS] Option + Delete should delete previous word 2018-11-07 14:12:04 -0800 1 1 1 Unclassified WebKit Platform WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191389 InRadar P2 Normal --- 190571 1 dbates dbates megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1476035 0 dbates 2018-11-07 10:05:30 -0800 We should recognize the key command Option + Delete and delete the previous word to more closely match iOS platform conventions. 1476036 1 dbates 2018-11-07 10:05:48 -0800 <rdar://problem/23681351> 1476044 2 354104 dbates 2018-11-07 10:22:32 -0800 Created attachment 354104 Patch It is not straightforward to write a test for this change because UIKit determines the modifier keys pressed (e.g. Option) by querying the keyboard directly. We could mock out the underlying keyboard though this seems fragile. 1476092 3 354116 dbates 2018-11-07 11:37:35 -0800 Created attachment 354116 Patch 1476208 4 354116 dbates 2018-11-07 14:12:02 -0800 Comment on attachment 354116 Patch Clearing flags on attachment: 354116 Committed r237943: <https://trac.webkit.org/changeset/237943> 1476209 5 dbates 2018-11-07 14:12:04 -0800 All reviewed patches have been landed. Closing bug. 354104 2018-11-07 10:22:32 -0800 2018-11-07 11:37:34 -0800 Patch bug-191381-20181107102232.patch text/plain 1586 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzMGYwNWU2OGFhOWNhYzM4 MzczMTc1MGEyNDMzZmZiOTBkYjA2MWQuLmNmMzM3YjBlNDJjNjg2ZWI0YzE1YjNmZDMyZDRlYWRi MmIzZTFkMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTEtMDcgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIE9wdGlvbiArIERlbGV0 ZSBzaG91bGQgZGVsZXRlIHByZXZpb3VzIHdvcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTM4MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjM2 ODEzNTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW1wbGVtZW50IHN1cHBvcnQgZm9yIHByZXNzaW5nIE9wdGlvbiArIERlbGV0ZSB0byBkZWxldGUg dGhlIHByZXZpb3VzIHdvcmQuIFRoaXMgbWFrZXMgdGV4dCBlZGl0aW5nCisgICAgICAgIGluIFdl YktpdCBtb3JlIGNsb3NlbHkgbWF0Y2ggdGhlIHBsYXRmb3JtIGNvbnZlbnRpb25zLgorCisgICAg ICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgX2RlbGV0ZUJ5V29yZF0pOgorCiAyMDE4LTExLTA3ICBEYW5pZWwg QmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBQcmVzc2luZyBmb3J3 YXJkIGRlbGV0ZSBrZXkgaW4gdGV4dCBmaWVsZCBkb2VzIG5vdGhpbmcgYW5kIHdlIHNob3VsZCBu b3QgaW52b2tlIGFuIGVkaXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggZDBlY2NkN2I0MWEyZDI2NjZi MmNjNjAwOTVjMjY4ZGE4NzkzMWFkOC4uMjc3YTE1ZmE4ZDdhMDY4MDBiZDFjMDExNDM2NjI3MWMy MzYxNTYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0zOTI3LDYgKzM5MjcsMTEgQEAgLSAodm9pZCll eGVjdXRlRWRpdENvbW1hbmRXaXRoQ2FsbGJhY2s6KE5TU3RyaW5nICopY29tbWFuZE5hbWUKICAg ICB9KTsKIH0KIAorLSAodm9pZClfZGVsZXRlQnlXb3JkCit7CisgICAgW3NlbGYgZXhlY3V0ZUVk aXRDb21tYW5kV2l0aENhbGxiYWNrOkAiZGVsZXRlV29yZEJhY2t3YXJkIl07Cit9CisKIC0gKHZv aWQpX2RlbGV0ZUZvcndhcmRBbmROb3RpZnk6KEJPT0wpbm90aWZ5CiB7CiAgICAgW3NlbGYgZXhl Y3V0ZUVkaXRDb21tYW5kV2l0aENhbGxiYWNrOkAiZGVsZXRlRm9yd2FyZCJdOwo= 354116 2018-11-07 11:37:35 -0800 2018-11-07 14:12:02 -0800 Patch bug-191381-20181107113734.patch text/plain 1659 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZmZjJmZDFlMmYzZmJiM2E3 Y2MxN2Q1MTNjM2NkZDhkYjU3OWE4ZDYuLjAxN2U2MDVlN2EyYTcwMzliMGQ1ZGU4NjdkYzdjNjlh NmU1ODFlOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTEtMDcgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIE9wdGlvbiArIERlbGV0 ZSBzaG91bGQgZGVsZXRlIHByZXZpb3VzIHdvcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTM4MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjM2 ODEzNTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW1wbGVtZW50IHN1cHBvcnQgZm9yIHByZXNzaW5nIE9wdGlvbiArIERlbGV0ZSB0byBkZWxldGUg dGhlIHByZXZpb3VzIHdvcmQuIFRoaXMgbWFrZXMgdGV4dCBlZGl0aW5nCisgICAgICAgIGluIFdl YktpdCBtb3JlIGNsb3NlbHkgbWF0Y2ggdGhlIHBsYXRmb3JtIGNvbnZlbnRpb25zLgorCisgICAg ICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgX2RlbGV0ZUJ5V29yZF0pOgorCiAyMDE4LTExLTA3ICBaYW1pdWwg SGFxdWUgIDx6aGFxdWVAYXBwbGUuY29tPgogCiAgICAgICAgIEZvcmNlIGEgZ3JlZ29yaWFuIGNh bGVuZGFyIHRvIHNob3cgZm9yIGNyZWRpdCBjYXJkIGV4cGlyYXRpb24gZGF0ZSBpbnB1dHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tCmluZGV4IDQ2ZmQ2MzA2NzBhN2QzNTcxYjI4YjBjNWEzYTRkMmZmYWZhNTE1NWQu Ljc2OWExOGRiYjE2OGVkOWE5YWE5Yzk3NWIxYzY1YzNlM2QwNjk5MjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQpAQCAtMzkyNyw2ICszOTI3LDExIEBAIC0gKHZvaWQpZXhlY3V0ZUVkaXRDb21tYW5kV2l0aENh bGxiYWNrOihOU1N0cmluZyAqKWNvbW1hbmROYW1lCiAgICAgfSk7CiB9CiAKKy0gKHZvaWQpX2Rl bGV0ZUJ5V29yZAoreworICAgIFtzZWxmIGV4ZWN1dGVFZGl0Q29tbWFuZFdpdGhDYWxsYmFjazpA ImRlbGV0ZVdvcmRCYWNrd2FyZCJdOworfQorCiAtIChVSVRleHRJbnB1dEFycm93S2V5SGlzdG9y eSAqKV9tb3ZlVXA6KEJPT0wpZXh0ZW5kaW5nIHdpdGhIaXN0b3J5OihVSVRleHRJbnB1dEFycm93 S2V5SGlzdG9yeSAqKWhpc3RvcnkKIHsKICAgICBbc2VsZiBleGVjdXRlRWRpdENvbW1hbmRXaXRo Q2FsbGJhY2s6ZXh0ZW5kaW5nID8gQCJtb3ZlVXBBbmRNb2RpZnlTZWxlY3Rpb24iIDogQCJtb3Zl VXAiXTsK