191318 2018-11-06 12:20:50 -0800 REGRESSION(r237113?): [GTK] Stable bots are unexpectedly running jhbuild 2019-01-23 10:00:51 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED DUPLICATE 193669 https://bugs.webkit.org/show_bug.cgi?id=191290 P2 Normal --- 1 mcatanzaro webkit-unassigned aakash_jain ap bugs-noreply ryanhaddad oldest_to_newest 1475618 0 mcatanzaro 2018-11-06 12:20:50 -0800 Ryan noticed that, after the bots were restarted for the change in r237113 "[GTK] Disable MSE build support on Debian and Ubuntu LTS bots" to take effect, steps_unittest.py is now failing: ====================================================================== FAIL: test_builder GTK Linux 64-bit Release Debian Stable (Build) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "steps_unittest.py", line 599, in doTest self.assertListEqual(expected_build_steps[builder['name']], buildSteps) AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki... First differing element 5: compile-webkit jhbuild Second list contains 1 additional elements. First extra element 6: compile-webkit ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', + 'jhbuild', 'compile-webkit'] ====================================================================== FAIL: test_builder GTK Linux 64-bit Release Ubuntu LTS (Build) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "steps_unittest.py", line 599, in doTest self.assertListEqual(expected_build_steps[builder['name']], buildSteps) AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki... First differing element 5: compile-webkit jhbuild Second list contains 1 additional elements. First extra element 6: compile-webkit ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', + 'jhbuild', 'compile-webkit'] These bots are not supposed to be running jhbuild. I'm skeptical that r237113 is to blame, but the timeline matches and I don't have another explanation. See the discussion in bug #191290. 1497385 1 ryanhaddad 2019-01-23 09:55:40 -0800 Aakash has a suggested fix in https://bugs.webkit.org/show_bug.cgi?id=190581#c8 factories.py L42 should be changed to something like: if platform == "gtk" and "--no-experimental-features" not in additionalArguments: 1497386 2 ryanhaddad 2019-01-23 09:56:47 -0800 Oh, this was addressed in https://bugs.webkit.org/show_bug.cgi?id=193669 *** This bug has been marked as a duplicate of bug 193669 ***