191087 2018-10-30 15:33:26 -0700 [iOS][WK2] Forward delete should only cause an editor action inside an editable element 2018-11-06 13:59:01 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build iPhone / iPad iOS 12 RESOLVED DUPLICATE 190566 https://bugs.webkit.org/show_bug.cgi?id=191088 PlatformOnly P2 Normal --- 1 dbates dbates aestes megan_gardner wenson_hsieh oldest_to_newest 1473442 0 dbates 2018-10-30 15:33:26 -0700 In Modern WebKit on iOS we perform a forward character deletion when the forward delete pressed regardless of whether we are in an editable element. We should only perform editing operations inside editable elements. 1473459 1 dbates 2018-10-30 15:53:46 -0700 We seem to perform an editing operation in iOS Legacy WebKit: <https://github.com/WebKit/webkit/blob/6dbd0e71cfdea78d2ad347d2efb6c9264c25d2e3/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm#L6091> :/ 1473461 2 353422 dbates 2018-10-30 15:55:34 -0700 Created attachment 353422 Patch 1475689 3 dbates 2018-11-06 13:59:01 -0800 *** This bug has been marked as a duplicate of bug 190566 *** 353422 2018-10-30 15:55:34 -0700 2018-10-30 15:55:34 -0700 Patch bug-191087-20181030155533.patch text/plain 2031 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiZTdkM2RkNmZmMzUwYmM0 NTBhZDQ1MDE5NjRjM2I4YmQxOGZlNGMuLmY4NTFkODNlYzRlZTk4ZTQzNTA3YTFhOWI1NjA1NDU2 MzM1NzhiOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMTAtMzAgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0gRm9yd2FyZCBk ZWxldGUgc2hvdWxkIG9ubHkgY2F1c2UgYW4gZWRpdG9yIGFjdGlvbiBpbnNpZGUgYW4gZWRpdGFi bGUgZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkxMDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ3VycmVudGx5IE1vZGVybiBXZWJLaXQgb24gaU9TIHBlcmZvcm1zIGFuIGVkaXRpbmcgb3Bl cmF0aW9uIHdoZW5ldmVyIHRoZSBmb3J3YXJkIGRlbGV0ZQorICAgICAgICBrZXkgaXMgcHJlc3Nl ZCByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhlIGZvY3VzZWQgZWxlbWVudCBpcyBlZGl0YWJsZS4g V2Ugc2hvdWxkIG9ubHkgcGVyZm9ybQorICAgICAgICBlZGl0aW5nIG9wZXJhdGlvbnMgaW4gZWRp dGFibGUgZWxlbWVudHMuCisKKyAgICAgICAgV2UgY2Fubm90IHRlc3QgdGhpcyBjaGFuZ2UgdW50 aWwgd2UgZml4IDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMDg4 Pi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t OgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9pbnRlcnByZXRLZXlFdmVudDppc0NoYXJFdmVu dDpdKToKKwogMjAxOC0xMC0xMSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAK ICAgICAgICAgW2lPU10gV2ViS2l0IHNob3VsZCBkaXNwYXRjaCBET00gZXZlbnRzIHdoZW4gYSBt b2RpZmllciBrZXkgaXMgcHJlc3NlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggNGFiNmQxMjViZjNmZDFh MDRlYmJkODQxYWFiOTU3MTJjOTRkMjg4Mi4uZmU3MjdiMDUyMmUyN2JlZGQxZDFjZDQ3ZjEwODAy ZTJkOGNlYzNkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0zODc3LDkgKzM4NzcsMTEgQEAgLSAoQk9P TClfaW50ZXJwcmV0S2V5RXZlbnQ6KDo6V2ViRXZlbnQgKilldmVudCBpc0NoYXJFdmVudDooQk9P TClpc0NoYXJFdmVudAogICAgICAgICBicmVhazsKIAogICAgIGNhc2Uga1dlYkRlbGV0ZUZvcndh cmRLZXk6Ci0gICAgICAgIF9wYWdlLT5leGVjdXRlRWRpdENvbW1hbmQoImRlbGV0ZUZvcndhcmQi X3MpOwotICAgICAgICByZXR1cm4gWUVTOwotCisgICAgICAgIGlmIChjb250ZW50RWRpdGFibGUg JiYgaXNDaGFyRXZlbnQpIHsKKyAgICAgICAgICAgIF9wYWdlLT5leGVjdXRlRWRpdENvbW1hbmQo ImRlbGV0ZUZvcndhcmQiX3MpOworICAgICAgICAgICAgcmV0dXJuIFlFUzsKKyAgICAgICAgfQor ICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICBpZiAoY29udGVudEVkaXRhYmxl ICYmIGlzQ2hhckV2ZW50KSB7CiAgICAgICAgICAgICBba2V5Ym9hcmQgYWRkSW5wdXRTdHJpbmc6 ZXZlbnQuY2hhcmFjdGVycyB3aXRoRmxhZ3M6ZXZlbnQua2V5Ym9hcmRGbGFncyB3aXRoSW5wdXRN YW5hZ2VySGludDpldmVudC5pbnB1dE1hbmFnZXJIaW50XTsK