191062 2018-10-30 05:04:33 -0700 Align entries in metadata table 2018-10-31 09:10:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dominik.infuehr webkit-unassigned commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1473224 0 dominik.infuehr 2018-10-30 05:04:33 -0700 Align entries in metadata table 1473225 1 353361 dominik.infuehr 2018-10-30 05:05:47 -0700 Created attachment 353361 Patch 1473226 2 dominik.infuehr 2018-10-30 05:08:02 -0700 This is necessary for some 32-bit architectures that don't support most unaligned accesses. 1473232 3 tzagallo 2018-10-30 05:17:28 -0700 I'm not officially a reviewer, so I can't r+ the patch, but looks good to me. However, we probably only want to do that for the platforms that don't like the unaligned accesses. 1473242 4 dominik.infuehr 2018-10-30 07:05:26 -0700 Thanks for taking a looking! I was also wondering about the same thing, in the end I aligned the metadata on all platforms since unaligned accesses are not free there either and just aligning shouldn't increase memory usage too much. What do you think? 1473258 5 fpizlo 2018-10-30 08:11:48 -0700 (In reply to Dominik Inführ from comment #4) > Thanks for taking a looking! I was also wondering about the same thing, in > the end I aligned the metadata on all platforms since unaligned accesses are > not free there either and just aligning shouldn't increase memory usage too > much. What do you think? It should be optional. Unaligned accesses are effectively free on some platforms. 1473265 6 353371 dominik.infuehr 2018-10-30 08:46:48 -0700 Created attachment 353371 Patch 1473268 7 dominik.infuehr 2018-10-30 08:49:44 -0700 Great, I made the alignment optional on CPU(NEEDS_ALIGNED_MEMORY). 1473456 8 353371 ysuzuki 2018-10-30 15:47:37 -0700 Comment on attachment 353371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353371&action=review > Source/JavaScriptCore/bytecode/Opcode.cpp:202 > +static unsigned metadataAlignments[] = { > + > +#define METADATA_ALIGNMENT(size) size, > + FOR_EACH_BYTECODE_METADATA_ALIGNMENT(METADATA_ALIGNMENT) > +#undef METADATA_ALIGNMENT > + > +}; This data is not necessary if `CPU(NEEDS_ALIGNED_ACCESS)` is false. Let's guard with this condition and drop this data from the binary. > Source/JavaScriptCore/bytecode/Opcode.cpp:212 > +unsigned metadataAlignment(OpcodeID opcodeID) > +{ > + return metadataAlignments[opcodeID]; > +} Ditto. 1473462 9 353371 keith_miller 2018-10-30 15:58:06 -0700 Comment on attachment 353371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353371&action=review > Source/JavaScriptCore/bytecode/MetadataTable.h:59 > + for (; metadata + 1 <= end; ++metadata) Can we make this metadata < end? 1473508 10 353439 dominik.infuehr 2018-10-30 16:57:57 -0700 Created attachment 353439 Patch 1473512 11 dominik.infuehr 2018-10-30 17:03:05 -0700 I've updated the patch, metadataAlignment is now only included if aligned memory access is required. @Keith: Not sure I can write this condition like this. Please correct me if I am wrong but wouldn't `metadata < end` run one iteration too often if there is an alignment gap at the end? 1473549 12 keith_miller 2018-10-30 18:15:28 -0700 (In reply to Dominik Inführ from comment #11) > I've updated the patch, metadataAlignment is now only included if aligned > memory access is required. > > @Keith: Not sure I can write this condition like this. Please correct me if > I am wrong but wouldn't `metadata < end` run one iteration too often if > there is an alignment gap at the end? Yeah, nvm ignore me. 1473732 13 353439 commit-queue 2018-10-31 09:09:15 -0700 Comment on attachment 353439 Patch Clearing flags on attachment: 353439 Committed r237638: <https://trac.webkit.org/changeset/237638> 1473733 14 commit-queue 2018-10-31 09:09:17 -0700 All reviewed patches have been landed. Closing bug. 1473735 15 webkit-bug-importer 2018-10-31 09:10:31 -0700 <rdar://problem/45701324> 353361 2018-10-30 05:05:47 -0700 2018-10-30 08:46:43 -0700 Patch bug-191062-20181030130545.patch text/plain 4766 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZTk2M2E4MzIwMzljNmIzYTgzZjAxODg1MTcxNWU4MWY3Njk3ZTA0Li4yN2JkNWIxZmNiMWRiMjZm NDFhMmIxNzliOTc2YWVhZWZjZTlhMWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMC0zMCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBBbGlnbiBlbnRyaWVzIGluIG1ldGFkYXRhIHRhYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwNjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnRyaWVzIGluIHRoZSBt ZXRhZGF0YSB0YWJsZSBuZWVkIHRvIGJlIGFsaWduZWQgb24gc29tZSAzMi1iaXQKKyAgICAgICAg YXJjaGl0ZWN0dXJlcy4KKworICAgICAgICAqIGJ5dGVjb2RlL01ldGFkYXRhVGFibGUuaDoKKyAg ICAgICAgKEpTQzo6TWV0YWRhdGFUYWJsZTo6Zm9yRWFjaCk6CisgICAgICAgICogYnl0ZWNvZGUv T3Bjb2RlLmNwcDoKKyAgICAgICAgKEpTQzo6bWV0YWRhdGFBbGlnbm1lbnQpOgorICAgICAgICAq IGJ5dGVjb2RlL09wY29kZS5oOgorICAgICAgICAqIGJ5dGVjb2RlL1VubGlua2VkTWV0YWRhdGFU YWJsZUlubGluZXMuaDoKKyAgICAgICAgKEpTQzo6VW5saW5rZWRNZXRhZGF0YVRhYmxlOjpmaW5h bGl6ZSk6CisgICAgICAgICogZ2VuZXJhdG9yL1NlY3Rpb24ucmI6CisKIDIwMTgtMTAtMzAgIFl1 c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICAiVW5y ZXZpZXdlZCwgcGFydGlhbCByb2xsaW5nIGluIHIyMzcyNTQiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTWV0YWRhdGFUYWJsZS5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL01ldGFkYXRhVGFibGUuaAppbmRleCA1NzBkMTBhYjhlMmY2NGNmYjkz N2YzZTUwODg3OTE3YTY3MjQxOTk2Li41YWNlYTcwOGMwODI4YjZkMzhiMzEyNGM4MTU0ZDYwNzlh YzZhMGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTWV0YWRh dGFUYWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9NZXRhZGF0YVRh YmxlLmgKQEAgLTU2LDcgKzU2LDcgQEAgcHVibGljOgogCiAgICAgICAgIGF1dG8qIG1ldGFkYXRh ID0gcmVpbnRlcnByZXRfY2FzdDx0eXBlbmFtZSBPcDo6TWV0YWRhdGEqPihnZXQoT3A6Om9wY29k ZUlEKSk7CiAgICAgICAgIGF1dG8qIGVuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dHlwZW5hbWUgT3A6 Ok1ldGFkYXRhKj4oZ2V0SW1wbChPcDo6b3Bjb2RlSUQgKyAxKSk7Ci0gICAgICAgIGZvciAoOyBt ZXRhZGF0YSAhPSBlbmQ7ICsrbWV0YWRhdGEpCisgICAgICAgIGZvciAoOyBtZXRhZGF0YSArIDEg PD0gZW5kOyArK21ldGFkYXRhKQogICAgICAgICAgICAgZnVuYygqbWV0YWRhdGEpOwogICAgIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmNwcAppbmRleCA2NDg4YjIy NTQzODEyMjQzNmUzMmU2ODYzYzFmOWJjNjVhMGZjN2UzLi5lY2VhN2Y3YzU1NTdhOWFlZWRmNGQ1 NjEyYzY5NjZkNTRjYjEwM2RjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvT3Bjb2RlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bj b2RlLmNwcApAQCAtMTkzLDExICsxOTMsMjQgQEAgc3RhdGljIHVuc2lnbmVkIG1ldGFkYXRhU2l6 ZXNbXSA9IHsKIAogfTsKIAorc3RhdGljIHVuc2lnbmVkIG1ldGFkYXRhQWxpZ25tZW50c1tdID0g eworCisjZGVmaW5lIE1FVEFEQVRBX0FMSUdOTUVOVChzaXplKSBzaXplLAorICAgIEZPUl9FQUNI X0JZVEVDT0RFX01FVEFEQVRBX0FMSUdOTUVOVChNRVRBREFUQV9BTElHTk1FTlQpCisjdW5kZWYg TUVUQURBVEFfQUxJR05NRU5UCisKK307CisKIHVuc2lnbmVkIG1ldGFkYXRhU2l6ZShPcGNvZGVJ RCBvcGNvZGVJRCkKIHsKICAgICByZXR1cm4gbWV0YWRhdGFTaXplc1tvcGNvZGVJRF07CiB9CiAK K3Vuc2lnbmVkIG1ldGFkYXRhQWxpZ25tZW50KE9wY29kZUlEIG9wY29kZUlEKQoreworICAgIHJl dHVybiBtZXRhZGF0YUFsaWdubWVudHNbb3Bjb2RlSURdOworfQorCiAKIH0gLy8gbmFtZXNwYWNl IEpTQwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2Rl LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgKaW5kZXggZjUzMDdm ZjE1OGRhMTk2NWVhNGI4NTRiZTM5YzllM2JiOGFiNjA0ZS4uNWZkYmQ0NmU3YjRjYmQxMmRmOWRj ZWE4NDhkNTZhZDFkZjQyMDYwNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL09wY29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNv ZGUuaApAQCAtMjQ1LDYgKzI0NSw3IEBAIGlubGluZSBib29sIGlzVGhyb3coT3Bjb2RlSUQgb3Bj b2RlSUQpCiB9CiAKIHVuc2lnbmVkIG1ldGFkYXRhU2l6ZShPcGNvZGVJRCk7Cit1bnNpZ25lZCBt ZXRhZGF0YUFsaWdubWVudChPcGNvZGVJRCk7CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRNZXRhZGF0YVRh YmxlSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkTWV0 YWRhdGFUYWJsZUlubGluZXMuaAppbmRleCBhM2JlOGYxMzI0NTc0M2VhYmFlODc5NWZmNTRmMTM1 MDJkYjJkOWRlLi4wYWRiMWMxYTlkNzRkMzZhZTEyMDkxNGE2ZTEyZjk0NWFmNzc3NmE5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRNZXRhZGF0YVRh YmxlSW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Vbmxpbmtl ZE1ldGFkYXRhVGFibGVJbmxpbmVzLmgKQEAgLTkxLDggKzkxLDEyIEBAIEFMV0FZU19JTkxJTkUg dm9pZCBVbmxpbmtlZE1ldGFkYXRhVGFibGU6OmZpbmFsaXplKCkKICAgICB1bnNpZ25lZCBvZmZz ZXQgPSBzX29mZnNldFRhYmxlU2l6ZTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc19v ZmZzZXRUYWJsZUVudHJpZXMgLSAxOyBpKyspIHsKICAgICAgICAgdW5zaWduZWQgbnVtYmVyT2ZF bnRyaWVzID0gbV9idWZmZXJbaV07Ci0gICAgICAgIG1fYnVmZmVyW2ldID0gb2Zmc2V0OwotICAg ICAgICBvZmZzZXQgKz0gbnVtYmVyT2ZFbnRyaWVzICogbWV0YWRhdGFTaXplKHN0YXRpY19jYXN0 PE9wY29kZUlEPihpKSk7CisKKyAgICAgICAgaWYgKG51bWJlck9mRW50cmllcyA+IDApIHsKKyAg ICAgICAgICAgIG1fYnVmZmVyW2ldID0gb2Zmc2V0ID0gcm91bmRVcFRvTXVsdGlwbGVPZihtZXRh ZGF0YUFsaWdubWVudChzdGF0aWNfY2FzdDxPcGNvZGVJRD4oaSkpLCBvZmZzZXQpOworICAgICAg ICAgICAgb2Zmc2V0ICs9IG51bWJlck9mRW50cmllcyAqIG1ldGFkYXRhU2l6ZShzdGF0aWNfY2Fz dDxPcGNvZGVJRD4oaSkpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIG1fYnVmZmVyW2ld ID0gb2Zmc2V0OwogICAgIH0KICAgICBtX2J1ZmZlcltzX29mZnNldFRhYmxlRW50cmllcyAtIDFd ID0gb2Zmc2V0OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRv ci9TZWN0aW9uLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRvci9TZWN0aW9uLnJi CmluZGV4IDhkNzQ4NzU3YWVlMmM4NDYxMjE2MjViZTViZTcyNmI1YTRmYTVjYzcuLmY0MjhhODM2 MTBjY2JiMzk4MWE2ZDIzYjNmZDJhNjY5NzU0OTk0M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9nZW5lcmF0b3IvU2VjdGlvbi5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZ2VuZXJhdG9yL1NlY3Rpb24ucmIKQEAgLTgxLDYgKzgxLDE5IEBAIGNsYXNzIFNlY3Rpb24K ICAgICAgICAgICAgICAgaSArPSAxCiAgICAgICAgICAgZW5kCiAgICAgICAgICAgb3V0IDw8ICJc biIKKworICAgICAgICAgIG91dC53cml0ZSgiI2RlZmluZSBGT1JfRUFDSF8je2NvbmZpZ1s6bWFj cm9fbmFtZV9jb21wb25lbnRdfV9NRVRBREFUQV9BTElHTk1FTlQobWFjcm8pIFxcXG4iKQorICAg ICAgICAgIGkgPSAwCisgICAgICAgICAgd2hpbGUgdHJ1ZQorICAgICAgICAgICAgICBpZiBvcGNv ZGVzW2ldLm1ldGFkYXRhLmVtcHR5PworICAgICAgICAgICAgICAgICAgb3V0IDw8ICJcbiIKKyAg ICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgICAgICAgIGVuZAorCisgICAgICAgICAgICAg IG91dC53cml0ZSgibWFjcm8oYWxpZ25vZigje29wY29kZXNbaV0uY2FwaXRhbGl6ZWRfbmFtZX06 Ok1ldGFkYXRhKSlcXFxuIikKKyAgICAgICAgICAgICAgaSArPSAxCisgICAgICAgICAgZW5kCisg ICAgICAgICAgb3V0IDw8ICJcbiIKICAgICAgIGVuZAogCiAgICAgICBpZiBjb25maWdbOmVtaXRf b3Bjb2RlX2lkX3N0cmluZ192YWx1ZXNfaW5faF9maWxlXQo= 353371 2018-10-30 08:46:48 -0700 2018-10-30 16:57:51 -0700 Patch bug-191062-20181030164647.patch text/plain 4826 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZTk2M2E4MzIwMzljNmIzYTgzZjAxODg1MTcxNWU4MWY3Njk3ZTA0Li4yN2JkNWIxZmNiMWRiMjZm NDFhMmIxNzliOTc2YWVhZWZjZTlhMWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMC0zMCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBBbGlnbiBlbnRyaWVzIGluIG1ldGFkYXRhIHRhYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwNjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnRyaWVzIGluIHRoZSBt ZXRhZGF0YSB0YWJsZSBuZWVkIHRvIGJlIGFsaWduZWQgb24gc29tZSAzMi1iaXQKKyAgICAgICAg YXJjaGl0ZWN0dXJlcy4KKworICAgICAgICAqIGJ5dGVjb2RlL01ldGFkYXRhVGFibGUuaDoKKyAg ICAgICAgKEpTQzo6TWV0YWRhdGFUYWJsZTo6Zm9yRWFjaCk6CisgICAgICAgICogYnl0ZWNvZGUv T3Bjb2RlLmNwcDoKKyAgICAgICAgKEpTQzo6bWV0YWRhdGFBbGlnbm1lbnQpOgorICAgICAgICAq IGJ5dGVjb2RlL09wY29kZS5oOgorICAgICAgICAqIGJ5dGVjb2RlL1VubGlua2VkTWV0YWRhdGFU YWJsZUlubGluZXMuaDoKKyAgICAgICAgKEpTQzo6VW5saW5rZWRNZXRhZGF0YVRhYmxlOjpmaW5h bGl6ZSk6CisgICAgICAgICogZ2VuZXJhdG9yL1NlY3Rpb24ucmI6CisKIDIwMTgtMTAtMzAgIFl1 c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICAiVW5y ZXZpZXdlZCwgcGFydGlhbCByb2xsaW5nIGluIHIyMzcyNTQiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTWV0YWRhdGFUYWJsZS5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL01ldGFkYXRhVGFibGUuaAppbmRleCA1NzBkMTBhYjhlMmY2NGNmYjkz N2YzZTUwODg3OTE3YTY3MjQxOTk2Li41YWNlYTcwOGMwODI4YjZkMzhiMzEyNGM4MTU0ZDYwNzlh YzZhMGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTWV0YWRh dGFUYWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9NZXRhZGF0YVRh YmxlLmgKQEAgLTU2LDcgKzU2LDcgQEAgcHVibGljOgogCiAgICAgICAgIGF1dG8qIG1ldGFkYXRh ID0gcmVpbnRlcnByZXRfY2FzdDx0eXBlbmFtZSBPcDo6TWV0YWRhdGEqPihnZXQoT3A6Om9wY29k ZUlEKSk7CiAgICAgICAgIGF1dG8qIGVuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dHlwZW5hbWUgT3A6 Ok1ldGFkYXRhKj4oZ2V0SW1wbChPcDo6b3Bjb2RlSUQgKyAxKSk7Ci0gICAgICAgIGZvciAoOyBt ZXRhZGF0YSAhPSBlbmQ7ICsrbWV0YWRhdGEpCisgICAgICAgIGZvciAoOyBtZXRhZGF0YSArIDEg PD0gZW5kOyArK21ldGFkYXRhKQogICAgICAgICAgICAgZnVuYygqbWV0YWRhdGEpOwogICAgIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmNwcAppbmRleCA2NDg4YjIy NTQzODEyMjQzNmUzMmU2ODYzYzFmOWJjNjVhMGZjN2UzLi5lY2VhN2Y3YzU1NTdhOWFlZWRmNGQ1 NjEyYzY5NjZkNTRjYjEwM2RjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvT3Bjb2RlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bj b2RlLmNwcApAQCAtMTkzLDExICsxOTMsMjQgQEAgc3RhdGljIHVuc2lnbmVkIG1ldGFkYXRhU2l6 ZXNbXSA9IHsKIAogfTsKIAorc3RhdGljIHVuc2lnbmVkIG1ldGFkYXRhQWxpZ25tZW50c1tdID0g eworCisjZGVmaW5lIE1FVEFEQVRBX0FMSUdOTUVOVChzaXplKSBzaXplLAorICAgIEZPUl9FQUNI X0JZVEVDT0RFX01FVEFEQVRBX0FMSUdOTUVOVChNRVRBREFUQV9BTElHTk1FTlQpCisjdW5kZWYg TUVUQURBVEFfQUxJR05NRU5UCisKK307CisKIHVuc2lnbmVkIG1ldGFkYXRhU2l6ZShPcGNvZGVJ RCBvcGNvZGVJRCkKIHsKICAgICByZXR1cm4gbWV0YWRhdGFTaXplc1tvcGNvZGVJRF07CiB9CiAK K3Vuc2lnbmVkIG1ldGFkYXRhQWxpZ25tZW50KE9wY29kZUlEIG9wY29kZUlEKQoreworICAgIHJl dHVybiBtZXRhZGF0YUFsaWdubWVudHNbb3Bjb2RlSURdOworfQorCiAKIH0gLy8gbmFtZXNwYWNl IEpTQwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2Rl LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgKaW5kZXggZjUzMDdm ZjE1OGRhMTk2NWVhNGI4NTRiZTM5YzllM2JiOGFiNjA0ZS4uNWZkYmQ0NmU3YjRjYmQxMmRmOWRj ZWE4NDhkNTZhZDFkZjQyMDYwNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL09wY29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNv ZGUuaApAQCAtMjQ1LDYgKzI0NSw3IEBAIGlubGluZSBib29sIGlzVGhyb3coT3Bjb2RlSUQgb3Bj b2RlSUQpCiB9CiAKIHVuc2lnbmVkIG1ldGFkYXRhU2l6ZShPcGNvZGVJRCk7Cit1bnNpZ25lZCBt ZXRhZGF0YUFsaWdubWVudChPcGNvZGVJRCk7CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRNZXRhZGF0YVRh YmxlSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkTWV0 YWRhdGFUYWJsZUlubGluZXMuaAppbmRleCBhM2JlOGYxMzI0NTc0M2VhYmFlODc5NWZmNTRmMTM1 MDJkYjJkOWRlLi4wM2ZmYjYzMjE2MWQ1M2VmYTUzMzFkNDRiZDZkZjFjNDE3NmM2NTk0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRNZXRhZGF0YVRh YmxlSW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Vbmxpbmtl ZE1ldGFkYXRhVGFibGVJbmxpbmVzLmgKQEAgLTkxLDggKzkxLDE1IEBAIEFMV0FZU19JTkxJTkUg dm9pZCBVbmxpbmtlZE1ldGFkYXRhVGFibGU6OmZpbmFsaXplKCkKICAgICB1bnNpZ25lZCBvZmZz ZXQgPSBzX29mZnNldFRhYmxlU2l6ZTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc19v ZmZzZXRUYWJsZUVudHJpZXMgLSAxOyBpKyspIHsKICAgICAgICAgdW5zaWduZWQgbnVtYmVyT2ZF bnRyaWVzID0gbV9idWZmZXJbaV07Ci0gICAgICAgIG1fYnVmZmVyW2ldID0gb2Zmc2V0OwotICAg ICAgICBvZmZzZXQgKz0gbnVtYmVyT2ZFbnRyaWVzICogbWV0YWRhdGFTaXplKHN0YXRpY19jYXN0 PE9wY29kZUlEPihpKSk7CisKKyAgICAgICAgaWYgKG51bWJlck9mRW50cmllcyA+IDApIHsKKyNp ZiBDUFUoTkVFRFNfQUxJR05FRF9BQ0NFU1MpCisgICAgICAgICAgICBvZmZzZXQgPSByb3VuZFVw VG9NdWx0aXBsZU9mKG1ldGFkYXRhQWxpZ25tZW50KHN0YXRpY19jYXN0PE9wY29kZUlEPihpKSks IG9mZnNldCk7CisjZW5kaWYKKyAgICAgICAgICAgIG1fYnVmZmVyW2ldID0gb2Zmc2V0OworICAg ICAgICAgICAgb2Zmc2V0ICs9IG51bWJlck9mRW50cmllcyAqIG1ldGFkYXRhU2l6ZShzdGF0aWNf Y2FzdDxPcGNvZGVJRD4oaSkpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIG1fYnVmZmVy W2ldID0gb2Zmc2V0OwogICAgIH0KICAgICBtX2J1ZmZlcltzX29mZnNldFRhYmxlRW50cmllcyAt IDFdID0gb2Zmc2V0OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVy YXRvci9TZWN0aW9uLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRvci9TZWN0aW9u LnJiCmluZGV4IDhkNzQ4NzU3YWVlMmM4NDYxMjE2MjViZTViZTcyNmI1YTRmYTVjYzcuLmY0Mjhh ODM2MTBjY2JiMzk4MWE2ZDIzYjNmZDJhNjY5NzU0OTk0M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9nZW5lcmF0b3IvU2VjdGlvbi5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZ2VuZXJhdG9yL1NlY3Rpb24ucmIKQEAgLTgxLDYgKzgxLDE5IEBAIGNsYXNzIFNlY3Rp b24KICAgICAgICAgICAgICAgaSArPSAxCiAgICAgICAgICAgZW5kCiAgICAgICAgICAgb3V0IDw8 ICJcbiIKKworICAgICAgICAgIG91dC53cml0ZSgiI2RlZmluZSBGT1JfRUFDSF8je2NvbmZpZ1s6 bWFjcm9fbmFtZV9jb21wb25lbnRdfV9NRVRBREFUQV9BTElHTk1FTlQobWFjcm8pIFxcXG4iKQor ICAgICAgICAgIGkgPSAwCisgICAgICAgICAgd2hpbGUgdHJ1ZQorICAgICAgICAgICAgICBpZiBv cGNvZGVzW2ldLm1ldGFkYXRhLmVtcHR5PworICAgICAgICAgICAgICAgICAgb3V0IDw8ICJcbiIK KyAgICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgICAgICAgIGVuZAorCisgICAgICAgICAg ICAgIG91dC53cml0ZSgibWFjcm8oYWxpZ25vZigje29wY29kZXNbaV0uY2FwaXRhbGl6ZWRfbmFt ZX06Ok1ldGFkYXRhKSlcXFxuIikKKyAgICAgICAgICAgICAgaSArPSAxCisgICAgICAgICAgZW5k CisgICAgICAgICAgb3V0IDw8ICJcbiIKICAgICAgIGVuZAogCiAgICAgICBpZiBjb25maWdbOmVt aXRfb3Bjb2RlX2lkX3N0cmluZ192YWx1ZXNfaW5faF9maWxlXQo= 353439 2018-10-30 16:57:57 -0700 2018-10-31 09:09:15 -0700 Patch bug-191062-20181031005756.patch text/plain 4941 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZTk2M2E4MzIwMzljNmIzYTgzZjAxODg1MTcxNWU4MWY3Njk3ZTA0Li4yN2JkNWIxZmNiMWRiMjZm NDFhMmIxNzliOTc2YWVhZWZjZTlhMWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMC0zMCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBBbGlnbiBlbnRyaWVzIGluIG1ldGFkYXRhIHRhYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwNjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnRyaWVzIGluIHRoZSBt ZXRhZGF0YSB0YWJsZSBuZWVkIHRvIGJlIGFsaWduZWQgb24gc29tZSAzMi1iaXQKKyAgICAgICAg YXJjaGl0ZWN0dXJlcy4KKworICAgICAgICAqIGJ5dGVjb2RlL01ldGFkYXRhVGFibGUuaDoKKyAg ICAgICAgKEpTQzo6TWV0YWRhdGFUYWJsZTo6Zm9yRWFjaCk6CisgICAgICAgICogYnl0ZWNvZGUv T3Bjb2RlLmNwcDoKKyAgICAgICAgKEpTQzo6bWV0YWRhdGFBbGlnbm1lbnQpOgorICAgICAgICAq IGJ5dGVjb2RlL09wY29kZS5oOgorICAgICAgICAqIGJ5dGVjb2RlL1VubGlua2VkTWV0YWRhdGFU YWJsZUlubGluZXMuaDoKKyAgICAgICAgKEpTQzo6VW5saW5rZWRNZXRhZGF0YVRhYmxlOjpmaW5h bGl6ZSk6CisgICAgICAgICogZ2VuZXJhdG9yL1NlY3Rpb24ucmI6CisKIDIwMTgtMTAtMzAgIFl1 c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICAiVW5y ZXZpZXdlZCwgcGFydGlhbCByb2xsaW5nIGluIHIyMzcyNTQiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTWV0YWRhdGFUYWJsZS5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL01ldGFkYXRhVGFibGUuaAppbmRleCA1NzBkMTBhYjhlMmY2NGNmYjkz N2YzZTUwODg3OTE3YTY3MjQxOTk2Li41YWNlYTcwOGMwODI4YjZkMzhiMzEyNGM4MTU0ZDYwNzlh YzZhMGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTWV0YWRh dGFUYWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9NZXRhZGF0YVRh YmxlLmgKQEAgLTU2LDcgKzU2LDcgQEAgcHVibGljOgogCiAgICAgICAgIGF1dG8qIG1ldGFkYXRh ID0gcmVpbnRlcnByZXRfY2FzdDx0eXBlbmFtZSBPcDo6TWV0YWRhdGEqPihnZXQoT3A6Om9wY29k ZUlEKSk7CiAgICAgICAgIGF1dG8qIGVuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dHlwZW5hbWUgT3A6 Ok1ldGFkYXRhKj4oZ2V0SW1wbChPcDo6b3Bjb2RlSUQgKyAxKSk7Ci0gICAgICAgIGZvciAoOyBt ZXRhZGF0YSAhPSBlbmQ7ICsrbWV0YWRhdGEpCisgICAgICAgIGZvciAoOyBtZXRhZGF0YSArIDEg PD0gZW5kOyArK21ldGFkYXRhKQogICAgICAgICAgICAgZnVuYygqbWV0YWRhdGEpOwogICAgIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmNwcAppbmRleCA2NDg4YjIy NTQzODEyMjQzNmUzMmU2ODYzYzFmOWJjNjVhMGZjN2UzLi45ZmFjNDUzMTQzMDU5OTViN2E2ZDI4 MWNiMGNjNWFhMmU1NDIyOWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvT3Bjb2RlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bj b2RlLmNwcApAQCAtMTkzLDExICsxOTMsMjcgQEAgc3RhdGljIHVuc2lnbmVkIG1ldGFkYXRhU2l6 ZXNbXSA9IHsKIAogfTsKIAorI2lmIENQVShORUVEU19BTElHTkVEX0FDQ0VTUykKK3N0YXRpYyB1 bnNpZ25lZCBtZXRhZGF0YUFsaWdubWVudHNbXSA9IHsKKworI2RlZmluZSBNRVRBREFUQV9BTElH Tk1FTlQoc2l6ZSkgc2l6ZSwKKyAgICBGT1JfRUFDSF9CWVRFQ09ERV9NRVRBREFUQV9BTElHTk1F TlQoTUVUQURBVEFfQUxJR05NRU5UKQorI3VuZGVmIE1FVEFEQVRBX0FMSUdOTUVOVAorCit9Owor I2VuZGlmCisKIHVuc2lnbmVkIG1ldGFkYXRhU2l6ZShPcGNvZGVJRCBvcGNvZGVJRCkKIHsKICAg ICByZXR1cm4gbWV0YWRhdGFTaXplc1tvcGNvZGVJRF07CiB9CiAKKyNpZiBDUFUoTkVFRFNfQUxJ R05FRF9BQ0NFU1MpCit1bnNpZ25lZCBtZXRhZGF0YUFsaWdubWVudChPcGNvZGVJRCBvcGNvZGVJ RCkKK3sKKyAgICByZXR1cm4gbWV0YWRhdGFBbGlnbm1lbnRzW29wY29kZUlEXTsKK30KKyNlbmRp ZgogCiB9IC8vIG5hbWVzcGFjZSBKU0MKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL09wY29kZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09w Y29kZS5oCmluZGV4IGY1MzA3ZmYxNThkYTE5NjVlYTRiODU0YmUzOWM5ZTNiYjhhYjYwNGUuLmE2 NWFmZTkxN2NkZDQxMGQ5NjQ4MTUwOGVlZGYxNDZmMGU0ODUyZDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgKQEAgLTI0NSw2ICsyNDUsOSBAQCBpbmxpbmUgYm9vbCBp c1Rocm93KE9wY29kZUlEIG9wY29kZUlEKQogfQogCiB1bnNpZ25lZCBtZXRhZGF0YVNpemUoT3Bj b2RlSUQpOworI2lmIENQVShORUVEU19BTElHTkVEX0FDQ0VTUykKK3Vuc2lnbmVkIG1ldGFkYXRh QWxpZ25tZW50KE9wY29kZUlEKTsKKyNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBKU0MKIApkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkTWV0YWRhdGFU YWJsZUlubGluZXMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZE1l dGFkYXRhVGFibGVJbmxpbmVzLmgKaW5kZXggYTNiZThmMTMyNDU3NDNlYWJhZTg3OTVmZjU0ZjEz NTAyZGIyZDlkZS4uMDNmZmI2MzIxNjFkNTNlZmE1MzMxZDQ0YmQ2ZGYxYzQxNzZjNjU5NCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkTWV0YWRhdGFU YWJsZUlubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5r ZWRNZXRhZGF0YVRhYmxlSW5saW5lcy5oCkBAIC05MSw4ICs5MSwxNSBAQCBBTFdBWVNfSU5MSU5F IHZvaWQgVW5saW5rZWRNZXRhZGF0YVRhYmxlOjpmaW5hbGl6ZSgpCiAgICAgdW5zaWduZWQgb2Zm c2V0ID0gc19vZmZzZXRUYWJsZVNpemU7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHNf b2Zmc2V0VGFibGVFbnRyaWVzIC0gMTsgaSsrKSB7CiAgICAgICAgIHVuc2lnbmVkIG51bWJlck9m RW50cmllcyA9IG1fYnVmZmVyW2ldOwotICAgICAgICBtX2J1ZmZlcltpXSA9IG9mZnNldDsKLSAg ICAgICAgb2Zmc2V0ICs9IG51bWJlck9mRW50cmllcyAqIG1ldGFkYXRhU2l6ZShzdGF0aWNfY2Fz dDxPcGNvZGVJRD4oaSkpOworCisgICAgICAgIGlmIChudW1iZXJPZkVudHJpZXMgPiAwKSB7Cisj aWYgQ1BVKE5FRURTX0FMSUdORURfQUNDRVNTKQorICAgICAgICAgICAgb2Zmc2V0ID0gcm91bmRV cFRvTXVsdGlwbGVPZihtZXRhZGF0YUFsaWdubWVudChzdGF0aWNfY2FzdDxPcGNvZGVJRD4oaSkp LCBvZmZzZXQpOworI2VuZGlmCisgICAgICAgICAgICBtX2J1ZmZlcltpXSA9IG9mZnNldDsKKyAg ICAgICAgICAgIG9mZnNldCArPSBudW1iZXJPZkVudHJpZXMgKiBtZXRhZGF0YVNpemUoc3RhdGlj X2Nhc3Q8T3Bjb2RlSUQ+KGkpKTsKKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBtX2J1ZmZl cltpXSA9IG9mZnNldDsKICAgICB9CiAgICAgbV9idWZmZXJbc19vZmZzZXRUYWJsZUVudHJpZXMg LSAxXSA9IG9mZnNldDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9nZW5l cmF0b3IvU2VjdGlvbi5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9nZW5lcmF0b3IvU2VjdGlv bi5yYgppbmRleCA4ZDc0ODc1N2FlZTJjODQ2MTIxNjI1YmU1YmU3MjZiNWE0ZmE1Y2M3Li5mNDI4 YTgzNjEwY2NiYjM5ODFhNmQyM2IzZmQyYTY2OTc1NDk5NDNhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZ2VuZXJhdG9yL1NlY3Rpb24ucmIKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2dlbmVyYXRvci9TZWN0aW9uLnJiCkBAIC04MSw2ICs4MSwxOSBAQCBjbGFzcyBTZWN0 aW9uCiAgICAgICAgICAgICAgIGkgKz0gMQogICAgICAgICAgIGVuZAogICAgICAgICAgIG91dCA8 PCAiXG4iCisKKyAgICAgICAgICBvdXQud3JpdGUoIiNkZWZpbmUgRk9SX0VBQ0hfI3tjb25maWdb Om1hY3JvX25hbWVfY29tcG9uZW50XX1fTUVUQURBVEFfQUxJR05NRU5UKG1hY3JvKSBcXFxuIikK KyAgICAgICAgICBpID0gMAorICAgICAgICAgIHdoaWxlIHRydWUKKyAgICAgICAgICAgICAgaWYg b3Bjb2Rlc1tpXS5tZXRhZGF0YS5lbXB0eT8KKyAgICAgICAgICAgICAgICAgIG91dCA8PCAiXG4i CisgICAgICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAgICBlbmQKKworICAgICAgICAg ICAgICBvdXQud3JpdGUoIm1hY3JvKGFsaWdub2YoI3tvcGNvZGVzW2ldLmNhcGl0YWxpemVkX25h bWV9OjpNZXRhZGF0YSkpXFxcbiIpCisgICAgICAgICAgICAgIGkgKz0gMQorICAgICAgICAgIGVu ZAorICAgICAgICAgIG91dCA8PCAiXG4iCiAgICAgICBlbmQKIAogICAgICAgaWYgY29uZmlnWzpl bWl0X29wY29kZV9pZF9zdHJpbmdfdmFsdWVzX2luX2hfZmlsZV0K