<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190929</bug_id>
          
          <creation_ts>2018-10-25 16:23:06 -0700</creation_ts>
          <short_desc>BytecodeGenerator should not force op_get_by_val to be wide within IndexedForInContext</short_desc>
          <delta_ts>2019-05-21 03:54:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>197979</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tadeu Zagallo">tzagallo</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1472242</commentid>
    <comment_count>0</comment_count>
    <who name="Tadeu Zagallo">tzagallo</who>
    <bug_when>2018-10-25 16:23:06 -0700</bug_when>
    <thetext>As part of https://bugs.webkit.org/show_bug.cgi?id=187373, when emitting an op_get_by_bal within an IndexedForInContext we force it to be emitted as a wide instruction since we might need to patch the instruction later and we want to guarantee that the alternative value fits in the instruction stream. However, we know the only value that we might use to patch the instruction ahead of time, so we could do do a Fits::check to see if it would fit in a narrow instruction and only force it to be wide otherwise.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537553</commentid>
    <comment_count>1</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-05-20 02:30:48 -0700</bug_when>
    <thetext>Right! We should do this :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1537847</commentid>
    <comment_count>2</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-05-21 03:54:24 -0700</bug_when>
    <thetext>I&apos;ll do this as a part of bug 197979.

*** This bug has been marked as a duplicate of bug 197979 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>