<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190905</bug_id>
          
          <creation_ts>2018-10-25 10:10:28 -0700</creation_ts>
          <short_desc>REGRESSION (r237255): Selection not painted for text with overflow:hidden</short_desc>
          <delta_ts>2018-10-25 12:52:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>macOS 10.14</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>190899</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, Regression</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>189833</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Ali Juma">ajuma</assigned_to>
          <cc>ajuma</cc>
    
    <cc>bfulgham</cc>
    
    <cc>mitz</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1472094</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-25 10:10:28 -0700</bug_when>
    <thetext>Selection is no longer painted for text with CSS overflow:hidden.

Open the page with the following markup in Safari:

[[
&lt;style&gt;
.test {
    text-decoration: underline;
}

.test::selection {
    background-color: blue;
    color: white;
}

.hidden {
    overflow: hidden;
}
&lt;/style&gt;
&lt;p class=&quot;test&quot;&gt;First line of text.&lt;/p&gt;
&lt;p class=&quot;test hidden&quot;&gt;Second line of text&lt;/p&gt;
]]

Click and drag from the word &quot;Second&quot; in the second line of text to the end of the line. No selection highlight is drawn. Compare to the behavior of clicking and dragging from the word &quot;First&quot; in the first line to the end of that line. I would have expected the same selection behavior for both lines. Additionally, if you focus the page and choose Edit &gt; Select All then only the first line and the gap between the first and second line are painted as selected. That is, the second line of text is not painted as selected. I would have expected all lines of text to have been painted as selected.

Weirdly, if you go through the motions to select the second line of text (e.g. click and drag from the word &quot;Second&quot; in the second of line text to the end of the line) then click where the selection would have been painted then the selection will be painted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472096</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-25 10:11:02 -0700</bug_when>
    <thetext>&lt;rdar://problem/45557072&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472098</commentid>
    <comment_count>2</comment_count>
      <attachid>353090</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-25 10:12:19 -0700</bug_when>
    <thetext>Created attachment 353090
Example

For convenience, here is a file with the markup given in comment #0.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472131</commentid>
    <comment_count>3</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-25 11:28:58 -0700</bug_when>
    <thetext>This regression was caused by &lt;http://trac.webkit.org/changeset/237255&gt; (bug #189833)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472133</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-25 11:30:16 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 190899 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472154</commentid>
    <comment_count>5</comment_count>
    <who name="Ali Juma">ajuma</who>
    <bug_when>2018-10-25 12:51:43 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472158</commentid>
    <comment_count>6</comment_count>
    <who name="Ali Juma">ajuma</who>
    <bug_when>2018-10-25 12:52:43 -0700</bug_when>
    <thetext>Whoops, meant to attach a patch to the other bug.

*** This bug has been marked as a duplicate of bug 190899 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>353090</attachid>
            <date>2018-10-25 10:12:19 -0700</date>
            <delta_ts>2018-10-25 10:12:19 -0700</delta_ts>
            <desc>Example</desc>
            <filename>example.html</filename>
            <type>text/html</type>
            <size>248</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">PHN0eWxlPgoudGVzdCB7CiAgICB0ZXh0LWRlY29yYXRpb246IHVuZGVybGluZTsKfQoKLnRlc3Q6
OnNlbGVjdGlvbiB7CiAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAgY29sb3I6IHdoaXRl
Owp9CgouaGlkZGVuIHsKICAgIG92ZXJmbG93OiBoaWRkZW47Cn0KPC9zdHlsZT4KPHAgY2xhc3M9
InRlc3QiPkZpcnN0IGxpbmUgb2YgdGV4dC48L3A+CjxwIGNsYXNzPSJ0ZXN0IGhpZGRlbiI+U2Vj
b25kIGxpbmUgb2YgdGV4dDwvcD4=
</data>

          </attachment>
      

    </bug>

</bugzilla>