190895 2018-10-24 18:49:03 -0700 [curl] ASSERTION FAILED: !m_didNotifyResponse || m_multipartHandle 2019-02-04 17:36:28 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii basuke don.olmstead ews-watchlist galpeter ross.kirsling webkit-bug-importer oldest_to_newest 1471989 0 fujii 2018-10-24 18:49:03 -0700 [curl] ASSERTION FAILED: !m_didNotifyResponse || m_multipartHandle Some test cases are failing due to hitting this assertion failure. https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Debug%20(Tests)/r237400%20(986)/results.html https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Debug%20(Tests)/r237400%20(986)/http/tests/xmlhttprequest/response-access-on-error-crash-log.txt > ASSERTION FAILED: !m_didNotifyResponse || m_multipartHandle > ..\..\Source\WebCore\platform\network\curl\CurlRequest.cpp(553) : WebCore::CurlRequest::invokeDidReceiveResponse > 1 00007FF94CE3221A WTFCrash > 2 00007FF930925CC1 WTFCrashWithInfo > 3 00007FF9329D6216 WebCore::CurlRequest::invokeDidReceiveResponse > 4 00007FF9329D5674 WebCore::CurlRequest::didCompleteTransfer > 5 00007FF933F021CA <lambda_5806470903b2870987393fc72f55f7e5>::operator() > 6 00007FF933F0323B WTF::Function<void __cdecl(WebCore::CurlRequestSchedulerClient *)>::CallableWrapper<<lambda_5806470903b2870987393fc72f55f7e5> >::call > 7 00007FF933F023C4 WTF::Function<void __cdecl(WebCore::CurlRequestSchedulerClient *)>::operator() > 8 00007FF933F020B0 <lambda_1da8f92f09c065ef17064f00a6de3c5d>::operator() > 9 00007FF933F0313F WTF::Function<void __cdecl(void)>::CallableWrapper<<lambda_1da8f92f09c065ef17064f00a6de3c5d> >::call > 10 00007FF930925598 WTF::Function<void __cdecl(void)>::operator() > 11 00007FF933EFCD2C WebCore::CurlRequestScheduler::executeTasks > 12 00007FF933EFCF12 WebCore::CurlRequestScheduler::workerThread > 13 00007FF933F022EB <lambda_f9d7a5b486f6e184d8e42c552b16bba4>::operator() > 14 00007FF933F032BF WTF::Function<void __cdecl(void)>::CallableWrapper<<lambda_f9d7a5b486f6e184d8e42c552b16bba4> >::call > 15 00007FF94CE49E07 WTF::Function<void __cdecl(void)>::operator() > 16 00007FF94CEBCB3E WTF::Thread::entryPoint > 17 00007FF94CF3E058 WTF::wtfThreadEntryPoint > 18 00007FF94BC5DC05 iswascii > 19 00007FF9531F1FE4 BaseThreadInitThunk > 20 00007FF965A2EF91 RtlUserThreadStart 1471990 1 fujii 2018-10-24 19:02:44 -0700 The other day I saw this assertion failure while using MiniBrowser. IIRC, m_didNotifyResponse was true in that case. 1471991 2 fujii 2018-10-24 19:08:45 -0700 I'm stupid. It is obvious. m_didNotifyResponse is true and m_multipartHandle is false in that case. Nvm my comment. 1501735 3 fujii 2019-02-03 21:13:41 -0800 This issue occurs in WK2, too. > python ./Tools/Scripts/run-webkit-tests --debug --wincairo --no-retry-failures --child-processes=1 -v http/tests/xmlhttprequest/access-control-basic-denied.html http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html 1501745 4 fujii 2019-02-03 22:34:56 -0800 Here is the members of CurlRequest that assertion failure is happening. > - this 0x000002b57563b230 {m_client=0x0000000000000000 <NULL> m_cancelled=false m_messageQueue=0x0000000000000000 <NULL> ...} WebCore::CurlRequest * > + WTF::ThreadSafeRefCounted<WebCore::CurlRequest,WTF::DestructionThread::Any> {...} WTF::ThreadSafeRefCounted<WebCore::CurlRequest,WTF::DestructionThread::Any> > + WebCore::CurlRequestSchedulerClient {...} WebCore::CurlRequestSchedulerClient > + WebCore::CurlMultipartHandleClient {...} WebCore::CurlMultipartHandleClient > + m_client 0x0000000000000000 <NULL> WebCore::CurlRequestClient * > m_cancelled false bool > + m_messageQueue 0x0000000000000000 <NULL> WTF::MessageQueue<WTF::Function<void ()> > * > + m_request {...} WebCore::ResourceRequest > + m_user {m_impl={m_ptr=0x0000000000000000 <NULL> } } WTF::String > + m_password {m_impl={m_ptr=0x0000000000000000 <NULL> } } WTF::String > m_authType 0xffffffef unsigned long > m_shouldSuspend false bool > m_enableMultipart false bool > + m_curlHandle unique_ptr {m_handle=0x000002b5756304a0 m_errorBuffer=0x000002b575635a30 "Operation too slow. Less than 1 bytes/sec transferred the last 10 seconds" ...} std::unique_ptr<WebCore::CurlHandle,std::default_delete<WebCore::CurlHandle> > > + m_formDataStream {m_formData={m_ptr=0x0000000000000000 <NULL> } m_postData=empty m_isContentLengthUpdated=false ...} WebCore::CurlFormDataStream > + m_multipartHandle empty std::unique_ptr<WebCore::CurlMultipartHandle,std::default_delete<WebCore::CurlMultipartHandle> > > + m_response {url={m_string={m_impl={m_ptr=0x000002b575600e10 {...} } } m_isValid=0x00000001 m_protocolIsInHTTPFamily=...} ...} WebCore::CurlResponse > m_didReceiveResponse true bool > m_didNotifyResponse true bool > m_didReturnFromNotify false bool > m_actionAfterInvoke ReceiveData (0x00000001) WebCore::CurlRequest::Action > m_finishedResultCode CURLE_OPERATION_TIMEDOUT (0x0000001c) <unnamed-tag> > m_isPausedOfRequest false bool > m_isPausedOfCallback true bool > + m_pauseStateMutex {m_byte={value=0x00 '\0' } } WTF::Lock > m_isHandlePaused true bool > + m_downloadMutex {m_byte={value=0x00 '\0' } } WTF::Lock > m_isEnabledDownloadToFile false bool > + m_downloadFilePath {m_impl={m_ptr=0x0000000000000000 <NULL> } } WTF::String > m_downloadFileHandle 0xffffffffffffffff void * > + m_certificateInfo {m_verificationError=0x00000000 m_certificateChain={...} } WebCore::CertificateInfo > m_captureExtraMetrics false bool > + m_networkLoadMetrics {domainLookupStart={m_value=0.00061202049255371094 } domainLookupEnd={m_value=0.015612020492553710 } ...} WebCore::NetworkLoadMetrics > + m_requestStartTime {m_value=1549261830.5828714 } WTF::MonotonicTime > + m_performStartTime {m_value=1549261830.5834835 } WTF::MonotonicTime > m_totalReceivedSize 0x0000000000000000 unsigned __int64 > behaviorAfterInvoke FinishTransfer (0x00000003) WebCore::CurlRequest::Action > + response {url={m_string={m_impl={m_ptr=0x000002b575600e10 {...} } } m_isValid=0x00000001 m_protocolIsInHTTPFamily=...} ...} const WebCore::CurlResponse & 1501746 5 fujii 2019-02-03 22:42:58 -0800 Here is the callstack: > WTF.dll!WTFCrash() Line 255 C++ > WebKit2.dll!WTFCrashWithInfo(int, const char *, const char *, int) Line 560 C++ > WebKit2.dll!WebCore::CurlRequest::invokeDidReceiveResponse(const WebCore::CurlResponse & response, WebCore::CurlRequest::Action behaviorAfterInvoke) Line 553 C++ > WebKit2.dll!WebCore::CurlRequest::didCompleteTransfer(<unnamed-tag> result) Line 428 C++ > WebKit2.dll!WebCore::CurlRequestScheduler::completeTransfer::<unnamed-tag>::operator()(WebCore::CurlRequestSchedulerClient * client) Line 210 C++ > WebKit2.dll!WTF::Function<void (WebCore::CurlRequestSchedulerClient *)>::CallableWrapper<`lambda at ..\..\Source\WebCore\platform\network\curl\CurlRequestScheduler.cpp:208:30'>::call(WebCore::CurlRequestSchedulerClient * in) Line 101 C++ > WebKit2.dll!WTF::Function<void (WebCore::CurlRequestSchedulerClient *)>::operator()(WebCore::CurlRequestSchedulerClient * in) Line 56 C++ > WebKit2.dll!WebCore::CurlRequestScheduler::finalizeTransfer::<unnamed-tag>::operator()() Line 232 C++ > WebKit2.dll!WTF::Function<void ()>::CallableWrapper<`lambda at ..\..\Source\WebCore\platform\network\curl\CurlRequestScheduler.cpp:222:17'>::call() Line 101 C++ > WebKit2.dll!WTF::Function<void ()>::operator()() Line 56 C++ > WebKit2.dll!WebCore::CurlRequestScheduler::executeTasks() Line 129 C++ > WebKit2.dll!WebCore::CurlRequestScheduler::workerThread() Line 146 C++ > WebKit2.dll!WebCore::CurlRequestScheduler::startThreadIfNeeded::<unnamed-tag>::operator()() Line 89 C++ > WebKit2.dll!WTF::Function<void ()>::CallableWrapper<`lambda at ..\..\Source\WebCore\platform\network\curl\CurlRequestScheduler.cpp:87:49'>::call() Line 101 C++ > WTF.dll!WTF::Function<void ()>::operator()() Line 56 C++ > WTF.dll!WTF::Thread::entryPoint(WTF::Thread::NewThreadContext * newThreadContext) Line 137 C++ > WTF.dll!WTF::wtfThreadEntryPoint(void * data) Line 152 C++ > [External Code] 1501751 6 fujii 2019-02-03 22:59:22 -0800 It seems that CurlRequestScheduler::completeTransfer was called while waiting for the reply of DidReceiveResponse. 1501763 7 361043 fujii 2019-02-03 23:34:30 -0800 Created attachment 361043 Patch 1502172 8 361043 fujii 2019-02-04 17:35:51 -0800 Comment on attachment 361043 Patch Clearing flags on attachment: 361043 Committed r240958: <https://trac.webkit.org/changeset/240958> 1502173 9 fujii 2019-02-04 17:35:54 -0800 All reviewed patches have been landed. Closing bug. 1502174 10 webkit-bug-importer 2019-02-04 17:36:28 -0800 <rdar://problem/47806894> 361043 2019-02-03 23:34:30 -0800 2019-02-04 17:35:51 -0800 Patch bug-190895-20190204163428.patch text/plain 2159 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTM0NzhlMzUzYmRmNGFl YWQ0NDE5OTEwNjJmOWFlZmJlZGM2ZjYwZi4uYTQxODlkN2ZlNDBhZjY5ZTBhYTdiOTBmNWNkNjJl MWY5MDViMzQwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAyLTAzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtjdXJsXSBB U1NFUlRJT04gRkFJTEVEOiAhbV9kaWROb3RpZnlSZXNwb25zZSB8fCBtX211bHRpcGFydEhhbmRs ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwODk1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQW4gYXNz ZXJ0aW9uIHdhcyBmYWlsaW5nIGluIEN1cmxSZXF1ZXN0OjppbnZva2VEaWRSZWNlaXZlUmVzcG9u c2UKKyAgICAgICAgYmVjYXVzZSBEaWRSZWNlaXZlUmVzcG9uc2Ugd2FzIGFscmVhZHkgZGlzcGF0 Y2hlZC4gVGhpcyBjb25kaXRpb24KKyAgICAgICAgd2FzIG1ldCBpZiBDdXJsUmVxdWVzdFNjaGVk dWxlcjo6Y29tcGxldGVUcmFuc2ZlciBpcyBjYWxsZWQgd2hpbGUKKyAgICAgICAgd2FpdGluZyBm b3IgdGhlIHJlcGx5IGZvciB0aGUgZmlyc3QgRGlkUmVjZWl2ZVJlc3BvbnNlLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oOgorICAgICAgICAoV2ViQ29yZTo6Q3Vy bFJlcXVlc3Q6Om5lZWRUb0ludm9rZURpZFJlY2VpdmVSZXNwb25zZSBjb25zdCk6CisgICAgICAg IFJldHVybiB0cnVlIGlmIG1fZGlkTm90aWZ5UmVzcG9uc2UgaXMgZmFsc2UgZGlzcmVnYXJkIHRv CisgICAgICAgIG1fZGlkUmV0dXJuRnJvbU5vdGlmeS4KKwogMjAxOS0wMi0wMyAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHNldE5lZWRzTGF5 b3V0IG9uIHRoZSByb290IG1vcmUgZXhwbGljaXRseSBhYm91dCB0cmlnZ2VyaW5nIGl0cyBzaWRl LWVmZmVjdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9DdXJsUmVxdWVzdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1 cmxSZXF1ZXN0LmgKaW5kZXggOTNjYTYxMDNmZTYzZDVmZjAzMTA1NWM4MjVkODAyODI3NjRhZWRi YS4uNTNhYTBiNTVmOGMwYzY5OGZhZWI0ZjFhZTNkZDY5YTFkNzMzMjQxMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmgKQEAgLTE0 MSw3ICsxNDEsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgc2V0dXBTZW5kRGF0YShib29sIGZvclB1 dE1ldGhvZCk7CiAKICAgICAvLyBQcm9jZXNzaW5nIGZvciBEaWRSZWNlaXZlUmVzcG9uc2UKLSAg ICBib29sIG5lZWRUb0ludm9rZURpZFJlY2VpdmVSZXNwb25zZSgpIGNvbnN0IHsgcmV0dXJuIG1f ZGlkUmVjZWl2ZVJlc3BvbnNlICYmICghbV9kaWROb3RpZnlSZXNwb25zZSB8fCAhbV9kaWRSZXR1 cm5Gcm9tTm90aWZ5KTsgfQorICAgIGJvb2wgbmVlZFRvSW52b2tlRGlkUmVjZWl2ZVJlc3BvbnNl KCkgY29uc3QgeyByZXR1cm4gbV9kaWRSZWNlaXZlUmVzcG9uc2UgJiYgIW1fZGlkTm90aWZ5UmVz cG9uc2U7IH0KICAgICBib29sIG5lZWRUb0ludm9rZURpZENhbmNlbFRyYW5zZmVyKCkgY29uc3Qg eyByZXR1cm4gbV9kaWROb3RpZnlSZXNwb25zZSAmJiAhbV9kaWRSZXR1cm5Gcm9tTm90aWZ5ICYm IG1fYWN0aW9uQWZ0ZXJJbnZva2UgPT0gQWN0aW9uOjpGaW5pc2hUcmFuc2ZlcjsgfQogICAgIHZv aWQgaW52b2tlRGlkUmVjZWl2ZVJlc3BvbnNlRm9yRmlsZShVUkwmKTsKICAgICB2b2lkIGludm9r ZURpZFJlY2VpdmVSZXNwb25zZShjb25zdCBDdXJsUmVzcG9uc2UmLCBBY3Rpb24pOwo=