<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190751</bug_id>
          
          <creation_ts>2018-10-19 03:18:51 -0700</creation_ts>
          <short_desc>[JSC] sub op with 0 should be optimized</short_desc>
          <delta_ts>2019-01-21 12:52:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1470833</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-10-19 03:18:51 -0700</bug_when>
    <thetext>[JSC] sub op with 0 should be optimized</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470835</commentid>
    <comment_count>1</comment_count>
      <attachid>352779</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-10-19 03:40:33 -0700</bug_when>
    <thetext>Created attachment 352779
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496375</commentid>
    <comment_count>2</comment_count>
      <attachid>352779</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-01-20 13:39:52 -0800</bug_when>
    <thetext>Comment on attachment 352779
Patch

Is this still valid?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496381</commentid>
    <comment_count>3</comment_count>
      <attachid>352779</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-20 13:48:53 -0800</bug_when>
    <thetext>Comment on attachment 352779
Patch

Hmm, not sure since this patch is old...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496409</commentid>
    <comment_count>4</comment_count>
      <attachid>359652</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-20 14:51:20 -0800</bug_when>
    <thetext>Created attachment 359652
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496411</commentid>
    <comment_count>5</comment_count>
      <attachid>359653</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-20 14:53:01 -0800</bug_when>
    <thetext>Created attachment 359653
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496412</commentid>
    <comment_count>6</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-20 14:53:20 -0800</bug_when>
    <thetext>Yes, it is still valid. Rebased the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496610</commentid>
    <comment_count>7</comment_count>
      <attachid>359653</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2019-01-21 10:08:34 -0800</bug_when>
    <thetext>Comment on attachment 359653
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359653&amp;action=review

r=me

&gt; Source/JavaScriptCore/offlineasm/arm64.rb:506
&gt; +                unless operands[0] == operands[2]

Why not express this as &quot;if operands[0] != operands[2]&quot;?

&gt; Source/JavaScriptCore/offlineasm/x86.rb:794
&gt; +                unless operands[0] == operands[2]

Why not express this as &quot;if operands[0] != operands[2]&quot;?

&gt; Source/JavaScriptCore/offlineasm/x86.rb:801
&gt; +                $asm.puts &quot;add#{x86Suffix(kind)} #{orderOperands(operands[0].x86Operand(kind), operands[2].x86Operand(kind))}&quot;

For completeness, you can make this line conditional on &quot;if Immediate.new(nil, 0) != operands[0]&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496643</commentid>
    <comment_count>8</comment_count>
      <attachid>359653</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-21 12:48:54 -0800</bug_when>
    <thetext>Comment on attachment 359653
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359653&amp;action=review

Thanks

&gt;&gt; Source/JavaScriptCore/offlineasm/arm64.rb:506
&gt;&gt; +                unless operands[0] == operands[2]
&gt; 
&gt; Why not express this as &quot;if operands[0] != operands[2]&quot;?

OK, fixed. And I also fixed the same condition in emitARM64Add.

&gt;&gt; Source/JavaScriptCore/offlineasm/x86.rb:794
&gt;&gt; +                unless operands[0] == operands[2]
&gt; 
&gt; Why not express this as &quot;if operands[0] != operands[2]&quot;?

Ditto.

&gt;&gt; Source/JavaScriptCore/offlineasm/x86.rb:801
&gt;&gt; +                $asm.puts &quot;add#{x86Suffix(kind)} #{orderOperands(operands[0].x86Operand(kind), operands[2].x86Operand(kind))}&quot;
&gt; 
&gt; For completeness, you can make this line conditional on &quot;if Immediate.new(nil, 0) != operands[0]&quot;.

Sounds fine, fixed!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496645</commentid>
    <comment_count>9</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-01-21 12:51:05 -0800</bug_when>
    <thetext>Committed r240241: &lt;https://trac.webkit.org/changeset/240241&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1496646</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-01-21 12:52:27 -0800</bug_when>
    <thetext>&lt;rdar://problem/47432315&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>352779</attachid>
            <date>2018-10-19 03:40:33 -0700</date>
            <delta_ts>2019-01-20 14:51:19 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190751-20181019194032.patch</filename>
            <type>text/plain</type>
            <size>5611</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
MTk4OWJkZWNiYjUyNDBhYTA4ZmU3M2EzOTRkNTRiYmM0NDhjOTU4Li45YzAzZDkxMzVkNGIxZWIx
NGVjODU1ODFkYjkyODU3ODllODY4YjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMiBAQAorMjAxOC0xMC0xOSAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93
c3RhcnQub3JnPgorCisgICAgICAgIFtKU0NdIHN1YiBvcCB3aXRoIDAgc2hvdWxkIGJlIG9wdGlt
aXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkw
NzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTExJ
bnQgc29tZXRpbWVzIGVtaXQgYHN1YnAgMCwgJXJ4eGAuIEZvciBleGFtcGxlLCBgbWF4RnJhbWVF
eHRlbnRGb3JTbG93UGF0aENhbGxgIGlzIDAgaW4gWDg2XzY0LCBBUk02NCwgYW5kIEFSTTY0RS4K
KyAgICAgICAgU28gYHN1YnAgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgc3BgIGJlY29t
ZXMgYHN1YnAgMCwgJXJzcGAuIFdoaWxlIGBhZGRwIDAsICVyc3BgIGlzIHJlbW92ZWQgaW4gb2Zm
bGluZWFzbSwKKyAgICAgICAgc3ViIG9wZXJhdGlvbiBkb2VzIG5vdCBoYXZlIHN1Y2ggYW4gb3B0
aW1pemF0aW9uLiBUaGlzIHBhdGNoIGFwcGxpZXMgdGhlIHNhbWUgb3B0aW1pemF0aW9uIHRvIHN1
YiBvcGVyYXRpb24gYWxyZWFkeQorICAgICAgICBkb25lIGluIGFkZCBvcGVyYXRpb24uIFNpbmNl
IHRoZSBDUFUgZmxhZ3MgY2hhbmdlZCBpbiBvZmZsaW5lYXNtJ3MgdGhlc2Ugb3BlcmF0aW9ucyBh
cmUgbm90IGNvbnNpZGVyZWQgKGlmIHRoZXNlIGZsYWdzCisgICAgICAgIGFyZSByZXF1aXJlZCwg
d2UgdXNlIHNwZWNpYWwgYnJhbmNoIG9wZXJhdGlvbnMgaW5zdGVhZCksIHRoaXMgb3B0aW1pemF0
aW9uIGlzIHNhbmUuCisKKyAgICAgICAgT25lIHByb2JsZW0gaXMgdGhhdCB6ZXJvLWV4dGVuc2lv
biBvZiB0aGUgMzJiaXQgcmVnaXN0ZXIgaW4gNjRiaXQgYXJjaGl0ZWN0dXJlLiBJZiB0aGUgaW5z
dHJ1Y3Rpb24gZW1pc3Npb24gaXMgc2tpcHBlZCwKKyAgICAgICAgdGhpcyB3b24ndCBiZSBoYXBw
ZW4uIEN1cnJlbnRseSwgd2UgYWxpZ24gb3VyIHN1YiB0byBhZGQgb3BlcmF0aW9uOiB3ZSBza2lw
IGVtaXNzaW9uIGluIHRoaXMgY2FzZS4KKworICAgICAgICAqIG9mZmxpbmVhc20vYXJtNjQucmI6
CisgICAgICAgICogb2ZmbGluZWFzbS94ODYucmI6CisKIDIwMTgtMTAtMTggIEFsZXhleSBQcm9z
a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgU3dpdGNoIGZyb20gUExBVEZPUk0o
SU9TKSB0byBQTEFURk9STShJT1NfRkFNSUxZKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp
cHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu
ZWFzbS9hcm02NC5yYgppbmRleCBlZWI5MGVkNTM1ZjI3MjgyODIzMjgxYmI4Nzc4NGMxODJiNmFm
ZmU3Li4wY2Y5Y2Y2M2UyNmEyNWJiMzBkZjNhZTU3MWVjMzA0Y2YzZmZiM2VmIDEwMDY0NAotLS0g
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYgorKysgYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYgpAQCAtNDYwLDcgKzQ2MCw3IEBAIGRl
ZiBlbWl0QVJNNjRBZGQob3Bjb2RlLCBvcGVyYW5kcywga2luZCkKICAgICAgICAgcmFpc2UgdW5s
ZXNzIG9wZXJhbmRzWzJdLnJlZ2lzdGVyPwogICAgICAgICAKICAgICAgICAgaWYgb3BlcmFuZHNb
MF0uaW1tZWRpYXRlPwotICAgICAgICAgICAgaWYgb3BlcmFuZHNbMF0udmFsdWUgPT0gMCBhbmQg
ZmxhZyAhfiAvcyQvCisgICAgICAgICAgICBpZiBvcGVyYW5kc1swXS52YWx1ZSA9PSAwIGFuZCBv
cGNvZGUgIX4gL3MkLwogICAgICAgICAgICAgICAgIHVubGVzcyBvcGVyYW5kc1sxXSA9PSBvcGVy
YW5kc1syXQogICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1vdiAje2FybTY0RmxpcHBl
ZE9wZXJhbmRzKG9wZXJhbmRzWzEuLjJdLCBraW5kKX0iCiAgICAgICAgICAgICAgICAgZW5kCkBA
IC00ODQsNiArNDg0LDMwIEBAIGRlZiBlbWl0QVJNNjRBZGQob3Bjb2RlLCBvcGVyYW5kcywga2lu
ZCkKICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlfSAje2FybTY0VEFDT3BlcmFuZHMob3BlcmFuZHMs
IGtpbmQpfSIKIGVuZAogCitkZWYgZW1pdEFSTTY0U3ViKG9wY29kZSwgb3BlcmFuZHMsIGtpbmQp
CisgICAgaWYgb3BlcmFuZHMuc2l6ZSA9PSAzCisgICAgICAgIHJhaXNlIHVubGVzcyBvcGVyYW5k
c1swXS5yZWdpc3Rlcj8KKyAgICAgICAgcmFpc2UgdW5sZXNzIG9wZXJhbmRzWzJdLnJlZ2lzdGVy
PworCisgICAgICAgIGlmIG9wZXJhbmRzWzFdLmltbWVkaWF0ZT8KKyAgICAgICAgICAgIGlmIG9w
ZXJhbmRzWzFdLnZhbHVlID09IDAgYW5kIG9wY29kZSAhfiAvcyQvCisgICAgICAgICAgICAgICAg
dW5sZXNzIG9wZXJhbmRzWzBdID09IG9wZXJhbmRzWzJdCisgICAgICAgICAgICAgICAgICAgICRh
c20ucHV0cyAibW92ICN7YXJtNjRGbGlwcGVkT3BlcmFuZHMoW29wZXJhbmRzWzBdLCBvcGVyYW5k
c1syXV0sIGtpbmQpfSIKKyAgICAgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgICAgICByZXR1
cm4KKyAgICAgICAgICAgIGVuZAorICAgICAgICBlbmQKKyAgICBlbmQKKworICAgIGlmIG9wZXJh
bmRzLnNpemUgPT0gMgorICAgICAgICBpZiBvcGVyYW5kc1swXS5pbW1lZGlhdGU/IGFuZCBvcGVy
YW5kc1swXS52YWx1ZSA9PSAwIGFuZCBvcGNvZGUgIX4gL3MkLworICAgICAgICAgICAgcmV0dXJu
CisgICAgICAgIGVuZAorICAgIGVuZAorCisgICAgZW1pdEFSTTY0VEFDKG9wY29kZSwgb3BlcmFu
ZHMsIGtpbmQpCitlbmQKKwogZGVmIGVtaXRBUk02NFVuZmxpcHBlZChvcGNvZGUsIG9wZXJhbmRz
LCBraW5kKQogICAgICRhc20ucHV0cyAiI3tvcGNvZGV9ICN7YXJtNjRPcGVyYW5kcyhvcGVyYW5k
cywga2luZCl9IgogZW5kCkBAIC02MzgsMTMgKzY2MiwxMyBAQCBkZWYgbG93ZXJBUk02NAogICAg
ICAgICB3aGVuICJtdWxxIgogICAgICAgICAgICAgJGFzbS5wdXRzICJtYWRkICN7YXJtNjRUQUNP
cGVyYW5kcyhvcGVyYW5kcywgOnF1YWQpfSwgeHpyIgogICAgICAgICB3aGVuICJzdWJpIgotICAg
ICAgICAgICAgZW1pdEFSTTY0VEFDKCJzdWIiLCBvcGVyYW5kcywgOndvcmQpCisgICAgICAgICAg
ICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6d29yZCkKICAgICAgICAgd2hlbiAic3Vi
cCIKLSAgICAgICAgICAgIGVtaXRBUk02NFRBQygic3ViIiwgb3BlcmFuZHMsIDpwdHIpCisgICAg
ICAgICAgICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6cHRyKQogICAgICAgICB3aGVu
ICJzdWJxIgotICAgICAgICAgICAgZW1pdEFSTTY0VEFDKCJzdWIiLCBvcGVyYW5kcywgOnF1YWQp
CisgICAgICAgICAgICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6cXVhZCkKICAgICAg
ICAgd2hlbiAic3ViaXMiCi0gICAgICAgICAgICBlbWl0QVJNNjRUQUMoInN1YnMiLCBvcGVyYW5k
cywgOndvcmQpCisgICAgICAgICAgICBlbWl0QVJNNjRTdWIoInN1YnMiLCBvcGVyYW5kcywgOndv
cmQpCiAgICAgICAgIHdoZW4gIm5lZ2kiCiAgICAgICAgICAgICAkYXNtLnB1dHMgInN1YiAje29w
ZXJhbmRzWzBdLmFybTY0T3BlcmFuZCg6d29yZCl9LCB3enIsICN7b3BlcmFuZHNbMF0uYXJtNjRP
cGVyYW5kKDp3b3JkKX0iCiAgICAgICAgIHdoZW4gIm5lZ3AiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
b2ZmbGluZWFzbS94ODYucmIKaW5kZXggOTlmZmI4YTAyZDE5YzAzMzUyZTVhZjg2ZmJkOTUwNDM4
OTVkZjA3My4uM2ZmOTE4M2U4ZmI1MTY4ZThmNDZjOTA2N2Y2YzQ3MjIwNWEyNGEzOCAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCisrKyBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5yYgpAQCAtNzc4LDEyICs3NzgsMjkgQEAg
ZGVmIGhhbmRsZVg4NkFkZChraW5kKQogICAgIGVuZAogICAgIAogICAgIGRlZiBoYW5kbGVYODZT
dWIoa2luZCkKLSAgICAgICAgaWYgb3BlcmFuZHMuc2l6ZSA9PSAzIGFuZCBvcGVyYW5kc1sxXSA9
PSBvcGVyYW5kc1syXQotICAgICAgICAgICAgJGFzbS5wdXRzICJuZWcje3g4NlN1ZmZpeChraW5k
KX0gI3tvcGVyYW5kc1syXS54ODZPcGVyYW5kKGtpbmQpfSIKLSAgICAgICAgICAgICRhc20ucHV0
cyAiYWRkI3t4ODZTdWZmaXgoa2luZCl9ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZP
cGVyYW5kKGtpbmQpLCBvcGVyYW5kc1syXS54ODZPcGVyYW5kKGtpbmQpKX0iCi0gICAgICAgIGVs
c2UKLSAgICAgICAgICAgIGhhbmRsZVg4Nk9wKCJzdWIje3g4NlN1ZmZpeChraW5kKX0iLCBraW5k
KQorICAgICAgICBpZiBvcGVyYW5kcy5zaXplID09IDMKKyAgICAgICAgICAgIGlmIEltbWVkaWF0
ZS5uZXcobmlsLCAwKSA9PSBvcGVyYW5kc1sxXQorICAgICAgICAgICAgICAgIHJhaXNlIHVubGVz
cyBvcGVyYW5kc1swXS5pc19hPyBSZWdpc3RlcklECisgICAgICAgICAgICAgICAgcmFpc2UgdW5s
ZXNzIG9wZXJhbmRzWzJdLmlzX2E/IFJlZ2lzdGVySUQKKyAgICAgICAgICAgICAgICB1bmxlc3Mg
b3BlcmFuZHNbMF0gPT0gb3BlcmFuZHNbMl0KKyAgICAgICAgICAgICAgICAgICAgJGFzbS5wdXRz
ICJtb3Yje3g4NlN1ZmZpeChraW5kKX0gI3tvcmRlck9wZXJhbmRzKG9wZXJhbmRzWzBdLng4Nk9w
ZXJhbmQoa2luZCksIG9wZXJhbmRzWzJdLng4Nk9wZXJhbmQoa2luZCkpfSIKKyAgICAgICAgICAg
ICAgICBlbmQKKyAgICAgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgICAgIGVuZAorICAgICAg
ICAgICAgaWYgb3BlcmFuZHNbMV0gPT0gb3BlcmFuZHNbMl0KKyAgICAgICAgICAgICAgICAkYXNt
LnB1dHMgIm5lZyN7eDg2U3VmZml4KGtpbmQpfSAje29wZXJhbmRzWzJdLng4Nk9wZXJhbmQoa2lu
ZCl9IgorICAgICAgICAgICAgICAgICRhc20ucHV0cyAiYWRkI3t4ODZTdWZmaXgoa2luZCl9ICN7
b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVyYW5kKGtpbmQpLCBvcGVyYW5kc1syXS54
ODZPcGVyYW5kKGtpbmQpKX0iCisgICAgICAgICAgICAgICAgcmV0dXJuCisgICAgICAgICAgICBl
bmQKKyAgICAgICAgZW5kCisKKyAgICAgICAgaWYgb3BlcmFuZHMuc2l6ZSA9PSAyCisgICAgICAg
ICAgICBpZiBJbW1lZGlhdGUubmV3KG5pbCwgMCkgPT0gb3BlcmFuZHNbMF0KKyAgICAgICAgICAg
ICAgICByZXR1cm4KKyAgICAgICAgICAgIGVuZAogICAgICAgICBlbmQKKworICAgICAgICBoYW5k
bGVYODZPcCgic3ViI3t4ODZTdWZmaXgoa2luZCl9Iiwga2luZCkKICAgICBlbmQKICAgICAKICAg
ICBkZWYgaGFuZGxlWDg2TXVsKGtpbmQpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>359652</attachid>
            <date>2019-01-20 14:51:20 -0800</date>
            <delta_ts>2019-01-20 14:53:00 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190751-20190120145119.patch</filename>
            <type>text/plain</type>
            <size>5617</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4
ZTllNTg0NGE4ZTA0Y2Y5MDZmZGRlYTEzMjllNThiM2QzYzdjY2QyLi5jZTU1ODdjOTQ3MjUyMGRj
Zjk1OTA3Mzk5YTczMmJmMDI0MGUwNmUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMiBAQAorMjAxOS0wMS0yMCAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93
c3RhcnQub3JnPgorCisgICAgICAgIFtKU0NdIHN1YiBvcCB3aXRoIDAgc2hvdWxkIGJlIG9wdGlt
aXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkw
NzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTExJ
bnQgc29tZXRpbWVzIGVtaXQgYHN1YnAgMCwgJXJ4eGAuIEZvciBleGFtcGxlLCBgbWF4RnJhbWVF
eHRlbnRGb3JTbG93UGF0aENhbGxgIGlzIDAgaW4gWDg2XzY0LCBBUk02NCwgYW5kIEFSTTY0RS4K
KyAgICAgICAgU28gYHN1YnAgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgc3BgIGJlY29t
ZXMgYHN1YnAgMCwgJXJzcGAuIFdoaWxlIGBhZGRwIDAsICVyc3BgIGlzIHJlbW92ZWQgaW4gb2Zm
bGluZWFzbSwKKyAgICAgICAgc3ViIG9wZXJhdGlvbiBkb2VzIG5vdCBoYXZlIHN1Y2ggYW4gb3B0
aW1pemF0aW9uLiBUaGlzIHBhdGNoIGFwcGxpZXMgdGhlIHNhbWUgb3B0aW1pemF0aW9uIHRvIHN1
YiBvcGVyYXRpb24gYWxyZWFkeQorICAgICAgICBkb25lIGluIGFkZCBvcGVyYXRpb24uIFNpbmNl
IHRoZSBDUFUgZmxhZ3MgY2hhbmdlZCBpbiBvZmZsaW5lYXNtJ3MgdGhlc2Ugb3BlcmF0aW9ucyBh
cmUgbm90IGNvbnNpZGVyZWQgKGlmIHRoZXNlIGZsYWdzCisgICAgICAgIGFyZSByZXF1aXJlZCwg
d2UgdXNlIHNwZWNpYWwgYnJhbmNoIG9wZXJhdGlvbnMgaW5zdGVhZCksIHRoaXMgb3B0aW1pemF0
aW9uIGlzIHNhbmUuCisKKyAgICAgICAgT25lIHByb2JsZW0gaXMgdGhhdCB6ZXJvLWV4dGVuc2lv
biBvZiB0aGUgMzJiaXQgcmVnaXN0ZXIgaW4gNjRiaXQgYXJjaGl0ZWN0dXJlLiBJZiB0aGUgaW5z
dHJ1Y3Rpb24gZW1pc3Npb24gaXMgc2tpcHBlZCwKKyAgICAgICAgdGhpcyB3b24ndCBiZSBoYXBw
ZW4uIEN1cnJlbnRseSwgd2UgYWxpZ24gb3VyIHN1YiB0byBhZGQgb3BlcmF0aW9uOiB3ZSBza2lw
IGVtaXNzaW9uIGluIHRoaXMgY2FzZS4KKworICAgICAgICAqIG9mZmxpbmVhc20vYXJtNjQucmI6
CisgICAgICAgICogb2ZmbGluZWFzbS94ODYucmI6CisKIDIwMTktMDEtMjAgIFl1c3VrZSBTdXp1
a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBbSlNDXSBTaHJpbmsg
ZGF0YSBzdHJ1Y3R1cmUgc2l6ZSBpbiBKU0MvaGVhcApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT
Y3JpcHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2Zm
bGluZWFzbS9hcm02NC5yYgppbmRleCAwYzkyZWIyZmUwNjgxYmFhNjRmYmRlZDhmNDY4ZGUwMDM3
NzFiM2I0Li4yOGQwZjlhMWM5ODcyYjYyOTliYmVlMmM3MjQwYjc2MDgwNGVlZjBkIDEwMDY0NAot
LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYgorKysgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYgpAQCAtNDYwLDcgKzQ2MCw3IEBA
IGRlZiBlbWl0QVJNNjRBZGQob3Bjb2RlLCBvcGVyYW5kcywga2luZCkKICAgICAgICAgcmFpc2Ug
dW5sZXNzIG9wZXJhbmRzWzJdLnJlZ2lzdGVyPwogICAgICAgICAKICAgICAgICAgaWYgb3BlcmFu
ZHNbMF0uaW1tZWRpYXRlPwotICAgICAgICAgICAgaWYgb3BlcmFuZHNbMF0udmFsdWUgPT0gMCBh
bmQgZmxhZyAhfiAvcyQvCisgICAgICAgICAgICBpZiBvcGVyYW5kc1swXS52YWx1ZSA9PSAwIGFu
ZCBvcGNvZGUgIX4gL3MkLwogICAgICAgICAgICAgICAgIHVubGVzcyBvcGVyYW5kc1sxXSA9PSBv
cGVyYW5kc1syXQogICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1vdiAje2FybTY0Rmxp
cHBlZE9wZXJhbmRzKG9wZXJhbmRzWzEuLjJdLCBraW5kKX0iCiAgICAgICAgICAgICAgICAgZW5k
CkBAIC00OTYsNiArNDk2LDMwIEBAIGRlZiBlbWl0QVJNNjRNdWwob3Bjb2RlLCBvcGVyYW5kcywg
a2luZCkKICAgICAkYXNtLnB1dHMgIm1hZGQgI3thcm02NFRBQ09wZXJhbmRzKG9wZXJhbmRzLCBr
aW5kKX0sICN7YXJtNjRHUFJOYW1lKCd4enInLCBraW5kKX0iCiBlbmQKIAorZGVmIGVtaXRBUk02
NFN1YihvcGNvZGUsIG9wZXJhbmRzLCBraW5kKQorICAgIGlmIG9wZXJhbmRzLnNpemUgPT0gMwor
ICAgICAgICByYWlzZSB1bmxlc3Mgb3BlcmFuZHNbMF0ucmVnaXN0ZXI/CisgICAgICAgIHJhaXNl
IHVubGVzcyBvcGVyYW5kc1syXS5yZWdpc3Rlcj8KKworICAgICAgICBpZiBvcGVyYW5kc1sxXS5p
bW1lZGlhdGU/CisgICAgICAgICAgICBpZiBvcGVyYW5kc1sxXS52YWx1ZSA9PSAwIGFuZCBvcGNv
ZGUgIX4gL3MkLworICAgICAgICAgICAgICAgIHVubGVzcyBvcGVyYW5kc1swXSA9PSBvcGVyYW5k
c1syXQorICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1vdiAje2FybTY0RmxpcHBlZE9w
ZXJhbmRzKFtvcGVyYW5kc1swXSwgb3BlcmFuZHNbMl1dLCBraW5kKX0iCisgICAgICAgICAgICAg
ICAgZW5kCisgICAgICAgICAgICAgICAgcmV0dXJuCisgICAgICAgICAgICBlbmQKKyAgICAgICAg
ZW5kCisgICAgZW5kCisKKyAgICBpZiBvcGVyYW5kcy5zaXplID09IDIKKyAgICAgICAgaWYgb3Bl
cmFuZHNbMF0uaW1tZWRpYXRlPyBhbmQgb3BlcmFuZHNbMF0udmFsdWUgPT0gMCBhbmQgb3Bjb2Rl
ICF+IC9zJC8KKyAgICAgICAgICAgIHJldHVybgorICAgICAgICBlbmQKKyAgICBlbmQKKworICAg
IGVtaXRBUk02NFRBQyhvcGNvZGUsIG9wZXJhbmRzLCBraW5kKQorZW5kCisKIGRlZiBlbWl0QVJN
NjRVbmZsaXBwZWQob3Bjb2RlLCBvcGVyYW5kcywga2luZCkKICAgICAkYXNtLnB1dHMgIiN7b3Bj
b2RlfSAje2FybTY0T3BlcmFuZHMob3BlcmFuZHMsIGtpbmQpfSIKIGVuZApAQCAtNjU1LDEzICs2
NzksMTMgQEAgZGVmIGxvd2VyQVJNNjQKICAgICAgICAgd2hlbiAibXVscSIKICAgICAgICAgICAg
IGVtaXRBUk02NE11bCgnbXVsJywgb3BlcmFuZHMsIDpxdWFkKQogICAgICAgICB3aGVuICJzdWJp
IgotICAgICAgICAgICAgZW1pdEFSTTY0VEFDKCJzdWIiLCBvcGVyYW5kcywgOndvcmQpCisgICAg
ICAgICAgICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6d29yZCkKICAgICAgICAgd2hl
biAic3VicCIKLSAgICAgICAgICAgIGVtaXRBUk02NFRBQygic3ViIiwgb3BlcmFuZHMsIDpwdHIp
CisgICAgICAgICAgICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6cHRyKQogICAgICAg
ICB3aGVuICJzdWJxIgotICAgICAgICAgICAgZW1pdEFSTTY0VEFDKCJzdWIiLCBvcGVyYW5kcywg
OnF1YWQpCisgICAgICAgICAgICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6cXVhZCkK
ICAgICAgICAgd2hlbiAic3ViaXMiCi0gICAgICAgICAgICBlbWl0QVJNNjRUQUMoInN1YnMiLCBv
cGVyYW5kcywgOndvcmQpCisgICAgICAgICAgICBlbWl0QVJNNjRTdWIoInN1YnMiLCBvcGVyYW5k
cywgOndvcmQpCiAgICAgICAgIHdoZW4gIm5lZ2kiCiAgICAgICAgICAgICAkYXNtLnB1dHMgInN1
YiAje29wZXJhbmRzWzBdLmFybTY0T3BlcmFuZCg6d29yZCl9LCB3enIsICN7b3BlcmFuZHNbMF0u
YXJtNjRPcGVyYW5kKDp3b3JkKX0iCiAgICAgICAgIHdoZW4gIm5lZ3AiCmRpZmYgLS1naXQgYS9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIgYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvb2ZmbGluZWFzbS94ODYucmIKaW5kZXggNWI1ZTlhMDE1YThlM2EwYjkyMmMyZjNiNGE1
ODk0MDNmYzA3YmY5Zi4uODA0NzA4ZjQwNDJkOWFmM2VjMmZkZmNiMTY3NWJhZDJkNWM3ZjA5NSAx
MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCisrKyBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5yYgpAQCAtNzg3LDEyICs3ODcs
MjkgQEAgZGVmIGhhbmRsZVg4NkFkZChraW5kKQogICAgIGVuZAogICAgIAogICAgIGRlZiBoYW5k
bGVYODZTdWIoa2luZCkKLSAgICAgICAgaWYgb3BlcmFuZHMuc2l6ZSA9PSAzIGFuZCBvcGVyYW5k
c1sxXSA9PSBvcGVyYW5kc1syXQotICAgICAgICAgICAgJGFzbS5wdXRzICJuZWcje3g4NlN1ZmZp
eChraW5kKX0gI3tvcGVyYW5kc1syXS54ODZPcGVyYW5kKGtpbmQpfSIKLSAgICAgICAgICAgICRh
c20ucHV0cyAiYWRkI3t4ODZTdWZmaXgoa2luZCl9ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1sw
XS54ODZPcGVyYW5kKGtpbmQpLCBvcGVyYW5kc1syXS54ODZPcGVyYW5kKGtpbmQpKX0iCi0gICAg
ICAgIGVsc2UKLSAgICAgICAgICAgIGhhbmRsZVg4Nk9wKCJzdWIje3g4NlN1ZmZpeChraW5kKX0i
LCBraW5kKQorICAgICAgICBpZiBvcGVyYW5kcy5zaXplID09IDMKKyAgICAgICAgICAgIGlmIElt
bWVkaWF0ZS5uZXcobmlsLCAwKSA9PSBvcGVyYW5kc1sxXQorICAgICAgICAgICAgICAgIHJhaXNl
IHVubGVzcyBvcGVyYW5kc1swXS5pc19hPyBSZWdpc3RlcklECisgICAgICAgICAgICAgICAgcmFp
c2UgdW5sZXNzIG9wZXJhbmRzWzJdLmlzX2E/IFJlZ2lzdGVySUQKKyAgICAgICAgICAgICAgICB1
bmxlc3Mgb3BlcmFuZHNbMF0gPT0gb3BlcmFuZHNbMl0KKyAgICAgICAgICAgICAgICAgICAgJGFz
bS5wdXRzICJtb3Yje3g4NlN1ZmZpeChraW5kKX0gI3tvcmRlck9wZXJhbmRzKG9wZXJhbmRzWzBd
Lng4Nk9wZXJhbmQoa2luZCksIG9wZXJhbmRzWzJdLng4Nk9wZXJhbmQoa2luZCkpfSIKKyAgICAg
ICAgICAgICAgICBlbmQKKyAgICAgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgICAgIGVuZAor
ICAgICAgICAgICAgaWYgb3BlcmFuZHNbMV0gPT0gb3BlcmFuZHNbMl0KKyAgICAgICAgICAgICAg
ICAkYXNtLnB1dHMgIm5lZyN7eDg2U3VmZml4KGtpbmQpfSAje29wZXJhbmRzWzJdLng4Nk9wZXJh
bmQoa2luZCl9IgorICAgICAgICAgICAgICAgICRhc20ucHV0cyAiYWRkI3t4ODZTdWZmaXgoa2lu
ZCl9ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVyYW5kKGtpbmQpLCBvcGVyYW5k
c1syXS54ODZPcGVyYW5kKGtpbmQpKX0iCisgICAgICAgICAgICAgICAgcmV0dXJuCisgICAgICAg
ICAgICBlbmQKICAgICAgICAgZW5kCisKKyAgICAgICAgaWYgb3BlcmFuZHMuc2l6ZSA9PSAyCisg
ICAgICAgICAgICBpZiBJbW1lZGlhdGUubmV3KG5pbCwgMCkgPT0gb3BlcmFuZHNbMF0KKyAgICAg
ICAgICAgICAgICByZXR1cm4KKyAgICAgICAgICAgIGVuZAorICAgICAgICBlbmQKKworICAgICAg
ICBoYW5kbGVYODZPcCgic3ViI3t4ODZTdWZmaXgoa2luZCl9Iiwga2luZCkKICAgICBlbmQKICAg
ICAKICAgICBkZWYgaGFuZGxlWDg2TXVsKGtpbmQpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>359653</attachid>
            <date>2019-01-20 14:53:01 -0800</date>
            <delta_ts>2019-01-21 10:08:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190751-20190120145300.patch</filename>
            <type>text/plain</type>
            <size>5608</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4
ZTllNTg0NGE4ZTA0Y2Y5MDZmZGRlYTEzMjllNThiM2QzYzdjY2QyLi5iM2NmODhmYTI5OGY5ZWJi
ZmIyMzFjMDI2NTYxYjJlZTk1NWI3Mjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMiBAQAorMjAxOS0wMS0yMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t
PgorCisgICAgICAgIFtKU0NdIHN1YiBvcCB3aXRoIDAgc2hvdWxkIGJlIG9wdGltaXplZAorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNzUxCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTExJbnQgc29tZXRp
bWVzIGVtaXQgYHN1YnAgMCwgJXJ4eGAuIEZvciBleGFtcGxlLCBgbWF4RnJhbWVFeHRlbnRGb3JT
bG93UGF0aENhbGxgIGlzIDAgaW4gWDg2XzY0LCBBUk02NCwgYW5kIEFSTTY0RS4KKyAgICAgICAg
U28gYHN1YnAgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgc3BgIGJlY29tZXMgYHN1YnAg
MCwgJXJzcGAuIFdoaWxlIGBhZGRwIDAsICVyc3BgIGlzIHJlbW92ZWQgaW4gb2ZmbGluZWFzbSwK
KyAgICAgICAgc3ViIG9wZXJhdGlvbiBkb2VzIG5vdCBoYXZlIHN1Y2ggYW4gb3B0aW1pemF0aW9u
LiBUaGlzIHBhdGNoIGFwcGxpZXMgdGhlIHNhbWUgb3B0aW1pemF0aW9uIHRvIHN1YiBvcGVyYXRp
b24gYWxyZWFkeQorICAgICAgICBkb25lIGluIGFkZCBvcGVyYXRpb24uIFNpbmNlIHRoZSBDUFUg
ZmxhZ3MgY2hhbmdlZCBpbiBvZmZsaW5lYXNtJ3MgdGhlc2Ugb3BlcmF0aW9ucyBhcmUgbm90IGNv
bnNpZGVyZWQgKGlmIHRoZXNlIGZsYWdzCisgICAgICAgIGFyZSByZXF1aXJlZCwgd2UgdXNlIHNw
ZWNpYWwgYnJhbmNoIG9wZXJhdGlvbnMgaW5zdGVhZCksIHRoaXMgb3B0aW1pemF0aW9uIGlzIHNh
bmUuCisKKyAgICAgICAgT25lIHByb2JsZW0gaXMgdGhhdCB6ZXJvLWV4dGVuc2lvbiBvZiB0aGUg
MzJiaXQgcmVnaXN0ZXIgaW4gNjRiaXQgYXJjaGl0ZWN0dXJlLiBJZiB0aGUgaW5zdHJ1Y3Rpb24g
ZW1pc3Npb24gaXMgc2tpcHBlZCwKKyAgICAgICAgdGhpcyB3b24ndCBiZSBoYXBwZW4uIEN1cnJl
bnRseSwgd2UgYWxpZ24gb3VyIHN1YiB0byBhZGQgb3BlcmF0aW9uOiB3ZSBza2lwIGVtaXNzaW9u
IGluIHRoaXMgY2FzZS4KKworICAgICAgICAqIG9mZmxpbmVhc20vYXJtNjQucmI6CisgICAgICAg
ICogb2ZmbGluZWFzbS94ODYucmI6CisKIDIwMTktMDEtMjAgIFl1c3VrZSBTdXp1a2kgIDx5dXN1
a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBbSlNDXSBTaHJpbmsgZGF0YSBzdHJ1
Y3R1cmUgc2l6ZSBpbiBKU0MvaGVhcApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl
L29mZmxpbmVhc20vYXJtNjQucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9h
cm02NC5yYgppbmRleCAwYzkyZWIyZmUwNjgxYmFhNjRmYmRlZDhmNDY4ZGUwMDM3NzFiM2I0Li4y
OGQwZjlhMWM5ODcyYjYyOTliYmVlMmM3MjQwYjc2MDgwNGVlZjBkIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYgorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYgpAQCAtNDYwLDcgKzQ2MCw3IEBAIGRlZiBlbWl0
QVJNNjRBZGQob3Bjb2RlLCBvcGVyYW5kcywga2luZCkKICAgICAgICAgcmFpc2UgdW5sZXNzIG9w
ZXJhbmRzWzJdLnJlZ2lzdGVyPwogICAgICAgICAKICAgICAgICAgaWYgb3BlcmFuZHNbMF0uaW1t
ZWRpYXRlPwotICAgICAgICAgICAgaWYgb3BlcmFuZHNbMF0udmFsdWUgPT0gMCBhbmQgZmxhZyAh
fiAvcyQvCisgICAgICAgICAgICBpZiBvcGVyYW5kc1swXS52YWx1ZSA9PSAwIGFuZCBvcGNvZGUg
IX4gL3MkLwogICAgICAgICAgICAgICAgIHVubGVzcyBvcGVyYW5kc1sxXSA9PSBvcGVyYW5kc1sy
XQogICAgICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1vdiAje2FybTY0RmxpcHBlZE9wZXJh
bmRzKG9wZXJhbmRzWzEuLjJdLCBraW5kKX0iCiAgICAgICAgICAgICAgICAgZW5kCkBAIC00OTYs
NiArNDk2LDMwIEBAIGRlZiBlbWl0QVJNNjRNdWwob3Bjb2RlLCBvcGVyYW5kcywga2luZCkKICAg
ICAkYXNtLnB1dHMgIm1hZGQgI3thcm02NFRBQ09wZXJhbmRzKG9wZXJhbmRzLCBraW5kKX0sICN7
YXJtNjRHUFJOYW1lKCd4enInLCBraW5kKX0iCiBlbmQKIAorZGVmIGVtaXRBUk02NFN1YihvcGNv
ZGUsIG9wZXJhbmRzLCBraW5kKQorICAgIGlmIG9wZXJhbmRzLnNpemUgPT0gMworICAgICAgICBy
YWlzZSB1bmxlc3Mgb3BlcmFuZHNbMF0ucmVnaXN0ZXI/CisgICAgICAgIHJhaXNlIHVubGVzcyBv
cGVyYW5kc1syXS5yZWdpc3Rlcj8KKworICAgICAgICBpZiBvcGVyYW5kc1sxXS5pbW1lZGlhdGU/
CisgICAgICAgICAgICBpZiBvcGVyYW5kc1sxXS52YWx1ZSA9PSAwIGFuZCBvcGNvZGUgIX4gL3Mk
LworICAgICAgICAgICAgICAgIHVubGVzcyBvcGVyYW5kc1swXSA9PSBvcGVyYW5kc1syXQorICAg
ICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1vdiAje2FybTY0RmxpcHBlZE9wZXJhbmRzKFtv
cGVyYW5kc1swXSwgb3BlcmFuZHNbMl1dLCBraW5kKX0iCisgICAgICAgICAgICAgICAgZW5kCisg
ICAgICAgICAgICAgICAgcmV0dXJuCisgICAgICAgICAgICBlbmQKKyAgICAgICAgZW5kCisgICAg
ZW5kCisKKyAgICBpZiBvcGVyYW5kcy5zaXplID09IDIKKyAgICAgICAgaWYgb3BlcmFuZHNbMF0u
aW1tZWRpYXRlPyBhbmQgb3BlcmFuZHNbMF0udmFsdWUgPT0gMCBhbmQgb3Bjb2RlICF+IC9zJC8K
KyAgICAgICAgICAgIHJldHVybgorICAgICAgICBlbmQKKyAgICBlbmQKKworICAgIGVtaXRBUk02
NFRBQyhvcGNvZGUsIG9wZXJhbmRzLCBraW5kKQorZW5kCisKIGRlZiBlbWl0QVJNNjRVbmZsaXBw
ZWQob3Bjb2RlLCBvcGVyYW5kcywga2luZCkKICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlfSAje2Fy
bTY0T3BlcmFuZHMob3BlcmFuZHMsIGtpbmQpfSIKIGVuZApAQCAtNjU1LDEzICs2NzksMTMgQEAg
ZGVmIGxvd2VyQVJNNjQKICAgICAgICAgd2hlbiAibXVscSIKICAgICAgICAgICAgIGVtaXRBUk02
NE11bCgnbXVsJywgb3BlcmFuZHMsIDpxdWFkKQogICAgICAgICB3aGVuICJzdWJpIgotICAgICAg
ICAgICAgZW1pdEFSTTY0VEFDKCJzdWIiLCBvcGVyYW5kcywgOndvcmQpCisgICAgICAgICAgICBl
bWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6d29yZCkKICAgICAgICAgd2hlbiAic3VicCIK
LSAgICAgICAgICAgIGVtaXRBUk02NFRBQygic3ViIiwgb3BlcmFuZHMsIDpwdHIpCisgICAgICAg
ICAgICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6cHRyKQogICAgICAgICB3aGVuICJz
dWJxIgotICAgICAgICAgICAgZW1pdEFSTTY0VEFDKCJzdWIiLCBvcGVyYW5kcywgOnF1YWQpCisg
ICAgICAgICAgICBlbWl0QVJNNjRTdWIoInN1YiIsIG9wZXJhbmRzLCA6cXVhZCkKICAgICAgICAg
d2hlbiAic3ViaXMiCi0gICAgICAgICAgICBlbWl0QVJNNjRUQUMoInN1YnMiLCBvcGVyYW5kcywg
OndvcmQpCisgICAgICAgICAgICBlbWl0QVJNNjRTdWIoInN1YnMiLCBvcGVyYW5kcywgOndvcmQp
CiAgICAgICAgIHdoZW4gIm5lZ2kiCiAgICAgICAgICAgICAkYXNtLnB1dHMgInN1YiAje29wZXJh
bmRzWzBdLmFybTY0T3BlcmFuZCg6d29yZCl9LCB3enIsICN7b3BlcmFuZHNbMF0uYXJtNjRPcGVy
YW5kKDp3b3JkKX0iCiAgICAgICAgIHdoZW4gIm5lZ3AiCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2Zm
bGluZWFzbS94ODYucmIKaW5kZXggNWI1ZTlhMDE1YThlM2EwYjkyMmMyZjNiNGE1ODk0MDNmYzA3
YmY5Zi4uODA0NzA4ZjQwNDJkOWFmM2VjMmZkZmNiMTY3NWJhZDJkNWM3ZjA5NSAxMDA2NDQKLS0t
IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCisrKyBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5yYgpAQCAtNzg3LDEyICs3ODcsMjkgQEAgZGVm
IGhhbmRsZVg4NkFkZChraW5kKQogICAgIGVuZAogICAgIAogICAgIGRlZiBoYW5kbGVYODZTdWIo
a2luZCkKLSAgICAgICAgaWYgb3BlcmFuZHMuc2l6ZSA9PSAzIGFuZCBvcGVyYW5kc1sxXSA9PSBv
cGVyYW5kc1syXQotICAgICAgICAgICAgJGFzbS5wdXRzICJuZWcje3g4NlN1ZmZpeChraW5kKX0g
I3tvcGVyYW5kc1syXS54ODZPcGVyYW5kKGtpbmQpfSIKLSAgICAgICAgICAgICRhc20ucHV0cyAi
YWRkI3t4ODZTdWZmaXgoa2luZCl9ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVy
YW5kKGtpbmQpLCBvcGVyYW5kc1syXS54ODZPcGVyYW5kKGtpbmQpKX0iCi0gICAgICAgIGVsc2UK
LSAgICAgICAgICAgIGhhbmRsZVg4Nk9wKCJzdWIje3g4NlN1ZmZpeChraW5kKX0iLCBraW5kKQor
ICAgICAgICBpZiBvcGVyYW5kcy5zaXplID09IDMKKyAgICAgICAgICAgIGlmIEltbWVkaWF0ZS5u
ZXcobmlsLCAwKSA9PSBvcGVyYW5kc1sxXQorICAgICAgICAgICAgICAgIHJhaXNlIHVubGVzcyBv
cGVyYW5kc1swXS5pc19hPyBSZWdpc3RlcklECisgICAgICAgICAgICAgICAgcmFpc2UgdW5sZXNz
IG9wZXJhbmRzWzJdLmlzX2E/IFJlZ2lzdGVySUQKKyAgICAgICAgICAgICAgICB1bmxlc3Mgb3Bl
cmFuZHNbMF0gPT0gb3BlcmFuZHNbMl0KKyAgICAgICAgICAgICAgICAgICAgJGFzbS5wdXRzICJt
b3Yje3g4NlN1ZmZpeChraW5kKX0gI3tvcmRlck9wZXJhbmRzKG9wZXJhbmRzWzBdLng4Nk9wZXJh
bmQoa2luZCksIG9wZXJhbmRzWzJdLng4Nk9wZXJhbmQoa2luZCkpfSIKKyAgICAgICAgICAgICAg
ICBlbmQKKyAgICAgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgICAgIGVuZAorICAgICAgICAg
ICAgaWYgb3BlcmFuZHNbMV0gPT0gb3BlcmFuZHNbMl0KKyAgICAgICAgICAgICAgICAkYXNtLnB1
dHMgIm5lZyN7eDg2U3VmZml4KGtpbmQpfSAje29wZXJhbmRzWzJdLng4Nk9wZXJhbmQoa2luZCl9
IgorICAgICAgICAgICAgICAgICRhc20ucHV0cyAiYWRkI3t4ODZTdWZmaXgoa2luZCl9ICN7b3Jk
ZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVyYW5kKGtpbmQpLCBvcGVyYW5kc1syXS54ODZP
cGVyYW5kKGtpbmQpKX0iCisgICAgICAgICAgICAgICAgcmV0dXJuCisgICAgICAgICAgICBlbmQK
ICAgICAgICAgZW5kCisKKyAgICAgICAgaWYgb3BlcmFuZHMuc2l6ZSA9PSAyCisgICAgICAgICAg
ICBpZiBJbW1lZGlhdGUubmV3KG5pbCwgMCkgPT0gb3BlcmFuZHNbMF0KKyAgICAgICAgICAgICAg
ICByZXR1cm4KKyAgICAgICAgICAgIGVuZAorICAgICAgICBlbmQKKworICAgICAgICBoYW5kbGVY
ODZPcCgic3ViI3t4ODZTdWZmaXgoa2luZCl9Iiwga2luZCkKICAgICBlbmQKICAgICAKICAgICBk
ZWYgaGFuZGxlWDg2TXVsKGtpbmQpCg==
</data>
<flag name="review"
          id="376394"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
          </attachment>
      

    </bug>

</bugzilla>