190732 2018-10-18 13:54:31 -0700 clean-webkit pulls in many unnecessary dependencies in webkitpy 2018-12-24 18:26:17 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 193025 1 dean_johnson dean_johnson commit-queue ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1470651 0 dean_johnson 2018-10-18 13:54:31 -0700 Tools/Scripts/clean-webkit pulls in many unnecessary dependencies in webkitpy through creation of the Host object, which starts auto-installing 'bugzilla', 'buildbot' and 'web' packages. These can take a while to install, and are not needed at all if just trying to clean your checkout. 1470656 1 352727 dean_johnson 2018-10-18 13:59:05 -0700 Created attachment 352727 Patch 1470665 2 352727 ap 2018-10-18 14:14:17 -0700 Comment on attachment 352727 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352727&action=review > Tools/Scripts/webkitpy/common/host.py:63 > + @property > + def bugs(self): > + if not hasattr(self, '_bugs'): > + from webkitpy.common.net import bugzilla > + self._bugs = bugzilla.Bugzilla() > + return self._bugs I think that this would be better with @memoized. @memoized def bugs(self): return bugzilla.Bugzilla() 1470666 3 ap 2018-10-18 14:15:04 -0700 Well, also the import. 1470669 4 352732 dean_johnson 2018-10-18 14:18:06 -0700 Created attachment 352732 Patch 1470671 5 dean_johnson 2018-10-18 14:19:24 -0700 Changed to use @memoized. Still need @property to access the functions as if they were a property, to allow class attributes 'bugzilla', 'buildbot', and 'web' to continue being used as they were. 1470672 6 352732 ap 2018-10-18 14:20:51 -0700 Comment on attachment 352732 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352732&action=review > Tools/Scripts/webkitpy/common/host.py:58 > + @property Do we need @property here? Looks like @memoized tends to be used without. 1470674 7 ap 2018-10-18 14:21:12 -0700 Saw your explanation now. 1470708 8 352732 commit-queue 2018-10-18 15:14:59 -0700 Comment on attachment 352732 Patch Clearing flags on attachment: 352732 Committed r237269: <https://trac.webkit.org/changeset/237269> 1470709 9 commit-queue 2018-10-18 15:15:01 -0700 All reviewed patches have been landed. Closing bug. 1470710 10 webkit-bug-importer 2018-10-18 15:15:26 -0700 <rdar://problem/45386267> 1490745 11 dbates 2018-12-24 18:26:17 -0800 (In reply to WebKit Commit Bot from comment #8) > Comment on attachment 352732 [details] > Patch > > Clearing flags on attachment: 352732 > > Committed r237269: <https://trac.webkit.org/changeset/237269> This broke "webkit-patch what-broke". See bug #193025. 352727 2018-10-18 13:59:05 -0700 2018-10-18 14:18:01 -0700 Patch bug-190732-20181018135905.patch text/plain 3034 dean_johnson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTk2NzY3Njc2ZThkZGU4YTdmYWEwM2JhMjQyMDQzNmFl YWMyOWNjMS4uNzM3YmQ0YjU2ZmRkMDJjOGYwMzJkMTljZmEzOTc1ZTY3M2I1YWUzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTEwLTE4ICBEZWFuIEpvaG5zb24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgor CisgICAgICAgIGNsZWFuLXdlYmtpdCBwdWxscyBpbiBtYW55IHVubmVjZXNzYXJ5IGRlcGVuZGVu Y2llcyBpbiB3ZWJraXRweQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkwNzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5OgorICAgICAgICAoSG9z dC5fX2luaXRfXyk6IFNwbGl0IG91dCAnYnVncycsICdidWd6aWxsYScsIGFuZCAnd2ViJyB0byBv bmx5IGJlIGNyZWF0ZWQgd2hlbiB1c2VkLgorICAgICAgICAoSG9zdCk6CisgICAgICAgIChIb3N0 LmJ1Z3MpOgorICAgICAgICAoSG9zdC5idWd6aWxsYSk6CisgICAgICAgIChIb3N0LndlYik6CisK IDIwMTgtMTAtMDEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM2NTUxLgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2hvc3QucHkKaW5kZXggOGNkMDM4YTc3ZWJkYTdmNTE1Nzc3M2VjYzJkMTZj YmM5OTRhOTRhMy4uYzdhZTlkODUyY2Y1YTU4MDQzZDkzNjA0YmI0MWIxNTNhY2Q1YTY0MiAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5CkBAIC0zNCw3ICszNCw2IEBAIGltcG9y dCBzeXMKIGZyb20gd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0IGltcG9ydCBDaGVja291dAogZnJv bSB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuc2NtLmRldGVjdGlvbiBpbXBvcnQgU0NNRGV0ZWN0 b3IKIGZyb20gd2Via2l0cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAotZnJvbSB3 ZWJraXRweS5jb21tb24ubmV0IGltcG9ydCBidWd6aWxsYSwgYnVpbGRib3QsIHdlYgogZnJvbSB3 ZWJraXRweS5jb21tb24uc3lzdGVtLnN5c3RlbWhvc3QgaW1wb3J0IFN5c3RlbUhvc3QKIGZyb20g d2Via2l0cHkuY29tbW9uLndhdGNobGlzdC53YXRjaGxpc3RwYXJzZXIgaW1wb3J0IFdhdGNoTGlz dFBhcnNlcgogZnJvbSB3ZWJraXRweS5wb3J0LmZhY3RvcnkgaW1wb3J0IFBvcnRGYWN0b3J5CkBA IC00NiwxNCArNDUsOCBAQCBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiBjbGFz cyBIb3N0KFN5c3RlbUhvc3QpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKICAgICAgICAgU3lz dGVtSG9zdC5fX2luaXRfXyhzZWxmKQotICAgICAgICBzZWxmLndlYiA9IHdlYi5XZWIoKQotCiAg ICAgICAgIHNlbGYuX2NoZWNrb3V0ID0gTm9uZQogCi0gICAgICAgICMgRXZlcnl0aGluZyBiZWxv dyB0aGlzIGxpbmUgaXMgV2ViS2l0LXNwZWNpZmljIGFuZCBiZWxvbmdzIG9uIGEgaGlnaGVyLWxl dmVsIG9iamVjdC4KLSAgICAgICAgc2VsZi5idWdzID0gYnVnemlsbGEuQnVnemlsbGEoKQotICAg ICAgICBzZWxmLmJ1aWxkYm90ID0gYnVpbGRib3QuQnVpbGRCb3QoKQotCiAgICAgICAgICMgRklY TUU6IFVuZm9ydHVuYXRlbHkgUG9ydCBvYmplY3RzIGFyZSBjdXJyZW50bHkgdGhlIGNlbnRyYWwt ZGlzcGF0Y2ggb2JqZWN0cyBvZiB0aGUgTlJXVCB3b3JsZC4KICAgICAgICAgIyBJbiBvcmRlciB0 byBpbnN0YW50aWF0ZSBhIHBvcnQgY29ycmVjdGx5LCB3ZSBoYXZlIHRvIHBhc3MgaXQgYXQgbGVh c3QgYW4gZXhlY3V0aXZlLCB1c2VyLCBzY20sIGFuZCBmaWxlc3lzdGVtCiAgICAgICAgICMgc28g Zm9yIG5vdyB3ZSBqdXN0IHBhc3MgYWxvbmcgdGhlIHdob2xlIEhvc3Qgb2JqZWN0LgpAQCAtNjIs NiArNTUsMjcgQEAgY2xhc3MgSG9zdChTeXN0ZW1Ib3N0KToKIAogICAgICAgICBzZWxmLl9lbmdh Z2VfYXdlc29tZV9sb2NhbGVfaGFja3MoKQogCisgICAgQHByb3BlcnR5CisgICAgZGVmIGJ1Z3Mo c2VsZik6CisgICAgICAgIGlmIG5vdCBoYXNhdHRyKHNlbGYsICdfYnVncycpOgorICAgICAgICAg ICAgZnJvbSB3ZWJraXRweS5jb21tb24ubmV0IGltcG9ydCBidWd6aWxsYQorICAgICAgICAgICAg c2VsZi5fYnVncyA9IGJ1Z3ppbGxhLkJ1Z3ppbGxhKCkKKyAgICAgICAgcmV0dXJuIHNlbGYuX2J1 Z3MKKworICAgIEBwcm9wZXJ0eQorICAgIGRlZiBidWd6aWxsYShzZWxmKToKKyAgICAgICAgaWYg bm90IGhhc2F0dHIoc2VsZiwgJ19idWlsZGJvdCcpOgorICAgICAgICAgICAgZnJvbSB3ZWJraXRw eS5jb21tb24ubmV0IGltcG9ydCBidWlsZGJvdAorICAgICAgICAgICAgc2VsZi5fYnVpbGRib3Qg PSBidWlsZGJvdC5CdWlsZEJvdCgpCisgICAgICAgIHJldHVybiBzZWxmLl9idWlsZGJvdAorCisg ICAgQHByb3BlcnR5CisgICAgZGVmIHdlYihzZWxmKToKKyAgICAgICAgaWYgbm90IGhhc2F0dHIo c2VsZiwgJ193ZWInKToKKyAgICAgICAgICAgIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldCBpbXBv cnQgd2ViCisgICAgICAgICAgICBzZWxmLl93ZWIgPSB3ZWIuV2ViKCkKKyAgICAgICAgcmV0dXJu IHNlbGYuX3dlYgorCiAgICAgIyBXZSBjYWxsIHRoaXMgZnJvbSB0aGUgSG9zdCBjb25zdHJ1Y3Rv ciwgYXMgaXQncyBvbmUgb2YgdGhlCiAgICAgIyBlYXJsaWVzdCBjYWxscyBtYWRlIGZvciBhbGwg d2Via2l0cHktYmFzZWQgcHJvZ3JhbXMuCiAgICAgZGVmIF9lbmdhZ2VfYXdlc29tZV9sb2NhbGVf aGFja3Moc2VsZik6Cg== 352732 2018-10-18 14:18:06 -0700 2018-10-18 15:14:59 -0700 Patch bug-190732-20181018141805.patch text/plain 2827 dean_johnson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTk2NzY3Njc2ZThkZGU4YTdmYWEwM2JhMjQyMDQzNmFl YWMyOWNjMS4uNzM3YmQ0YjU2ZmRkMDJjOGYwMzJkMTljZmEzOTc1ZTY3M2I1YWUzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTEwLTE4ICBEZWFuIEpvaG5zb24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgor CisgICAgICAgIGNsZWFuLXdlYmtpdCBwdWxscyBpbiBtYW55IHVubmVjZXNzYXJ5IGRlcGVuZGVu Y2llcyBpbiB3ZWJraXRweQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkwNzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5OgorICAgICAgICAoSG9z dC5fX2luaXRfXyk6IFNwbGl0IG91dCAnYnVncycsICdidWd6aWxsYScsIGFuZCAnd2ViJyB0byBv bmx5IGJlIGNyZWF0ZWQgd2hlbiB1c2VkLgorICAgICAgICAoSG9zdCk6CisgICAgICAgIChIb3N0 LmJ1Z3MpOgorICAgICAgICAoSG9zdC5idWd6aWxsYSk6CisgICAgICAgIChIb3N0LndlYik6CisK IDIwMTgtMTAtMDEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM2NTUxLgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2hvc3QucHkKaW5kZXggOGNkMDM4YTc3ZWJkYTdmNTE1Nzc3M2VjYzJkMTZj YmM5OTRhOTRhMy4uMDc4MTM5ZDcwMjJmM2I0MWE2NjVhMzM1ZDJhZDU2NjZkZDYyYjZmMyAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5CkBAIC0zNCw3ICszNCw2IEBAIGltcG9y dCBzeXMKIGZyb20gd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0IGltcG9ydCBDaGVja291dAogZnJv bSB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuc2NtLmRldGVjdGlvbiBpbXBvcnQgU0NNRGV0ZWN0 b3IKIGZyb20gd2Via2l0cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAotZnJvbSB3 ZWJraXRweS5jb21tb24ubmV0IGltcG9ydCBidWd6aWxsYSwgYnVpbGRib3QsIHdlYgogZnJvbSB3 ZWJraXRweS5jb21tb24uc3lzdGVtLnN5c3RlbWhvc3QgaW1wb3J0IFN5c3RlbUhvc3QKIGZyb20g d2Via2l0cHkuY29tbW9uLndhdGNobGlzdC53YXRjaGxpc3RwYXJzZXIgaW1wb3J0IFdhdGNoTGlz dFBhcnNlcgogZnJvbSB3ZWJraXRweS5wb3J0LmZhY3RvcnkgaW1wb3J0IFBvcnRGYWN0b3J5CkBA IC00NiwxNCArNDUsOCBAQCBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiBjbGFz cyBIb3N0KFN5c3RlbUhvc3QpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKICAgICAgICAgU3lz dGVtSG9zdC5fX2luaXRfXyhzZWxmKQotICAgICAgICBzZWxmLndlYiA9IHdlYi5XZWIoKQotCiAg ICAgICAgIHNlbGYuX2NoZWNrb3V0ID0gTm9uZQogCi0gICAgICAgICMgRXZlcnl0aGluZyBiZWxv dyB0aGlzIGxpbmUgaXMgV2ViS2l0LXNwZWNpZmljIGFuZCBiZWxvbmdzIG9uIGEgaGlnaGVyLWxl dmVsIG9iamVjdC4KLSAgICAgICAgc2VsZi5idWdzID0gYnVnemlsbGEuQnVnemlsbGEoKQotICAg ICAgICBzZWxmLmJ1aWxkYm90ID0gYnVpbGRib3QuQnVpbGRCb3QoKQotCiAgICAgICAgICMgRklY TUU6IFVuZm9ydHVuYXRlbHkgUG9ydCBvYmplY3RzIGFyZSBjdXJyZW50bHkgdGhlIGNlbnRyYWwt ZGlzcGF0Y2ggb2JqZWN0cyBvZiB0aGUgTlJXVCB3b3JsZC4KICAgICAgICAgIyBJbiBvcmRlciB0 byBpbnN0YW50aWF0ZSBhIHBvcnQgY29ycmVjdGx5LCB3ZSBoYXZlIHRvIHBhc3MgaXQgYXQgbGVh c3QgYW4gZXhlY3V0aXZlLCB1c2VyLCBzY20sIGFuZCBmaWxlc3lzdGVtCiAgICAgICAgICMgc28g Zm9yIG5vdyB3ZSBqdXN0IHBhc3MgYWxvbmcgdGhlIHdob2xlIEhvc3Qgb2JqZWN0LgpAQCAtNjIs NiArNTUsMjQgQEAgY2xhc3MgSG9zdChTeXN0ZW1Ib3N0KToKIAogICAgICAgICBzZWxmLl9lbmdh Z2VfYXdlc29tZV9sb2NhbGVfaGFja3MoKQogCisgICAgQHByb3BlcnR5CisgICAgQG1lbW9pemVk CisgICAgZGVmIGJ1Z3Moc2VsZik6CisgICAgICAgIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldCBp bXBvcnQgYnVnemlsbGEKKyAgICAgICAgcmV0dXJuIGJ1Z3ppbGxhLkJ1Z3ppbGxhKCkKKworICAg IEBwcm9wZXJ0eQorICAgIEBtZW1vaXplZAorICAgIGRlZiBidWd6aWxsYShzZWxmKToKKyAgICAg ICAgZnJvbSB3ZWJraXRweS5jb21tb24ubmV0IGltcG9ydCBidWlsZGJvdAorICAgICAgICByZXR1 cm4gYnVpbGRib3QuQnVpbGRCb3QoKQorCisgICAgQHByb3BlcnR5CisgICAgQG1lbW9pemVkCisg ICAgZGVmIHdlYihzZWxmKToKKyAgICAgICAgZnJvbSB3ZWJraXRweS5jb21tb24ubmV0IGltcG9y dCB3ZWIKKyAgICAgICAgcmV0dXJuIHdlYi5XZWIoKQorCiAgICAgIyBXZSBjYWxsIHRoaXMgZnJv bSB0aGUgSG9zdCBjb25zdHJ1Y3RvciwgYXMgaXQncyBvbmUgb2YgdGhlCiAgICAgIyBlYXJsaWVz dCBjYWxscyBtYWRlIGZvciBhbGwgd2Via2l0cHktYmFzZWQgcHJvZ3JhbXMuCiAgICAgZGVmIF9l bmdhZ2VfYXdlc29tZV9sb2NhbGVfaGFja3Moc2VsZik6Cg==