190683 2018-10-17 12:57:51 -0700 [GStreamer][WebRTC] Do not try to handle framerate modulation in the encoder 2018-11-06 06:24:22 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190682 187064 190684 1 tsaunier tsaunier alex calvaris commit-queue pnormand webkit-bug-importer oldest_to_newest 1470283 0 tsaunier 2018-10-17 12:57:51 -0700 [GStreamer][WebRTC] Do not try to handle framerate modulation in the encoder 1470284 1 352620 tsaunier 2018-10-17 12:58:07 -0700 Created attachment 352620 Patch 1470287 2 352622 tsaunier 2018-10-17 12:59:18 -0700 Created attachment 352622 Patch 1475174 3 353888 tsaunier 2018-11-05 11:05:06 -0800 Created attachment 353888 Patch 1475420 4 353888 calvaris 2018-11-05 22:56:44 -0800 Comment on attachment 353888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353888&action=review > Source/WebCore/ChangeLog:8 > + This has to already be handled in capturing pipeline or in libwebrtc itself Period at the end. > Source/WebCore/ChangeLog:10 > + No other encoder implementation try to do that, and libwebrtc is not happy with encoder that do not output the exact number of frames that have been passed in try -> tried, "with encoders that" and period at the end. 1475421 5 353888 calvaris 2018-11-05 22:58:45 -0800 Comment on attachment 353888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353888&action=review > Source/WebCore/ChangeLog:12 > + No regressions detected and libwebrtc is happier this way, less warning output and no more frame corruption in H264 streams found. My only concern is we should have a test for this, I'll let Phil decide. 1475497 6 tsaunier 2018-11-06 04:15:43 -0800 (In reply to Xabier Rodríguez Calvar from comment #5) > Comment on attachment 353888 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353888&action=review > > > Source/WebCore/ChangeLog:12 > > + No regressions detected and libwebrtc is happier this way, less warning output and no more frame corruption in H264 streams found. > > My only concern is we should have a test for this, I'll let Phil decide. Well, we basically have "test", libwebrtc is not throwing WARNINGS anymore, I do not see how we could have a dedicated test at our level. 1475499 7 353962 tsaunier 2018-11-06 04:40:20 -0800 Created attachment 353962 Patch 1475513 8 353962 commit-queue 2018-11-06 06:23:32 -0800 Comment on attachment 353962 Patch Clearing flags on attachment: 353962 Committed r237860: <https://trac.webkit.org/changeset/237860> 1475514 9 commit-queue 2018-11-06 06:23:33 -0800 All reviewed patches have been landed. Closing bug. 1475515 10 webkit-bug-importer 2018-11-06 06:24:22 -0800 <rdar://problem/45841276> 352620 2018-10-17 12:58:07 -0700 2018-10-17 12:59:14 -0700 Patch bug-190683-20181017165806.patch text/plain 3013 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc3OTdkMmNkMDIwMDJh YTNmNDNjNTY2NGRiYzNkY2ViOWFkYWE0MC4uNzI4MmExNmIwYTg5Njc2OTlhOWM1YTcxZmUzZThi MTY2Y2EyOTk2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTE3ICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCB0cnkgdG8gaGFuZGxlIGZyYW1lcmF0ZSBtb2R1bGF0aW9uIGluIHRo ZSBlbmNvZGVyCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhhcyB0byBhbHJlYWR5 IGJlIGhhbmRsZWQgaW4gY2FwdHVyaW5nIHBpcGVsaW5lIG9yIGluIGxpYndlYnJ0YyBpdHNlbGYK KworICAgICAgICBObyBvdGhlciBlbmNvZGVyIGltcGxlbWVudGF0aW9uIHRyeSB0byBkbyB0aGF0 LCBhbmQgbGlid2VicnRjIGlzIG5vdCBoYXBweSB3aXRoIGVuY29kZXIgdGhhdCBkbyBub3Qgb3V0 cHV0IHRoZSBleGFjdCBudW1iZXIgb2YgZnJhbWVzIHRoYXQgaGF2ZSBiZWVuIHBhc3NlZCBpbgor CisgICAgICAgIE5vIHJlZ3Jlc3Npb25zIGRldGVjdGVkIGFuZCBsaWJ3ZWJydGMgaXMgaGFwcGll ciB0aGlzIHdheSwgbGVzcyB3YXJuaW5nIG91dHB1dCBhbmQgbm8gbW9yZSBmcmFtZSBjb3JydXB0 aW9uIGluIEgyNjQgc3RyZWFtcyBmb3VuZC4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdTdHJlYW1lclZpZGVvRW5jb2Rlcjo6SW5pdEVuY29kZSk6CisKIDIwMTgtMTAt MTcgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmllckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH U3RyZWFtZXJdW1dlYlJUQ10gSGFuZGxlIHNldHRpbmcgbWF4IG51bWJlciBvZiBmcmFtZSBiZXR3 ZWVuIGtleWZyYW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2RlckZhY3RvcnkuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5j b2RlckZhY3RvcnkuY3BwCmluZGV4IDY4YzBmMTdjNTYwMDMzZTcxNTg0MjkwZjkzZTM3ODBmMjhi MDY4MWUuLmI0NDIxMTM3ZTFjMmVkZmM0NDBlN2Y0NWM1MTA4ZTc4ODQzZTAwZWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9HU3RyZWFt ZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9saWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNvZGVyRmFjdG9yeS5jcHAKQEAg LTgzLDcgKzgzLDYgQEAgcHVibGljOgogICAgICAgICAgICAgbmV3Qml0cmF0ZSwgZnJhbWVSYXRl KTsKIAogICAgICAgICBhdXRvIGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2NhcHNfY29weShtX3Jlc3Ry aWN0aW9uQ2Fwcy5nZXQoKSkpOwotICAgICAgICBnc3RfY2Fwc19zZXRfc2ltcGxlKGNhcHMuZ2V0 KCksICJmcmFtZXJhdGUiLCBHU1RfVFlQRV9GUkFDVElPTiwgZnJhbWVSYXRlLCAxLCBudWxscHRy KTsKIAogICAgICAgICBTZXRSZXN0cmljdGlvbkNhcHMoV1RGTW92ZShjYXBzKSk7CiAKQEAgLTEz OCw3ICsxMzcsNiBAQCBwdWJsaWM6CiAgICAgICAgIGdfb2JqZWN0X3NldChtX3NyYywgImlzLWxp dmUiLCB0cnVlLCAiZm9ybWF0IiwgR1NUX0ZPUk1BVF9USU1FLCBudWxscHRyKTsKIAogICAgICAg ICBhdXRvIHZpZGVvY29udmVydCA9IG1ha2VFbGVtZW50KCJ2aWRlb2NvbnZlcnQiKTsKLSAgICAg ICAgYXV0byB2aWRlb3JhdGUgPSBtYWtlRWxlbWVudCgidmlkZW9yYXRlIik7CiAgICAgICAgIGF1 dG8gc2luayA9IG1ha2VFbGVtZW50KCJhcHBzaW5rIik7CiAgICAgICAgIGdzdF9hcHBfc2lua19z ZXRfZW1pdF9zaWduYWxzKEdTVF9BUFBfU0lOSyhzaW5rKSwgVFJVRSk7CiAgICAgICAgIGdfc2ln bmFsX2Nvbm5lY3Qoc2luaywgIm5ldy1zYW1wbGUiLCBHX0NBTExCQUNLKG5ld1NhbXBsZUNhbGxi YWNrVHJhbXApLCB0aGlzKTsKQEAgLTE0OCw4ICsxNDYsOCBAQCBwdWJsaWM6CiAgICAgICAgIGlm IChtX3Jlc3RyaWN0aW9uQ2FwcykKICAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX2NhcHNGaWx0 ZXIsICJjYXBzIiwgbV9yZXN0cmljdGlvbkNhcHMuZ2V0KCksIG51bGxwdHIpOwogCi0gICAgICAg IGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTihtX3BpcGVsaW5lLmdldCgpKSwgbV9zcmMsIHZpZGVv cmF0ZSwgdmlkZW9jb252ZXJ0LCBtX2NhcHNGaWx0ZXIsIGVuY29kZXIubGVha1JlZigpLCBzaW5r LCBudWxscHRyKTsKLSAgICAgICAgaWYgKCFnc3RfZWxlbWVudF9saW5rX21hbnkobV9zcmMsIHZp ZGVvcmF0ZSwgdmlkZW9jb252ZXJ0LCBtX2NhcHNGaWx0ZXIsIG1fZW5jb2Rlciwgc2luaywgbnVs bHB0cikpCisgICAgICAgIGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTihtX3BpcGVsaW5lLmdldCgp KSwgbV9zcmMsIHZpZGVvY29udmVydCwgbV9jYXBzRmlsdGVyLCBlbmNvZGVyLmxlYWtSZWYoKSwg c2luaywgbnVsbHB0cik7CisgICAgICAgIGlmICghZ3N0X2VsZW1lbnRfbGlua19tYW55KG1fc3Jj LCB2aWRlb2NvbnZlcnQsIG1fY2Fwc0ZpbHRlciwgbV9lbmNvZGVyLCBzaW5rLCBudWxscHRyKSkK ICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogCiAgICAgICAgIGdzdF9lbGVtZW50 X3NldF9zdGF0ZShtX3BpcGVsaW5lLmdldCgpLCBHU1RfU1RBVEVfUExBWUlORyk7Cg== 352622 2018-10-17 12:59:18 -0700 2018-11-05 11:05:02 -0800 Patch bug-190683-20181017165917.patch text/plain 3034 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc3OTdkMmNkMDIwMDJh YTNmNDNjNTY2NGRiYzNkY2ViOWFkYWE0MC4uOWYxMGY0YzU1OWMzMmU1YzYyZmRhZjlmY2Y3NGZm MGU4Y2U1YTQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTE3ICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCB0cnkgdG8gaGFuZGxlIGZyYW1lcmF0ZSBtb2R1bGF0aW9uIGluIHRo ZSBlbmNvZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTA2ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGhhcyB0byBhbHJlYWR5IGJlIGhhbmRsZWQgaW4gY2FwdHVyaW5nIHBpcGVsaW5lIG9y IGluIGxpYndlYnJ0YyBpdHNlbGYKKworICAgICAgICBObyBvdGhlciBlbmNvZGVyIGltcGxlbWVu dGF0aW9uIHRyeSB0byBkbyB0aGF0LCBhbmQgbGlid2VicnRjIGlzIG5vdCBoYXBweSB3aXRoIGVu Y29kZXIgdGhhdCBkbyBub3Qgb3V0cHV0IHRoZSBleGFjdCBudW1iZXIgb2YgZnJhbWVzIHRoYXQg aGF2ZSBiZWVuIHBhc3NlZCBpbgorCisgICAgICAgIE5vIHJlZ3Jlc3Npb25zIGRldGVjdGVkIGFu ZCBsaWJ3ZWJydGMgaXMgaGFwcGllciB0aGlzIHdheSwgbGVzcyB3YXJuaW5nIG91dHB1dCBhbmQg bm8gbW9yZSBmcmFtZSBjb3JydXB0aW9uIGluIEgyNjQgc3RyZWFtcyBmb3VuZC4KKworICAgICAg ICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJG YWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJlYW1lclZpZGVvRW5jb2Rlcjo6SW5p dEVuY29kZSk6CisKIDIwMTgtMTAtMTcgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmllckBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdW1dlYlJUQ10gSGFuZGxlIHNldHRpbmcgbWF4 IG51bWJlciBvZiBmcmFtZSBiZXR3ZWVuIGtleWZyYW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2Rl ckZhY3RvcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2Vi cnRjL0dTdHJlYW1lclZpZGVvRW5jb2RlckZhY3RvcnkuY3BwCmluZGV4IDY4YzBmMTdjNTYwMDMz ZTcxNTg0MjkwZjkzZTM3ODBmMjhiMDY4MWUuLmI0NDIxMTM3ZTFjMmVkZmM0NDBlN2Y0NWM1MTA4 ZTc4ODQzZTAwZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9F bmNvZGVyRmFjdG9yeS5jcHAKQEAgLTgzLDcgKzgzLDYgQEAgcHVibGljOgogICAgICAgICAgICAg bmV3Qml0cmF0ZSwgZnJhbWVSYXRlKTsKIAogICAgICAgICBhdXRvIGNhcHMgPSBhZG9wdEdSZWYo Z3N0X2NhcHNfY29weShtX3Jlc3RyaWN0aW9uQ2Fwcy5nZXQoKSkpOwotICAgICAgICBnc3RfY2Fw c19zZXRfc2ltcGxlKGNhcHMuZ2V0KCksICJmcmFtZXJhdGUiLCBHU1RfVFlQRV9GUkFDVElPTiwg ZnJhbWVSYXRlLCAxLCBudWxscHRyKTsKIAogICAgICAgICBTZXRSZXN0cmljdGlvbkNhcHMoV1RG TW92ZShjYXBzKSk7CiAKQEAgLTEzOCw3ICsxMzcsNiBAQCBwdWJsaWM6CiAgICAgICAgIGdfb2Jq ZWN0X3NldChtX3NyYywgImlzLWxpdmUiLCB0cnVlLCAiZm9ybWF0IiwgR1NUX0ZPUk1BVF9USU1F LCBudWxscHRyKTsKIAogICAgICAgICBhdXRvIHZpZGVvY29udmVydCA9IG1ha2VFbGVtZW50KCJ2 aWRlb2NvbnZlcnQiKTsKLSAgICAgICAgYXV0byB2aWRlb3JhdGUgPSBtYWtlRWxlbWVudCgidmlk ZW9yYXRlIik7CiAgICAgICAgIGF1dG8gc2luayA9IG1ha2VFbGVtZW50KCJhcHBzaW5rIik7CiAg ICAgICAgIGdzdF9hcHBfc2lua19zZXRfZW1pdF9zaWduYWxzKEdTVF9BUFBfU0lOSyhzaW5rKSwg VFJVRSk7CiAgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3Qoc2luaywgIm5ldy1zYW1wbGUiLCBHX0NB TExCQUNLKG5ld1NhbXBsZUNhbGxiYWNrVHJhbXApLCB0aGlzKTsKQEAgLTE0OCw4ICsxNDYsOCBA QCBwdWJsaWM6CiAgICAgICAgIGlmIChtX3Jlc3RyaWN0aW9uQ2FwcykKICAgICAgICAgICAgIGdf b2JqZWN0X3NldChtX2NhcHNGaWx0ZXIsICJjYXBzIiwgbV9yZXN0cmljdGlvbkNhcHMuZ2V0KCks IG51bGxwdHIpOwogCi0gICAgICAgIGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTihtX3BpcGVsaW5l LmdldCgpKSwgbV9zcmMsIHZpZGVvcmF0ZSwgdmlkZW9jb252ZXJ0LCBtX2NhcHNGaWx0ZXIsIGVu Y29kZXIubGVha1JlZigpLCBzaW5rLCBudWxscHRyKTsKLSAgICAgICAgaWYgKCFnc3RfZWxlbWVu dF9saW5rX21hbnkobV9zcmMsIHZpZGVvcmF0ZSwgdmlkZW9jb252ZXJ0LCBtX2NhcHNGaWx0ZXIs IG1fZW5jb2Rlciwgc2luaywgbnVsbHB0cikpCisgICAgICAgIGdzdF9iaW5fYWRkX21hbnkoR1NU X0JJTihtX3BpcGVsaW5lLmdldCgpKSwgbV9zcmMsIHZpZGVvY29udmVydCwgbV9jYXBzRmlsdGVy LCBlbmNvZGVyLmxlYWtSZWYoKSwgc2luaywgbnVsbHB0cik7CisgICAgICAgIGlmICghZ3N0X2Vs ZW1lbnRfbGlua19tYW55KG1fc3JjLCB2aWRlb2NvbnZlcnQsIG1fY2Fwc0ZpbHRlciwgbV9lbmNv ZGVyLCBzaW5rLCBudWxscHRyKSkKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwog CiAgICAgICAgIGdzdF9lbGVtZW50X3NldF9zdGF0ZShtX3BpcGVsaW5lLmdldCgpLCBHU1RfU1RB VEVfUExBWUlORyk7Cg== 353888 2018-11-05 11:05:06 -0800 2018-11-06 04:40:16 -0800 Patch bug-190683-20181105160505.patch text/plain 3034 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJiNGE1Zjc1OTc2YzQx N2EyZGM4YjNlNWIwNzRlN2NhYWMwZWIyYy4uNzcyNzc3OTc0NGQxYmI1MjY4YzRhN2E2MzZhNDk1 NWM2YjQzYzBjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTE3ICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCB0cnkgdG8gaGFuZGxlIGZyYW1lcmF0ZSBtb2R1bGF0aW9uIGluIHRo ZSBlbmNvZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTA2ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGhhcyB0byBhbHJlYWR5IGJlIGhhbmRsZWQgaW4gY2FwdHVyaW5nIHBpcGVsaW5lIG9y IGluIGxpYndlYnJ0YyBpdHNlbGYKKworICAgICAgICBObyBvdGhlciBlbmNvZGVyIGltcGxlbWVu dGF0aW9uIHRyeSB0byBkbyB0aGF0LCBhbmQgbGlid2VicnRjIGlzIG5vdCBoYXBweSB3aXRoIGVu Y29kZXIgdGhhdCBkbyBub3Qgb3V0cHV0IHRoZSBleGFjdCBudW1iZXIgb2YgZnJhbWVzIHRoYXQg aGF2ZSBiZWVuIHBhc3NlZCBpbgorCisgICAgICAgIE5vIHJlZ3Jlc3Npb25zIGRldGVjdGVkIGFu ZCBsaWJ3ZWJydGMgaXMgaGFwcGllciB0aGlzIHdheSwgbGVzcyB3YXJuaW5nIG91dHB1dCBhbmQg bm8gbW9yZSBmcmFtZSBjb3JydXB0aW9uIGluIEgyNjQgc3RyZWFtcyBmb3VuZC4KKworICAgICAg ICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJG YWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJlYW1lclZpZGVvRW5jb2Rlcjo6SW5p dEVuY29kZSk6CisKIDIwMTgtMTAtMTcgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmllckBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdW1dlYlJUQ10gSGFuZGxlIHNldHRpbmcgbWF4 IG51bWJlciBvZiBmcmFtZSBiZXR3ZWVuIGtleWZyYW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2Rl ckZhY3RvcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2Vi cnRjL0dTdHJlYW1lclZpZGVvRW5jb2RlckZhY3RvcnkuY3BwCmluZGV4IDY4YzBmMTdjNTYwMDMz ZTcxNTg0MjkwZjkzZTM3ODBmMjhiMDY4MWUuLmI0NDIxMTM3ZTFjMmVkZmM0NDBlN2Y0NWM1MTA4 ZTc4ODQzZTAwZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9F bmNvZGVyRmFjdG9yeS5jcHAKQEAgLTgzLDcgKzgzLDYgQEAgcHVibGljOgogICAgICAgICAgICAg bmV3Qml0cmF0ZSwgZnJhbWVSYXRlKTsKIAogICAgICAgICBhdXRvIGNhcHMgPSBhZG9wdEdSZWYo Z3N0X2NhcHNfY29weShtX3Jlc3RyaWN0aW9uQ2Fwcy5nZXQoKSkpOwotICAgICAgICBnc3RfY2Fw c19zZXRfc2ltcGxlKGNhcHMuZ2V0KCksICJmcmFtZXJhdGUiLCBHU1RfVFlQRV9GUkFDVElPTiwg ZnJhbWVSYXRlLCAxLCBudWxscHRyKTsKIAogICAgICAgICBTZXRSZXN0cmljdGlvbkNhcHMoV1RG TW92ZShjYXBzKSk7CiAKQEAgLTEzOCw3ICsxMzcsNiBAQCBwdWJsaWM6CiAgICAgICAgIGdfb2Jq ZWN0X3NldChtX3NyYywgImlzLWxpdmUiLCB0cnVlLCAiZm9ybWF0IiwgR1NUX0ZPUk1BVF9USU1F LCBudWxscHRyKTsKIAogICAgICAgICBhdXRvIHZpZGVvY29udmVydCA9IG1ha2VFbGVtZW50KCJ2 aWRlb2NvbnZlcnQiKTsKLSAgICAgICAgYXV0byB2aWRlb3JhdGUgPSBtYWtlRWxlbWVudCgidmlk ZW9yYXRlIik7CiAgICAgICAgIGF1dG8gc2luayA9IG1ha2VFbGVtZW50KCJhcHBzaW5rIik7CiAg ICAgICAgIGdzdF9hcHBfc2lua19zZXRfZW1pdF9zaWduYWxzKEdTVF9BUFBfU0lOSyhzaW5rKSwg VFJVRSk7CiAgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3Qoc2luaywgIm5ldy1zYW1wbGUiLCBHX0NB TExCQUNLKG5ld1NhbXBsZUNhbGxiYWNrVHJhbXApLCB0aGlzKTsKQEAgLTE0OCw4ICsxNDYsOCBA QCBwdWJsaWM6CiAgICAgICAgIGlmIChtX3Jlc3RyaWN0aW9uQ2FwcykKICAgICAgICAgICAgIGdf b2JqZWN0X3NldChtX2NhcHNGaWx0ZXIsICJjYXBzIiwgbV9yZXN0cmljdGlvbkNhcHMuZ2V0KCks IG51bGxwdHIpOwogCi0gICAgICAgIGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTihtX3BpcGVsaW5l LmdldCgpKSwgbV9zcmMsIHZpZGVvcmF0ZSwgdmlkZW9jb252ZXJ0LCBtX2NhcHNGaWx0ZXIsIGVu Y29kZXIubGVha1JlZigpLCBzaW5rLCBudWxscHRyKTsKLSAgICAgICAgaWYgKCFnc3RfZWxlbWVu dF9saW5rX21hbnkobV9zcmMsIHZpZGVvcmF0ZSwgdmlkZW9jb252ZXJ0LCBtX2NhcHNGaWx0ZXIs IG1fZW5jb2Rlciwgc2luaywgbnVsbHB0cikpCisgICAgICAgIGdzdF9iaW5fYWRkX21hbnkoR1NU X0JJTihtX3BpcGVsaW5lLmdldCgpKSwgbV9zcmMsIHZpZGVvY29udmVydCwgbV9jYXBzRmlsdGVy LCBlbmNvZGVyLmxlYWtSZWYoKSwgc2luaywgbnVsbHB0cik7CisgICAgICAgIGlmICghZ3N0X2Vs ZW1lbnRfbGlua19tYW55KG1fc3JjLCB2aWRlb2NvbnZlcnQsIG1fY2Fwc0ZpbHRlciwgbV9lbmNv ZGVyLCBzaW5rLCBudWxscHRyKSkKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwog CiAgICAgICAgIGdzdF9lbGVtZW50X3NldF9zdGF0ZShtX3BpcGVsaW5lLmdldCgpLCBHU1RfU1RB VEVfUExBWUlORyk7Cg== 353962 2018-11-06 04:40:20 -0800 2018-11-06 06:23:32 -0800 Patch bug-190683-20181106094018.patch text/plain 3029 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJiNGE1Zjc1OTc2YzQx N2EyZGM4YjNlNWIwNzRlN2NhYWMwZWIyYy4uYTNlYjJmM2UwOTlmNGFhYzQyN2ZlNTkwYjM0ZGVi NmQ1MjM0Yjk2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTE3ICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCB0cnkgdG8gaGFuZGxlIGZyYW1lcmF0ZSBtb2R1bGF0aW9uIGluIHRo ZSBlbmNvZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTA2ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGhhcyB0byBhbHJlYWR5IGJlIGhhbmRsZWQgaW4gY2FwdHVyaW5nIHBpcGVsaW5lIG9y IGluIGxpYndlYnJ0YyBpdHNlbGYuCisKKyAgICAgICAgTm8gb3RoZXIgZW5jb2RlciBpbXBsZW1l bnRhdGlvbiBkbyB0aGF0LCBhbmQgbGlid2VicnRjIGlzIG5vdCBoYXBweSB3aXRoIGVuY29kZXIg dGhhdCBkbyBub3Qgb3V0cHV0IHRoZSBleGFjdCBudW1iZXIgb2YgZnJhbWVzIHRoYXQgaGF2ZSBi ZWVuIHBhc3NlZCBpbi4KKworICAgICAgICBObyByZWdyZXNzaW9ucyBkZXRlY3RlZCBhbmQgbGli d2VicnRjIGlzIGhhcHBpZXIgdGhpcyB3YXksIGxlc3Mgd2FybmluZyBvdXRwdXQgYW5kIG5vIG1v cmUgZnJhbWUgY29ycnVwdGlvbiBpbiBIMjY0IHN0cmVhbXMgZm91bmQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNvZGVyRmFjdG9y eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJWaWRlb0VuY29kZXI6OkluaXRFbmNv ZGUpOgorCiAyMDE4LTEwLTE3ICBUaGliYXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1N0cmVhbWVyXVtXZWJSVENdIEhhbmRsZSBzZXR0aW5nIG1heCBudW1i ZXIgb2YgZnJhbWUgYmV0d2VlbiBrZXlmcmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0 b3J5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9H U3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAppbmRleCA2OGMwZjE3YzU2MDAzM2U3MTU4 NDI5MGY5M2UzNzgwZjI4YjA2ODFlLi5iNDQyMTEzN2UxYzJlZGZjNDQwZTdmNDVjNTEwOGU3ODg0 M2UwMGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9s aWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNvZGVyRmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2Rl ckZhY3RvcnkuY3BwCkBAIC04Myw3ICs4Myw2IEBAIHB1YmxpYzoKICAgICAgICAgICAgIG5ld0Jp dHJhdGUsIGZyYW1lUmF0ZSk7CiAKICAgICAgICAgYXV0byBjYXBzID0gYWRvcHRHUmVmKGdzdF9j YXBzX2NvcHkobV9yZXN0cmljdGlvbkNhcHMuZ2V0KCkpKTsKLSAgICAgICAgZ3N0X2NhcHNfc2V0 X3NpbXBsZShjYXBzLmdldCgpLCAiZnJhbWVyYXRlIiwgR1NUX1RZUEVfRlJBQ1RJT04sIGZyYW1l UmF0ZSwgMSwgbnVsbHB0cik7CiAKICAgICAgICAgU2V0UmVzdHJpY3Rpb25DYXBzKFdURk1vdmUo Y2FwcykpOwogCkBAIC0xMzgsNyArMTM3LDYgQEAgcHVibGljOgogICAgICAgICBnX29iamVjdF9z ZXQobV9zcmMsICJpcy1saXZlIiwgdHJ1ZSwgImZvcm1hdCIsIEdTVF9GT1JNQVRfVElNRSwgbnVs bHB0cik7CiAKICAgICAgICAgYXV0byB2aWRlb2NvbnZlcnQgPSBtYWtlRWxlbWVudCgidmlkZW9j b252ZXJ0Iik7Ci0gICAgICAgIGF1dG8gdmlkZW9yYXRlID0gbWFrZUVsZW1lbnQoInZpZGVvcmF0 ZSIpOwogICAgICAgICBhdXRvIHNpbmsgPSBtYWtlRWxlbWVudCgiYXBwc2luayIpOwogICAgICAg ICBnc3RfYXBwX3Npbmtfc2V0X2VtaXRfc2lnbmFscyhHU1RfQVBQX1NJTksoc2luayksIFRSVUUp OwogICAgICAgICBnX3NpZ25hbF9jb25uZWN0KHNpbmssICJuZXctc2FtcGxlIiwgR19DQUxMQkFD SyhuZXdTYW1wbGVDYWxsYmFja1RyYW1wKSwgdGhpcyk7CkBAIC0xNDgsOCArMTQ2LDggQEAgcHVi bGljOgogICAgICAgICBpZiAobV9yZXN0cmljdGlvbkNhcHMpCiAgICAgICAgICAgICBnX29iamVj dF9zZXQobV9jYXBzRmlsdGVyLCAiY2FwcyIsIG1fcmVzdHJpY3Rpb25DYXBzLmdldCgpLCBudWxs cHRyKTsKIAotICAgICAgICBnc3RfYmluX2FkZF9tYW55KEdTVF9CSU4obV9waXBlbGluZS5nZXQo KSksIG1fc3JjLCB2aWRlb3JhdGUsIHZpZGVvY29udmVydCwgbV9jYXBzRmlsdGVyLCBlbmNvZGVy LmxlYWtSZWYoKSwgc2luaywgbnVsbHB0cik7Ci0gICAgICAgIGlmICghZ3N0X2VsZW1lbnRfbGlu a19tYW55KG1fc3JjLCB2aWRlb3JhdGUsIHZpZGVvY29udmVydCwgbV9jYXBzRmlsdGVyLCBtX2Vu Y29kZXIsIHNpbmssIG51bGxwdHIpKQorICAgICAgICBnc3RfYmluX2FkZF9tYW55KEdTVF9CSU4o bV9waXBlbGluZS5nZXQoKSksIG1fc3JjLCB2aWRlb2NvbnZlcnQsIG1fY2Fwc0ZpbHRlciwgZW5j b2Rlci5sZWFrUmVmKCksIHNpbmssIG51bGxwdHIpOworICAgICAgICBpZiAoIWdzdF9lbGVtZW50 X2xpbmtfbWFueShtX3NyYywgdmlkZW9jb252ZXJ0LCBtX2NhcHNGaWx0ZXIsIG1fZW5jb2Rlciwg c2luaywgbnVsbHB0cikpCiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKIAogICAg ICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUobV9waXBlbGluZS5nZXQoKSwgR1NUX1NUQVRFX1BM QVlJTkcpOwo=