190676 2018-10-17 12:04:02 -0700 [GStreamer][WebRTC] properly mark H.264 stream type in the "decoder" 2018-11-05 07:06:22 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190674 187064 190677 1 tsaunier tsaunier alex commit-queue pnormand webkit-bug-importer oldest_to_newest 1470243 0 tsaunier 2018-10-17 12:04:02 -0700 [GStreamer][WebRTC] properly mark H.264 stream type in the "decoder" 1470244 1 352604 tsaunier 2018-10-17 12:04:54 -0700 Created attachment 352604 Patch 1470253 2 352604 pnormand 2018-10-17 12:12:53 -0700 Comment on attachment 352604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352604&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:281 > + if (codecInfo && codecInfo->codecType != webrtc::kVideoCodecH264) Would this really happen? Perhaps could be replaced with an ASSERT? 1473676 3 tsaunier 2018-10-31 04:21:35 -0700 (In reply to Philippe Normand from comment #2) > Comment on attachment 352604 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352604&action=review > > > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:281 > > + if (codecInfo && codecInfo->codecType != webrtc::kVideoCodecH264) > > Would this really happen? Perhaps could be replaced with an ASSERT? For some reason this is what they do in libwebrtc itself, just did the same here. 1475072 4 352604 commit-queue 2018-11-05 07:05:48 -0800 Comment on attachment 352604 Patch Clearing flags on attachment: 352604 Committed r237800: <https://trac.webkit.org/changeset/237800> 1475073 5 commit-queue 2018-11-05 07:05:49 -0800 All reviewed patches have been landed. Closing bug. 1475074 6 webkit-bug-importer 2018-11-05 07:06:22 -0800 <rdar://problem/45806531> 352604 2018-10-17 12:04:54 -0700 2018-11-05 07:05:48 -0800 Patch bug-190676-20181017160453.patch text/plain 3934 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA5NTU0OWFjOGNhZDM2 YWIwNjk5YTM3NTAzOGIxYjJkNzEwMjMyMi4uMjM4ZWI1OTcxYjFkODVhYjc2OTUyYmI0MjFlOWQ0 NDIxMmY2OGI3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEwLTEyICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIHByb3Blcmx5IG1hcmsgSC4yNjQgc3RyZWFtIHR5cGUgaW4gdGhlICJkZWNvZGVy IgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNjc2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWRp bmcgdG8gaGF2ZSBoMjY0cGFyc2UgbWFrZSBhc3N1bXB0aW9uICh3aGljaCBtaWdodCBiZSB3cm9u ZyBhdCBzb21lCisgICAgICAgIHBvaW50KS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0RlY29kZXJGYWN0b3J5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdTdHJlYW1lclZpZGVvRGVjb2Rlcjo6R2V0Q2Fwc0ZvckZyYW1lKToKKwogMjAx OC0xMC0xMiAgVGhpYmF1bHQgU2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dTdHJlYW1lcl1bV2ViUlRDXSBBZGQgd2VicnRjZW5jb2RlciBiaW4gdG8gY2xlYW51cCBh bmQgcmVmYWN0b3IgdGhlIHdheSB3ZSBzZXQgZW5jb2RlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0RlY29k ZXJGYWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndl YnJ0Yy9HU3RyZWFtZXJWaWRlb0RlY29kZXJGYWN0b3J5LmNwcAppbmRleCA0MzQyN2E4ZmZhODdh YzA5ZGY3MDg2MjFlMWFlZjcxMjdiZmJmZjUwLi5kYzMzMGI5NmM5MGU5ZGJjZGRiY2E1ZmEyNGFi YTE2ZDYwNzI4YmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9saWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9EZWNvZGVyRmFjdG9yeS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVv RGVjb2RlckZhY3RvcnkuY3BwCkBAIC03NCw3ICs3NCw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0 dXJuIGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZShmYWN0b3J5TmFtZSwgbmFtZS5nZXQoKSk7CiAg ICAgfQogCi0gICAgaW50MzJfdCBJbml0RGVjb2RlKGNvbnN0IHdlYnJ0Yzo6VmlkZW9Db2RlYyos IGludDMyX3QpCisgICAgaW50MzJfdCBJbml0RGVjb2RlKGNvbnN0IHdlYnJ0Yzo6VmlkZW9Db2Rl YyosIGludDMyX3QpIG92ZXJyaWRlCiAgICAgewogICAgICAgICBtX3NyYyA9IG1ha2VFbGVtZW50 KCJhcHBzcmMiKTsKIApAQCAtMTgyLDcgKzE4Miw3IEBAIHB1YmxpYzoKICAgICAgICAgfQogICAg IH0KIAotICAgIEdzdENhcHMqIEdldENhcHNGb3JGcmFtZShjb25zdCB3ZWJydGM6OkVuY29kZWRJ bWFnZSYgaW1hZ2UpCisgICAgdmlydHVhbCBHc3RDYXBzKiBHZXRDYXBzRm9yRnJhbWUoY29uc3Qg d2VicnRjOjpFbmNvZGVkSW1hZ2UmIGltYWdlKQogICAgIHsKICAgICAgICAgaWYgKCFtX2NhcHMp IHsKICAgICAgICAgICAgIG1fY2FwcyA9IGFkb3B0R1JlZihnc3RfY2Fwc19uZXdfc2ltcGxlKENh cHMoKSwKQEAgLTI3NSw5ICsyNzUsNTggQEAgcHJpdmF0ZToKIGNsYXNzIEgyNjREZWNvZGVyIDog cHVibGljIEdTdHJlYW1lclZpZGVvRGVjb2RlciB7CiBwdWJsaWM6CiAgICAgSDI2NERlY29kZXIo KSB7IH0KKworICAgIGludDMyX3QgSW5pdERlY29kZShjb25zdCB3ZWJydGM6OlZpZGVvQ29kZWMq IGNvZGVjSW5mbywgaW50MzJfdCBuQ29yZXMpIGZpbmFsCisgICAgeworICAgICAgICBpZiAoY29k ZWNJbmZvICYmIGNvZGVjSW5mby0+Y29kZWNUeXBlICE9IHdlYnJ0Yzo6a1ZpZGVvQ29kZWNIMjY0 KQorICAgICAgICAgICAgcmV0dXJuIFdFQlJUQ19WSURFT19DT0RFQ19FUlJfUEFSQU1FVEVSOwor CisgICAgICAgIG1fcHJvZmlsZSA9IG51bGxwdHI7CisgICAgICAgIGlmIChjb2RlY0luZm8pIHsK KyAgICAgICAgICAgIGF1dG8gaDI2NEluZm8gPSBjb2RlY0luZm8tPkgyNjQoKTsKKworICAgICAg ICAgICAgc3dpdGNoIChoMjY0SW5mby5wcm9maWxlKSB7CisgICAgICAgICAgICBjYXNlIHdlYnJ0 Yzo6SDI2NDo6a1Byb2ZpbGVDb25zdHJhaW5lZEJhc2VsaW5lOgorICAgICAgICAgICAgICAgIG1f cHJvZmlsZSA9ICJjb25zdHJhaW5lZC1iYXNlbGluZSI7CisgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgICAgICBjYXNlIHdlYnJ0Yzo6SDI2NDo6a1Byb2ZpbGVCYXNlbGluZToKKyAgICAg ICAgICAgICAgICBtX3Byb2ZpbGUgPSAiYmFzZWxpbmUiOworICAgICAgICAgICAgICAgIGJyZWFr OworICAgICAgICAgICAgY2FzZSB3ZWJydGM6OkgyNjQ6OmtQcm9maWxlTWFpbjoKKyAgICAgICAg ICAgICAgICBtX3Byb2ZpbGUgPSAibWFpbiI7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICBjYXNlIHdlYnJ0Yzo6SDI2NDo6a1Byb2ZpbGVDb25zdHJhaW5lZEhpZ2g6CisgICAg ICAgICAgICAgICAgbV9wcm9maWxlID0gImNvbnN0cmFpbmVkLWhpZ2giOworICAgICAgICAgICAg ICAgIGJyZWFrOworICAgICAgICAgICAgY2FzZSB3ZWJydGM6OkgyNjQ6OmtQcm9maWxlSGlnaDoK KyAgICAgICAgICAgICAgICBtX3Byb2ZpbGUgPSAiaGlnaCI7CisgICAgICAgICAgICAgICAgYnJl YWs7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gR1N0cmVhbWVy VmlkZW9EZWNvZGVyOjpJbml0RGVjb2RlKGNvZGVjSW5mbywgbkNvcmVzKTsKKyAgICB9CisKKyAg ICBHc3RDYXBzKiBHZXRDYXBzRm9yRnJhbWUoY29uc3Qgd2VicnRjOjpFbmNvZGVkSW1hZ2UmIGlt YWdlKSBmaW5hbAorICAgIHsKKyAgICAgICAgaWYgKCFtX2NhcHMpIHsKKyAgICAgICAgICAgIG1f Y2FwcyA9IGFkb3B0R1JlZihnc3RfY2Fwc19uZXdfc2ltcGxlKENhcHMoKSwKKyAgICAgICAgICAg ICAgICAid2lkdGgiLCBHX1RZUEVfSU5ULCBpbWFnZS5fZW5jb2RlZFdpZHRoLAorICAgICAgICAg ICAgICAgICJoZWlnaHQiLCBHX1RZUEVfSU5ULCBpbWFnZS5fZW5jb2RlZEhlaWdodCwKKyAgICAg ICAgICAgICAgICAicHJvZmlsZSIsIEdfVFlQRV9TVFJJTkcsIG1fcHJvZmlsZSA/IG1fcHJvZmls ZSA6ICJiYXNlbGluZSIsCisgICAgICAgICAgICAgICAgInN0cmVhbS1mb3JtYXQiLCBHX1RZUEVf U1RSSU5HLCAiYnl0ZS1zdHJlYW0iLAorICAgICAgICAgICAgICAgICJhbGlnbm1lbnQiLCBHX1RZ UEVfU1RSSU5HLCAiYXUiLAorICAgICAgICAgICAgICAgIG51bGxwdHIpKTsKKyAgICAgICAgfQor CisgICAgICAgIHJldHVybiBtX2NhcHMuZ2V0KCk7CisgICAgfQogICAgIGNvbnN0IGdjaGFyKiBD YXBzKCkgZmluYWwgeyByZXR1cm4gInZpZGVvL3gtaDI2NCI7IH0KICAgICBjb25zdCBnY2hhciog TmFtZSgpIGZpbmFsIHsgcmV0dXJuIGNyaWNrZXQ6OmtIMjY0Q29kZWNOYW1lOyB9CiAgICAgd2Vi cnRjOjpWaWRlb0NvZGVjVHlwZSBDb2RlY1R5cGUoKSBmaW5hbCB7IHJldHVybiB3ZWJydGM6OmtW aWRlb0NvZGVjSDI2NDsgfQorCitwcml2YXRlOgorICAgIGNvbnN0IGdjaGFyKiBtX3Byb2ZpbGU7 CiB9OwogCiBjbGFzcyBWUDhEZWNvZGVyIDogcHVibGljIEdTdHJlYW1lclZpZGVvRGVjb2RlciB7 Cg==