190581 2018-10-15 08:33:38 -0700 [GTK] Disable MSE build support on Debian and Ubuntu LTS bots 2020-10-27 10:57:52 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193669 https://bugs.webkit.org/show_bug.cgi?id=218247 InRadar P2 Normal --- 1 pnormand pnormand aakash_jain ap lforschler mcatanzaro ryanhaddad webkit-bug-importer oldest_to_newest 1469239 0 pnormand 2018-10-15 08:33:38 -0700 Their GStreamer version is too old. 1469242 1 352324 pnormand 2018-10-15 08:34:54 -0700 Created attachment 352324 Patch 1469244 2 pnormand 2018-10-15 08:36:02 -0700 Lucas, when this lands can you please update build.webkit.org ? 1469245 3 352324 mcatanzaro 2018-10-15 08:37:03 -0700 Comment on attachment 352324 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352324&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:332 > + "additionalArguments": ["--no-experimental-features --no-media-source"], Actually pretty sure this should be: ["--no-experimental-features", "--no-media-source"] right? That matches the rest of this file. 1469247 4 pnormand 2018-10-15 08:41:39 -0700 Yes! Thanks for the review! 1469248 5 pnormand 2018-10-15 08:42:47 -0700 Committed r237113: <https://trac.webkit.org/changeset/237113> 1469249 6 webkit-bug-importer 2018-10-15 08:43:23 -0700 <rdar://problem/45272072> 1469631 7 ryanhaddad 2018-10-15 21:05:22 -0700 (In reply to Philippe Normand from comment #2) > Lucas, when this lands can you please update build.webkit.org ? I just updated build.webkit.org for another change, so this should be live now. 1496757 8 aakash_jain 2019-01-22 07:11:16 -0800 Because of this change an additional buildbot step 'jhbuild' is being run. e.g.: notice 'jhbuild' step in: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/18912 This is because https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py#L42 checks for "additionalArguments != ["--no-experimental-features"]" This causes unit-test failures: https://bugs.webkit.org/show_bug.cgi?id=193669 Is this step 'jhbuild' expected? If this step is expected, we should simply update unit-tests. If this step is not expected, factories.py L42 should be changed to something like: if platform == "gtk" and "--no-experimental-features" not in additionalArguments: 1496765 9 pnormand 2019-01-22 08:14:38 -0800 (In reply to Aakash Jain from comment #8) > Because of this change an additional buildbot step 'jhbuild' is being run. > e.g.: notice 'jhbuild' step in: > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20Debian%20Stable%20%28Build%29/builds/18912 > > > This is because > https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build. > webkit.org-config/factories.py#L42 checks for "additionalArguments != > ["--no-experimental-features"]" > > This causes unit-test failures: > https://bugs.webkit.org/show_bug.cgi?id=193669 > > Is this step 'jhbuild' expected? > Hum, I'm not sure this is expected. IIRC the Debian and Ubuntu LTS bots shouldn't rely in jhbuild. 1496767 10 mcatanzaro 2019-01-22 08:18:06 -0800 Wow, thanks for noticing Aakash. Indeed, these bots should not be running jhbuild as that defeats the purpose of having the bots. (In reply to Aakash Jain from comment #8) > if platform == "gtk" and "--no-experimental-features" not in > additionalArguments: This sounds like the right solution. 352324 2018-10-15 08:34:54 -0700 2018-10-15 08:35:44 -0700 Patch bug-190581-20181015163453.patch text/plain 2061 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWM4MjEyYjE3ZjEwYmRhZGNkOTZhMGM2NWMxZTYyZTNl YzFlYTg0Yy4uZTMyMzI3MDQyMGY3OWFlNTRjYmI1NDFkMWUzNjEwNWU3NGFkYTY0OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTEwLTE1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBEaXNhYmxlIE1TRSBidWlsZCBzdXBwb3J0IG9uIERlYmlhbiBhbmQg VWJ1bnR1IExUUyBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTA1ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL2NvbmZp Zy5qc29uOgorCiAyMDE4LTEwLTE1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVXNlIHByYWdtYSBvbmNlIGluIFdURgpkaWZmIC0tZ2l0IGEv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpz b24gYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25m aWcuanNvbgppbmRleCAzZDEyYjBmNmExMGNhZGNkZmZjMGQyODllMjU1NmZlYzBiOTI1ZDYwLi5h ODEyMzlmMzFlNTJiNDE4YWZkYWQyZWU4MjQ1NjVhNDQzMWQyMTYzIDEwMDY0NAotLS0gYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbgor KysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25m aWcuanNvbgpAQCAtMzI5LDEzICszMjksMTMgQEAKICAgICAgICAgICAgICAgICAgICAgewogICAg ICAgICAgICAgICAgICAgICAgICJuYW1lIjogIkdUSyBMaW51eCA2NC1iaXQgUmVsZWFzZSBEZWJp YW4gU3RhYmxlIChCdWlsZCkiLCAidHlwZSI6ICJCdWlsZCIsICJidWlsZGRpciI6ICJndGstbGlu dXgtNjQtcmVsZWFzZS1kZWJpYW4iLAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6 ICJndGsiLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVjdHVyZXMiOiBbIng4 Nl82NCJdLAotICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsQXJndW1lbnRzIjogWyIt LW5vLWV4cGVyaW1lbnRhbC1mZWF0dXJlcyJdLAorICAgICAgICAgICAgICAgICAgICAgICJhZGRp dGlvbmFsQXJndW1lbnRzIjogWyItLW5vLWV4cGVyaW1lbnRhbC1mZWF0dXJlcyAtLW5vLW1lZGlh LXNvdXJjZSJdLAogICAgICAgICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJndGstbGlu dXgtc2xhdmUtMTAiXQogICAgICAgICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgICAgICAg ICB7CiAgICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiR1RLIExpbnV4IDY0LWJpdCBSZWxl YXNlIFVidW50dSBMVFMgKEJ1aWxkKSIsICJ0eXBlIjogIkJ1aWxkIiwgImJ1aWxkZGlyIjogImd0 ay1saW51eC02NC1yZWxlYXNlLXVidW50dSIsCiAgICAgICAgICAgICAgICAgICAgICAgInBsYXRm b3JtIjogImd0ayIsICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0dXJlcyI6 IFsieDg2XzY0Il0sCi0gICAgICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxBcmd1bWVudHMi OiBbIi0tbm8tZXhwZXJpbWVudGFsLWZlYXR1cmVzIl0sCisgICAgICAgICAgICAgICAgICAgICAg ImFkZGl0aW9uYWxBcmd1bWVudHMiOiBbIi0tbm8tZXhwZXJpbWVudGFsLWZlYXR1cmVzIC0tbm8t bWVkaWEtc291cmNlIl0sCiAgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBbImd0 ay1saW51eC1zbGF2ZS0xMSJdCiAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAg ICAgICAgIHsK