190525 2018-10-12 09:55:32 -0700 Web Inspector: Canvas: previews aren't removed when the parent view is hidden 2018-10-12 16:53:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 175485 1 hi hi commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1468460 0 hi 2018-10-12 09:55:32 -0700 * STEPS TO REPRODUCE: 1. Inspect <https://devinrousso.com/demo/WebKit/canvas.html> 2. Go to the Canvas tab 3. Refresh the page 4. Go to any other tab 5. Refresh the page 6. Go back to the Canvas tab => A Canvas preview with "No Preview Available" is shown for each canvas that was on the page before it was refreshed 1468688 1 352231 hi 2018-10-12 16:17:37 -0700 Created attachment 352231 Patch 1468692 2 352231 mattbaker 2018-10-12 16:22:56 -0700 Comment on attachment 352231 Patch r=me 1468693 3 352231 joepeck 2018-10-12 16:23:57 -0700 Comment on attachment 352231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352231&action=review > Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:138 > for (let canvas of this._canvasCollection) { > - if (!canvases.has(canvas)) > + if (!WI.canvasManager.canvases.includes(canvas)) > this._removeCanvas(canvas); > } > > - for (let canvas of canvases) { > + for (let canvas of WI.canvasManager.canvases) { > if (!this._canvasCollection.has(canvas)) > this._addCanvas(canvas); > } Given that `WI.canvasManager.canvases` is a non-simple getter we should only run it once: let canvases = WI.canvasManager.canvases; And use this everywhere instead of `WI.canvasManager.canvases` everywhere. 1468709 4 352236 hi 2018-10-12 16:35:46 -0700 Created attachment 352236 Patch 1468717 5 mattbaker 2018-10-12 16:44:37 -0700 (In reply to Joseph Pecoraro from comment #3) > Comment on attachment 352231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352231&action=review > > > Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:138 > > for (let canvas of this._canvasCollection) { > > - if (!canvases.has(canvas)) > > + if (!WI.canvasManager.canvases.includes(canvas)) > > this._removeCanvas(canvas); > > } > > > > - for (let canvas of canvases) { > > + for (let canvas of WI.canvasManager.canvases) { > > if (!this._canvasCollection.has(canvas)) > > this._addCanvas(canvas); > > } > > Given that `WI.canvasManager.canvases` is a non-simple getter we should only > run it once: > > let canvases = WI.canvasManager.canvases; > > And use this everywhere instead of `WI.canvasManager.canvases` everywhere. Good eye! I didn't think to check the getter. 1468719 6 352236 commit-queue 2018-10-12 16:52:18 -0700 Comment on attachment 352236 Patch Clearing flags on attachment: 352236 Committed r237090: <https://trac.webkit.org/changeset/237090> 1468720 7 commit-queue 2018-10-12 16:52:19 -0700 All reviewed patches have been landed. Closing bug. 1468722 8 webkit-bug-importer 2018-10-12 16:53:31 -0700 <rdar://problem/45241822> 352231 2018-10-12 16:17:37 -0700 2018-10-12 16:35:45 -0700 Patch bug-190525-20181012161736.patch text/plain 1999 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRiOTY4NmY3OGIzYTc5MzQwNTkyZDA4ZTEyMTRk ZDI4NmUyYzNjMzIuLmRhZjQ3ZTMzYWRjNDQ4Zjk3ZmNlNjg0YjUzMzQwNGU2YTk1ZjNiNzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IHByZXZpZXdzIGFyZW4ndCByZW1vdmVkIHdoZW4gdGhlIHBhcmVudCB2aWV3IGlzIGhp ZGRlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkw NTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0ku Q2FudmFzVGFiQ29udGVudFZpZXcucHJvdG90eXBlLmF0dGFjaGVkKToKKwogMjAxOC0xMC0xMSAg RGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogTmV0d29yazogZGV0YWlsIHZpZXcgcmV2ZXJ0cyB0byAiUmVzcG9uc2UiIHdoZW4gbmV3IHJl cXVlc3RzIGFyZSBhZGRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ2FudmFzVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250ZW50Vmlldy5qcwppbmRleCBm MGY1YWQ1YjcxMjZhZmIyZWZlYzdhYmMxNTliZDU3MDg2YzFiMzIwLi5hZTA3M2Y1M2M4M2E4ZjFk MjgxZGIxZDBlNTM0Y2U1ODhlMmM0NTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250ZW50Vmll dy5qcwpAQCAtMTI3LDE0ICsxMjcsMTIgQEAgV0kuQ2FudmFzVGFiQ29udGVudFZpZXcgPSBjbGFz cyBDYW52YXNUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRCcm93c2VyVGEKICAgICAg ICAgV0kuY2FudmFzTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdJLkNhbnZhc01hbmFnZXIuRXZl bnQuUmVjb3JkaW5nSW1wb3J0ZWQsIHRoaXMuX3JlY29yZGluZ0ltcG9ydGVkT3JTdG9wcGVkLCB0 aGlzKTsKICAgICAgICAgV0kuQ2FudmFzLmFkZEV2ZW50TGlzdGVuZXIoV0kuQ2FudmFzLkV2ZW50 LlJlY29yZGluZ1N0b3BwZWQsIHRoaXMuX3JlY29yZGluZ0ltcG9ydGVkT3JTdG9wcGVkLCB0aGlz KTsKIAotICAgICAgICBsZXQgY2FudmFzZXMgPSBuZXcgU2V0KFsuLi50aGlzLl9jYW52YXNDb2xs ZWN0aW9uLCAuLi5XSS5jYW52YXNNYW5hZ2VyLmNhbnZhc2VzXSk7Ci0KICAgICAgICAgZm9yIChs ZXQgY2FudmFzIG9mIHRoaXMuX2NhbnZhc0NvbGxlY3Rpb24pIHsKLSAgICAgICAgICAgIGlmICgh Y2FudmFzZXMuaGFzKGNhbnZhcykpCisgICAgICAgICAgICBpZiAoIVdJLmNhbnZhc01hbmFnZXIu Y2FudmFzZXMuaW5jbHVkZXMoY2FudmFzKSkKICAgICAgICAgICAgICAgICB0aGlzLl9yZW1vdmVD YW52YXMoY2FudmFzKTsKICAgICAgICAgfQogCi0gICAgICAgIGZvciAobGV0IGNhbnZhcyBvZiBj YW52YXNlcykgeworICAgICAgICBmb3IgKGxldCBjYW52YXMgb2YgV0kuY2FudmFzTWFuYWdlci5j YW52YXNlcykgewogICAgICAgICAgICAgaWYgKCF0aGlzLl9jYW52YXNDb2xsZWN0aW9uLmhhcyhj YW52YXMpKQogICAgICAgICAgICAgICAgIHRoaXMuX2FkZENhbnZhcyhjYW52YXMpOwogICAgICAg ICB9Cg== 352236 2018-10-12 16:35:46 -0700 2018-10-12 16:52:18 -0700 Patch bug-190525-20181012163546.patch text/plain 2854 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRiOTY4NmY3OGIzYTc5MzQwNTkyZDA4ZTEyMTRk ZDI4NmUyYzNjMzIuLjQxNGVkYTM2NjE4MTk1OWQ5MWIwZTY3Njg3M2U1YzViODA3NzA5ZGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IHByZXZpZXdzIGFyZW4ndCByZW1vdmVkIHdoZW4gdGhlIHBhcmVudCB2aWV3IGlzIGhp ZGRlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkw NTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWF0dCBCYWtlci4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvQ2FudmFzVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5DYW52 YXNUYWJDb250ZW50Vmlldy5wcm90b3R5cGUuYXR0YWNoZWQpOgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9DYW52YXNNYW5hZ2VyLmpzOgorICAgICAgICAoV0kuQ2FudmFz TWFuYWdlci5wcm90b3R5cGUuZ2V0IGNhbnZhc2VzKToKKyAgICAgICAgKFdJLkNhbnZhc01hbmFn ZXIucHJvdG90eXBlLmdldCBzaGFkZXJQcm9ncmFtcyk6CisgICAgICAgIERyaXZlLWJ5OiBzaW1w bGlmeSB0aGVzZSBnZXR0ZXJzLgorCiAyMDE4LTEwLTExICBEZXZpbiBSb3Vzc28gIDxkcm91c3Nv QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3b3JrOiBkZXRhaWwgdmll dyByZXZlcnRzIHRvICJSZXNwb25zZSIgd2hlbiBuZXcgcmVxdWVzdHMgYXJlIGFkZGVkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9D YW52YXNNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvQ2FudmFzTWFuYWdlci5qcwppbmRleCAzMDNhNjYyMzFjOTE0MmVkYzVkYTc5NTU2 YzAxZDUwYjY2NDk5YWM0Li5mZDJmODZmYzk5MjdiZDc4OTU1Y2U3MTY0M2UxNzVhZjcwMDQ0ZGM2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9DYW52YXNNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0NhbnZhc01hbmFnZXIuanMKQEAgLTQyLDEyICs0MiwxMiBAQCBX SS5DYW52YXNNYW5hZ2VyID0gY2xhc3MgQ2FudmFzTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAog CiAgICAgZ2V0IGNhbnZhc2VzKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBbLi4udGhpcy5fY2Fu dmFzSWRlbnRpZmllck1hcC52YWx1ZXMoKV07CisgICAgICAgIHJldHVybiBBcnJheS5mcm9tKHRo aXMuX2NhbnZhc0lkZW50aWZpZXJNYXAudmFsdWVzKCkpOwogICAgIH0KIAogICAgIGdldCBzaGFk ZXJQcm9ncmFtcygpCiAgICAgewotICAgICAgICByZXR1cm4gWy4uLnRoaXMuX3NoYWRlclByb2dy YW1JZGVudGlmaWVyTWFwLnZhbHVlcygpXTsKKyAgICAgICAgcmV0dXJuIEFycmF5LmZyb20odGhp cy5fc2hhZGVyUHJvZ3JhbUlkZW50aWZpZXJNYXAudmFsdWVzKCkpOwogICAgIH0KIAogICAgIGlt cG9ydFJlY29yZGluZygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3LmpzCmluZGV4IGYw ZjVhZDViNzEyNmFmYjJlZmVjN2FiYzE1OWJkNTcwODZjMWIzMjAuLjkyZmZhNWRjNzA1OWRjYjlh ODdkYjliMTY2OTQ3ZmUzOWYzMjEyYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3 LmpzCkBAIC0xMjcsMTAgKzEyNywxMCBAQCBXSS5DYW52YXNUYWJDb250ZW50VmlldyA9IGNsYXNz IENhbnZhc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudEJyb3dzZXJUYQogICAgICAg ICBXSS5jYW52YXNNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV0kuQ2FudmFzTWFuYWdlci5FdmVu dC5SZWNvcmRpbmdJbXBvcnRlZCwgdGhpcy5fcmVjb3JkaW5nSW1wb3J0ZWRPclN0b3BwZWQsIHRo aXMpOwogICAgICAgICBXSS5DYW52YXMuYWRkRXZlbnRMaXN0ZW5lcihXSS5DYW52YXMuRXZlbnQu UmVjb3JkaW5nU3RvcHBlZCwgdGhpcy5fcmVjb3JkaW5nSW1wb3J0ZWRPclN0b3BwZWQsIHRoaXMp OwogCi0gICAgICAgIGxldCBjYW52YXNlcyA9IG5ldyBTZXQoWy4uLnRoaXMuX2NhbnZhc0NvbGxl Y3Rpb24sIC4uLldJLmNhbnZhc01hbmFnZXIuY2FudmFzZXNdKTsKKyAgICAgICAgbGV0IGNhbnZh c2VzID0gV0kuY2FudmFzTWFuYWdlci5jYW52YXNlczsKIAogICAgICAgICBmb3IgKGxldCBjYW52 YXMgb2YgdGhpcy5fY2FudmFzQ29sbGVjdGlvbikgewotICAgICAgICAgICAgaWYgKCFjYW52YXNl cy5oYXMoY2FudmFzKSkKKyAgICAgICAgICAgIGlmICghY2FudmFzZXMuaW5jbHVkZXMoY2FudmFz KSkKICAgICAgICAgICAgICAgICB0aGlzLl9yZW1vdmVDYW52YXMoY2FudmFzKTsKICAgICAgICAg fQogCg==