190482 2018-10-11 13:47:28 -0700 Web Inspector: Canvas recording sidebar scroll position lost after switching tabs 2018-10-16 12:14:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 175485 1 joepeck hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1468147 0 joepeck 2018-10-11 13:47:28 -0700 Canvas recording sidebar scroll position lost after switching tabs. Steps to Reproduce: 1. Inspect <https://devinrousso.com/demo/DoubleHelixCircle.html> 2. Capture a single frame recording 3. Scroll down and select action 3000 4. Switch to Console Tab 5. Switch back to Canvas Tab => Navigation Sidebar appears empty, scrolling updates it and it appears to have lost its scroll position 1469786 1 352474 hi 2018-10-16 10:52:14 -0700 Created attachment 352474 Patch 1469808 2 352474 joepeck 2018-10-16 11:27:50 -0700 Comment on attachment 352474 Patch r=me 1469829 3 352474 commit-queue 2018-10-16 12:13:25 -0700 Comment on attachment 352474 Patch Clearing flags on attachment: 352474 Committed r237196: <https://trac.webkit.org/changeset/237196> 1469830 4 commit-queue 2018-10-16 12:13:27 -0700 All reviewed patches have been landed. Closing bug. 1469831 5 webkit-bug-importer 2018-10-16 12:14:25 -0700 <rdar://problem/45314082> 352474 2018-10-16 10:52:14 -0700 2018-10-16 12:13:25 -0700 Patch bug-190482-20181016105213.patch text/plain 5744 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMwY2E4MzA3Y2M1NzFlOWMyNGE5ZWI4ODQ1NGJh NjMzZmEwNTI5ZTMuLmU4NGJhZDJkYjU5NGYzOTRhNzQwNDVlNWYzNWNmZjgzOWJjZDYzZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE4LTEwLTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXMgcmVjb3JkaW5nIHNpZGViYXIgc2Nyb2xsIHBvc2l0aW9uIGxvc3QgYWZ0ZXIgc3dpdGNo aW5nIHRhYnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MDQ4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFyLmpzOgorICAgICAgICAoV0kuU2lkZWJhci5w cm90b3R5cGUucmVtb3ZlU2lkZWJhclBhbmVsKToKKyAgICAgICAgKFdJLlNpZGViYXIucHJvdG90 eXBlLnNldCBzZWxlY3RlZFNpZGViYXJQYW5lbCk6CisgICAgICAgIENhbGwgYGhpZGRlbmAgYmVm b3JlIHNldHRpbmcgYHNlbGVjdGVkYCB0byBgZmFsc2VgLCBhcyB0aGF0IHNldHMgYGRpc3BsYXk6 IG5vbmU7YCBvbiB0aGUKKyAgICAgICAgZWxlbWVudCwgd2hpY2ggc2V0cyB0aGUgYHNjcm9sbFRv cGAgdG8gYDBgLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFyUGFuZWwu anM6CisgICAgICAgIChXSS5TaWRlYmFyUGFuZWwucHJvdG90eXBlLnNob3duKToKKyAgICAgICAg KFdJLlNpZGViYXJQYW5lbC5wcm90b3R5cGUuaGlkZGVuKToKKyAgICAgICAgKFdJLlNpZGViYXJQ YW5lbC5wcm90b3R5cGUuZ2V0IHNjcm9sbEVsZW1lbnQpOiBBZGRlZC4KKyAgICAgICAgQWxsb3cg c3ViY2xhc3NlcyB0byBzcGVjaWZ5IHRoZSBzY3JvbGxpbmcgZWxlbWVudCBmb3Igc2F2aW5nL3Jl c3RvcmluZyB0aGUgc2Nyb2xsIHBvc2l0aW9uLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXSS5DYW52YXNTaWRlYmFyUGFu ZWwucHJvdG90eXBlLmdldCBzY3JvbGxFbGVtZW50KTogQWRkZWQuCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdTdGF0ZURldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAg ICAgIChXSS5SZWNvcmRpbmdTdGF0ZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLmdldCBz Y3JvbGxFbGVtZW50KTogQWRkZWQuCisKIDIwMTgtMTAtMTUgIE1hdHQgQmFrZXIgIDxtYXR0YmFr ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04gKHIyMzM4 MjQpOiBleGVjdXRpb24gaGlnaGxpZ2h0IHJhbmdlIG1pc3NpbmcvaW5jb3JyZWN0IGluIHByZXR0 eSBwcmludGVkIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NhbnZhc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1NpZGViYXJQYW5lbC5qcwppbmRleCBjZDdjYTkz NmE3ZTUxZWIxYjdkMjQ5NzVkNTBmNmRjM2QxYjcxZDI4Li5iMzkyOWE3ZjMxZmI4ZmNhM2IxODA3 YjVhYWQ4NDQzYzI0MDM2NDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJhclBhbmVsLmpzCkBAIC0y MjIsNiArMjIyLDExIEBAIFdJLkNhbnZhc1NpZGViYXJQYW5lbCA9IGNsYXNzIENhbnZhc1NpZGVi YXJQYW5lbCBleHRlbmRzIFdJLk5hdmlnYXRpb25TaWRlYmFyUGFuCiAKICAgICAvLyBQcm90ZWN0 ZWQKIAorICAgIGdldCBzY3JvbGxFbGVtZW50KCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlz Ll9yZWNvcmRpbmdDb250ZW50Q29udGFpbmVyOworICAgIH0KKwogICAgIGhhc0N1c3RvbUZpbHRl cnMoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdTdGF0ZURldGFpbHNTaWRl YmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9S ZWNvcmRpbmdTdGF0ZURldGFpbHNTaWRlYmFyUGFuZWwuanMKaW5kZXggMzdiY2JjYTY4YzRmZDAx ZTM3NmIzNzZkM2NiNjA1Y2RkNGUzZTIwOS4uZmI3MjIxOTZiODdkOGViMmQxZjRhNWY5NTVlZWY4 OTQ5M2FlZDI0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvUmVjb3JkaW5nU3RhdGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ1N0YXRlRGV0YWls c1NpZGViYXJQYW5lbC5qcwpAQCAtNzQsNiArNzQsMTMgQEAgV0kuUmVjb3JkaW5nU3RhdGVEZXRh aWxzU2lkZWJhclBhbmVsID0gY2xhc3MgUmVjb3JkaW5nU3RhdGVEZXRhaWxzU2lkZWJhclBhbmVs IGUKICAgICAgICAgdGhpcy51cGRhdGVMYXlvdXRJZk5lZWRlZCgpOwogICAgIH0KIAorICAgIC8v IFByb3RlY3RlZAorCisgICAgZ2V0IHNjcm9sbEVsZW1lbnQoKQorICAgIHsKKyAgICAgICAgcmV0 dXJuIHRoaXMuX2RhdGFHcmlkLnNjcm9sbENvbnRhaW5lcjsKKyAgICB9CisKICAgICAvLyBQcml2 YXRlCiAKICAgICBfZ2VuZXJhdGVEZXRhaWxzQ2FudmFzMkQoYWN0aW9uKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJhci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NpZGViYXIuanMKaW5kZXgg OThkYTk5ZmI4MWE1MWVhOWYzYzNhMGNmNzhjMTE1ZDkyZWYwYjczZS4uODU2YWExZTQ0OTUzYTQx OGYzYTZmNmVjNGYwNmFiMGM4Njk0NzQzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJhci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFyLmpzCkBAIC05MywxMyArOTMsMTMgQEAg V0kuU2lkZWJhciA9IGNsYXNzIFNpZGViYXIgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIGlmICgh c2lkZWJhclBhbmVsKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIHNpZGViYXJQYW5l bC5zZWxlY3RlZCA9IGZhbHNlOwotCiAgICAgICAgIGlmIChzaWRlYmFyUGFuZWwudmlzaWJsZSkg ewogICAgICAgICAgICAgc2lkZWJhclBhbmVsLmhpZGRlbigpOwogICAgICAgICAgICAgc2lkZWJh clBhbmVsLnZpc2liaWxpdHlEaWRDaGFuZ2UoKTsKICAgICAgICAgfQogCisgICAgICAgIHNpZGVi YXJQYW5lbC5zZWxlY3RlZCA9IGZhbHNlOworCiAgICAgICAgIGlmICh0aGlzLl9zZWxlY3RlZFNp ZGViYXJQYW5lbCA9PT0gc2lkZWJhclBhbmVsKSB7CiAgICAgICAgICAgICB2YXIgaW5kZXggPSB0 aGlzLl9zaWRlYmFyUGFuZWxzLmluZGV4T2Yoc2lkZWJhclBhbmVsKTsKICAgICAgICAgICAgIHRo aXMuc2VsZWN0ZWRTaWRlYmFyUGFuZWwgPSB0aGlzLl9zaWRlYmFyUGFuZWxzW2luZGV4IC0gMV0g fHwgdGhpcy5fc2lkZWJhclBhbmVsc1tpbmRleCArIDFdIHx8IG51bGw7CkBAIC0xMjYsMTQgKzEy NiwxMiBAQCBXSS5TaWRlYmFyID0gY2xhc3MgU2lkZWJhciBleHRlbmRzIFdJLlZpZXcKICAgICAg ICAgICAgIHJldHVybjsKIAogICAgICAgICBpZiAodGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwp IHsKLSAgICAgICAgICAgIHZhciB3YXNWaXNpYmxlID0gdGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFu ZWwudmlzaWJsZTsKLQotICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwuc2Vs ZWN0ZWQgPSBmYWxzZTsKLQotICAgICAgICAgICAgaWYgKHdhc1Zpc2libGUpIHsKKyAgICAgICAg ICAgIGlmICh0aGlzLl9zZWxlY3RlZFNpZGViYXJQYW5lbC52aXNpYmxlKSB7CiAgICAgICAgICAg ICAgICAgdGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwuaGlkZGVuKCk7CiAgICAgICAgICAgICAg ICAgdGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwudmlzaWJpbGl0eURpZENoYW5nZSgpOwogICAg ICAgICAgICAgfQorCisgICAgICAgICAgICB0aGlzLl9zZWxlY3RlZFNpZGViYXJQYW5lbC5zZWxl Y3RlZCA9IGZhbHNlOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fc2VsZWN0ZWRTaWRlYmFy UGFuZWwgPSBzaWRlYmFyUGFuZWwgfHwgbnVsbDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NpZGViYXJQYW5lbC5qcwppbmRleCA4NjA4 YzFjMmU0ZTJiYjQ1YTRkMTcxZjcyYWRjMmY1NGE2NWZmMGExLi4xOTc1NTEwOTY1YmFhZGI1ZTJj NzE0ODY0YzVmNGI3NGI3NjRiNGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJhclBhbmVsLmpzCkBAIC05NCw3ICs5NCw3 IEBAIFdJLlNpZGViYXJQYW5lbCA9IGNsYXNzIFNpZGViYXJQYW5lbCBleHRlbmRzIFdJLlZpZXcK IAogICAgIHNob3duKCkKICAgICB7Ci0gICAgICAgIHRoaXMuX2NvbnRlbnRWaWV3LmVsZW1lbnQu c2Nyb2xsVG9wID0gdGhpcy5fc2F2ZWRTY3JvbGxQb3NpdGlvbjsKKyAgICAgICAgdGhpcy5zY3Jv bGxFbGVtZW50LnNjcm9sbFRvcCA9IHRoaXMuX3NhdmVkU2Nyb2xsUG9zaXRpb247CiAKICAgICAg ICAgLy8gRklYTUU6IHJlbW92ZSBvbmNlIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTA3NDE+IGlz IGZpeGVkLgogICAgICAgICB0aGlzLnVwZGF0ZUxheW91dElmTmVlZGVkKCk7CkBAIC0xMDQsNyAr MTA0LDcgQEAgV0kuU2lkZWJhclBhbmVsID0gY2xhc3MgU2lkZWJhclBhbmVsIGV4dGVuZHMgV0ku VmlldwogCiAgICAgaGlkZGVuKCkKICAgICB7Ci0gICAgICAgIHRoaXMuX3NhdmVkU2Nyb2xsUG9z aXRpb24gPSB0aGlzLl9jb250ZW50Vmlldy5lbGVtZW50LnNjcm9sbFRvcDsKKyAgICAgICAgdGhp cy5fc2F2ZWRTY3JvbGxQb3NpdGlvbiA9IHRoaXMuc2Nyb2xsRWxlbWVudC5zY3JvbGxUb3A7CiAK ICAgICAgICAgLy8gSW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KICAgICB9CkBAIC0xMTMsNCAr MTEzLDEyIEBAIFdJLlNpZGViYXJQYW5lbCA9IGNsYXNzIFNpZGViYXJQYW5lbCBleHRlbmRzIFdJ LlZpZXcKICAgICB7CiAgICAgICAgIC8vIEltcGxlbWVudGVkIGJ5IHN1YmNsYXNzZXMuCiAgICAg fQorCisgICAgLy8gUHJvdGVjdGVkCisKKyAgICBnZXQgc2Nyb2xsRWxlbWVudCgpCisgICAgewor ICAgICAgICAvLyBPdmVycmlkZGVuIGJ5IHN1Yi1jbGFzc2VzIGlmIG5lZWRlZC4KKyAgICAgICAg cmV0dXJuIHRoaXMuY29udGVudFZpZXcuZWxlbWVudDsKKyAgICB9CiB9Owo=