190390 2018-10-08 20:52:06 -0700 [iOS] Cleanup EventHandler::passSubframeEventToSubframe() 2018-10-14 22:02:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190571 1 dbates dbates aestes webkit-bug-importer wenson_hsieh oldest_to_newest 1467327 0 dbates 2018-10-08 20:52:06 -0700 Cleanup EventHandler::passSubframeEventToSubframe() as a step towards enhancing it. 1467328 1 351853 dbates 2018-10-08 20:53:39 -0700 Created attachment 351853 Patch 1467560 2 351853 dbates 2018-10-09 14:31:38 -0700 Comment on attachment 351853 Patch Clearing flags on attachment: 351853 Committed r236983: <https://trac.webkit.org/changeset/236983> 1467561 3 dbates 2018-10-09 14:31:39 -0700 All reviewed patches have been landed. Closing bug. 1467562 4 webkit-bug-importer 2018-10-09 14:33:03 -0700 <rdar://problem/45140675> 351853 2018-10-08 20:53:39 -0700 2018-10-09 14:31:38 -0700 Patch bug-190390-20181008205338.patch text/plain 4716 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM5Njk1OTlmNDNhMmI0 YThhMzFiZTk2YTZhOGMxYjJjODhjMDUxYi4uMDQwZjYzOGY5ZWRkNWZhMmE3NWE4MmEwODZmMWE4 ODFiYzE5ODgyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEwLTA4ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDbGVhbnVwIEV2 ZW50SGFuZGxlcjo6cGFzc1N1YmZyYW1lRXZlbnRUb1N1YmZyYW1lKCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDM5MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuaW5kZW50IGNhc2Ugc3RhdGVtZW50 cyBpbiBzd2l0Y2ggYmxvY2sgYW5kIHVzZSBtb3JlIGF1dG8uCisKKyAgICAgICAgKiBwYWdlL2lv cy9FdmVudEhhbmRsZXJJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OnBh c3NTdWJmcmFtZUV2ZW50VG9TdWJmcmFtZSk6CisKIDIwMTgtMTAtMDggIFdlbnNvbiBIc2llaCAg PHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBbV0syXSBBZGQgc3Vw cG9ydCBmb3IgdGV4dCBhbGlnbm1lbnQgYW5kIHRleHQgbGlzdHMgaW4gZm9udCBhdHRyaWJ1dGVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9FdmVudEhhbmRsZXJJT1MubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9FdmVudEhhbmRsZXJJT1MubW0KaW5kZXggNDk2Zjky YTVlZTNmMDVhZTdkMzA0MWZiNGVkMTk0MDBhOTdjY2Y2Zi4uOGVlOWFhY2MwOTViYmE1Y2E4OGYw NDg3OGRjZjE2YWU2OGQ3OGM5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3Mv RXZlbnRIYW5kbGVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0V2ZW50SGFu ZGxlcklPUy5tbQpAQCAtMzY2LDQ4ICszNjYsNDggQEAgYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NT dWJmcmFtZUV2ZW50VG9TdWJmcmFtZShNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBldmUK IAogICAgIFdlYkV2ZW50VHlwZSBjdXJyZW50RXZlbnRUeXBlID0gY3VycmVudEV2ZW50KCkudHlw ZTsKICAgICBzd2l0Y2ggKGN1cnJlbnRFdmVudFR5cGUpIHsKLSAgICAgICAgY2FzZSBXZWJFdmVu dE1vdXNlTW92ZWQ6IHsKLSAgICAgICAgICAgIC8vIFNpbmNlIHdlJ3JlIHBhc3NpbmcgaW4gY3Vy cmVudE5TRXZlbnQoKSBoZXJlLCB3ZSBjYW4gY2FsbAotICAgICAgICAgICAgLy8gaGFuZGxlTW91 c2VNb3ZlRXZlbnQoKSBkaXJlY3RseSwgc2luY2UgdGhlIHNhdmUvcmVzdG9yZSBvZgotICAgICAg ICAgICAgLy8gY3VycmVudE5TRXZlbnQoKSB0aGF0IG1vdXNlTW92ZWQoKSBkb2VzIHdvdWxkIGhh dmUgbm8gZWZmZWN0LgotICAgICAgICAgICAgQVNTRVJUKCFtX3NlbmRpbmdFdmVudFRvU3Vidmll dyk7Ci0gICAgICAgICAgICBtX3NlbmRpbmdFdmVudFRvU3VidmlldyA9IHRydWU7Ci0gICAgICAg ICAgICBzdWJmcmFtZS0+ZXZlbnRIYW5kbGVyKCkuaGFuZGxlTW91c2VNb3ZlRXZlbnQoY3VycmVu dFBsYXRmb3JtTW91c2VFdmVudCgpLCBob3ZlcmVkTm9kZSk7Ci0gICAgICAgICAgICBtX3NlbmRp bmdFdmVudFRvU3VidmlldyA9IGZhbHNlOwotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAg ICAgIH0KLSAgICAgICAgY2FzZSBXZWJFdmVudE1vdXNlRG93bjogewotICAgICAgICAgICAgTm9k ZSogbm9kZSA9IGV2ZW50LnRhcmdldE5vZGUoKTsKLSAgICAgICAgICAgIGlmICghbm9kZSkKLSAg ICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICBhdXRvKiByZW5kZXJlciA9 IG5vZGUtPnJlbmRlcmVyKCk7Ci0gICAgICAgICAgICBpZiAoIWlzPFJlbmRlcldpZGdldD4ocmVu ZGVyZXIpKQotICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgIFdpZGdl dCogd2lkZ2V0ID0gZG93bmNhc3Q8UmVuZGVyV2lkZ2V0PigqcmVuZGVyZXIpLndpZGdldCgpOwot ICAgICAgICAgICAgaWYgKCF3aWRnZXQgfHwgIXdpZGdldC0+aXNGcmFtZVZpZXcoKSkKLSAgICAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICBpZiAoIXBhc3NXaWRnZXRNb3Vz ZURvd25FdmVudFRvV2lkZ2V0KGRvd25jYXN0PFJlbmRlcldpZGdldD4ocmVuZGVyZXIpKSkKLSAg ICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICBtX21vdXNlRG93bldhc0lu U3ViZnJhbWUgPSB0cnVlOwotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIH0KLSAg ICAgICAgY2FzZSBXZWJFdmVudE1vdXNlVXA6IHsKLSAgICAgICAgICAgIGlmICghbV9tb3VzZURv d25XYXNJblN1YmZyYW1lKQotICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAg ICAgIEFTU0VSVCghbV9zZW5kaW5nRXZlbnRUb1N1YnZpZXcpOwotICAgICAgICAgICAgbV9zZW5k aW5nRXZlbnRUb1N1YnZpZXcgPSB0cnVlOwotICAgICAgICAgICAgc3ViZnJhbWUtPmV2ZW50SGFu ZGxlcigpLmhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KGN1cnJlbnRQbGF0Zm9ybU1vdXNlRXZlbnQo KSk7Ci0gICAgICAgICAgICBtX3NlbmRpbmdFdmVudFRvU3VidmlldyA9IGZhbHNlOwotICAgICAg ICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIH0KLSAgICAgICAgY2FzZSBXZWJFdmVudEtleURv d246Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRLZXlVcDoKLSAgICAgICAgY2FzZSBXZWJFdmVudFNj cm9sbFdoZWVsOgotICAgICAgICBjYXNlIFdlYkV2ZW50VG91Y2hCZWdpbjoKLSAgICAgICAgY2Fz ZSBXZWJFdmVudFRvdWNoQ2FuY2VsOgotICAgICAgICBjYXNlIFdlYkV2ZW50VG91Y2hDaGFuZ2U6 Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaEVuZDoKKyAgICBjYXNlIFdlYkV2ZW50TW91c2VN b3ZlZDogeworICAgICAgICAvLyBTaW5jZSB3ZSdyZSBwYXNzaW5nIGluIGN1cnJlbnROU0V2ZW50 KCkgaGVyZSwgd2UgY2FuIGNhbGwKKyAgICAgICAgLy8gaGFuZGxlTW91c2VNb3ZlRXZlbnQoKSBk aXJlY3RseSwgc2luY2UgdGhlIHNhdmUvcmVzdG9yZSBvZgorICAgICAgICAvLyBjdXJyZW50TlNF dmVudCgpIHRoYXQgbW91c2VNb3ZlZCgpIGRvZXMgd291bGQgaGF2ZSBubyBlZmZlY3QuCisgICAg ICAgIEFTU0VSVCghbV9zZW5kaW5nRXZlbnRUb1N1YnZpZXcpOworICAgICAgICBtX3NlbmRpbmdF dmVudFRvU3VidmlldyA9IHRydWU7CisgICAgICAgIHN1YmZyYW1lLT5ldmVudEhhbmRsZXIoKS5o YW5kbGVNb3VzZU1vdmVFdmVudChjdXJyZW50UGxhdGZvcm1Nb3VzZUV2ZW50KCksIGhvdmVyZWRO b2RlKTsKKyAgICAgICAgbV9zZW5kaW5nRXZlbnRUb1N1YnZpZXcgPSBmYWxzZTsKKyAgICAgICAg cmV0dXJuIHRydWU7CisgICAgfQorICAgIGNhc2UgV2ViRXZlbnRNb3VzZURvd246IHsKKyAgICAg ICAgYXV0byogbm9kZSA9IGV2ZW50LnRhcmdldE5vZGUoKTsKKyAgICAgICAgaWYgKCFub2RlKQor ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBhdXRvKiByZW5kZXJlciA9IG5vZGUt PnJlbmRlcmVyKCk7CisgICAgICAgIGlmICghaXM8UmVuZGVyV2lkZ2V0PihyZW5kZXJlcikpCiAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGF1dG8qIHdpZGdldCA9IGRvd25jYXN0 PFJlbmRlcldpZGdldD4oKnJlbmRlcmVyKS53aWRnZXQoKTsKKyAgICAgICAgaWYgKCF3aWRnZXQg fHwgIXdpZGdldC0+aXNGcmFtZVZpZXcoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICAgICAgaWYgKCFwYXNzV2lkZ2V0TW91c2VEb3duRXZlbnRUb1dpZGdldChkb3duY2FzdDxSZW5k ZXJXaWRnZXQ+KHJlbmRlcmVyKSkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAg IG1fbW91c2VEb3duV2FzSW5TdWJmcmFtZSA9IHRydWU7CisgICAgICAgIHJldHVybiB0cnVlOwor ICAgIH0KKyAgICBjYXNlIFdlYkV2ZW50TW91c2VVcDogeworICAgICAgICBpZiAoIW1fbW91c2VE b3duV2FzSW5TdWJmcmFtZSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgQVNT RVJUKCFtX3NlbmRpbmdFdmVudFRvU3Vidmlldyk7CisgICAgICAgIG1fc2VuZGluZ0V2ZW50VG9T dWJ2aWV3ID0gdHJ1ZTsKKyAgICAgICAgc3ViZnJhbWUtPmV2ZW50SGFuZGxlcigpLmhhbmRsZU1v dXNlUmVsZWFzZUV2ZW50KGN1cnJlbnRQbGF0Zm9ybU1vdXNlRXZlbnQoKSk7CisgICAgICAgIG1f c2VuZGluZ0V2ZW50VG9TdWJ2aWV3ID0gZmFsc2U7CisgICAgICAgIHJldHVybiB0cnVlOworICAg IH0KKyAgICBjYXNlIFdlYkV2ZW50S2V5RG93bjoKKyAgICBjYXNlIFdlYkV2ZW50S2V5VXA6Cisg ICAgY2FzZSBXZWJFdmVudFNjcm9sbFdoZWVsOgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaEJlZ2lu OgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaENhbmNlbDoKKyAgICBjYXNlIFdlYkV2ZW50VG91Y2hD aGFuZ2U6CisgICAgY2FzZSBXZWJFdmVudFRvdWNoRW5kOgorICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgfQogICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiAK