190362 2018-10-08 11:27:22 -0700 Web Inspector: REGRESSION: selection in network table is lost when new entries are added 2018-10-10 13:53:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189705 InRadar P2 Normal --- 190330 1 hi hi commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1467120 0 hi 2018-10-08 11:27:22 -0700 * STEPS TO REPRODUCE: 1. Inspect <https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_fmp4/master.m3u8> 2. Open the Network tab 3. Refresh the page 4. Select an entry in the network table 5. Play the video (should add another entry to the end of the table) => Selection is lost From what I can tell, it seems that this is caused by the fact that the `WI.Table` in the `WI.NetworkTableContentView` has its `layout()` call _after_ it's "owner" `WI.NetworkTableContentView`. Since the manager of the selected row is the `WI.NetworkTableContentView`, the `WI.Table` has no idea about what it is or how to restore it. As such, when the `WI.Table` calls `layout()` the selection styling is lost, even though `WI.NetworkTableContentView` still has a reference to the selected row. Possibly a regression from r236853 <https://webkit.org/b/189705>. 1467776 1 351975 hi 2018-10-10 11:32:20 -0700 Created attachment 351975 Patch 1467808 2 351975 mattbaker 2018-10-10 13:25:12 -0700 Comment on attachment 351975 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351975&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Table.js:241 > + this._selectedRowIndex = NaN; Oops, good catch! 1467818 3 351975 commit-queue 2018-10-10 13:52:22 -0700 Comment on attachment 351975 Patch Clearing flags on attachment: 351975 Committed r237016: <https://trac.webkit.org/changeset/237016> 1467819 4 commit-queue 2018-10-10 13:52:23 -0700 All reviewed patches have been landed. Closing bug. 1467820 5 webkit-bug-importer 2018-10-10 13:53:34 -0700 <rdar://problem/45171654> 351975 2018-10-10 11:32:20 -0700 2018-10-10 13:52:22 -0700 Patch 190362.diff text/plain 6982 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRkYmIyMmE0ZDMyLi5iZGQ3YTQ3ZDQ5NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTgtMTAtMTAgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJF R1JFU1NJT046IHNlbGVjdGlvbiBpbiBuZXR3b3JrIHRhYmxlIGlzIGxvc3Qgd2hlbiBuZXcgZW50 cmllcyBhcmUgYWRkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MDM2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBgX3NlbGVjdGVkUm93c2AgbGlzdCBpcyBjbGVhcmVkIGVhY2ggdGltZSBgcmVs b2FkRGF0YWAgaXMgY2FsbGVkLCBtZWFuaW5nIHRoYXQKKyAgICAgICAgYFdJLlRhYmxlYCBleHBl Y3RzIGl0cyAib3duZXIiIHRvIHJlc3RvcmUgdGhlIHNlbGVjdGlvbiAoc2luY2UgaXQgZG9lc24n dCBrbm93IGhvdykuIEFzIGEKKyAgICAgICAgcmVzdWx0LCBgV0kuTmV0d29ya1RhYmxlQ29udGVu dFZpZXdgIG5lZWRzIHRvIGNhbGwgYHNlbGVjdFJvd2AgX2FmdGVyXyBgcmVsb2FkRGF0YWAgaXMK KyAgICAgICAgY2FsbGVkLCBub3QgYmVmb3JlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJs ZUNvbnRlbnRWaWV3LnByb3RvdHlwZS50YWJsZVNvcnRDaGFuZ2VkKToKKyAgICAgICAgKFdJLk5l dHdvcmtUYWJsZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fcG9wdWxhdGVOYW1lQ2VsbCk6CisgICAg ICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmlldy5wcm90b3R5cGUuX3Byb2Nlc3NQZW5kaW5n RW50cmllcyk6CisgICAgICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmlldy5wcm90b3R5cGUu X2luc2VydFJlc291cmNlQW5kUmVsb2FkVGFibGUpOgorICAgICAgICAoV0kuTmV0d29ya1RhYmxl Q29udGVudFZpZXcucHJvdG90eXBlLl91cGRhdGVTb3J0KTogQWRkZWQuCisgICAgICAgIChXSS5O ZXR3b3JrVGFibGVDb250ZW50Vmlldy5wcm90b3R5cGUuX3VwZGF0ZUZpbHRlcmVkRW50cmllcyk6 CisgICAgICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmlldy5wcm90b3R5cGUuX3JlbG9hZFRh YmxlKTogQWRkZWQuCisgICAgICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmlldy5wcm90b3R5 cGUuX3Jlc2V0RmlsdGVycyk6CisgICAgICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmlldy5w cm90b3R5cGUuX3R5cGVGaWx0ZXJTY29wZUJhclNlbGVjdGlvbkNoYW5nZWQpOgorICAgICAgICAo V0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcucHJvdG90eXBlLl9oYW5kbGVHcm91cEJ5RE9NTm9k ZUNoZWNrZWREaWRDaGFuZ2UpOgorICAgICAgICAoV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcu cHJvdG90eXBlLl91cmxGaWx0ZXJEaWRDaGFuZ2UpOgorICAgICAgICAoV0kuTmV0d29ya1RhYmxl Q29udGVudFZpZXcucHJvdG90eXBlLl91cGRhdGVTb3J0QW5kRmlsdGVyZWRFbnRyaWVzKTogRGVs ZXRlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanM6CisgICAgICAg IChXSS5UYWJsZS5wcm90b3R5cGUucmVsb2FkRGF0YSk6CisgICAgICAgIEVuc3VyZSB0aGF0IHRo ZSBgX3NlbGVjdGVkUm93SW5kZXhgIGlzIGFsc28gcmVzZXQuCisKIDIwMTgtMTAtMDggIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNy ZWF0ZSBzcGVjaWFsIE5ldHdvcmsgd2F0ZXJmYWxsIGZvciBtZWRpYSBldmVudHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJs ZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKaW5kZXggMzY2NmNiOTZkZmMuLmFhOTc0MjY1 OGU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwpAQCAtMzMyLDEw ICszMzIsOSBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtUYWJs ZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogICAgICAgICBmb3IgKGxldCBub2Rl RW50cnkgb2YgdGhpcy5fZG9tTm9kZUVudHJpZXMudmFsdWVzKCkpCiAgICAgICAgICAgICBub2Rl RW50cnkuaW5pdGlhdGVkUmVzb3VyY2VFbnRyaWVzLnNvcnQodGhpcy5fZW50cmllc1NvcnRDb21w YXJhdG9yKTsKIAotICAgICAgICB0aGlzLl9lbnRyaWVzLnNvcnQodGhpcy5fZW50cmllc1NvcnRD b21wYXJhdG9yKTsKLQorICAgICAgICB0aGlzLl91cGRhdGVTb3J0KCk7CiAgICAgICAgIHRoaXMu X3VwZGF0ZUZpbHRlcmVkRW50cmllcygpOwotICAgICAgICB0aGlzLl90YWJsZS5yZWxvYWREYXRh KCk7CisgICAgICAgIHRoaXMuX3JlbG9hZFRhYmxlKCk7CiAgICAgfQogCiAgICAgLy8gVGFibGUg ZGVsZWdhdGUKQEAgLTQ5Miw3ICs0OTEsNyBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9 IGNsYXNzIE5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogICAg ICAgICAgICAgICAgIGVudHJ5LmV4cGFuZGVkID0gIWVudHJ5LmV4cGFuZGVkOwogCiAgICAgICAg ICAgICAgICAgdGhpcy5fdXBkYXRlRmlsdGVyZWRFbnRyaWVzKCk7Ci0gICAgICAgICAgICAgICAg dGhpcy5fdGFibGUucmVsb2FkRGF0YSgpOworICAgICAgICAgICAgICAgIHRoaXMuX3JlbG9hZFRh YmxlKCk7CiAgICAgICAgICAgICB9KTsKIAogICAgICAgICAgICAgY3JlYXRlSWNvbkVsZW1lbnQo KTsKQEAgLTExNDcsOCArMTE0Niw5IEBAIFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3ID0gY2xh c3MgTmV0d29ya1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmllCiAKICAgICAg ICAgdGhpcy5fcGVuZGluZ0ZpbHRlciA9IGZhbHNlOwogCi0gICAgICAgIHRoaXMuX3VwZGF0ZVNv cnRBbmRGaWx0ZXJlZEVudHJpZXMoKTsKLSAgICAgICAgdGhpcy5fdGFibGUucmVsb2FkRGF0YSgp OworICAgICAgICB0aGlzLl91cGRhdGVTb3J0KCk7CisgICAgICAgIHRoaXMuX3VwZGF0ZUZpbHRl cmVkRW50cmllcygpOworICAgICAgICB0aGlzLl9yZWxvYWRUYWJsZSgpOwogICAgIH0KIAogICAg IF9wb3B1bGF0ZVdpdGhJbml0aWFsUmVzb3VyY2VzSWZOZWVkZWQoKQpAQCAtMTQ5Nyw3ICsxNDk3 LDcgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3JrVGFibGVDb250 ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWUKICAgICAgICAgICAgIGlmICh0aGlzLl9maWx0 ZXJlZEVudHJpZXMubGFzdFZhbHVlID09PSByZXNvdXJjZUVudHJ5KQogICAgICAgICAgICAgICAg IHRoaXMuX3RhYmxlLnJlbG9hZERhdGFBZGRlZFRvRW5kT25seSgpOwogICAgICAgICAgICAgZWxz ZQotICAgICAgICAgICAgICAgIHRoaXMuX3RhYmxlLnJlbG9hZERhdGEoKTsKKyAgICAgICAgICAg ICAgICB0aGlzLl9yZWxvYWRUYWJsZSgpOwogICAgICAgICB9CiAgICAgfQogCkBAIC0xNjIxLDEy ICsxNjIxLDEwIEBAIFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya1Rh YmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmllCiAgICAgICAgICAgICAmJiB0aGlz Ll9wYXNzVVJMRmlsdGVyKGVudHJ5KTsKICAgICB9CiAKLSAgICBfdXBkYXRlU29ydEFuZEZpbHRl cmVkRW50cmllcygpCisgICAgX3VwZGF0ZVNvcnQoKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMu X2VudHJpZXNTb3J0Q29tcGFyYXRvcikKICAgICAgICAgICAgIHRoaXMuX2VudHJpZXMgPSB0aGlz Ll9lbnRyaWVzLnNvcnQodGhpcy5fZW50cmllc1NvcnRDb21wYXJhdG9yKTsKLQotICAgICAgICB0 aGlzLl91cGRhdGVGaWx0ZXJlZEVudHJpZXMoKTsKICAgICB9CiAKICAgICBfdXBkYXRlRmlsdGVy ZWRFbnRyaWVzKCkKQEAgLTE2NjcsMTIgKzE2NjUsMTYgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVu dFZpZXcgPSBjbGFzcyBOZXR3b3JrVGFibGVDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRW aWUKICAgICAgICAgICAgIH0pOwogICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5fcmVzdG9yZVNl bGVjdGVkUm93KCk7Ci0KICAgICAgICAgdGhpcy5fdXBkYXRlVVJMRmlsdGVyQWN0aXZlSW5kaWNh dG9yKCk7CiAgICAgICAgIHRoaXMuX3VwZGF0ZUVtcHR5RmlsdGVyUmVzdWx0c01lc3NhZ2UoKTsK ICAgICB9CiAKKyAgICBfcmVsb2FkVGFibGUoKQorICAgIHsKKyAgICAgICAgdGhpcy5fdGFibGUu cmVsb2FkRGF0YSgpOworICAgICAgICB0aGlzLl9yZXN0b3JlU2VsZWN0ZWRSb3coKTsKKyAgICB9 CisKICAgICBfZ2VuZXJhdGVUeXBlRmlsdGVyKCkKICAgICB7CiAgICAgICAgIGxldCBzZWxlY3Rl ZEl0ZW1zID0gdGhpcy5fdHlwZUZpbHRlclNjb3BlQmFyLnNlbGVjdGVkSXRlbXM7CkBAIC0xNzAx LDcgKzE3MDMsNyBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtU YWJsZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogICAgICAgICBjb25zb2xlLmFz c2VydCghdGhpcy5faGFzQWN0aXZlRmlsdGVyKCkpOwogCiAgICAgICAgIHRoaXMuX3VwZGF0ZUZp bHRlcmVkRW50cmllcygpOwotICAgICAgICB0aGlzLl90YWJsZS5yZWxvYWREYXRhKCk7CisgICAg ICAgIHRoaXMuX3JlbG9hZFRhYmxlKCk7CiAgICAgfQogCiAgICAgX2FyZUZpbHRlckxpc3RzSWRl bnRpY2FsKGxpc3RBLCBsaXN0QikKQEAgLTE3MzUsNyArMTczNyw3IEBAIFdJLk5ldHdvcmtUYWJs ZUNvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5D b250ZW50VmllCiAKICAgICAgICAgdGhpcy5fYWN0aXZlVHlwZUZpbHRlcnMgPSBuZXdGaWx0ZXI7 CiAgICAgICAgIHRoaXMuX3VwZGF0ZUZpbHRlcmVkRW50cmllcygpOwotICAgICAgICB0aGlzLl90 YWJsZS5yZWxvYWREYXRhKCk7CisgICAgICAgIHRoaXMuX3JlbG9hZFRhYmxlKCk7CiAgICAgfQog CiAgICAgX2hhbmRsZUdyb3VwQnlET01Ob2RlQ2hlY2tlZERpZENoYW5nZShldmVudCkKQEAgLTE3 NDUsOCArMTc0Nyw5IEBAIFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29y a1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmllCiAgICAgICAgIGlmICghV0ku c2V0dGluZ3MuZ3JvdXBCeURPTU5vZGUudmFsdWUpCiAgICAgICAgICAgICB0aGlzLl90YWJsZS5l bGVtZW50LmNsYXNzTGlzdC5yZW1vdmUoImdyb3VwZWQiKTsKIAotICAgICAgICB0aGlzLl91cGRh dGVTb3J0QW5kRmlsdGVyZWRFbnRyaWVzKCk7Ci0gICAgICAgIHRoaXMuX3RhYmxlLnJlbG9hZERh dGEoKTsKKyAgICAgICAgdGhpcy5fdXBkYXRlU29ydCgpOworICAgICAgICB0aGlzLl91cGRhdGVG aWx0ZXJlZEVudHJpZXMoKTsKKyAgICAgICAgdGhpcy5fcmVsb2FkVGFibGUoKTsKICAgICB9CiAK ICAgICBfdXJsRmlsdGVyRGlkQ2hhbmdlKGV2ZW50KQpAQCAtMTc2Niw3ICsxNzY5LDcgQEAgV0ku TmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3JrVGFibGVDb250ZW50VmlldyBl eHRlbmRzIFdJLkNvbnRlbnRWaWUKICAgICAgICAgICAgIHRoaXMuX2FjdGl2ZVVSTEZpbHRlclJl c291cmNlcy5jbGVhcigpOwogCiAgICAgICAgICAgICB0aGlzLl91cGRhdGVGaWx0ZXJlZEVudHJp ZXMoKTsKLSAgICAgICAgICAgIHRoaXMuX3RhYmxlLnJlbG9hZERhdGEoKTsKKyAgICAgICAgICAg IHRoaXMuX3JlbG9hZFRhYmxlKCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIApA QCAtMTc4MCw3ICsxNzgzLDcgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBO ZXR3b3JrVGFibGVDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWUKICAgICAgICAgICAg IHRoaXMuX2NoZWNrVVJMRmlsdGVyQWdhaW5zdFJlc291cmNlKGVudHJ5LnJlc291cmNlKTsKIAog ICAgICAgICB0aGlzLl91cGRhdGVGaWx0ZXJlZEVudHJpZXMoKTsKLSAgICAgICAgdGhpcy5fdGFi bGUucmVsb2FkRGF0YSgpOworICAgICAgICB0aGlzLl9yZWxvYWRUYWJsZSgpOwogICAgIH0KIAog ICAgIF9yZXN0b3JlU2VsZWN0ZWRSb3coKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcwppbmRleCAyYTU0ODhlOGY0Mi4uODJiM2MzMTcx MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RhYmxlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RhYmxlLmpzCkBAIC0yMzcsNiArMjM3LDggQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRl bmRzIFdJLlZpZXcKICAgICByZWxvYWREYXRhKCkKICAgICB7CiAgICAgICAgIHRoaXMuX2NhY2hl ZFJvd3MuY2xlYXIoKTsKKworICAgICAgICB0aGlzLl9zZWxlY3RlZFJvd0luZGV4ID0gTmFOOwog ICAgICAgICB0aGlzLl9zZWxlY3RlZFJvd3MuY2xlYXIoKTsKIAogICAgICAgICB0aGlzLl9wcmV2 aW91c1JldmVhbGVkUm93Q291bnQgPSBOYU47Cg==